From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.511.1635476141911700722 for ; Thu, 28 Oct 2021 19:55:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=L3se68xf; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="230434654" X-IronPort-AV: E=Sophos;i="5.87,191,1631602800"; d="scan'208";a="230434654" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 19:55:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,191,1631602800"; d="scan'208";a="448214658" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 28 Oct 2021 19:55:41 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 19:55:40 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 19:55:40 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 19:55:40 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 28 Oct 2021 19:55:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MD4FXLhNp8Ys0Nz4qy6V/bPzxxNt6XS7lZa6ZsCoybPKVJTz8j1GPJz3/DM8iQIWA7WFIRo7skDTsS/ZnSVKGF1g3ej7qZBeJsxp+6FE5aQlEq8JdlhjjP0YNIbUr9EBSmtXtdDDatgxdA+8LAArpgzQe+YXd3ftUnhiGxfk4MDOzd7YRtcsi7Doc/wv+e0GINCYOV79AJ1ClZazKm1dPbcd+O0ItTU0DPbi4deOZG7rtOC+0RDFYl6WK+/koUUr1WW5WyjJwjCTZFyAYXeOD/9lsJIpkAF/cA/PW273eYj+sR3DdRAe061uU1QRm8KDdX0HL3Pura/BtDP2wwG3MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTRBnXWUTx9xsonAtv198yUV+783dVPqDqQM1phdMG0=; b=fWS/If/NRw1IO3nvApXx/cipra6rtqUjo25vpyphvv5aZGxKT97fFZrmLOmT2ptAkIMYqRr6E5BE3fTwWzS6q8YqhC4DgKb4df9shjYqvTrnvqsvN+W9AnchxPGdIHJl3qvYuxACbUrC39SMfA5Igz5oAzPGJAKMRg4ixRnDb+HFkYFjO9E5vkyTMgdAhZRj4ZWjgryN0lN5mTEYRhmMjsIQiuSNhtLmQS1U/62yoWiPILmEws5/YaCqF00QaMIFusAX8E8SFY4FMlyQRyIJnWMq+EJPKWnO1pCmViI8EeL3Lcg2nshxO1U3OgSYAuAayKQUk/O2xAvLbqGkeO36kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BTRBnXWUTx9xsonAtv198yUV+783dVPqDqQM1phdMG0=; b=L3se68xfzQ6m/N2eLelaFz04QFh6EPGVVYAOLmq611k/zv5QyL3CrW7RTYvKcPzRjtEL0prr5VaAP4qDtG3Ou04sD58LVgy6V0j27LHAPp0qiEEO5vW3pxgwdQan7UM6yjcgN13rnPrvyoXQsmMzVIL5ikrTUfYYO75hLl+hmag= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4790.namprd11.prod.outlook.com (2603:10b6:510:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct 2021 02:55:39 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4%4]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 02:55:39 +0000 From: "Min Xu" To: gaoliming , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Liu, Zhiguang" , "Yao, Jiewen" , "Wang, Jian J" , "Lu, Ken" , 'Sami Mujawar' Subject: Re: [edk2-devel] [PATCH V3 1/3] MdePkg: Introduce TeeMeasurementProtocol for TEE Guest firmware Thread-Topic: [edk2-devel] [PATCH V3 1/3] MdePkg: Introduce TeeMeasurementProtocol for TEE Guest firmware Thread-Index: AQHXy7jCoXj7xY29DUW2RiHZDdmWpKvpO6MAgAAFUYA= Date: Fri, 29 Oct 2021 02:55:39 +0000 Message-ID: References: <00af01d7cc69$8b16d240$a14476c0$@byosoft.com.cn> In-Reply-To: <00af01d7cc69$8b16d240$a14476c0$@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15000209-95bc-4b2b-1446-08d99a87972e x-ms-traffictypediagnostic: PH0PR11MB4790: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QJmc2g8trO+yZzoiYYHnkboD9SSnqYXRYXCyYrGJUdLzZLMxVhIiO/aFy0hjj14GrLzFkU64IcTRyBuMkSNpcpRlc6Lg0QopJf5peZlwsEu7sX5rlYb4FdOZcuAihjm7xOxQ2LNGDhhAg+UgxkfDOtGqxvgaGo8LTEs5Yrvc3uvj+fAZzs1VlD0t9Jtf6ilmrCbzYOjmXPNjAGeeJGZzvU8LTbW0ShURYaPhdBJeimEBGPqGFSWQe6VSRKO9S0Mcm5wYe0wQBD1tsJx+Qu3Jzmd//GF9xiAoDiyGatjP3dFIqzqYZ89CPEIsQfsoc/dRWO/Pf0Q96bxlydl9e+H0S9vDH3lIPCF4lZHR64SWxZuiwyvpvQnvrBmNZDlUpkXaTP4xQb1e/+SOidJ++jn4HYrjAfc6rL6Nh8eU/J2bItyaTnY97EDyIb4jl+tic6r8fTreNCgEO64ZPa0/SBJ89356mvcmkd3cbxTY5Cg9L+6YZ0IFuW7ZFR0WRmxgaWpIl9+ShUrtHqSjvw73grRWuAjUkZZs6V06+WGN9oUnUz2l1qPEibMA0Ocunj5cEVtvJUR2jv0GBpPZXV6tUOWU5oghZfm5S5lx/rrZuyD7VXleLdOozzBQeJr+K30+GEjbmP3jEpNtIzHZnvpnaFS2q2bunVVpnxP4h/L1CEuzLRZB9+TjBhwcGVKHFucJ06DlS10JUkcpSPT05R1wf+YSide4IjAmungEFr+9Ws3lRwItxEtQw/tB9otg344uXkzOJWB0NfLk9Ufc3/TEzqooy62hCt8CWCFQy8wlK3yCt/g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(86362001)(66446008)(64756008)(83380400001)(66556008)(5660300002)(9686003)(66946007)(76116006)(33656002)(6506007)(7696005)(38070700005)(4744005)(4326008)(966005)(26005)(55016002)(508600001)(8676002)(122000001)(186003)(54906003)(52536014)(38100700002)(110136005)(316002)(71200400001)(8936002)(82960400001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+7nulRIo2ggOZTwCac4abzwpru84BUat/NzotETlVI2jUeT1kb2J0mpd0eRI?= =?us-ascii?Q?UDLaW1TW+h8QGyo34ptPOvKQdJJvN4dhh0BVTH+KJYkdY52HEhMNt6AGF6XN?= =?us-ascii?Q?VOp+tLK/0sVnpFqtV7JaZS2XbzwjB7pWpCxVqwphEPftZQjlubetZyUI2Dut?= =?us-ascii?Q?D1QvslMtld+IujwTHlbeUwM3n9pwjqvz+CvrCYjeCqLTRYho12QUbtadZh75?= =?us-ascii?Q?3G7B5jFMroh9hDn6cRnrQB83JH1CA/DY24YDHssPb1KAFMMATgQYa229o1gH?= =?us-ascii?Q?5Ndz4zJ3rJp8/FRLm7Jc5XHISrsQvlO6bre01U53o3RwDMfopVKqIfBMm1lW?= =?us-ascii?Q?QSsPJeacWps3MiplY4yVx8LD3siz6mIHIKTl0QXzTBmwM8em4l3eAlpHJhuU?= =?us-ascii?Q?EpvMrgzRGzjgCBg2UAT63mIa3lU76c9+cVMfjlmYjfKjiMpTOb/kD5H26I8m?= =?us-ascii?Q?V/Ev5EcQG4k/20uV6M0YHkbPDkKfcaQbJZkCJq5ote6MBofsLAPxZz/ZBe5A?= =?us-ascii?Q?HGB0CNqBnHuYbSG3ktdhYTNDugowPw+4SuSil2C+Mf5skmBX0gOpdTy2FPib?= =?us-ascii?Q?IdKzCvFv3anBww8JNrA3BOQaPW150vcEDciBwCp88vZ+6zVC5a4ynDowHDob?= =?us-ascii?Q?CAmHstGhM/x2eaNydIsWfLdnJa26cLQEyRFdD85nBmYD6XQMtFh/HftflYPq?= =?us-ascii?Q?mf9ZUDu9e1BG9juIeIebjqabD+x2ir8B0FTfn1jPlzOVdjt72loU/MToBZnA?= =?us-ascii?Q?WvAPVQK+TMyO+a+tMSUflNtilHRvWbYpXGCB6FGCHEawWgsdSdewvrXCA8Ek?= =?us-ascii?Q?oGg2xy9JdO5AqX73Y+iqGxBcqxvAKg0vGlU403DUZgO4CEOF+udVe+YtRz50?= =?us-ascii?Q?jmgvqglestTriVuJRcuWanu/PzRgmK53AMdcTsvZqcuwDNUMe4jck0jhzTUG?= =?us-ascii?Q?6ln23M2K1CWmjXSWsWeTYpZdh2xwFUsS4yMkHeHsTuRQcxsWY4Sjqq34J85U?= =?us-ascii?Q?iTefFyK12N3y5v4Bn+6Ps1E9K6InK5cxfdV6Ikj1WV7MhsBbfp1qjop+pTXl?= =?us-ascii?Q?ejkfWnoQlxTFdBRuUvlK03jxvlNHKTKKfHGfa+KAmD7ZiQq1DmHxcokCullG?= =?us-ascii?Q?t8Pb1PyrnOPV8/YzWxuNnyHw2m0pYND6iUOd/KFq6KjFZFYcq6EQNw8eLvOH?= =?us-ascii?Q?sQjLO7Xk84OciaDnx0e1eIaOoz067hel457rGKJ9gNfot1ZOcetli6A4q+jo?= =?us-ascii?Q?Cspqzh7c/UFzA3mw5VcRd2kgrW+d5EtS0c7gGscOG+EE5PEV6mopwrCnLu2r?= =?us-ascii?Q?bmn3AxozIxX3D+Rj1WGYHVmAU1ggDHXB2E63tZE4pOY0aFjWj+HEuiF88536?= =?us-ascii?Q?PhCFPdX0vmt1ybW1TgUck81n29RejFOoskIH6/PAO8hZyn6NNp3OG2kGynpz?= =?us-ascii?Q?H4AGXaJC+RCuFiUFm3LME1sn///WcK0okZB9TWFgdgiRh3q7DeBOZ9HBe44C?= =?us-ascii?Q?TWLu49+qj3h0PlcYxrywBu8gM1NFFBnEA1jiZbf/DVom1+NGOoMk8RXnFjph?= =?us-ascii?Q?RYVP/iE6pumNQd97HbA4wKCTajx88AoNh2A5GtmLbePrbDvtPF77ZyuJvv96?= =?us-ascii?Q?jg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15000209-95bc-4b2b-1446-08d99a87972e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2021 02:55:39.5784 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bQHtFhiC7jXyo06pNSYQkNrSLZ1+OSGNxGZN4b/Jfp2lMOqdnfB4WwRJcaIVyU7gIVZnlLlMKwjrF4H+HsoEgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On October 29, 2021 10:06 AM, Liming Gao wrote: > Min: > I add my comments below. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3625 > > >=20 > Why adds MdePkg/Include/Protocol/TdProtocol.h? Can combine it into > MdePkg/Include/Protocol/TeeMeasurement.h? I once thought TdProtocol.h includes the TDX specific defitions, while TeeM= easurement.h contains the neutral ones. I will squash TdProtocol.h to TeeMeasurement.h in the next version. >=20 > > + > > +#include >=20 > Uefi/UefiBaseType.h is not required to be included. Module header file ha= s > includes it. Thanks for reminder. It will be removed in the next version. >=20 >=20 > gEfiTeeFinalEventsTableGuid is not declared in MdePkg.dec. Then, how does > the module consume it? Sorry for the error. It should be declared in MdePkg.dec. Thanks for the re= minder. >=20 Thanks. Min