From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.21927.1647410174244682087 for ; Tue, 15 Mar 2022 22:56:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=EDj8R6oM; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647410174; x=1678946174; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=V6/RE3ZBK6ZAyaf7gKYdYby5i5XwuotwupPzeDJYrI0=; b=EDj8R6oM8WF4OgIybgX6U23R7XSTi2+VuppPwdgT61bEhEp+P8zWvO3A o9LIDEbN+8u6epMMgKDNxvD/x+XvmVwjnXNjQrg1tmr2ychAAnJsHgqXv N3hKuMbxEUtfzurzpHliT4KskiWWsC5EE/JMI8apBlVYzljSEgPmwwaln r/hb9fMCUVkdGgMfPXs+gKYtA2SmP868U+HcTk3WtT96H+adhGRLclkDT 7kXjBjeVfCu2gMhXpGnqiyRUnYJtUwj7I3wqibiuIrZIVP9rAUvLfOtVt r6u+LOOlgF2RcZ1kLrvf6Y16W5Ce1VCA64jYEztrIXMtCBdWL6wbgVv2s g==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="256689187" X-IronPort-AV: E=Sophos;i="5.90,185,1643702400"; d="scan'208";a="256689187" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 22:56:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,185,1643702400"; d="scan'208";a="580787368" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 15 Mar 2022 22:56:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 22:56:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 22:56:12 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 22:56:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=REyR3YHenugSuxmxD75xPpgFWJtZEEzTlyv1ImxCJrd1p8urx/Fbq3RaYYXBHT6LSL7ApRst5I7bmYh89H+KkjGS2N8RqSo7pnmz/t/LI0ZTQj6skKljjYrzsCGpdntRcju1tujHxzXjBaYxDP4UgwSEXWN+81zwua4zEmdhBeaiyXvMVrhaPudxOGvV1FAN4ehjvkgBjbJPsYZAqcSXc/VZFdhX3fVmN4iOXd3RU3lb+TJoybpXQ3Iq8bCahggI6gUZKe203+5QB4nxfYUVCc4rt0D0308wU8/dIas5Oyx+jVg4QoUqVI2yOob1W7xT8SQjy58FHB46qOSxfBlIjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=snba85EiF+fjhhp1OVBEhQA2WMYkJSxi7vnldNSQnQk=; b=oLv7PsZmJf70d+f6/CuwekZFPfgmDA/4LTHRMiVEGNl3zrfe/khANfmTMSQjV2FtnImibgDliQllzlEayrenXm9EDmqBr6eN9wQ64jGuDfBiwwh6GOSRWWoefQgh4ABX52Iz0/hrERtoln2KCfMrKYNAQLsmgIJgNPezsSwwcQoPZgvo8aJUl3kAWRErDupI8YUllm163XBh9ZGDaQ6YbqdbznyAKfTN7+zaMjBFySvRomgSYjZ+YgnftsEFFBKZsJiX3Epvsey8IL/Cqn6sf+ozOyIeh6XmWPrF5PYS6vv9WnxQGqhLV2+Yf9MaNL6wVtsGPXlVcXRUYk7tGc3vxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by CY4PR1101MB2087.namprd11.prod.outlook.com (2603:10b6:910:25::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.25; Wed, 16 Mar 2022 05:56:10 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a%7]) with mapi id 15.20.5081.014; Wed, 16 Mar 2022 05:56:09 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Boeuf, Sebastien" Subject: Re: [edk2-devel] [PATCH V8 21/47] OvmfPkg/PlatformPei: Refactor AddressWidthInitialization Thread-Topic: [edk2-devel] [PATCH V8 21/47] OvmfPkg/PlatformPei: Refactor AddressWidthInitialization Thread-Index: AQHYNbRKt2t/JokKV0SLRINmKp8BaqzAGxAAgAFuUxA= Date: Wed, 16 Mar 2022 05:56:09 +0000 Message-ID: References: <035b3e0cec5d51584ac80a3b335d6b520a9da3b1.1647047482.git.min.m.xu@intel.com> <20220315080404.ehm3nps3xhegtps4@sirius.home.kraxel.org> In-Reply-To: <20220315080404.ehm3nps3xhegtps4@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc520efc-88c8-4b05-4e1b-08da0711ab86 x-ms-traffictypediagnostic: CY4PR1101MB2087:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ehfdseY9GUvprcnivdot+zw+ktia5vqIV1+8DI9+Lfd20kD/f80kNOAcz27rXQiujN15OTc63kvbN4/e+1NfCgeGCFsjSjYJ0ZXubsAzf5zHlYe9J4JHD2g3fepPTYZ1SfhfGZWoFG37G2uS+izgSqYN3xx4mKHZkp1GYvpR6/IW+q3xSDOiyWgbcRl1ma1Wqe0jPJVJt3IM5Sv+gBD4uCpVmKl6F10ygfnvTwxCmkW9EgPxPdgKQzTdPkVHYfUTAU+YjS5DTTw0GW9QfmkbNkx0n3rdFJqynAOi5Kkp6j96/f8tdpSLyGk2n1thPs0rGQzQ+aS7NcgkuT1AoTXqN2he8MhjIRn5S3CAJy8sW10bx0617PgUVCvrWPoZrRfxVphUS/VPQMUEVbfcMg0Vs75ZbW406a+MiEDrHjQXOURxT5KFZP3WsUJPAmnh8bxhxnUr8BJ6KTW9ZQRAioMsATSc9zxyLq4pl5hia4CYf5b8TIxdu4Wkh5ozIesq0g6im5WiexCEdEv1JGKmfmo8hsh2CzniL5KLF3naske+KbqyNcfj6p8aKduruVB/rJpmPnaBBv01hDRsvDOhvFwithAW1sFHrSZ8xwTNGAIBakkUQp1Aw23tcufVM/1jqxU/ErGAQaSVsHpSc2q/devkYp/cdAaPm4erSDYnCzDNluMyr6/ze/1vo9YXScE0ijUIGJeRKGvAUL6GW8xKzDFpIA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(33656002)(52536014)(508600001)(4744005)(8936002)(4326008)(8676002)(66446008)(64756008)(122000001)(66556008)(66946007)(66476007)(316002)(5660300002)(2906002)(110136005)(54906003)(107886003)(7696005)(6506007)(86362001)(9686003)(76116006)(38070700005)(82960400001)(71200400001)(26005)(55016003)(186003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?82x+iNJy5RSpFR+w2z1g//PopFBtCVqW03eZf9gihMYqWbcrWuqmfTAz/6OL?= =?us-ascii?Q?sRA8jU/JQjxXjnhn5Cp+/FjKG0jnmG3RaFyKDppl9O8tATfzxC7e6xJVJHJq?= =?us-ascii?Q?+mNP2Vm2DRrmJhLPoLQiu5Z5LdrFTPv8+jswMWy0VsaTdPy2U+pzzxZIi+95?= =?us-ascii?Q?DYmJYtilKeB2c5kGtckfzjRp8fsXeKfUOKCGp7UlVNEmjM/iz2khIw0+oD0L?= =?us-ascii?Q?g5UOtExhZl0pjtsT7UxC5V4jxO3DsF4tgD9UoigkA1lE//qn56Oh6+ppfRTg?= =?us-ascii?Q?EYshexrkSy5HaxpUxdoPheB3sO4l6z0oxDz6h8quTdDOKPE3jprUaYmIBbNx?= =?us-ascii?Q?wYIG6vtJCRtgHFFlt3X4Q3nLxwa15GNGkk7OKDOh94bBOgjU0d6r9s4KT3Ht?= =?us-ascii?Q?N93ecmB2q5aSFf303h4NdJqIPKFUZrXOmYOtanyd9MhGxSzhazYUCfKeaDWz?= =?us-ascii?Q?ga8hcdl7YM1uym9cqcB8BVoisFqwJGKBLrkp4wcH2KJGfg5A1PvKtF8lhEox?= =?us-ascii?Q?VbRtkEMwuRg/LzUp1re8VtI71DYgGFg5gg1/mya6wSZvwXC2UYBZMGiN+/V7?= =?us-ascii?Q?FI2KxX1ZshX6pqIrTdSw4TlqCJdO9cbAkx7D28RSGdtwp/bONkHfmcvnkHQd?= =?us-ascii?Q?QbxhQ3pKfg4IHGuYTa+MumVrBRwjKrJosM7NeVn4WUbr7DruoskjXhBjjsHV?= =?us-ascii?Q?g40WmLRlPFSh/kWsqFxt4D7HpWloyO3nkTgUHVsWI7Paf9+PUWAeWe/iFFQJ?= =?us-ascii?Q?yhLxywjTQk2KWY9/w0LwyGKJ5m65Nh+mqz2XhZakmQ3JsvfIu8fECscOA3U9?= =?us-ascii?Q?GvWgsNnJfAl9cZGQQyLO4/zFQZ5or+bmDm3WM5C1/NCTowcGmABIAtGcX5c+?= =?us-ascii?Q?KAyvR1yEpMFhQno6+HhsRqIlRHB3lcl1MYrOynYWnZy3uq4GsVQz+x4fF5Cl?= =?us-ascii?Q?g1wQLO4W7avqX6Y5KiuwkC0O3nvgeSosX/rJKwfEkZbj+FETB8BLx/V+Sfnt?= =?us-ascii?Q?TvQuCBIOAKLfP3iF4PSfzA4YGfxbwj9yJOcYpNbrSAeDSEmJtucM5iVOd25W?= =?us-ascii?Q?BNSI9EKEkopwTHTRSTZZsag7NhFXBgvu7Y7hzjcFrZDovZBq44b6UZOmB528?= =?us-ascii?Q?19adp87GN2qNdgrfq7UG5dr+gO6oBVJsnRphYSuPP+l+9e3opsJq/9h5n+C1?= =?us-ascii?Q?iqcvTSI1kE2fzTZW/HojudJ72ccSTBjo04+tCTmZyTFWzb3W0Mp6ylYrlI03?= =?us-ascii?Q?5YSo3PDLvzJzgyKIGkNXozyzISZcIPxl7cQ4mCsuhSD8yftfLLJcUSCuu7Sy?= =?us-ascii?Q?z1X5O2xDOfyIg7lmgtMP69huROlxuBvlYycs+CtCIuyCVvyNgWM0gNi1VG6T?= =?us-ascii?Q?mTUyWue2mSvYmO6ZByBkXVn3l99HIQKjulh4FhdJhwLc4pki6DHFuj1HOXUs?= =?us-ascii?Q?Ja1hk1p3i4+zyCety0LOOdeZLM/W8giD?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc520efc-88c8-4b05-4e1b-08da0711ab86 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 05:56:09.9109 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U0xG9UTkn9EWrY4VFmkU2kih+hlNU02NP09mXcc4bjbW6hleeqKbZ878riS6ltGXXPUZFf7nj2uIZATc0ecA5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2087 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On March 15, 2022 4:04 PM, Gerd Hofmann wrote: >=20 > On Sat, Mar 12, 2022 at 09:53:46AM +0800, Min Xu wrote: > > +/** > > + Initialize the mPhysMemAddressWidth variable, based on guest RAM siz= e. > > +**/ >=20 > That comment isn't correct any more, the global variables are in > PlatformInfoHob now (there are probably more cases like this). Thanks for reminder. They will be updated in the next version. Thanks Min