Re: [edk2-devel] [PATCH 02/10] EmbeddedPkg/PrePiLib: Update PrePiLib

["Min Xu" <min.m.xu@intel.com>]

On December 14, 2021 10:01 PM, Ard Biesheuvel wrote:
> On Tue, 14 Dec 2021 at 14:42, Min Xu <min.m.xu@intel.com> wrote:
> > --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c
> > +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c
> > @@ -335,7 +335,7 @@ FfsProcessSection (
> >
> >          Status = UefiDecompressGetInfo (
> >                     CompressedData,
> > -                   CompressedDataLength,
> > +                   (UINT32)CompressedDataLength,
> 
> How is this change related to the items listed in the commit log?
> 
> If there are code issues affecting this library, please fix them in a separate
> patch.
> 
CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. But the second parameter of UefiDecompressGetInfo() is declared as UINT32. So a build error is triggered.
  RETURN_STATUS
  EFIAPI
  UefiDecompressGetInfo (
    IN  CONST VOID  *Source,
    IN  UINT32      SourceSize,
    OUT UINT32      *DestinationSize,
    OUT UINT32      *ScratchSize
    );

I will fix it in a separate patch.

Thanks
Min