From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.9107.1632987121572266200 for ; Thu, 30 Sep 2021 00:32:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Jn5GYQ62; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="225165036" X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208,217";a="225165036" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 00:32:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208,217";a="521111877" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 30 Sep 2021 00:32:00 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 00:31:59 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 00:31:59 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 00:31:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LsPKkS56ptHxw+apLzeD+WvgtOsoDu5f0egVw2K0G8W8KrS6mXeWjdYCnALyqUcErqZ2ASt6nTpK8NyFFlcPBF0z3aLhVPzNGnORCSmml4QsOXF/b/gvloxDSe+WOSczoLAiLNWJDZqvuD34I5lxHRwLxLY0k3lce7xiP/WG7I5JtmcfqNkHkACJeZjYmDUdFL0QR/3N3fc3vVijllGaAaqPuaA1ykwmhG7vvzpPZBkeL0bTNNiJFlqrdgOAdL7SnXG0P68T/grDV0N8+6mJrWfJu1LGRl9wRdh9Pwq5rUax903SbQNQ1cnNTLDqHAIyb1WrUnkx7zYYe978IEb9rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RwRhE3dpj5j5n+7ZtawVUCRUpkvMkCERhEAzxIBYcko=; b=LBodqRZ/gucbHHDZMJnXr7Uc0Rr9bynm9DMWgja0TQlNWNj+8wJvXFSWPa1GPg//keGy/+9tECeEokJ7/8qIFOBdaGNNYs2YS/w3pcLmqtvvPPoMNulVOmvwaMEifP8Pn/O14uZqnOutaJ6viPUWbLK9atxoV45RKE/iAJ2P7P0+BJlI0KKEbwio8N3H4jiKDNRzGDsCe5ToRkjI22PX2gu3o8HEZCF74Qzjle8mZW3Fkv3GF6cL+bmt/YE/zJTPpE+tVyLJhVyPrETy8HQuT7bz1DzYc32+rigTKFIU+4lN5D6TAaJgfT2NJZZR4yOHLFfy39h0NQg8akQxUyYwVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RwRhE3dpj5j5n+7ZtawVUCRUpkvMkCERhEAzxIBYcko=; b=Jn5GYQ62xRVYqKEVZ6yV7Ntu4vhUz9fM2US+hGRfWSV8ytlD7W+n7Lba374OBBInkw3JduW2mSKEhcCJBeXJMtWMLen66WKlQ8TALpsR4DlJYEpBSW+twGW9dG3UsfRL1vFnGBh8PB/AaVAALHTJJLs2dRh3tgRMf3pNO/wMcDw= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4982.namprd11.prod.outlook.com (2603:10b6:510:37::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Thu, 30 Sep 2021 07:31:56 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7191:ea9d:f193:5591]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7191:ea9d:f193:5591%7]) with mapi id 15.20.4566.015; Thu, 30 Sep 2021 07:31:56 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "brijesh.singh@amd.com" , "kraxel@redhat.com" , "Yao, Jiewen" CC: Ard Biesheuvel , "Justen, Jordan L" , Erdem Aktas , "James Bottomley" , "Lendacky, Thomas" Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Thread-Topic: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Thread-Index: AQHXs0QwX8//s6Z2f0yRFpz23fm/qqu3kLSAgAEMVRCAAEMIAIAALc3QgACFLgCAAJwHgA== Date: Thu, 30 Sep 2021 07:31:56 +0000 Message-ID: References: <729034c8d47013be1e87a68ba1b6c3a7b79a4b2a.1632707635.git.min.m.xu@intel.com> <20210927084235.pj7x2agzzzjqz7be@sirius.home.kraxel.org> <20210928044254.kdqpd76ltmcllqkr@sirius.home.kraxel.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=True; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-09-28T15:23:29.446Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b8845ba-c12b-488e-8fdc-08d983e461d8 x-ms-traffictypediagnostic: PH0PR11MB4982: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BnaB0B4fpo+CpbJyoYVYxz1jDkpaKNcCB6QUbCxPy42k+rEmBpjmpsnCqKXlAIbN2hLeD0179HgCgk6pXTjO8n50hOrX8xcbRw964yUtSCcV1S4Y4Fzb6fZl03v9FX1s+hi149FDMd4e5KTg3rIs0ifH7JrZHi/LEqngFZOaqyvs5OZCGV45OSP9dZwRUZusjjl4LOQp+78xjUVBpQWObyYkCyhnu9rqsxSGKL2lEIGNXnRZEjdfHiIthQaFxq8+IL+rCae4CoxBo2tZnt+R4h3yY6rvPb2+buOmBQKVOu1Z+vxoTvIB/pL5mu29iIMPYPYqTPH29IAWuKovQ8B+U1eXidPBvNJwv98q2c+hGEmj5iuQHFhRbal1PoCy3TnWpipiw5EJFiHlVDo4i+w9XLyuyn05m2uJNay5C6k7k1gqDxOW6URPBHZqD81Mbl50FTvKx7PbOG0SMHW0dzeaWD9M6XrPAh6XC+49vIGf+ABz0bvxZrSyjr9sG1zF8HhFO/zIP5oMm0bVCYkJZ2RHxst/O6DwKZgHaAkp23dRvzweBhQqFjXQ54G/8wOu14psteMKMBI3X4zXuM498hbQKp0dsPVg4v2TQ4u8DU8E3lt4Z921HU0UuDdmFqecpV3hdPK4FO0QSzf99yaMiqFvKWvg/tnfr+lEURf4GvoUeFuYcnEEmmha13mAoZxiHU8m9bwoMp5TutYC/6g1E4ljAvyZ331QBt1tbbdrm0Lj4LLX59nQtjSe15WGzcC950jdCMwwkJ5EAvDr9BIQAHseTX6PUUEihv7yHCFkQYPvildK8T4fZctN1XtHaZniTAUGj5TyhJT4UpJlCQ0JCAcxBw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(966005)(54906003)(38070700005)(76236003)(8936002)(110136005)(316002)(33656002)(2906002)(186003)(45080400002)(66476007)(55016002)(66556008)(64756008)(66446008)(7696005)(6636002)(5660300002)(52536014)(166002)(76116006)(71200400001)(26005)(508600001)(38100700002)(9686003)(66946007)(8676002)(122000001)(86362001)(6506007)(53546011)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d9iLhRUwPEYTKC7OozMr5yN9Wql5zQCfY36gnLBZJDAnuZxlN9/g38lPGurh?= =?us-ascii?Q?Io6zwNMKeQ5RFz4W5qnmtIWDWGMnTzbAXX5/eN+qpmJZ5LXzrRiUrqKJa+Jv?= =?us-ascii?Q?ELHoakQU7ZZCuTeqr7pUSBCW+bPXE8gDrs3gez/eQkPHQkF80GBi5P2u1Weu?= =?us-ascii?Q?/RUGUwDN/uTN/fKHP6kp8ggU748WwR77MWWQVlGBlSR10QdGGkIuIvPLlb8q?= =?us-ascii?Q?cdmx48E199Gli5HzL5VGKHABk7qOcQGVh2Su0E9bMhILAUr5+msj492FNHfS?= =?us-ascii?Q?LhaQh5a9g4izvaWjd4FRAxfNGNKVnk06hoyzXpSh8E+G8oudPcfDELEYxMx5?= =?us-ascii?Q?m7hTvsGOho7rhMo8E4RpTU9fWKLMmRml/91gt0vnz2VXbx4MrDAE+maCnmnT?= =?us-ascii?Q?e/bRs/wVkRZVFYKqHUb/Qc4+TTtQebT3ezPP1rd+5Ji3sUiSmXm9dXxYEcY3?= =?us-ascii?Q?A+tj7wnODhrwkyljtX+oJRZqW6vuX2A/doG/Ob0Kjfp575DPixNqCbz2jIrQ?= =?us-ascii?Q?l+M0S8Kgoc2RSo0ZOtGxYyilMMEDz2LMprqa2+CpY26b8qbxefwOLg8+DyNh?= =?us-ascii?Q?MPKTK13fc0BJqFY+NreVRnFWbnWyFGm2VLHUO4Pjifo9kii4Tr3mnd43hhb8?= =?us-ascii?Q?FYhmEux3G7iwDomRtbDrmc44Z6O6nbdFWRDytWqkrt7BP4Lr1phxCgsZaJi0?= =?us-ascii?Q?8QJJIUhDlBlX99XAiQ2PMtH2fv/ScjdE3Ki4fjveFfEZ9lN0W3GBLYcuJNR3?= =?us-ascii?Q?Yi39Dy12gtEFdmeo7gH5GVcoEWH6+ujfD6M+j137m4BBHBuisFFoDbSuNQK5?= =?us-ascii?Q?A6PqH9CHqXbBoGs1/tUhv1YcVrdFBdvj8ApsV60+wf6uDrGZ0IFjvpz2irJ7?= =?us-ascii?Q?+/tWV4WDgG6nJoSOngKMCMoUt1qnTzasurQN4GcGXrynTh3zTY6rt3fNvvbK?= =?us-ascii?Q?/PE/yeplJJP7MzDc5L4y4gePBVQDbwiVyRGpYEvO/vzqv2MrMh9eMSyfs3U+?= =?us-ascii?Q?ImIC9OrbOpeORC4cx0JGC4eI8/c9k/fdJB6cFoaFzYjwXJ/UkzpuC8NqMRfc?= =?us-ascii?Q?6KIVzTfVOwLr/oW/FsSmEyLcmSr87H7er/oIb+c3uIPQpCqUy41jo00LRs/G?= =?us-ascii?Q?8iXKBxznd6x2xEjVoa11MbXpaZc7BrY/4+plwxf6VHR5BklOEA9AI/CNZZai?= =?us-ascii?Q?PTyjAd9QGt7KPmwWPXrLOFoWw4mZx4CfGz3DPKNSG8a0t8qE1abQO5wNEjQr?= =?us-ascii?Q?QQnbBwKjhWRvTX64a/aZwTOkAN2eyfl/9ej9WGmU7cWaKM6DSiLDG64NC7ky?= =?us-ascii?Q?FS8ntHob/Hy2Y+jdngKnFEVO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b8845ba-c12b-488e-8fdc-08d983e461d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2021 07:31:56.5746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MLF9JVFRf40LDYTVO+R07z6BfcrivQQoUaI2oWaIOXLpm9tVoLPgv6SvNPCvndJHmUB98MByeyWUpsoJFEu6Gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4982 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR11MB506499575BE68128554B9D9EC5AA9PH0PR11MB5064namp_" --_000_PH0PR11MB506499575BE68128554B9D9EC5AA9PH0PR11MB5064namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Brijesh In the current discussion there are 2 options for the metadata, a unified M= etadata and 2 separate Metadata (SEV and TDX metadata). My understanding to your last mail is that you're going to use the unified = Metadata option, right? As to the offset of metadata, absolute offset is a good idea. I will update= it in my next version. Thanks! Min From: devel@edk2.groups.io On Behalf Of Brijesh Sing= h via groups.io Sent: Tuesday, September 28, 2021 11:24 PM To: Xu, Min M ; devel@edk2.groups.io; kraxel@redhat.com Cc: Yao, Jiewen ; Ard Biesheuvel ; Justen, Jordan L ; Erdem Aktas ; James Bottomley ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] May I ask to use the OvmfMetadata instead of the of TdxMetadata for the Gui= ded structure name label (same as what I did in SNP series patch #4). If yo= u can send the metadata introduction as a patch separately then add the TDX= descriptor in TDX series. I can try to make it work for the SNP series and= add SNP specific descriptors. Additionally, I think you want to provide an= absolute offset for the start of the metadata instead relative value so th= at VMM can very easily reach to the start of metadata. e.g +OvmfMetadataOffsetStart: + DD (fourGigabytes - OvmfMetadataGuid - 16) + DW OvmfMetadataOffsetEnd - OvmfMetadataOffsetStart + DB 0x35, 0x65, 0x7a, 0xe4, 0x4a, 0x98, 0x98, 0x47 + DB 0x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2 +OvmfMetadataOffsetEnd: For SNP series, I will 3 section types #1 CPUID, # Secrets, and #3 SEC_MEM = and will probably add a total of 3 more descriptors. ________________________________ From: Xu, Min M > Sent: Tuesday, September 28, 2021 2:35 AM To: devel@edk2.groups.io >; kraxel@redhat.com= > Cc: Yao, Jiewen >; Ard Bi= esheuvel >; Jus= ten, Jordan L >= ; Singh, Brijesh >; Erd= em Aktas >; James Botto= mley >; Lendacky, Thomas > Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector On September 28, 2021 12:43 PM, Gerd Hoffmann wrote: > Hi, > > > > Can you move the metadata changes to a separate patch please? > > Yes, the metadata changes will be in a separate patch in the next versi= on. > > Can you also add a comment block documenting the format? Not only those > parts which are used for TDVF, but everything? The description in tdx-vi= rtual- > firmware-design-guide-rev-1.pdf seems to be incomplete, specifically the > option to use the table for TD memory allocation (as mentioned by Jiewen)= is > not covered. And possibly there is more which is missing ... Sure. I will add the comment in IntelTdxMetadata.asm to describe the format= of Tdx Metadata. Here is the PR I would send as the next version. https://nam11.safelinks.pr= otection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fp= ull%2F2018&data=3D04%7C01%7Cbrijesh.singh%40amd.com%7Cf49ea5bc7d79474e5= 72108d982529cbd%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63768411359027= 3535%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik= 1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DbGOxYMIKtHYKhcfk0Wt4qoIgiz3b9DM%2FA= D%2Fui3ByVrU%3D&reserved=3D0 You can have a preliminary review if you want. > > thanks, > Gerd > > > > > --_000_PH0PR11MB506499575BE68128554B9D9EC5AA9PH0PR11MB5064namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi, Brijesh

In the current discussion there are 2 options for th= e metadata, a unified Metadata and 2 separate Metadata (SEV and TDX metadat= a).

My understanding to your last mail is that you’= ;re going to use the unified Metadata option, right?

 

As to the offset of metadata, absolute offset is a g= ood idea. I will update it in my next version.

 

Thanks!

Min

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Brijesh Singh via groups.io
Sent: Tuesday, September 28, 2021 11:24 PM
To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io; krax= el@redhat.com
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Ard Biesheuvel <ard= b+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com&= gt;; Erdem Aktas <erdemaktas@google.com>; James Bottomley <jejb@li= nux.ibm.com>; Lendacky, Thomas <Thomas.Lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector

 

[AMD Official Use Only]

 

May I a= sk to use the OvmfMetadata instead of the of TdxMetadata for the Guide= d structure name label (same as what I did in SNP series patch #4). If you = can send the metadata introduction as a patch separately then add the TDX descriptor in TDX series. I can try to make it= work for the SNP series and add SNP specific descriptors. Additionally, I = think you want to provide an absolute offset for the start of the meta= data instead relative value so that VMM can very easily reach to the start of metadata. 

e.g

&n= bsp;

+OvmfMetadataOffsetStart:
+  DD      (fourGigaby= tes - OvmfMetadataGuid - 16)
+  DW      O= vmfMetadataOffsetEnd - OvmfMetadataOffsetStart
+  DB      0= x35, 0x65, 0x7a, 0xe4, 0x4a, 0x98, 0x98, 0x47
+  DB      0= x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2
+OvmfMetadataOffsetEnd:

&n= bsp;

For SNP= series, I will 3 section types #1 CPUID, # Secrets, and #3 SEC_MEM and wil= l probably add a total of 3 more descriptors. 

&n= bsp;

From: Xu, Min M <min.m.xu@intel.com>
Sent: Tuesday, September 28, 2021 2:35 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; kraxel@redhat.com <kraxel@redhat.com>
Cc: Yao, Jiewen <jiewen.y= ao@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Singh, Brijesh <brijesh.singh@= amd.com>; Erdem Aktas <e= rdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Lendacky, Thomas <Thomas.Lendacky@amd.com= >
Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector

 

On September 28, 2021= 12:43 PM, Gerd Hoffmann wrote:
>   Hi,
>
> > > Can you move the metadata changes to a separate patch please= ?
> > Yes, the metadata changes will be in a separate patch in the next= version.
>
> Can you also add a comment block documenting the format?  Not onl= y those
> parts which are used for TDVF, but everything?  The description i= n tdx-virtual-
> firmware-design-guide-rev-1.pdf seems to be incomplete, specifically t= he
> option to use the table for TD memory allocation (as mentioned by Jiew= en) is
> not covered.  And possibly there is more which is missing ...
Sure. I will add the comment in IntelTdxMetadata.asm to describe the format= of Tdx Metadata.
Here is the PR I would send as the next version. https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Ftianocore%2Fedk2%2Fpull%2F2018&amp;data=3D04%7C01%7Cbrijesh.singh= %40amd.com%7Cf49ea5bc7d79474e572108d982529cbd%7C3dd8961fe4884e608e11a82d994= e183d%7C0%7C0%7C637684113590273535%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw= MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3Db= GOxYMIKtHYKhcfk0Wt4qoIgiz3b9DM%2FAD%2Fui3ByVrU%3D&amp;reserved=3D0<= br> You can have a preliminary review if you want.
>
> thanks,
>   Gerd
>
>
>
>
>

--_000_PH0PR11MB506499575BE68128554B9D9EC5AA9PH0PR11MB5064namp_--