From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C8813AC0684 for ; Wed, 25 Oct 2023 01:30:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SETAA4k4LZ94thXGQvH+3onIE3U4fgayztNbIb5ZxpU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698197437; v=1; b=ol7LcadfDd2UQ0gHuhqe/RuG6578sN0SVuKkecql1vXnmSoclA+K+6QMdDKE/JcMx3YsNF/f xhRFz7I3QL+sn1Hj431P/3XUFZ6haFPQRrc9Zb/pynbiH7844pOSeZ+EYLKlxPPaUd2xNssUnS8 NKMzGNXOsQqe05mASwnZcA5A= X-Received: by 127.0.0.2 with SMTP id QgWEYY7687511xFK48i8a0lA; Tue, 24 Oct 2023 18:30:37 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.164546.1698197436126861410 for ; Tue, 24 Oct 2023 18:30:36 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="372272362" X-IronPort-AV: E=Sophos;i="6.03,249,1694761200"; d="scan'208";a="372272362" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 18:30:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="882282933" X-IronPort-AV: E=Sophos;i="6.03,249,1694761200"; d="scan'208";a="882282933" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2023 18:30:35 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 24 Oct 2023 18:30:35 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 24 Oct 2023 18:30:35 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 24 Oct 2023 18:30:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fHWgRueFmDofTuhTzTvvbD8UfH7pSkodYk3xtuP4s/Xi5NgaqdDURZgHIphnRVQIxfH0Y1x82ZD068Z3ygqOHZ9Ge3xGtOSFZ67UXo2OE7Ae+TWkWB6RHNb6mKbfKYV/cmN7Iui+14I1NW9QetEQj2Kon0idWo8qCQ87WWeVRud2lE8buHme6AGWWhi7ErKRvbosudCGdefz8Ntg3LAb1x4T47B3bt3+qfF4nvZkBQHFpTKocLZI70b/DD8i9h1LiuTBiExBgff4TsA/aPVhJtxY2braJXXcXVA1oi3u3GNxX4/wo5GsNrEXspeyC1Nptbr9YdhRhLS9nCVFpsBI9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VP713kG7Bz9XeMGJLNVCi14j4mB8n0pt8dYdJkJlR8U=; b=GRqyXZHPzhMi8DdPg1mvpdHfqeJbWhZqHmM2PjTOxRr23xS6rl866vjrxoYbodMsdcnFf0ks+Zm3Lh4G2HL5c9A2zqTEdNLOEan2l8fqaaMtf6JNtoApNJ9lfEWwDoyu41GTAj3H47oJFEyLCM3vxdrXbDIIWVRo3CLZd0Oqd84551oEgJl0PjyJojZoXBFre0dw8ImoCnfafg0/QKNjjl22YslQGfU8fyMZjlfZ+7x0sDGEAJy55j8baMmoFw9U4DYeTpBnuhdhkf5TJNcl5p2/TgNfqFhMEJvYRIDqa15BDICRuYuJUxmR9w4qx3MPogjQweQXEI+aJt/Zx5OLrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by SN7PR11MB7591.namprd11.prod.outlook.com (2603:10b6:806:32b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Wed, 25 Oct 2023 01:30:25 +0000 X-Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::6e52:bcf2:fc8b:c263]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::6e52:bcf2:fc8b:c263%5]) with mapi id 15.20.6907.032; Wed, 25 Oct 2023 01:30:25 +0000 From: "Min Xu" To: "Sun, CepingX" , "devel@edk2.groups.io" CC: "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Michael Roth , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Fix Coverity report issues Thread-Topic: [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Fix Coverity report issues Thread-Index: AQHaBZAoiwgETKWkrkmQjkpLUaTEgrBZuOkw Date: Wed, 25 Oct 2023 01:30:25 +0000 Message-ID: References: <20231023090539.1003-1-cepingx.sun@intel.com> In-Reply-To: <20231023090539.1003-1-cepingx.sun@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5064:EE_|SN7PR11MB7591:EE_ x-ms-office365-filtering-correlation-id: 8e486e7a-0608-41e3-2033-08dbd4f9f6a0 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: aN9KpzOxI2+FWP8+jVfF1qYfzvWXJFKE+MXLkYjOMXN5ilRScqxL3+tEAOTjho7ASgEhhZsdjD40pLuf8c5+2ieHTSUHz7jmU6h3Rmg0QZR5ylm8hUoPFZ1xnbsYp/yw7TR2Kzi2rlIyXo+vm4MJkVMr24fMdt4sRtTYfNS9wWtsMNYdnwqSugqbSEUZseDJZgyOIfvpQm7Et7HIHrxOYjtyxedCuVVhd95Cbz6bv2ih78vK1Xd3nme25BqhKKI8gvFHOr7rAO3hnQZuTsDMhBW3Y3uHerrOXQJnRaGLFmgBnmCewUUUWcWFbaBkLlZEbaEgkBe+AO8QFx++OyBTWmEsdhaqIqjxB4WXF0CNwzDZDbI53QenvRKdZTBb+gj9dWV7WLQy4XsTvqWIAUtNO+RYG5qyY+9AkqU2zZtcols9fwLfMmKxCuzkVj/u1J9j0+0mwo45MmckBqrpt+T6ZoGPzJukUUitUlPZhgPEM/m4vDzzzbHXH9Wx0vSfiMX8Z5V1zQxAYCgXJOQ2ujRW4bbSYxMBgXH4W7ccoCVAldBX19NRy+V0ZMIueTeSaYtTGO+wN5/lKXve2HZ68ZevOU2Rr/NMsegP8A6aGKmFoLE6/ewUKZYB9zw7UsAQg81qxhBqWvEysusbdWPNrqmm/w== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x99QmbX4FjcthmO0xciddmSS63U8390i31VikDKSUcqcnvzvCosZgPqdAz2h?= =?us-ascii?Q?EsHsEf+X3qO6kQWWqmpKIM8XCDj3l/jmMuestWkhDBvnwx/AFKeyZnOpfdOe?= =?us-ascii?Q?fK4IqUcIJI7efyjWH4VY8iFlzkA8hLQHRbTeHZF8HEskX2sG48xfg4u48WJl?= =?us-ascii?Q?zHvvwrTYK/LukQNy93XCQqoPkSigdoevcss5PZDOrFrWgYq6Q258HCDH/hWQ?= =?us-ascii?Q?0oL0ldwW3dSAaUr3zfRnCkiCH38z4gZmuRvMRzcZKEWKx7Cdiq5mlVjVbSrE?= =?us-ascii?Q?+8VOrhnai8/rtJLQ7Vjp7zYXaKRNSCMv16tU+t6V7i/jT6H3jZge67pP76iH?= =?us-ascii?Q?TVqDKD/eXpuWpyTmcaxA4g3OfRpP0C4QdVNDmW8aSwVbxCUOtYOniuulJ6fE?= =?us-ascii?Q?TrYcW12vV52hcnejG/RjAc1N2Eijwan3x4378bOC+xYlJG7MTAg7kkY4x/ns?= =?us-ascii?Q?hk0UbFtwBBC01eCiKS26jbqS6kQoGNNBIV+XYgDaR/ps7We3nLFo0kFf5m9d?= =?us-ascii?Q?icgiHfVlDB7Rcqe/oeKtlPYzBUUD3vFifdTWCtfOfYSb7SR5FlNJt3mm9aFA?= =?us-ascii?Q?8UDpzsMPeKtPpzqb7IGR1mhFrc8AAsrw7VaN5vOlxKFEbhSRIPGSxr7U1HwU?= =?us-ascii?Q?OzDl4Qtp/KZ/BW5g2jlyKpFRWpL22U0UQ8E0KMJrKmLhuJhaUnv0dyIJ6eDA?= =?us-ascii?Q?f0dFTmL5nIqknyyVnIfY4DknpK/NwhdGeOzkqrGYzVPs4or26hQ6dVekRXMf?= =?us-ascii?Q?Eqvgebjnc6h2hWCG+4zfTGA6oq2fgNvUCla0mAIdOGZRc6rH9hEMuJikBaNT?= =?us-ascii?Q?alMZcRPJvq/zoJ7Ahnpt0zKvHBqZjcmxiwSRNwnmutJ/EjrDJ4HVsGOMq6WH?= =?us-ascii?Q?kGtmLhMpwxbpdiKiyQn8L12czZ3I5DtfvwOValoOKKbs03e8vrXX6qUwyNl9?= =?us-ascii?Q?F2WIZlL60KcqFQw2sDAAOPmwWg3ROA91OR295v/29yUXR+lbEwS2bX3t7QGW?= =?us-ascii?Q?o03DJ7SbA5TU5WbfPn0Eh4jh/Ib49xXWwvZPU0GjwtgPpKIbgMY3b0SV101E?= =?us-ascii?Q?brbZdqA/4aacJb8cgB+2acUNJuKDsJtOfNA9rd1pzC78bF86jzSfGL/7iPuA?= =?us-ascii?Q?CHXLT8WxYbNj9sg5E36um9ZfmZEu3z6IwI7YV1skDHea4I7B4HMq4NW5I0p4?= =?us-ascii?Q?T4Iy2BSWaW/zWCSnbbJ3FjHWTD31r2OaJCsKR9zJxVGj+kOWwrGI6qnrKKE6?= =?us-ascii?Q?kXUhGuLpBYf851/Xa+1OLnFfrYpRbLVoqd4gECWhtYPxzBp6LcvtOYY+DW19?= =?us-ascii?Q?J1+K/huH28VWBXbVOUx9Qd6eoLN+/QyGMWCM1IBP8jhc9AkvvQ9KpfNLkzeM?= =?us-ascii?Q?lcsQs4aaoAvGoqCr6P2tFcV50OPfIwPlfpJ8SyFJTwtmjFsrP1IfYiRnwMg/?= =?us-ascii?Q?HPEbt2uR2kUk13h4h2V3G1clcQpTxucjC+A5AUxZCzaq5D+X09gUrGamPGnO?= =?us-ascii?Q?O31PUVn1Pbehu6U/ADqUFuegWc0G6yeUhz9TKEWRehiiN1aQtvi2T/Cwsg6D?= =?us-ascii?Q?IAYj1tf9vQb1IPSA/VeULhNb0lv4vJbADkcgWW1v?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e486e7a-0608-41e3-2033-08dbd4f9f6a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2023 01:30:25.2642 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dcEhK3U3/xx00n3SX/MxV6P9BbkRLTVsBc/2rpbjbqwXBTqKXvfccXMAfzKhp3AmiurPSqoON0S2ul5scvZvKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7591 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Kydg09HGHQrB1rKo8HjBeHmix7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ol7Lcadf; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Min Xu > -----Original Message----- > From: Sun, CepingX > Sent: Monday, October 23, 2023 5:06 PM > To: devel@edk2.groups.io > Cc: Sun, CepingX ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Xu, Min M ; Tom > Lendacky ; Michael Roth > ; Gerd Hoffmann > Subject: [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Fix Coverity report > issues >=20 > From: Ceping Sun >=20 > v1 -> v2 Changed list: > 1:Since both commits are intended to fix coverity issues, they are merge= d > into one > 2: Changed the debug info level to debug error when "DsdtTable =3D=3D NU= LL" > 3:Add the Cc member as below > Erdem Aktas erdemaktas@google.com > James Bottomley jejb@linux.ibm.com > Tom Lendacky thomas.lendacky@amd.com > Michael Roth michael.roth@amd.com >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4568 >=20 > The function InstallCloudHvTablesTdx had an Assert when "DsdtTable =3D=3D > NULL", but this comes into play only in DEBUG mode. In Release mode , > there is no handling if the pointer is NULL. To avoid the possible null p= ointer > dereference, it is better to handle it when the pointer is null. >=20 > In addition, the status of "AcpiProtocol->InstallAcpiTable" is overwritte= n > before it can be used in the function, it is better to check it before > overwriting. >=20 > code: https://github.com/sunceping/edk2/tree/fixcoverityerrors.v2 >=20 > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Tom Lendacky > Cc: Michael Roth > Cc: Gerd Hoffmann > Signed-off-by: Ceping Sun > --- > OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c > b/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c > index d3e73c155e8f..4629fa260366 100644 > --- a/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c > +++ b/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c > @@ -53,6 +53,11 @@ InstallCloudHvTablesTdx ( > CurrentTable->Length, > &TableHandle > ); > + if (EFI_ERROR (Status)) { > + ASSERT_EFI_ERROR (Status); > + return Status; > + } > + > for (UINTN i =3D 0; i < CurrentTable->Length; i++) { > DEBUG ((DEBUG_INFO, " %x", *((UINT8 *)CurrentTable + i))); > } > @@ -69,8 +74,9 @@ InstallCloudHvTablesTdx ( > // then we're out of sync with the hypervisor, and cannot continue. > // > if (DsdtTable =3D=3D NULL) { > - DEBUG ((DEBUG_INFO, "%a: no DSDT found\n", __func__)); > + DEBUG ((DEBUG_ERROR, "%a: no DSDT found\n", __func__)); > ASSERT (FALSE); > + CpuDeadLoop (); > } >=20 > Status =3D AcpiProtocol->InstallAcpiTable ( > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110013): https://edk2.groups.io/g/devel/message/110013 Mute This Topic: https://groups.io/mt/102131520/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-