From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.21340.1661414223359176171 for ; Thu, 25 Aug 2022 00:57:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NDUFHskc; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661414223; x=1692950223; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6ytQZmUK6z906WDcJaSREEagtQHCc3NHC29D25b3afo=; b=NDUFHskctvr7xibd2Bm1tNwQBduD/dWP1ofBc9x9i079BMTOYRNn7sjm kOueu4zzDNx4tYRW635TK+4dMF+D5x0+rhLKoasA0VVfAaJR0D3f65KWV ozAwk+M3l/Hk3wjxLIaM5sIXs+8ZDLXhPsY+pRA59fVDRjmx5q6KIi2Tw rAD/at6433IlheKT6poNgiRINjYwDnpECfzump13++J/7X2tYsPR5HU+l COUo7bbK7iqsIppnMDQcwpeHR+kg6h1jg+ZdMJUtSUikAZ2tNEF2xLhA8 mckquVluWd9623iBqAjEqR2Lmu6iXub/oa4IfqNd2MaLkXqbF81spGDnX Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10449"; a="291743938" X-IronPort-AV: E=Sophos;i="5.93,262,1654585200"; d="scan'208";a="291743938" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2022 00:57:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,262,1654585200"; d="scan'208";a="586770837" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 25 Aug 2022 00:56:55 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 25 Aug 2022 00:56:54 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 25 Aug 2022 00:56:54 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 25 Aug 2022 00:56:54 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 25 Aug 2022 00:56:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5Dgn73gWvpiel/uAjhbAFo4cS3H2YxtLEK/dOtGDcgnKhOEFE86xdVnMQIJVXltDiGIie/OKkKYTpnl6xtNTS2sKeCaeGnVIJuuqys9bYQaF99BZZbousPj1rU2q/Bvo6PfguaimNYCd/IpsFpWbWy9VeyH8WKuDVYsksnoxIKeF74ZxJmCxzqb993diyhqUygNthVRWvDUH7Z8vuafNZJU/1RbNbRkNt4B8Z+6kWhQsOBv4czKZzu8svbCTzWiHqekKt3GwNYvNc5yxceubAplsuhvAXr4D6L/ofx92p8VB1PZw6QX3K2ewkrB80DJYngKx0LtcjCzY9j3ErVMrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DMajatMC8EmF5nJE558u3xo8U40z0m2RrnS8fwR8YBE=; b=DEyrnuVeFe992/Bv89XEtZbZjaFQF0bmG1js5c1aOoselyh7W30koY9eJG2P2o4j7Wb4X8T7kTTEyYNf06jiJ9QRvyrGBXvhD3rJpEQe5Kk2vsvMnNtIwzVBB9erld6WRHz/OyE20LVwym+OA6pqZs35zPCg1Wd45VV9+qCK64mJWrXUfIVBAFHRou/BK7eVGnzgu9OMrgxCHqqyWtbnuu1Zs2YVGmzlaK5usoUdTrStRQT6bQyIrJqOlysTkLDr/+YXpR1WHXjCMqn2EFgxrISfDOng/0SpOj/kTspGDvD+P13WtQKf8hxGLxEjKmGgqkPBtONKDre5xJxKERx/dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BN0PR11MB5744.namprd11.prod.outlook.com (2603:10b6:408:166::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 25 Aug 2022 07:56:51 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ec3f:8428:41d6:3284]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ec3f:8428:41d6:3284%4]) with mapi id 15.20.5566.014; Thu, 25 Aug 2022 07:56:50 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "thomas.lendacky@amd.com" , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA Thread-Index: AQHYtc4z5aKi8l6fvU+iczNv26Kj5K26nSEAgAEW23CAAGbwgIAAD9DggABMQICAAqYhIIAAI7OAgAABm8A= Date: Thu, 25 Aug 2022 07:56:50 +0000 Message-ID: References: <20220822022301.1454-1-min.m.xu@intel.com> <20220822085130.sdmuz3schsia4fxw@sirius.home.kraxel.org> <20220823073759.qwcbpaohiqjnzrrh@sirius.home.kraxel.org> <20220825074223.qrjhfb5fcixtgq3a@sirius.home.kraxel.org> In-Reply-To: <20220825074223.qrjhfb5fcixtgq3a@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 957ebf5c-5d52-40bf-819c-08da866f5e55 x-ms-traffictypediagnostic: BN0PR11MB5744:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QgQzn/Rmd4MeU9K/fyMrRffQl0sP6XeFpyw5fjGzQ00BUif6xj9EjbvhWgdytVxyF23nsVY1XNanhT9CUXE8jxITObbIQKooQjVW9v6Hgb3goWox+aXEpTrvN8s7LVhARf5Sl8YS1NN1iB3DJ4Dtw+Skanwr7ZkywNbbzWE1RAnFFhozJnqAa6pOIPEa2YkpAsrR8G4q0TjWGkQ0Ul2YGhBpTJj5wFBfBGyoD5oL1YUOip3LdXk0Q3OUbaLBKrfxtWB+7VUAGSv9ZxoobsUZyLePhIha18D8qqfaavvQDIAPa3mo4VZwtX9wknfcXoL/sRIzEfSsGHv1QWMFJAyk79Bk6SHTof8FkreTrAVGXT07px7YF/cIWA7ENLrY2/ZV69ZdQ9QfGyShvBS++hNoWELgi5yMsJ4N0K5elfXkuxUtQx+r2kEDmsP0eDoz1V3Q9AAFu2pOOyekRDADB8IgOfKf3OsDnVS+QZXkL2VqhZ5qgYgwPgvbQcZgY975EHTQyrNgzkIu1cPmzmUeImIaYxIf7SpwUJG4huS2tg6HI/Q5OQQY4/rtoM4jA69C+UTA5/6Lw7INbGn2uxGDmkHUnO3d3QjeHcsBupYrSy8KF1+Dkww2wM6/oJesCphZif+Nsu6Y9lTdFyJJ9Jl67THNb3EYhnKza4mrIm+1Elvb9VkFoddXyWGhu6t9vNgce2rmE2gZYLUTy7Mi37SuBMQLCE32TqO4+53myzaBxHWVihkSili2DZytkwXp29lrnzlzJUp3V4g+m59eiN0kdUmMZey2GyzbD/KA5vgGbsmf159BMyItVUlIbdMsIOAmwK4sZCMZdzpdjRh8uscDSXr+pA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(39860400002)(376002)(366004)(136003)(6506007)(5660300002)(107886003)(71200400001)(966005)(41300700001)(478600001)(7696005)(9686003)(83380400001)(26005)(186003)(55016003)(8936002)(52536014)(316002)(54906003)(19627235002)(2906002)(4326008)(33656002)(66946007)(38100700002)(66556008)(66476007)(8676002)(76116006)(86362001)(66446008)(110136005)(122000001)(64756008)(82960400001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o6gOzLetolFcsXeBONgf7FBBRyYjWBD6zr+BPotidVK56iatToOYBTWxFaj+?= =?us-ascii?Q?Llhqxiw7ACimjxSyLEwpsOJz/UybQ6pAapxvVrzUCMwRLpgRVAIa33WP6N01?= =?us-ascii?Q?KD6186AZiSmc+42UuI0ahFMEWo10ru6Np9aRy23q6A9NZ6VOLw/MMkVouE7N?= =?us-ascii?Q?Pa3VwHl8epvO5Sj+3e1ZEOT6U3KXhPdg463uITqD0WIgZ6bhv3/yiOKaS2pC?= =?us-ascii?Q?Z0iWbWwQNRGy0vjfVQ4a00B2Yvhb7ctEXgh6MkVFnbX5HEUU+UP6BcgHjtCa?= =?us-ascii?Q?rwuHth8oUThGtYQMdnE2GH129f46T4AeBmEubee4J44ocoaIihKRVYfekoId?= =?us-ascii?Q?soJyDtssvXll0MPJCAQUowOQC/wDs12f69a4PR2jcml96PRcHdsvwTVC2+z6?= =?us-ascii?Q?poWRKtEqaU12Ciybte6OpBona30FqTZzarojLmoWKiMNNRpoZ4ba4/qgK6/Z?= =?us-ascii?Q?LV2yUtB92cf0gXWiZ6k66+VVUFMBHYTKXhY07ItHwiTODd0yely1nKla7Asa?= =?us-ascii?Q?t1KBFoUGND25ijwgeHT8xtuRW0Gb1dfs4QJF62XQAG/+8PKKlwKPRl5+1rDL?= =?us-ascii?Q?wMCix6vx98xlk9AzZgkJExcOHihQ859XMoKzFNH5rR8UL8b2Ngjd5vu3whAq?= =?us-ascii?Q?2cWunDwSEGDnHcx/UazH3cSyzgJmAZE4YpQpEOxuxRYUeNkrWpRnHIDp3uNz?= =?us-ascii?Q?Ix2bbzryT3xlREgodnevwUYA6SwKUQQGtPn9tdU3Gr6tPJYktROrcXDi0s/T?= =?us-ascii?Q?ahVBjvfbR3mZG21qz8WpsZW7sFAa6Bz45oz44BNBH/xsFUVZD0ogTnazxIRK?= =?us-ascii?Q?UoUuNxpo7aJWI9EaUsU06nln+AtWsWdciXvEEo4XKzferK26hbkBVizQJrJD?= =?us-ascii?Q?dEYn9NrwjWmBjeXofcsbBCvNppA1k2SN/+uEUozlNJywLQXM4OW1iZ6TNPZs?= =?us-ascii?Q?FpMFBPq9sX+ZVrYWQ48Ib5DEE+7N1BvGtrj1cE4Jms0qkH4hHqWsqpgbDWKW?= =?us-ascii?Q?L1O4v1+WZAsW8ldxa1w+iaH3+YwW8sqa0+1P32OnLZeSIA5wHk8Aav7ql+wJ?= =?us-ascii?Q?yFhQQ7hkfD+qoRCo4YMcsomaF1po0YIIojOy0q6SJsmiw1cXt429NW2qViXQ?= =?us-ascii?Q?vIh+55Hm+2bcah0enUbxcqxO2ar3TSwbu+LWJZJU1TqfQ8ggyUOC4Brfz2UG?= =?us-ascii?Q?yiuSl/YYSXX5QMRtKLsOE+yDsK6k5MBoenZxRbqUh7MNKCiNHZwje/BBnz1T?= =?us-ascii?Q?hsIfQZUhM7PyRGZnlpwcNDGLKYqvOq6g093KtitEWv7dFRk6cwvlJwu2KRzf?= =?us-ascii?Q?p7zHIJh/psrJ1ijIjx96Ubvpr3WCELqu1DBFQ1ZpRx2R1bzsrgQmA6Ll/15k?= =?us-ascii?Q?w1XAAXScB63iz7m4mGx7JIG6htjcTbOmbItRas9ZvnkFXEu6UyFfva70/bIF?= =?us-ascii?Q?Jnf6qsA5et8ATQFOhNQLL0HYxNxi8yEZItZr+mdpP0/S7jxz4RKjPQcYOooQ?= =?us-ascii?Q?BIL/E4zPLEC5CPDV4DqSQO5F6Du+Aaa9P+C1GK4irE+s+d2/kKDs95ng2VQv?= =?us-ascii?Q?welTNyG8TlPWUQGdOW6BFAPyXYs0y7u00m9CWYT/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 957ebf5c-5d52-40bf-819c-08da866f5e55 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2022 07:56:50.8032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QNDKw4xtH+I87eEqf5lrZ8hMSrYXF/hMoZ0SsYYI7yZlhoIRRtDiz3qwh6TwDlbUCx6OiL4E7agq70Nh7FQUug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5744 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On August 25, 2022 3:42 PM, Gerd Hoffmann wrote: > Hi, >=20 > > > Runtime service call are restricted so that you don't have > > > concurrent threads executing (see section 8.1 of the specification). > > > Without that you would have problems with runtime services today. > > > > > One of the situation of CcProbe used is in BaseIoLib. > > https://github.com/tianocore/edk2/blob/master/MdePkg/Library/BaseIoLib > > Intrinsic/IoLibInternalTdx.c#L35-L40 > > > > BaseIoLib is a basic library and it may be called by APs. While dynamic= PCD > access is not allowed in APs. Of course we can cache the PCD in a variabl= e but > I think it is still not safe. > > > > Reserving the OVMF work area as RT_DATA breaks the original intention o= f > the design. > > > > Then how about this solution? > > https://edk2.groups.io/g/devel/message/91132 > > We can design 2 instances of CcProbe. One is to read the OvmfWorkArea. > The other is to call Cc guest specific way to determine the type. >=20 > When using RT_DATA is out of question there is no way around two instance= s > I think. >=20 > I don't see the point in reinventing the wheel though. We know what the > guest type is, why determine it *again*? We only need to copy the guest = type > from the work area to another place before it is gone. I think the dxe l= ibrary > instance could copy it to a variable in the init function. >=20 As I mentioned CcProbe is used in BaseIoLib which is a basic library and it= is used in SEC/PEI/DXE phases. Global variable cannot be used in SEC phase= . Unless BaseIoLib is split into 2 instance, one for SEC/PEI phase, the oth= er for DXE phase.=20 Gerd, do you mean this solution? Or there is another solution based on https://edk2.groups.io/g/devel/messag= e/91132 We can design 2 instances of CcProbe. One is to read the OvmfWorkArea. This= is for SEC/PEI phase. The other is to save the guest type in Ovmf work area to a global variable = in its init function. This is for DXE phase. Thanks Min