From: "Min Xu" <min.m.xu@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V4 06/12] OvmfPkg/PeilessStartupLib: Build GuidHob for Tdx measurement
Date: Fri, 27 Jan 2023 11:30:46 +0000 [thread overview]
Message-ID: <PH0PR11MB5064B205A3D71E5C25020166C5CC9@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230127075419.72x2sbvn2fcau3jw@sirius.home.kraxel.org>
On January 27, 2023 3:54 PM, Gerd Hoffmann wrote:
> On Fri, Jan 27, 2023 at 08:11:00AM +0800, Min Xu wrote:
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
> >
> What is the reason to create a new TdxHelperLib btw.?
> Are there any problems with the code being in PlatformInitLib?
>
When tdx-measurement is being enabled in OvmfPkgX64, we find below functions are needed.
- ProcessTdHob
- MeasureTdHob
- MeasureCfvImage
- BuildGuidHobForTdxMeasurement
The first one was implemented in PlatformInitLib. The others were implemented in PeilessStartupLib. These 4 functions should be implemented in one lib so that they could be called in both OvmfPkgX64 and IntelTdxX64.
So there are below 2 options
1) Implement all these 4 functions in PlatformInitLib
2) Implement all these 4 functions in a new TdxHelperLib
We choose option-2 (a new TdxHelperLib).
1. TdxHelperLib contains all the tdx specific helper functions as the lib name indicates.
2. We can avoid PlatformInitLib getting bigger and bigger by adding more and more functions. (these functions can be implemented in a separate lib)
3. Furthermore, PlatformTdxPublishRamRegions in PlatformInitLib can be moved to TdxHelperLib as well (we will submit a separate patch-set later). So that we can have a general-purpose PlatformInitLib.
Based on above consideration, we create a new TdxHelperLib.
Thanks
Min
next prev parent reply other threads:[~2023-01-27 11:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 0:10 [PATCH V4 00/12] Enable Tdx measurement in OvmfPkgX64 Min Xu
2023-01-27 0:10 ` [PATCH V4 01/12] OvmfPkg: Add Tdx measurement data structure in WorkArea Min Xu
2023-01-27 0:10 ` [PATCH V4 02/12] OvmfPkg/IntelTdx: Add TdxHelperLibNull Min Xu
2023-01-27 0:10 ` [PATCH V4 03/12] OvmfPkg/IntelTdx: Add SecTdxHelperLib Min Xu
2023-01-27 0:10 ` [PATCH V4 04/12] OvmfPkg/IntelTdx: Update tdx measurement in SEC phase Min Xu
2023-01-27 0:10 ` [PATCH V4 05/12] OvmfPkg/PeilessStartupLib: Update the define of FV_HANDOFF_TABLE_POINTERS2 Min Xu
2023-01-27 0:11 ` [PATCH V4 06/12] OvmfPkg/PeilessStartupLib: Build GuidHob for Tdx measurement Min Xu
2023-01-27 7:54 ` Gerd Hoffmann
2023-01-27 11:30 ` Min Xu [this message]
2023-01-27 11:49 ` Gerd Hoffmann
2023-01-28 11:55 ` Min Xu
2023-01-27 0:11 ` [PATCH V4 07/12] OvmfPkg/PeilessStartupLib: Call TdxHelperBuildGuidHobForTdxMeasurement Min Xu
2023-01-27 0:11 ` [PATCH V4 08/12] OvmfPkg/TdxHelperLib: Implement TdxHelperBuildGuidHobForTdxMeasurement Min Xu
2023-01-27 0:11 ` [PATCH V4 09/12] OvmfPkg: Enable Tdx measurement in OvmfPkgX64 Min Xu
2023-01-27 0:11 ` [PATCH V4 10/12] OvmfPkg/IntelTdx: Add PeiTdxHelperLib Min Xu
2023-01-27 0:11 ` [PATCH V4 11/12] OvmfPkg/PlatformPei: Build GuidHob for Tdx measurement Min Xu
2023-01-27 0:11 ` [PATCH V4 12/12] OvmfPkg/TdxHelperLib: Implement TdxHelperProcessTdHob Min Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5064B205A3D71E5C25020166C5CC9@PH0PR11MB5064.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox