Re: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib

["Min Xu" <min.m.xu@intel.com>]

On March 15, 2022 3:42 PM, Ni Ray wrote:
> +
> +%macro tdcall 0
> +    db 0x66,0x0f,0x01,0xcc
> +%endmacro
> 
> 1. can you please check whether the tdcall instruction is supported by latest
> NASM compiler?
I checked the NASM (2.15.05) doc https://www.nasm.us/xdoc/2.15.05/html/nasmdocb.html#section-B.1 but not find the tdcall instruction.
> 
> 
> +    AsmCpuid (CPUID_VERSION_INFO, NULL, NULL, &Ecx, NULL);
> +    if ((Ecx & BIT31) == 0) {
> 
> 2. Can you please update CPUID_VERSION_INFO_ECX in
> MdePkg/Include/Regiter/Intel/Cpuid.h for the BIT31?
Sure. It will be updated in the next version.
> 
> +      break;
> +    }
> +
> +    if (LargestEax < 0x21) {
> +      break;
> +    }
> +
> +    AsmCpuidEx (0x21, 0, &Eax, &Ebx, &Ecx, &Edx);
> +    if (  (Ebx != SIGNATURE_32 ('I', 'n', 't', 'e'))
> +       || (Edx != SIGNATURE_32 ('l', 'T', 'D', 'X'))
> +       || (Ecx != SIGNATURE_32 (' ', ' ', ' ', ' ')))
> +    {
> +      break;
> +    }
> +
> 
> 3. Similar comment as #2.
Sure. It will be updated in the next version.
> 
> 
> +%macro tdcall 0
> +    db 0x66,0x0f,0x01,0xcc
> +%endmacro
> 
> 4. similar comment as #1.
See my answer to comment #1.

Thanks
Min