From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.32539.1629159293012481457 for ; Mon, 16 Aug 2021 17:14:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=UFI5nT6+; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="279709328" X-IronPort-AV: E=Sophos;i="5.84,327,1620716400"; d="scan'208";a="279709328" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 17:14:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,327,1620716400"; d="scan'208";a="441309190" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 16 Aug 2021 17:14:51 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 17:14:51 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 17:14:50 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 16 Aug 2021 17:14:50 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 16 Aug 2021 17:14:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8AWEbfq8BeKA2SdhMpXuX3GVzAY1f5ppgS1HmU4cBj+SwtHrgVQILpZ0xXlIV5lKKMZmxNkO6R9D4OeO9glbZ1IcZT5PexJ0NaERu2Uu4akQNuh4ez+ShBAIHbxrWMnRGSHkX94O88S3PegUXu546XtmnSXBfTnHE4R0eHZA6p/llVTX2RWmFskff662PJ1cLOZNd4zZAk0XWXaJxgoJuC075gaPhG/TGaQybxStPKRvC1KAWj26b8PI/VAtEW0nXnT9OU3RNaaj1n0AwWO7IK8RgQkXY6EINbbEbcm81KcyzdmdCm9Zf28SAUznjW4WHBcucEvGjhHgPhC/qAXtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h6aZcqy43Et4kJit04ZyS259CTF0idA5XUtHZhc5xLQ=; b=Dyl5DfXh9omvjStJCXoB32WEII1Z/se61bDU8osdzBX6FXryoPoJkP41UrRs/GLhGMdCo7vvo+aSlokSuTdKI3tiP8PcFWITnvd/pfjTMqxdVRV7kbCOIaTpanhpvZRTk3QFI6kMHlrYp5hM7QSdnCe2pJwxFgqsB9KnX3Apt3ur+6dF8MqE3cfb2SKwWNCIFSUFsbds405IroEdtLULfQfV614rnT8Gf5BvckicLx6zwuSnHSwn5WcvBKKxEG6pfkqxa379diK0CHy3piMX/1az1Jj1Uzit2f2CRoCjoRQDi2BxyrNfKAGY0gf/QaYI/3PJchLUgyBXoqR1ZOSGUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h6aZcqy43Et4kJit04ZyS259CTF0idA5XUtHZhc5xLQ=; b=UFI5nT6+LngoCrduscC7uxjrLLo2U+S1d07E++lPPmP5Vxz8MabY9s+tL1QSOcfsp1PyNn8820cVaw0sNCg1Yo/c99DRZ0Wm/e9dhGK08Mr3vSqu9iyvqq4IBbwmybKHBxkXzmopsHdXeiBZPFzNdVe0Ww9yElaBPMjC1Ctbz+s= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB5109.namprd11.prod.outlook.com (2603:10b6:510:3e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15; Tue, 17 Aug 2021 00:14:44 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b%3]) with mapi id 15.20.4415.023; Tue, 17 Aug 2021 00:14:44 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Brijesh Singh" , Erdem Aktas , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" Subject: Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx Thread-Topic: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx Thread-Index: AQHXj3FCIAbAU4r56UqJemw0Tww+IKt151KAgADs5yA= Date: Tue, 17 Aug 2021 00:14:44 +0000 Message-ID: References: <20210816094301.2h3e4d747ig6eyrm@sirius.home.kraxel.org> In-Reply-To: <20210816094301.2h3e4d747ig6eyrm@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ae1bfe4-83ff-40c0-0e5d-08d96114040a x-ms-traffictypediagnostic: PH0PR11MB5109: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5LQkQfL9iJSER2DrhWxKsafj3EU2WD2FL8TmtfSA4sd+rQkv0GCPgJO1c0RYnOIcJvv4Gy7wo4BnMKNllOK/S2THLkNWhQ8EwPvMGIlIRfJUG4ZGO0F7IkfAyVAz9Kf9DsHZb412pogr66sBMhpTLNNzK8QsZoKK6FolwiHVBEMXiImzaUf+o4x+GDGTeCtsAK0YNEBZ8NN5AoAk0EXzsl+ucCd3DyxPxHTUluHhsGnaKTP1llTixKRfc83mdkzKbNQieikS9ZJxRrcO+FAXR1Uoki83BXQjwme9rKdD9lv67SARysv4AdoOkkunJFoZRAq5VLDQEbXAMpGbpMfxmjd5RT8tLEwbEGYOgQtXnBJiowgXZQpzLHTsl41eEZDLTDO62R1U1cxVhJEfTtLGfQu9Ty82Dybk59jgzUnmh0FUkMDgyH/bYg5Tcw3N+pakfgXKhmWcppqYyJoNigSA2b38Ot4W8HzRfKDb2vBd1mtL/7YkZmPV3ASv6fNcpbCkMu2xSxgjN6CeYyirBxNsqsadDJFi+sGhPk6oV2ZhMLQyOATLCKE4zonz3JvS3K/OFo5p0qmfC2H90B86UfOQED16v+eut5cxa10ws/fkB0kJUtZ7oCWuq3db6QVfXwfl0EEAsXXYS3ahiGryjyopJO0oQDm7UJZMwHHkYM94OWc6T1MIm32r1KwhT5bHkhr6ns0FXTprvGRxHkvHuXnQZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(366004)(136003)(39860400002)(376002)(2906002)(83380400001)(122000001)(478600001)(186003)(26005)(4326008)(8676002)(71200400001)(316002)(76116006)(38100700002)(66476007)(66556008)(52536014)(64756008)(66446008)(54906003)(8936002)(55016002)(38070700005)(66946007)(9686003)(110136005)(4744005)(53546011)(86362001)(33656002)(5660300002)(7696005)(19627235002)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lc8Bnu3CGeLxQYWcScyNaD8bjqcRFwrWnZGLcrxayW7oJisZyHatytuaAGla?= =?us-ascii?Q?i8BIME2TiyFT3EBPtc1tIZGimToir10UujcN1wNmKMiMLPUjzG0RQPXULlcY?= =?us-ascii?Q?G9nFu84u4kn4zuG7ake+JSDviYDVPzbfU/C1KiEV8lyB2h0XEAF55RsNM1jv?= =?us-ascii?Q?u1TlSq6zaKPRLw0/YpM7s57kCDtuV96SLJXWS39GSL1n2TaAxVAeT+RfetH5?= =?us-ascii?Q?cKlELw7wSIeuKOH3l+0lON295oFvEkzp7uzC65O9qG6DDVHLEGhcT3krujNZ?= =?us-ascii?Q?5UsMNLv4JgW2yKvt5g1qwFc30hhBYaAqzzfucJrK+9MU0r2/G1URFWA9+7V/?= =?us-ascii?Q?E0CofJNSOWJPJhC8hzQNlSK8YuzfWXQ7vbn/rDQpnBYPcvapvEvsGy4QgykB?= =?us-ascii?Q?b/1PWcTBDuncgur4HcIXWMuQFx00ND9atcbxt2629XZBuMXhrZygz1s4r9BW?= =?us-ascii?Q?nuLCV4VyQBOdsmke7kSdoC6YwUzpn4O4Eylogd+aAYv1m1s6VzLLyb75tiSN?= =?us-ascii?Q?+EPMUIGRtvkoJY2wYlDk+wsjxntYj+HsGLVVxkrNl2g0qEodWhPxa4KtpbND?= =?us-ascii?Q?EbHsZztY1xcShbGzZp4NCJlNCMGpSyWrlSQVynMVDm2nMT4WxjqWC+sRuUo+?= =?us-ascii?Q?GzGFt2/4Nx/AkebORgOO0bHvXfE7PioMSLWge9C2eKwYm9MUs/zrQ0II9DVf?= =?us-ascii?Q?O1rKFMEwg7XcRvKFXRHVOA6C2TEAnp9vuioN1rLeJPFIAE62Y5LhfDdwuncD?= =?us-ascii?Q?2nO7nYd/30ovq1PIPLRK9yn7pzxJShoViXqhtq1enbVzTxToFkzMXqM6HsDE?= =?us-ascii?Q?JIK757HOEenVxZHO0gA836F69pf4Q0b+Ks/yx6LBY6/zPZYnpBBcfDGDz9vg?= =?us-ascii?Q?NTr8v6lB1751NEkkwlkk/deGWfnPMsy86CZVnQMEAZr08ig2H6sKWUKGSLHx?= =?us-ascii?Q?dOMPMR2Pn0Uscazn4CL96l3O64lfLNtxy/WJR9F3a1VkTdDQqQH4ebvxNH51?= =?us-ascii?Q?4KGN/kc8x5iJreH0S2C1NawXjgKYZTh4EOJ2uztbUIT6hR5SRU+YbJS7STya?= =?us-ascii?Q?hTdS/kRDamU6DVpWEr396lnlOQV2duSQsHds6mj/J/LBUbCSehM7Y51zzb/V?= =?us-ascii?Q?DkMZQxYuoNqFIfcCet5EAGH9wuQe+XGUM6og9GE1S1EEmYItG6vSp4B/PU3j?= =?us-ascii?Q?y1zqYWck7lpl7ZO8+dCicprbNG0Kg8XOyrYtl+jYssQRrYPOHdDo7NLcCBKW?= =?us-ascii?Q?MGHAmqZmf1YngAS0l0EON+0iky7fxabiN6ShSFBwP3fEY1CmCk1u64/++3ua?= =?us-ascii?Q?efVxCOig6HS33DKt2LpFWWGt?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ae1bfe4-83ff-40c0-0e5d-08d96114040a X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 00:14:44.2712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f9nZDHbP20YxfzUo+MdszvDvJY3Y2aZdQw8D5RD6ZHmSQyodtivC2M+mtDCD8iffmqqVoU8S/41mYFJ0DzAtqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5109 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote: > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm >=20 > Any specific reason why you code up your own instead of using the existin= g > cpuid functions in BaseLib ? Actually there is no specific reason. I am not sure if AsmCpuid is a prefer= red way in this situation? If yes I will update my code to use AsmCpuid. >=20 Thanks! Min