From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.4562.1645664969570793652 for ; Wed, 23 Feb 2022 17:09:29 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=eBcanKex; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645664969; x=1677200969; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=sNvqYGhuLUj+I6fo7Q1g/DWgpatN2NfHhV9ZwQMswqA=; b=eBcanKexRa9V2Czgksq+ZisrbnpLc+To3qj8SN4FbyVZSQtEQF05rtgp MclDc+bx6UGAY1U45GVNJYcqSTv9l2th7d6GOyv2jmfpwXu3nHRrgR1pA DFNTXUP3laN9liKVPG2/Jn8ksHJU8ZGcBjBVr/7ZRSvyw9WIKzmawAPvT AhH80kIUv4zEntSqTV0n3S8xVXYsXGoaZEJDH3GkCNJW149YdMF/6IV/2 18e8v+RkrfgLA30rXl6rQAi2RRAnbP8YqSRo7CHvnOL6UgsTei5HoEdIv YonSKhV0V15KG8HgRvmL0+C4zRVbxkJoMk+GLrhx9oxXUdK/qjb5rSadZ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="315346852" X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="315346852" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 17:09:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="639532240" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 23 Feb 2022 17:09:26 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 17:09:26 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 23 Feb 2022 17:09:26 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 17:09:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ErqyhVeJkTs/+6gYGspPzMm3Yp1m5zvm58CT9yIEPLMrc5fgNaiU77kFBqqcOomtY7UB0fTPUog/5m7LoRRxPOnpFsJX1oVkpY8x8qULoyTPXejLXFjErDVHvzFR3P78u14iWbdl3s7FmYPwRjQbT3U3LqMkKv51rp5JCoOOsh5WOOKecJb7WSgwzLjhTuU+v9jOIwjuc3NTkL5EhvM5ffHxkL58o3TiWD+8hQGq1sBn43888E2nhVZuS8kYNg41t2860Wfrwv+cWf8T+8KhNC5OEFgJy8dlD0CtuOz0UqqjPVJKr5Mc2itsjpdx11IHWRsRkSaMYed5pq7eDrjxZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ncO35VpVQZ8oF7OjWgaPPYETi480t8pKBZY9K2v5bY=; b=Vx3NyDb4Ds5ArjniWdajjRa1bkyMGlQbktYPotV3kKbRBOt8nMs28g05pFKNzac/jR1/Tp7RdO1p0Rbm085M9AWIeHgiLavH41B7qc30JkM7fM88yEfn4wP0P7pyDEFQUrLLBh94wc1Gn//3H2FzLeDRsiqRak3YeeJs+Pe7cjz2QMCKxe8Hdy9z/f7BXwMyQn/BWXRzQ+BdgnpTJWInTLeLZhN8JzhJHyTkbxV1xH8h4mQAmEI1Fg//99h21bOb9JZeckID+1TZhEJ5pbg275mUQFluaw6fxXeEbvk6iojFLKTq3bWvTxSA8asy6oOCCH0NGmEQJ+4SYWm9zV0mhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM5PR1101MB2204.namprd11.prod.outlook.com (2603:10b6:4:58::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb 2022 01:09:24 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%8]) with mapi id 15.20.4995.026; Thu, 24 Feb 2022 01:09:24 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" Subject: Re: [edk2-devel] [PATCH V3 4/8] OvmfPkg: Add TdxStartupLib Thread-Topic: [edk2-devel] [PATCH V3 4/8] OvmfPkg: Add TdxStartupLib Thread-Index: AQHYJgJSQWo6h8tEWESjQLE/AJKYBKyg+jaAgADuFlA= Date: Thu, 24 Feb 2022 01:09:24 +0000 Message-ID: References: <20220220023319.1495-1-min.m.xu@intel.com> <20220220023319.1495-5-min.m.xu@intel.com> <20220223105005.tfb7uk2qk5iac4l3@sirius.home.kraxel.org> In-Reply-To: <20220223105005.tfb7uk2qk5iac4l3@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 02dbe21e-369e-4451-50c0-08d9f7324bd6 x-ms-traffictypediagnostic: DM5PR1101MB2204:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iyVBPKP001fnMd3t0jaL7Y3kLwG6+5RQdjY6limI4z7EQFWiaKcZ0elOOfFqfUJ319RWhUq9GS4LSWED/Q+846qUxr7P5PaY5+6ov/oSH3KRW3DyMUu/hwP04ZzkV9yfwmE6XNWNphA14+yqzljacHmJEHObUtdjxYT3voZ0MzAMu/huIFHxX8cr3jgCnTnl3yHjsw5WbebmTgwzSxnQdpFZ5ItaiBCkaTFN62oDAhXznxyxYQpD+mK7m7z3pl8p0mXQJRAVPAqaAaCFShqjxv2EU04+e2SYSF+zkHu1v3PsQ3rckuse/2VwAQ3SlwLNpA9owxjhYWbkw3TUY34gDGaK7WIG/DsEnAQ2XFzassmn7Keim+8FTte/6GbLAf8WJGPwtavjBlcIkbacp1JMvZduwu2Z4cT1HT+V0oKhBlsWpr1Kh1KZ/9lcRvFawTWFwT5iVtYe/TDRV/qvQvWL4Bn0Hwre2hRbFzeFrNR3qFi0NEB3xCVJrP1pzjABZrOtP+qLiz9FRqu5QEiIP3Ld0s0OeNoFIYTvClavd0/KDVl9vL/WIZTKmz76qBnIXT4nYxdbWI0nF+tKiYTKVS2uw4/WElxD+qCjDz6waAL8MMC0PUw7RzA7p9FgGdIBOkgsXE2AbpakaTHk8M3HSonIXCq6tnNzGhtBRhfi32NyRHMWbwf7oxVyqS7BCSWTtFJMh/WeJtlqUfxgIWOE3AuXEA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(52536014)(7696005)(8936002)(38100700002)(33656002)(508600001)(6506007)(54906003)(110136005)(86362001)(2906002)(8676002)(38070700005)(4326008)(82960400001)(66476007)(122000001)(186003)(26005)(66446008)(64756008)(66946007)(316002)(66556008)(76116006)(55016003)(71200400001)(83380400001)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4Jiii6giOcadn2ObEAaqi9w+WhXkB6RK3KPZQ4OnPkQL4JvN9n4fT3kTugqW?= =?us-ascii?Q?VQpn8xREMP3ayCXcPcZ2GUIS88CaDRCXwn8JfRVNKstCLbK9gYl31Wa6QcVs?= =?us-ascii?Q?hh6gX6/pfy3aCG1SPBv/RqRrkYx9dvS3Gg8wmNCkz50ZCDfHFkMRokeqBNgr?= =?us-ascii?Q?xlYx5ztJPlfMXITbonqg47lIQbhvzB/kB1hMj4vDvwz1KcKUmS4DRl1T660S?= =?us-ascii?Q?TqWOgKM65HN17w2BcB0v3qqX5FG8T5Pz+oo+8PgKkReTNKjgrmBd0vf4KjSk?= =?us-ascii?Q?g+pnwjlHE79Jqh3FFGBnTFSeXsiNpUb2DKtKWqdjbOTMOm8/USI1wlxBQkoN?= =?us-ascii?Q?CZWRK6MRcv7aMM9Hnpj5idd/o/Vs1NXH5ZFVkEAJNjvSvO3PA3724AkVwHya?= =?us-ascii?Q?jhlFCfmD6XGtiRDhb+nuRiiJQ6ewJ2kkLunMGb9LzB72Is1i7CF9X5rtP6PZ?= =?us-ascii?Q?K6qUV8zc++IDxdFyZXFFM5Ga2FoaIikyKUEuNEsONwhFJBAs2WWu/RAp/yxq?= =?us-ascii?Q?ZiNofRRjEyQU0JGZY4kUsT6bOi8JaLw0tQL2ew8lAWTzxRqZsSxXMENTy15I?= =?us-ascii?Q?Hi7tHBwwYLfDYNcS1Gs3SmyKzZq1N1G8mPOLV1rEhpMiAxzcddaycBnnT4kT?= =?us-ascii?Q?Hhc+oje8v8IwRc8YDT4PKhYxNhV8dxXQJcGmtzQfBKN4uPVMUNE8OgMfW/jq?= =?us-ascii?Q?nwe6gqyNYwFtxvaZs4a9C16j67tkCa/sKbOZscMHyP4ciawQJMyD4I5nQQaY?= =?us-ascii?Q?PQDF91O+PvU7UgVQShH+2tCq/i1uPgIEarWTcQdG/qvBdp/GDbnKooTMUEyt?= =?us-ascii?Q?HHMDYBFjqdwWWe8rUVCEqjwftcw8jNfhu/dOdmMJNlic5PN/Ic8uXUSvUqEB?= =?us-ascii?Q?YQGqrklBPaTebaRl/fQRYsqaMdUdqlDQ3D2cEUUhk4NlhZGvlxiGvV4NjIdg?= =?us-ascii?Q?zC9wUR+ObLNVfdq7vABvXMDIzPVaZL7k6nw/7txUa+Go6J+V00MTbNuorF0n?= =?us-ascii?Q?cGHkOsxcjor0VqY7d65VQLS0VTvKW7nrl2DBRBPeANPPiJoErLNkAN33aeDY?= =?us-ascii?Q?ftLZuTrc8tGPYQtitZVWk1GjqDANio0djQZJMvFoYHHqYORiIlQcAduFOUwm?= =?us-ascii?Q?22OFjq3uUqeSRCKxv+cGpAJt0zjpdyOoeMhulFcse3nPzjl1tpsSid3ijbHu?= =?us-ascii?Q?90TjMoE6ZoXsY2nEYF7PWHe5jkdsfImIiwJElmGW/FPXgmxKecdHK9BdPWgd?= =?us-ascii?Q?CK8m1esGD7RBrO3WILNdqa1SkBWr1w+1jE3MYGCi1Ejb6vZ1Y8yrarmiOwiJ?= =?us-ascii?Q?xqtRLo/F9CCWCyt2FfRfXp86EOUg9T1AWgR2MtQIGEYOXt7ypjFlD1bErun5?= =?us-ascii?Q?Dy5oFNRuYRKkpo5aAxs1ASAVjb7EEMdDWCvFovaNyb0X0HFT2DlqWODrabyp?= =?us-ascii?Q?R4KHEdBGT6ZxPLsiVfITc8JjZ9P22ylwMznTeEs34yS7LMXnSNVvmkMFHgtO?= =?us-ascii?Q?XCogOFYcOB0XPVorkfP0QTMuJNlN4IFw3xeYvxvh3Bct0vuPlUn985gx8EKk?= =?us-ascii?Q?q01rKGtGosj6YJOxcoXrnzDwBH3S389ZgWCPBIjuhcx2jHcqOgrAWKtqZ6P0?= =?us-ascii?Q?HiFkbahfk1k+HsiMSmfqlhk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02dbe21e-369e-4451-50c0-08d9f7324bd6 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 01:09:24.1773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y5KL+8AlPwbE2rK61tSRkLq7z02Hdh2FCsnhXMIqeIwQfoVrfv0jQUU4XyALgIz/rjDu1YroQgmu78B8F4oVDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2204 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On February 23, 2022 6:50 PM, Gerd Hoffmann wrote: >=20 > > +EFI_STATUS > > +EFIAPI > > +InitializePlatform ( > > + EFI_HOB_PLATFORM_INFO *PlatformInfoHob > > + ) > > +{ >=20 > > + Pci64Base =3D 0; > > + Pci64Size =3D 0; > > + > > + FirstNonAddress =3D PlatformGetFirstNonAddress (&P= ci64Base, > &Pci64Size, 0x800000000); > > + PlatformInfoHob->PcdPciMmio64Base =3D Pci64Base; > > + PlatformInfoHob->PcdPciMmio64Size =3D Pci64Size; >=20 > I think here are opportunities to make the differences between PEI and PE= I- > less boot even smaller, by: >=20 > (1) Allocate a PlatformInfoHob also when using PEI boot workflow. > (2) Switch PlatformInitLib functions like PlatformGetFirstNonAddress() = to > receive a PlatformInfoHob pointer so they can update the HOB > directly. > (3) Add more platform info variables to PlatformInfoHob > (FirstNonAddress, PhysMemAddressWidth for example). >=20 > But I guess that kind of improvements can also be done incrementally afte= r > getting this upstream. It's also easier to test that kind of changes whe= n we > have both PEI and PEI-less variants present in the upstream repo. So I'm= fine > with deferring these changes for now. Agree. Thanks for your understanding. >=20 > Beside that: The name TdxStartupLib doesn't reflect reality any more, we > should give it a better name. How about PeilessStartupLib?=20 Thanks Min