From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.23447.1643254705600572170 for ; Wed, 26 Jan 2022 19:38:25 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WCOh99lS; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643254705; x=1674790705; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=o4tfFaEVKSLbgk5YiXaJgsAPcxjx063f6peLflyS9Mw=; b=WCOh99lSNbV8pGvHlY4aK3BOAM+nLkMBwRTDlX659lchI9Z4C7lF3LvR A3rAEJ6AdX4N6TJRRyDBv5L1u/P35j7ZQnbe1fEuKXMoaLycVWGVd0bvI 0eWzxZx6s8jyyiXJWJ/z1pqRIloc7kU5ePlRPn4TO4OZl6OC00DAFJbrQ Ek3Yc07+BHjlr2vrwiPVbUt/MGqJm/xnuddqseXN3VKS9csuD34wWenaZ OgQYF3xhOx/zYaSm1eEde5nnhdGihe6yYV4aMXnEOXAmtsEnBLTK7GsBg yd3nz2wDz4EZh4241GbeDQS+o/xYvW/cDKewLX+Kedxo//YI02mncXq+a A==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="333092526" X-IronPort-AV: E=Sophos;i="5.88,319,1635231600"; d="scan'208,217";a="333092526" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 19:38:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,319,1635231600"; d="scan'208,217";a="767360088" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 26 Jan 2022 19:38:24 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 26 Jan 2022 19:38:24 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 26 Jan 2022 19:38:24 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 26 Jan 2022 19:38:24 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 26 Jan 2022 19:38:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GSzDTP7v+3xCKviSzq+Cgls+ckPdoDZXd/dmO1n8E9vKyUS6bj+T6ZPBlZt6qVwFtplybi3TeVDlWXWLlfEKExRwTaflfy9gqDEfE8egbjj+tPID6NeoReZqayduBW+r0dSII1ep69m7jEYHYAask42WQh91O8tpG7xCfL3rFWRlRYDve0iubQsenx7Y/6HeD+2rwDEGVkieVUYvMbsVnO50EJvj/ZrFaqjZpAIXIG+FalcV0RUf/fsdheXXBKsOmKOP9Wc7yDtX0E1f1DtHP6XasXBxWmWiqfTS2Cbf0R6cMJjW4zL32qvxaX8d2jFOPNg6sJNYZz2pEkHNlHsf7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N7x69pTEfJHl/MfT4jRtWlY2Njpx1WQYcGeuo7F1V3Y=; b=Vb3oDxBfogtH13W2B5VU7zDRREKQ4J5A/b7x3z2khoGIYzrxlFzTn60v36htt6LcIoiTjTTi/EvXlnOlyDEwIFA5axlIHuC2+4bwuUlPbxjXHhwa/0gwctAp648BYLTOKEruirJsv1NbpKLZ5TT0mPlJE38Lv0HGEoLf2/69/Sq/s5/Cp8go85ShINGhDIlIOHZpbkChk3/lkb7TsqJtlBWczJGOr5pZGo9Rw//BceJMZP6d/20YE4hKjMJIx4k+Yxo9uo1zk3CgYAa02nwTJl12jV/N7b3mswNfk8OT51f9cHuin50so0w9sUbxcj3QmhLqZu2BjYN+BoWGeVHPhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM6PR11MB3579.namprd11.prod.outlook.com (2603:10b6:5:13c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.14; Thu, 27 Jan 2022 03:38:22 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c%7]) with mapi id 15.20.4909.017; Thu, 27 Jan 2022 03:38:22 +0000 From: "Min Xu" To: "Chang, Abner" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Thread-Topic: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Thread-Index: AQHYEbXFY87ZjKGpdUKSdm0QX/dQwqxz15iAgAIytICAAAOT0IAAEL4AgAAKV6CAAAfggIAACi7A Date: Thu, 27 Jan 2022 03:38:21 +0000 Message-ID: References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-2-min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a388f49-82ad-4c44-a8a1-08d9e14677b3 x-ms-traffictypediagnostic: DM6PR11MB3579:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yRefiDpTa1iA3Y4j3lBuk1ZLzo6mf9+DOWklr7y1YncBarjoQs+eMwl8MvtT1G21UU5icOFT1xe7ghRhRJPbQCzcngZgJ91NR4VAJokclZQDKrBSRVYZoTOb2caIPEuRpvD5LP8SbzuXzqLgNfgeM7U3nFSpg8dI7vdPJ5RNLlK4n0kGjZayR4kHZSWn5qC6kNwJnf2ETNjgJ5BauD3ZVqLHsokebpWyAHd/RYVAnM/y0X3ra+SFZia82OwwXc6jphg6sdD6f/RkvW6KO67zlUpZbe5Mqzyh0oQWmusSW7PpD1GLG8DF9TWS82hiHPi5z3t6o2GDwOdQqctRoJGDw8PeiqfzqpfTUr3H0+QwR9QR1vQIXtzZePBR+AZDfyPlQeA/oEBzDZtXyFPQkj5irXmne1KjMe4wqJOtpsazLd28AqtilWh6L7TKWKlPzPDiNsxhkT+GaIZgSrHE3pNO5wSBsdR0iLCeVu1MGvvIDt+4EBxKIWWdAZJZ7ggebR5PpRq76vUEoy4j4BKVAM9ieNADVeO9bL6oZ8dv29yZ4EecnvNFuf9YrPt0masFkR/ZTYeeksEvuPaOmpHOcWkaqYCe0RTDTY5DCDv+RuduPP3l5YKoqHaxiWpqQUg9NBMnpFOPb8p8ARtJhncL+mitl6PDEd8RRrZvQFQqMYyAqThH8IFqXnG9xHEWyZ5vHVZ5kiirXf8PyOQ+O02A00drn1l+PbnjJLbZ3PkOQ/z3Ffw8k7JRDPjXstrKAk89PLEQs5gCsu4lBIPexnjFzOozpwwgtp+trlU+ccU4J1sbdDpX+Fxyr9qZN7F3OY20g2slrfPa33V+Gw8N/Z2xZSeALA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(66946007)(64756008)(110136005)(166002)(66476007)(296002)(8676002)(66556008)(316002)(26005)(38100700002)(66446008)(83380400001)(55016003)(8936002)(7696005)(82960400001)(38070700005)(6506007)(122000001)(966005)(9686003)(76116006)(508600001)(2906002)(71200400001)(86362001)(53546011)(76236003)(186003)(5660300002)(33656002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i9v/AAOKtrf0mMghaBlVRsq6/VxKAyqORUj+rqOMfm9M7yEV7xQd9lN8aqmJ?= =?us-ascii?Q?k07EsVJW+V4iV9NZ4mXyxBthOrRJ0bDlUkcWdzrTLHglOsb4hwxNz850c2f/?= =?us-ascii?Q?p6ePM7cQITkg9uRKj978YdEGCgs5SYDSozj9m/vu4FH/ccz52BfZf4eOpPAr?= =?us-ascii?Q?/KEKuTo4/bJGiBDPWnx2iIIp34214Q9MrHxHQUTfsH6hk1k97af4xWfkFiwO?= =?us-ascii?Q?ItxrEERr1Vwgx4tMv2I6xC6jkMUwGOd0sbEt43zt6t63JFTc6hpdhHFwE2pf?= =?us-ascii?Q?JkcRpBOXWXd/En+Q/9PCFPF3ofnqvLgsAzUhcJkcpQ7xYk+uTTSxlxmitiUy?= =?us-ascii?Q?u6Fqp61/YANEkodLz6AePqdzw90HMEjzKwl4ZtxvvCyZPvVEp+WOuKSv9TU5?= =?us-ascii?Q?Mdtk8JnP2hhZ7cGWYJn3gl/nQiB5c6GTSR/oua2gigUUYtQVDhDgBjJkG8Bl?= =?us-ascii?Q?lbwgUVSRNo0Gw3Ca3vyuR2m6PCW0/UyXjoDKXW5rB84hd6HBj388vRuCqfN2?= =?us-ascii?Q?4r3XSWlGyXU8NzICQk+uF1x9J96NFxhmhfQqV2xkun1WyglXoUYbnsz9Zr0O?= =?us-ascii?Q?3drP599NXcpOqwpVUPIESx5bCO9MdtuUc3itZpsLwbEhYS0iePbpasWx4wI4?= =?us-ascii?Q?RyY6FVItVw2VJIqBQmkhUB5RNbwriraFZZeSj5IViKR/h4faBK+PHPil1uW0?= =?us-ascii?Q?2RaqtitcpNoBQY0SWqBrubSYoxZg3uzeVe6jCV73cyJVdsg0SeN5cIRWAzfl?= =?us-ascii?Q?k6ssjfI3VhtvW0q9qFfpBmq+bLflUJQaBamR5O5qxDV1AlIYSNn2E6UqbYm6?= =?us-ascii?Q?npRsTvaZ5addE3lLTnC6S1cONlEqjzrv9T1okxrz+aFyjIMCXxqJBmsid2z3?= =?us-ascii?Q?XB2nTVjtJiH3oEHYcxV9j9GNS/N3Pyyu6Tmoxwd2cMHAQ3aM3J0/IYowLr6H?= =?us-ascii?Q?YTes+D3zQvAjN3/FJMk8d7QoZ0W6HYamkurVj41VwfVh7VFCJvbwlRhyeWg3?= =?us-ascii?Q?/LIjVxeKccyEFSnPEVdkbI52LeoO6M8FPZQquexMDJRvH6sTEjmCg1o7JH2q?= =?us-ascii?Q?Y+tC8SWm+5Lo4KWr+O63LJT4rbyIY9fUZ2Ywk815vp6g85S9ujKR4LP0gaAG?= =?us-ascii?Q?CNp1uOnUzfy19i6AWlQWurLuKxeMb0pwlyj5aSNR3Q6JFG3ZSwNiLbfdj+Pd?= =?us-ascii?Q?Zvu27RET3wY+NH52ysLdbjkVVRyLJplRGHf8nArYRMW3XyGPx4R9fNaYoVva?= =?us-ascii?Q?sX/KgsXriHt787TOK6Yk+/CbKvhUZ5J/V5QZjRGDVouMV+s7NQNtxdD4Ck0B?= =?us-ascii?Q?rP7SCuiEBax8j4mRKt79vSuWhSFepc+8HXTFsf+UQoTNka1agqfZ1BLgKgCW?= =?us-ascii?Q?Fqrda5kLhC9bsfuufDn1LrPTQaQjTygKjo+NUj4KzVo6x03Dfs3DiGYk1I/9?= =?us-ascii?Q?ASG2r8MSKQ5aDgzKWFdceVQPebsoeuTZOiQ0M5UlrqgI+1TexQM4bceM6X7K?= =?us-ascii?Q?YTD5q2MZ2XeSDPqct65XSCPgi2mAWBeB6Dbsu3WDO1r52Jb7oUT1Srlttulc?= =?us-ascii?Q?nl+h5MkySSXnOnsK158TarFmIy//SSwVSqj++TJNRN4T57dVJNSf1wdG5qWA?= =?us-ascii?Q?xzKUuvP9g4yH7rKMdACGz4M=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a388f49-82ad-4c44-a8a1-08d9e14677b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2022 03:38:21.6391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 98ZIsggkmevHsZx2TifIeGhhm/9dKTvDONdwU4JgoWjBv8rLfVp/SfjJfaX8WbcZSqEvVAEK7OJA2MJlQh3zBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3579 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR11MB5064BA71C0B2101918C51A3AC5219PH0PR11MB5064namp_" --_000_PH0PR11MB5064BA71C0B2101918C51A3AC5219PH0PR11MB5064namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure. The standalone patch is sent out. PR: https://github.com/tianocore/edk2/pull/2444 From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, January 27, 2022 11:01 AM To: Xu, Min M ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch yes, I can do that if you separate it to a standalone patch. This change do= esn't hurt others. Abner ________________________________ From: Xu, Min M > Sent: Thursday, January 27, 2022 10:39 AM To: Chang, Abner (HPS SW/FW Technologist) >; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Hi, Abner Other patches are still in review. I am thinking if this patch can be in a = separate patch-sets so that you can merge it to EmbeddedPkg? What's your th= ought? Thanks Min From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, January 27, 2022 9:56 AM To: Xu, Min M >; devel@edk2.g= roups.io Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Hi Min, Did you get the reviewed-by for other patches? Just let me know when the re= view process is done, I can then merge the patch to EmbeddedPkg. Regards, Abner ________________________________ From: Xu, Min M > Sent: Thursday, January 27, 2022 8:58 AM To: devel@edk2.groups.io >; Chang, Abner (HPS SW/FW Technologist) > Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Hi, Abner This is the PR of the patch-sets. https://github.com/tianocore/edk2/pull/2313 Thanks Min From: devel@edk2.groups.io > On Behalf Of Abner Chang Sent: Thursday, January 27, 2022 8:43 AM To: devel@edk2.groups.io; Xu, Min M > Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Hi Min, Would you please create a PR for this and point me to the link? Thanks Abner ________________________________ From: Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, January 25, 2022 11:09 PM To: devel@edk2.groups.io >; min.m.xu@intel.com > Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Reviewed-by: Abner Chang > > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Min Xu > Sent: Tuesday, January 25, 2022 2:33 PM > To: devel@edk2.groups.io > Cc: Min Xu >; Leif Lindholm= >; Ard > Biesheuvel >;= Chang, Abner (HPS SW/FW > Technologist) >; Schaefer= , Daniel (ROM Janitor) > > > Subject: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in > FwVol.c in X64 arch > > RFC: > INVALID URI REMOVED > d=3D3429__;!!NpxR!xMRxJim2LXdgV0CClUrT7jWBUouLzrVwMc5fB_wt1PT17W > WWyZKgREYswYM1Tz0$ > > CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. > But the second parameter of UefiDecompressGetInfo() is declared as > UINT32. So a build error is triggered. To declare CompressedDataLength > as UINT32 to fix the build error. > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Abner Chang > > Cc: Daniel Schaefer > > Signed-off-by: Min Xu > > --- > EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c > b/EmbeddedPkg/Library/PrePiLib/FwVol.c > index 92ae68f0d382..0a6d6925b7ea 100644 > --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c > +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c > @@ -291,7 +291,7 @@ FfsProcessSection ( > UINT16 SectionAttribute; > UINT32 AuthenticationStatus; > CHAR8 *CompressedData; > - UINTN CompressedDataLength; > + UINT32 CompressedDataLength; > > *OutputBuffer =3D NULL; > ParsedLength =3D 0; > @@ -320,7 +320,7 @@ FfsProcessSection ( > } > > CompressedData =3D (CHAR8 *)((EFI_COMPRESSION_SECTION2 > *)Section + 1); > - CompressedDataLength =3D (UINT32)SectionLength - sizeof > (EFI_COMPRESSION_SECTION2); > + CompressedDataLength =3D SectionLength - sizeof > (EFI_COMPRESSION_SECTION2); > } else { > CompressionSection =3D (EFI_COMPRESSION_SECTION *)Section; > SectionLength =3D SECTION_SIZE (Section); > @@ -330,7 +330,7 @@ FfsProcessSection ( > } > > CompressedData =3D (CHAR8 *)((EFI_COMPRESSION_SECTION > *)Section + 1); > - CompressedDataLength =3D (UINT32)SectionLength - sizeof > (EFI_COMPRESSION_SECTION); > + CompressedDataLength =3D SectionLength - sizeof > (EFI_COMPRESSION_SECTION); > } > > Status =3D UefiDecompressGetInfo ( > -- > 2.29.2.windows.2 > > > > > --_000_PH0PR11MB5064BA71C0B2101918C51A3AC5219PH0PR11MB5064namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Sure. The standalone patch is sent out. <= /p>

PR: https://github.com/tianocore/edk2/pull/2444

 

From: Chang, Abner (HPS SW/FW Technologist) &= lt;abner.chang@hpe.com>
Sent: Thursday, January 27, 2022 11:01 AM
To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch

 

yes, I can do that if you separate it to a standalone p= atch. This change doesn't hurt others.

 

Abner

From: Xu, Min M <min.m.xu@intel.com>
Sent: Thursday, January 27, 2022 10:39 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch

 

Hi, Abner

Other patches are still in review. I am thinking if= this patch can be in a separate patch-sets so that you can merge it to Emb= eddedPkg? What’s your thought?

 

Thanks

Min

From: Chang, Abner (HPS SW/FW Technologist) = <abner.chang@hpe.com>
Sent: Thursday, January 27, 2022 9:56 AM
To: Xu, Min M <min.m.xu@int= el.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch

 

Hi Min,

Did you get the reviewed-by for other patches? Just le= t me know when the review process is done, I can then merge the patch to Em= beddedPkg.

 

Regards,

Abner

From: Xu, Min M <min.m.xu@intel.com>
Sent: Thursday, January 27, 2022 8:58 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; = Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch

 

Hi, Abner

This is the PR of the patch-sets.

https://github.com/tianocore/edk2/pull/2313

 

Thanks

Min

 

Hi Min,

Would you please create a PR for this and point me to= the link?

 

Thanks

Abner

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, January 25, 2022 11:09 PM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; min.m.xu@intel.com <min.m.xu@intel.com>
Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch

 

Reviewed-by: Abner = Chang <abner.chang@hpe.com>= ;

> -----Original Message-----
> From: devel@edk2.groups.io= <devel@edk2.groups.io> O= n Behalf Of Min Xu
> Sent: Tuesday, January 25, 2022 2:33 PM
> To: devel@edk2.groups.io > Cc: Min Xu <min.m.xu@intel.co= m>; Leif Lindholm <leif@nuvi= ainc.com>; Ard
> Biesheuvel <ardb+tiano= core@kernel.org>; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@h= pe.com>; Schaefer, Daniel (ROM Janitor)
> <daniel.schaefer@hpe.com= >
> Subject: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error = in
> FwVol.c in X64 arch
>
> RFC:
> INVALID URI REMOVED
> d=3D3429__;!!NpxR!xMRxJim2LXdgV0CClUrT7jWBUouLzrVwMc5fB_wt1PT17W
> WWyZKgREYswYM1Tz0$
>
> CompressedDataLength is declared as UINTN which is UINT64 in X64 arch.=
> But the second parameter of UefiDecompressGetInfo() is declared as
> UINT32. So a build error is triggered. To declare CompressedDataLength=
> as UINT32 to fix the build error.
>
> Cc: Leif Lindholm <leif@nuviai= nc.com>
> Cc: Ard Biesheuvel <ar= db+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang= @hpe.com>
> Cc: Daniel Schaefer <dan= iel.schaefer@hpe.com>
> Signed-off-by: Min Xu <min.m.= xu@intel.com>
> ---
>  EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c
> b/EmbeddedPkg/Library/PrePiLib/FwVol.c
> index 92ae68f0d382..0a6d6925b7ea 100644
> --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c
> +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c
> @@ -291,7 +291,7 @@ FfsProcessSection (
>    UINT16       &nbs= p;            Sectio= nAttribute;
>    UINT32       &nbs= p;            Authen= ticationStatus;
>    CHAR8        = ;             *= CompressedData;
> -  UINTN         &nb= sp;           CompressedD= ataLength;
> +  UINT32         &n= bsp;          CompressedDataLe= ngth;
>
>    *OutputBuffer =3D NULL;
>    ParsedLength  =3D 0;
> @@ -320,7 +320,7 @@ FfsProcessSection (
>            } >
>            Comp= ressedData       =3D (CHAR8 *)((EFI_COMPRESSI= ON_SECTION2
> *)Section + 1);
> -          CompressedData= Length =3D (UINT32)SectionLength - sizeof
> (EFI_COMPRESSION_SECTION2);
> +          CompressedData= Length =3D SectionLength - sizeof
> (EFI_COMPRESSION_SECTION2);
>          } else {
>            Comp= ressionSection =3D (EFI_COMPRESSION_SECTION *)Section;
>            Sect= ionLength      =3D SECTION_SIZE (Section);
> @@ -330,7 +330,7 @@ FfsProcessSection (
>            } >
>            Comp= ressedData       =3D (CHAR8 *)((EFI_COMPRESSI= ON_SECTION
> *)Section + 1);
> -          CompressedData= Length =3D (UINT32)SectionLength - sizeof
> (EFI_COMPRESSION_SECTION);
> +          CompressedData= Length =3D SectionLength - sizeof
> (EFI_COMPRESSION_SECTION);
>          }
>
>          Status =3D UefiD= ecompressGetInfo (
> --
> 2.29.2.windows.2
>
>
>
>
>

--_000_PH0PR11MB5064BA71C0B2101918C51A3AC5219PH0PR11MB5064namp_--