From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3361.1634172926670827095 for ; Wed, 13 Oct 2021 17:55:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=r0g6WAXU; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="313772215" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="313772215" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 17:55:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="442516998" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 13 Oct 2021 17:55:24 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 17:55:23 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 17:55:23 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 17:55:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B2z+EuazkEpG4pSwG8EZsSsOSeHeZLWAst5k0qkfdLHE97A1DmgS/XEU3wo1mFN9OtbpwG3EzyOMJi/hqJJ4i+pgH5qo4Qe3sJX4JAXeGJuV2mqtpzrWxuw4bX5Z4/lghHF3AEOZ2ma3OQ+x7G6fp55chHMgVd9z+R5UOFjuUP5PZFM2AfpfQil/Hy06yXIr6/7YzkuMZJkOwvgj2PZ8vWJxOejGJ6Wg4IBO1EPuahfDbIKWlx9qZZdZugYRqBJ9328dWJMW7BUe+yWmF9CJbZ89PSfX5u7ZAyDvubSBPYMY3wgzKYhnk5rovV4AieFSZtBy+88mNQwYJebGse4y3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjD95GcL3+rxVRp3fQ6AmXM68QITk2p6czCuJAPzehQ=; b=ilCAXZgF4tJLSKbqmzOY+wJ4sD0ERn4/au3gE3njhZjSd/QKOP6fT4oqMbWOrQiAmrKQsUIpbtkvj5CNQdAQZH+UXo5oGhy7T9i/H8UyGqDUET4yK6nVRpw106z5wyiuFo0K5r3/JbJF22+rRYbV8vFmlUOctWjxPauG+w+zJTILxlepy2c026FtBanpWxtSMvsloK1v4vpOLVfZVwzlqPD9mbY91AqEMHMEVhEalQbt+BsTtuPmzZoxEWAJlfjBSJB7egmxNfdiYtW1dG+QbwBFZ5Z2xx7OnHp+VgL06S+kgvP3VIRqQLVhW6wqVODY/by37Okx1z/CBbBLFh1rGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vjD95GcL3+rxVRp3fQ6AmXM68QITk2p6czCuJAPzehQ=; b=r0g6WAXUkzKTt0H48nKW1CIf/C+dPbhS8/QkfjZgGB4QNXx/H0qJnzAVofrkGroyWODaLW7cqsf2ex9jt8Lw+vOWLWkWRFgulIWGVJUyolmolCubksPhgckhUA/f1vZlPdscBu/okav/uHT6qpuvEbzWQLIrgpPZT70EjRL6k5Q= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH7PR11MB5861.namprd11.prod.outlook.com (2603:10b6:510:133::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 14 Oct 2021 00:55:22 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4%3]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 00:55:22 +0000 From: "Min Xu" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Erdem Aktas" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V2 14/28] OvmfPkg: Update SecEntry.nasm to support Tdx Thread-Topic: [edk2-devel] [PATCH V2 14/28] OvmfPkg: Update SecEntry.nasm to support Tdx Thread-Index: AQHXuZrVFHtN3RSrvkyGL8bhJK+Ud6vPN3uAgAJ6JgA= Date: Thu, 14 Oct 2021 00:55:22 +0000 Message-ID: References: <2f440070a868156b6f22ab57076f86bad003c88e.1633401643.git.min.m.xu@intel.com> <20211012103851.bfqbrbmhhsmtlozx@sirius.home.kraxel.org> In-Reply-To: <20211012103851.bfqbrbmhhsmtlozx@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8938c03-5c0f-4db0-9477-08d98ead4d0e x-ms-traffictypediagnostic: PH7PR11MB5861: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: apm1V8FxvHditU9c/ZLb9OitHpW6Otwar832q0fVT55C+PGjnKBxcOKVUEhcow2rXpZToSbeXEQVaFzqPrfL/pFAOiOLWmCcergMmIMHJSjtO+OuyeDyUZP6uV/7vDbCwoBe1Fl/OxH+HjQ4zkn6mmN/UQwuFGgwDiSirxxQvVnXKj/cznVI+G9LbcbUe7yqFhmOAP7jkM2UAeaeBYWIHVIYE8GtKCjqMYrCr7U3OELeLXeDC12hqlx5f7Q+6vcbEk/QVrPTRxV4BcO2nZj61Nltedok5Ed2t390+QPJB89Lpd2VV28i45hvN5ekoi2hkB/9cPzvbArAgeRhyUdQO1vxB//GDZTaA10cSUYfIKnbiytMkHWEBQfa7AYUsCzM9xJPDngXLMyofzArACOpkDGQpp3KqBAn3trquSDktCc8Xeg4gA5qgZN83pQuQ7Qk/45+sXKV3tcmngbGUrhn55xVKKfqe1JbL/Ew4RD8dMq8P3VpBrbd+nU+8PcmgFCCqSWklXHV3UvXqi71nFr3ogC6E67eLZqR9d2g2eutKiyW85iGinIrP2Lp+UflqgfQwVpZuJv62ncrQI4WmWQ1y5s2sFl2yEI94e5pll8R2f98EEgMHhZar3kYa9G05/d2z3JcX8itOMzk1+5QP2sJRrc7AMr4pXp7MM3nj9Whq/r1d2XuASp/33vaM8875O8lgOGg6m+TjVkAZyJh/I3N3g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38070700005)(86362001)(110136005)(316002)(26005)(7696005)(8676002)(55016002)(15650500001)(33656002)(4326008)(54906003)(8936002)(82960400001)(508600001)(2906002)(6506007)(122000001)(5660300002)(66556008)(66476007)(52536014)(71200400001)(38100700002)(83380400001)(186003)(66446008)(66946007)(9686003)(76116006)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uoR+N9mP4stdwUuht9CK4qqftQEq7jEedxwOJklTzdfygE3tH7R5b3Nk2sbK?= =?us-ascii?Q?qolm97iTr1pgcNg3J/wsAwsIb+VWHd0zY6scOJyfc/THmFoL2nozWvArUpHO?= =?us-ascii?Q?42YpsMYlDldkY1Rn03FHKr+yuOoESe36kZ4phLKSiJBm0Xlcacl7LaGbvjeI?= =?us-ascii?Q?sC/yzot3v9iF0n9y/rLIugsslrs1gElUWFOB6TzOW0kr99kToqy3IKkE/Quz?= =?us-ascii?Q?U2J11poRSvXDGy6oO6puJUFQjfV/aHmUFXK/6pBbWh2eqcn7kAh2nuL9m721?= =?us-ascii?Q?VFuP+P0SOonWGTjW2UQACh29SHOCOhxu83OG9PlzS2SzmVPdwclvf2XCCLD8?= =?us-ascii?Q?u9ZwDa4xQjKxjhTAXhY4sXQFdfQoksH3uyBHd9Y6XAsYDyt7kYgrGb0ekA6e?= =?us-ascii?Q?uUJlKd/hSs7xA6vgN1LhqHvf51RoxgEAhlj+iQZ1GTM5F4quwqFshbISXNaF?= =?us-ascii?Q?fqil9Pm8hJZYnSELGSzC0dHOInEOT7JCWFUqwgN/FA+GhILErFeB5ZS/yQD+?= =?us-ascii?Q?BXLdf045IIIhsP0dRz7wC8UNvZActunJIMHQUmwOeXkFl1PlrJ7tot41ucKc?= =?us-ascii?Q?TOVNh4Qq4iyfk4KV6270rGfNGgTRtlPvEnr53qMK5oWjykL3LAOz+2eVC+Dr?= =?us-ascii?Q?x9KbRhBs1dDXK3/DyX4ZCsn7yS65mnsH6TvN4q3WnwGvMCUhCGdlrwMsvbdB?= =?us-ascii?Q?dN+FI/aUdaCfHkLNBn87RMEfsLiMnTgL8pjxR6npBb8tD02Q8RRsChRt5tO7?= =?us-ascii?Q?JlzJol1fAaQyK4Y2/mLG9gpJfJhmG+ulhkUN+C0k/28LhQMbTY3Dw1ZKiDIx?= =?us-ascii?Q?1kHUuF0ntQviGjlVcEm+i5nBZsZr/gkUXi81Zl3cl02n/GtifllQRczBL3bX?= =?us-ascii?Q?nIXdw7F5ldHYdF7R8Qd2W/ViTPf7gre55Qk2iS0KWqZAJr1LsEBSmBQhHBbw?= =?us-ascii?Q?vHi7nVXuD5lXiOAOsS89wo+EqgxhQTXvRUoOM+j+LqU794PvlewUwSNnYg7I?= =?us-ascii?Q?sHCkgEYKdiBcNtkciWZbqgw3RAEUMApuuL+7M6RwLDZhh0avHdmP5lH+Ylq7?= =?us-ascii?Q?/KNcLVL98ZpemLnTdPjxptHpHtQ2uzdTLBHklV8PtE0NTXXOAiFLEV62zKKN?= =?us-ascii?Q?BjaDfeS26JVPE/sryR2knQpeNEcAF2Bjra3LvMnYi9fdqHWkCRI+Bz2eonjz?= =?us-ascii?Q?cUbK2ZwSJZeoMfnJKStro2uRmZIRwMZlVDeQS8rnhw1KD6vsOq9X9vMzaxxK?= =?us-ascii?Q?S38bQbEJVZiAS3CNQ0Ci6vEq+i8rFd61JJil1cl4BTVLPXRol6JjtKGfWF1e?= =?us-ascii?Q?NWJ3Psuzp46u12QgBA9jJvJL?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8938c03-5c0f-4db0-9477-08d98ead4d0e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 00:55:22.1897 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wOlj6xhN80VFhmNuQqRTaaQgI7e5W1U8VQZr7Q6J/FOR32EnGnKoEEQ12anTJs4Gz+kcvqAGesce3urQtI6S3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5861 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On October 12, 2021 6:39 PM, Gerd Hoffmann wrote: > Hi, >=20 > > - AcceptPages: > > To mitigate the performance impact of accepting pages in SEC phase o= n > > BSP, BSP will parse memory resources and assign each AP the task of > > accepting a subset of pages. This command may be called several time= s > > until all memory resources are processed. In accepting pages, PageLe= vel > > may fall back to smaller one if SIZE_MISMATCH error is returned. >=20 > Hmm, I'm wondering whenever it is useful to have this in the first place = with > the longer-term plan to implement lazy on-demand acceptance. To mitigate the performance impact of accepting pages, there are 3 ways. 1. Big accept page size. 2. Accept the pages by BSP and APs together. 3. Lazy on-demand acceptance. >>From the perspective of implementation complexity, 1 < 2 < 3. Lazy on-demand acceptance need the update not only in TDVF, but also in Gue= st kernel. More investigation shows it also impacts the grub and memory man= agement in EDK2. >>From the perspective of performance improvement, 2M accept page size + BSP/= AP together, can improve the performance a lot.=20 Based on above consideration, in current TDVF upstream, 1 + 2 are the ways = to mitigate the performance impact. Upstream of 3 is in the future plan. Thanks! Min