From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.6980.1635944262535460087 for ; Wed, 03 Nov 2021 05:57:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=JesnBXj0; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="230207418" X-IronPort-AV: E=Sophos;i="5.87,205,1631602800"; d="scan'208";a="230207418" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 05:57:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,205,1631602800"; d="scan'208";a="667513484" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 03 Nov 2021 05:57:40 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 05:57:40 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 05:57:39 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 05:57:39 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 05:57:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BLCALyRTL7LFiMuiptpCNCVmLcqDv8ixHvoJbvYCTqXBq1yS8/EZeE4k8e0DbvUcb7/KT6Fb6Y92hW66udMwSG2HTESyt34TZYTNeZ6LfxxvbAJ+uWH8li0LR1nl/GiaH5P3kpuJZIGzyOWW4ABbcgmoqY6ycsV5Ta66BWGF44PrQfQv3s81tBFIXZ1bZG9qBhQiMzZITletrOtqumGucgoZ8V+kMsJsfVxIMDf4W4U1eEq7mocXyPLnXtLGYl1lKsA1OyoA/T9S8r/u2oL+y1Wqd8xeRKLqRWXQP/kjIYOo/DtWIXRqZ0WKXrscml9NcYBQTd9rUQAgLXZWn5If3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zVPXumvXQUfM74Lv4BxOclE0QKRNGeL+YirHWcVNOsI=; b=BxG8mqCC75Yf3TTMh3BzjEGLwnrD+5xA5oQm1L9guG0+26R9dQjnH2Qh8LDBwxWU9s4oVZx2nXqwSKgeFONGb+yz95IqJ5pkBfI9bqv/EiUzEsAYrlQVUYQcIBDAb+t/qOCvLbGDDHjRpy6XtVZhR5M2pIFVT/FBRqOdVd+MM+3petisE2BPQtDJ7tM76fjRllpxcjWNJrDgPVLwv07GEAHNisZkWAm6z8b6CPmCkkynbfB32drra0KUNbqOANnTajTBvJ6cmHzmwCyb+WtUQQ68TmFpCB/n7s7J0ktSSc+Ccvi9gMdDeXCxbr23r4xU5M3J9doTIYlyaLnw9QFiJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zVPXumvXQUfM74Lv4BxOclE0QKRNGeL+YirHWcVNOsI=; b=JesnBXj0RWgV7igV0uvfqLTCa/PD5KaaVl4JWv656vpVGsszJwMD221kw6tYcOe1voMzgfb/NJhS4r2/G+gkw2DeNITrM6Gk2Qjp18v9rMywbFG1qHIbv0mqOailQItcP9jQf0CZ7+m+L1JVhPXoN6o+MRkOuj4DJsI/LNfpi1U= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4902.namprd11.prod.outlook.com (2603:10b6:510:37::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 3 Nov 2021 12:57:38 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4%3]) with mapi id 15.20.4669.011; Wed, 3 Nov 2021 12:57:38 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" Subject: Re: [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Topic: [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Index: AQHXzyL4/LyrZHH5q0iUxm90gqEiQ6vxVGAAgABucWA= Date: Wed, 3 Nov 2021 12:57:37 +0000 Message-ID: References: <9d8a7f7da913a1062d3f01e24615bb8bdc958458.1635769996.git.min.m.xu@intel.com> <20211103060914.scktdnjbfzrtu4xk@sirius.home.kraxel.org> In-Reply-To: <20211103060914.scktdnjbfzrtu4xk@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 30e90725-aeed-41cf-f12a-08d99ec9837b x-ms-traffictypediagnostic: PH0PR11MB4902: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M1bjXXH/IeTMzouaTOdKQzD/ID1wsgB0wcXCNbMScwOXtlKrdAC3I5mUiOU54zKSmfFhSxs11mo5cKFgKOagGhF2moR/k22YilmGa7JgIZAuaPsG9PDSBjA7F+0HdOOFB/f0IqTEnU92YFxPiYjVtNrcZEEQsD4K5S+GyreWHKzT9RxSvaVRn9pir9SPAHQvoMFIemeug7G/vi28j7qeyhG7/4XGfa/5ttFP2w7WbwnU5e3VoPSBu+sHO3TF8wjxKAQYzJHeAn2pgHVAcpARNxbODbOZxW0OQTd8Qo/Bb+G3NCrzUXQhePaPTNg05WdEFF8uU4yB7HJmWcI6e/1Bo6iWgUixKmcNuhR12ARS1stTjVN6/KHNTEtXjBlX+UgYl7NVuSd5i8XrhJRqTWHvVNwPLrPyCJ++G/6dZLz7MTLeKfJEcxhYdotWnx7rRJBNNHzcyqSm4hlam34324OenU3QQjisZzFtNHDFHCX5hCUqZuLe5C8B0M8LX6K4iy7Ol2KEw4ByoctTalf+xLEipjvNnXUL3ycHWfOpi8jcxarKNqJyfr12YwCKIozwVYTaUQzy0Y7nKYiDG6j7xj+qHt4EAlCrpUHVRzQGT+bUp67RIjEeYJ2Bxoa0a1qi056JEwyKbGK/StuOdyN5Vifn/vs4MdXUJgUFnnkPoBUBci5IW+SSgvVB1+NE6SVYD4lRGDNm7DkReLG3gf9EfMOb0w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(66446008)(64756008)(5660300002)(66476007)(2906002)(66556008)(6916009)(8936002)(508600001)(52536014)(19627235002)(38100700002)(7696005)(122000001)(86362001)(9686003)(26005)(76116006)(66946007)(186003)(33656002)(6506007)(8676002)(4326008)(54906003)(83380400001)(38070700005)(107886003)(55016002)(316002)(71200400001)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZiMXMP+ZG9UFpI6erUe1YGec5ibbViJqHsV8QjC38auBjAfP4DK+8h8FscJH?= =?us-ascii?Q?5VKlbyqwGTReVtMcr7I26H2Lj2xxedJ0KWl3pq4h6vx8gq0XMGpM6klasCNW?= =?us-ascii?Q?SOty7iTZ7oJpswAy2vXwB5guzI3yXEbk0FmNOppqrVcBFEfetM6G5ekzq8cP?= =?us-ascii?Q?I9U7EPVWvnqgUGQAt03qTsoMkjfi1udvXR8/reXzrKMBF6z3/LN8rlVIgVhG?= =?us-ascii?Q?3k6AJG3uK8AJDy1sDMgc593gulTFCVs6ph3Fb4MrWGw99G3xg7rvQXkaFFQ+?= =?us-ascii?Q?aPlNzuig8r5AT5CEVQAQjdXOWbJAZzafzslAXyf2LlZg8qvQvxnJK/M3W8hP?= =?us-ascii?Q?3PM4W6FNac7Z6LHSwULBdwaNB85qXjyciWZE+89y9Vjn+q48BxTxFjNOvP48?= =?us-ascii?Q?WPVo6zlG2/r1EDgVQGyn/1Uzbf/0+gwMKIYaK7Sf5zhhPDEocDqkydxudxN0?= =?us-ascii?Q?8bP7va+E3xDp3IeTImTW3pyXfIu0ASiAOh0mIznnE15DgX1wBwubwk5QEz38?= =?us-ascii?Q?4Ds2iAnXwlrqtMYorwn7JB4vMoFcSML+hmWBp2B07gLq76+wS9mimsA7KT7g?= =?us-ascii?Q?dMB9kkFH7LubFZdCAqLEMI82iezM1MpTP20jje8Mqm8NYlhHZnk0RxP64dz4?= =?us-ascii?Q?n3+GTqUi+6si56f0+HDqXG5xaEz6WTd9lUdHzEa70DS53ymaAJZ63pywQ5vy?= =?us-ascii?Q?cR8paz+bXkknpRrlASSC9QKHACSRPLNa851Pdt5GLfnxhiHBoWipWkzV/SL5?= =?us-ascii?Q?smNGtcELhxR1KnUV/rlVFleMq03PQHFYKaXG31s8FxFgdmjdUk81QqfQZaKz?= =?us-ascii?Q?4K0zYUj+XuOqmO4Ok04KjDLN5XZJ6KFBw5ZLwFB0JhUHp4YG5gr1H2u7Tr/K?= =?us-ascii?Q?QMYz7IWoMv5xnRq0creuORb554NnvDwCUBt+Qncp1eeQr1tUmtuvuNOWDNI3?= =?us-ascii?Q?jt7VIO45PvROqMiwCOBh5PvzfZFpR9oDawWvcxC5/55zNUs62KYU7kI/klMg?= =?us-ascii?Q?ubyQZcRBIzznUORWjbntSvGCtxWL/zkl61/hLj1CHh/fwaZXGXm6jn3cb+B0?= =?us-ascii?Q?kJeRKDC4AycAjhQRbE937dgNQjQNiMgV/LJvle8PG0hbQ/4fj1gpd5xbv8vn?= =?us-ascii?Q?OIu/KPJ6XnKlWCVcNM9V7vK4en96jUjBU/sluxOqZk0MnGvtSl84Ptnlf9Sf?= =?us-ascii?Q?alCIzpFL9C5rzZuvj4dSc9KhNWoJGh++WXAlD02ORyPFgtpfBR+3FCPLImzk?= =?us-ascii?Q?H4hUrXVoiy31T0H+02+G7lJPkwgOEquJV6flZCg8cyg79sPg2hlryWJtkwW0?= =?us-ascii?Q?sfTACG7pkdJa1AdUyDLXUG1f3251fr3kjZqp2Jp3rStF5AUO4A871Zmeq83H?= =?us-ascii?Q?jd02tvH2gBDAv0ODJjDGpJ0paVVKWfnXIDIvoA7D52pA91ld3xDvhjN8Gc33?= =?us-ascii?Q?xjzciKk+T6jKGZwZNe2bLREJDra6ZeQmCeXkW1E4O044ZZqcQLhF9y87qxaK?= =?us-ascii?Q?5yr4cRXGWHTCJ7Pok5izqOPiefvD5lpGzjmj/RixAjndQohT0k+yt3v0Dy36?= =?us-ascii?Q?th4bQqKC4GvAojhnr63/3fSkFYUBuUxYMKUsiEu8/Rh6M2nXp3nRVJWTYuT+?= =?us-ascii?Q?vMbgPuQmqZgiOScfDeqCDXM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30e90725-aeed-41cf-f12a-08d99ec9837b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2021 12:57:37.9317 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BMgN01nBc7KYjtG6ecW5G8GDOCijENpF3N6fkm5hhXONnkInup79cCr0IOas8tMJcZALAutpjeLbnyNSG7kD2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4902 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On November 3, 2021 2:09 PM, Gerd Hoffmann wrote: > > +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm > > @@ -0,0 +1,120 @@ > > +;-------------------------------------------------------------------- > > +---------- > > +;* > > +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights > > +reserved.
> > +;* SPDX-License-Identifier: BSD-2-Clause-Patent > > +;* > > +;* > > +;-------------------------------------------------------------------- > > +---------- > > + > > +DEFAULT REL > > +SECTION .text > > + > > +%macro tdcall 0 > > + db 0x66,0x0f,0x01,0xcc > > +%endmacro >=20 > Hmm, could you just use TdxLib instead of bringing your own copy of the > assembler code? >=20 My initial thought was to include TdxLib in the .dsc as little as possible.= For example, DxeMpInitLib is included in OvmfPkg/Microvm/MicrovmX64.dsc. I= f TdxLib is used by DxeMpInitLib, then it has to be included in MicrovmX64.= dsc as well. So I copy the assemble code in MpInitLib. But now VmgExitLib is extended to handle #VE exception ( TdxLib must be use= d ), so TdxLib has to be included in the .dsc where VmgExitLib is included. I will update the MpInitLib to use TdxLib in the next version. Thanks Min