From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.6625.1642733674084355719 for ; Thu, 20 Jan 2022 18:54:34 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QLNwfNs6; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642733674; x=1674269674; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=HMROrA/1+iVJWh/gJkXJ6G7YlmmN/Ay7aLWaYfEOx08=; b=QLNwfNs6HVoew8qubFDjDL4DjN3sL2c+w5uECg5PiebD83A4rn3NjplL Hsn49fL5dL8YZQ/BP796TVt49erW7p1RDqQffcOz6E0LTksJyFfsArbUe bzQw0CjNgALshjYk5QlA2FoXlz6yICMrSbJkcwLahNRjWkRx3zWRZtQ/X AdtSJewPp+19tUIJ0aTPsr8elJA+n2opj3BisfWYwQRKADS0Zf3aNAlO1 7Ynd6DQrrzm2RdK2obTPpty3eRZhASsnSkccvoW2jH8Uf55hM5vRRAhSM ijGnEdLt7yd9UmCpk6htvNgOyLGX07d5wL0y2KMcsmtN1mcV79i5PMkzH Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10233"; a="308880093" X-IronPort-AV: E=Sophos;i="5.88,304,1635231600"; d="scan'208";a="308880093" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 18:54:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,304,1635231600"; d="scan'208";a="579455851" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 20 Jan 2022 18:54:32 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 20 Jan 2022 18:54:32 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 20 Jan 2022 18:54:31 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 20 Jan 2022 18:54:31 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 20 Jan 2022 18:54:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MYNU1bLJ8xtA7QZRwN85Nv4OmwilTM8JFedhzZgO2WkvHkeI2Hngr9CzLHtmhB6/QGhUdQcEcdBob7ynjsHvS+80M6yd5esPMnLL3wSDoygF2X/QKZO5wwUc0IqPL5JoQTioEjbG6UwjdIBPTxatGe+ffjWrNYecG9XqVhJV8kQG2GP9KhC9W2hpRydtDKLPB2advAniSq3sV3LiGDQD7x0E2DlDeJ2ErgRZRClN/XxLnvKrTEBBORMa2HCqb0W1KQDpEvHfOiLQ4rZPRpE/xn6HQw6b6V/TOIKsFwDcEBYv6rKVgGIniFzG6n8WAELgP0XzE2fP4EfNWhKdNNOkeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lQL8LeekOENDaWi7ZO92hxjlmtFiSnpjl5HAIfXZpsQ=; b=aO/cXRolsjuNFi5eupQf/HKTN6KSneo7jAhFyjHiz+ZAUoMrEAaw3dTcmlI1w8BPXFccJgWmI2WUeYBOBIkfxQ9MxsVJG3jTx5Lk1BKhZqPLmwvJdbMgwYRagNR5LV91bVTJCRr+oI8qlGCt8iEzE8WIuYQwYdxPlfUe2kLbEUCndtDwVWyDfqkO0uuuQv2CPMKtvaRTKk5xOCn6nar0bRrM+ky1E12octojqdwI0jh+yt1/EaZz+VZlluUN8Qvma6yzvLFAtX7iCd76qL5j7xpwzZ70JlsE4hQom4S9YJ+Ay1E3usn0tAGMJ/BKajqbMtmo/XD4KpH1EUYn3xr28A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH7PR11MB5767.namprd11.prod.outlook.com (2603:10b6:510:13a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Fri, 21 Jan 2022 02:54:27 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c%5]) with mapi id 15.20.4888.014; Fri, 21 Jan 2022 02:54:27 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library Thread-Topic: [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library Thread-Index: AQHX8CFJmDVHtLIPVEO7sEWFrXRlX6wzSH0AgDm6pdA= Date: Fri, 21 Jan 2022 02:54:27 +0000 Message-ID: References: <20211215091600.q63ltwlbliwjbm4q@sirius.home.kraxel.org> In-Reply-To: <20211215091600.q63ltwlbliwjbm4q@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87ace2f8-878c-486d-da40-08d9dc8956e5 x-ms-traffictypediagnostic: PH7PR11MB5767:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YTWc99w2VbGwZOgOUGX2Tv0y9A6rSJF0Nu6D+N52lx/Zxlx3D1bBY9O4+lNsYV2SQfJFm2p56i34TVqzjPR3L2bdNZN1eLdsC+Czg+HXBwHenIMFl8oJoWKP2mDVFmS7+PAhGQ0hw2FZA4lJJH1UOc7rBYFA3vjFP3tKf27mgNilhwxN7iZEPdqz6LpZPK5qumjo5A0MehmagIbw40aMQLxdYJfTmAvs0QINKLPlRhocGxzng2284Vm7lwjEShO7YTJOPTg/BQSSB+ah/JZvQQX1M/luzAIyt14HBh+31vt8Fa462GZ++lsG0LRWC1ClI69DXpts20BM2k5a3+CySxOe6S25LXx2lnqSZ8Y7zmHomqplSlKKjvRO7lhfUu5QEBYaQPzqZNVEBBhDySAs1Fd4QZfmAEqAcuRomGWjCS8W0tlx5x/yVkLiFeNk4f8kdfrn/KxrRwhg79kCwqRMNb0/DQN9jFsdBIRjVPJupoWSZbDrBbcOafMJlaJRum5THpwul8wjeh3+/bCZeq3nLpaqMp60Vkdf5ZosZEIiH9zg9kQE4v8/ePIrSytMeelj6nxRUZYl4UxcTn0Dv3QCJaIifN2L24njbFMbtD+jPx+kIg8qpj0Ty7N4jwrCLuIOc1ovRi+wS9GkBYoQHdaR0SOgeO+dSaVJ+kHU1w3TJJjvj4pKx+y/FMsfW1ZmcbW0I0hp6c3QTy8MFDfPPg725qGW7JNz0y3W+FgRa+RIOevF4gEd57ASogIS47fse4Zb84zgZC1JX6QdZUthx+G0CEKYidtECMgVpQp/DjujH8hemTqdBeXYcw3Rf6qVRKI/ZPKK1DjC8oOxPn8ZU3boOeSfOXCIPj7w0HLE9Qx8yck= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(38070700005)(6506007)(4326008)(7696005)(33656002)(82960400001)(2906002)(4744005)(66946007)(83380400001)(71200400001)(55016003)(64756008)(26005)(186003)(5660300002)(38100700002)(66476007)(54906003)(76116006)(86362001)(508600001)(316002)(66556008)(6916009)(9686003)(966005)(19627235002)(8936002)(66446008)(8676002)(52536014)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q7VRVRqhOXFl3z7y0kDrJqjU86pGfqylAWovpzDQTuCOD0TBz3LXTlBU6kDa?= =?us-ascii?Q?HSL48llIx9K6xVtEa+3iF/ii8lN5vGmYu9iW4i6h3wkaUzIQe/T5nZJ6cTpu?= =?us-ascii?Q?Ni/PVzsxKELtPo8ENgzcQBFT+8npLldpMW6EEhDZ2TGIXqJJ3WeVbQLu9ngw?= =?us-ascii?Q?NAtxR7IXzTEbBAS1KguLtdV+XW+OZWH24alCP/qv43+gz47wVspuJ2VMEfyt?= =?us-ascii?Q?LPVU9A+41LkEZjawMyq+H01hmhezwWp6d5ew8gBPojJAxbfIScYhvWmkHpZb?= =?us-ascii?Q?808ekJb7706XX757WmeO0LqsQEpsYZnbrqB1gBkkYu3X3CiM54zfqVqqzuwN?= =?us-ascii?Q?xA13kJ9omh8ODuYidRr5KTbofNScQ6qISJgoZpAwfrIwsSm/2ZRFUIOg+XIW?= =?us-ascii?Q?4KY/S4LHgjeKVMqXeC9TM4AldU0bmqwJIcBk2OuxIW9GzUatTS8jUoitdY09?= =?us-ascii?Q?E8CF9/jrDc0Eg1HX15cLwri352+mVK1SCSwxDwz5HlKHrT5KSapXJE0Csx9Z?= =?us-ascii?Q?VPICPphi86uvXFR+6prLjbZcbSFKpZvwqYpy/XPvJ1FNACWzAs2jHMNjqISb?= =?us-ascii?Q?UpzuhbUfoexA3YIMn4pzvFK/y0/32oTk7rHY2qeQP3dCXTgGFwWN3s/eQbYO?= =?us-ascii?Q?yCQ83PqjTz5aprwJJx3ZBztYBXg7uXRPWDEQMCx5reqaL6tMdG3oyOYNnB3c?= =?us-ascii?Q?18dp77ggesjATGqbJwxPz3+1oJT9K7B/30ci0iBJPx1t4DF9md4smjLlbFWv?= =?us-ascii?Q?pMMHGykUoMxH4bbziUDGtCFOieSckcXJ2vIYATd2KWa9e1TQDF35dvQd3gi1?= =?us-ascii?Q?i4Z98Jz15VXCoiuS8Ses6t3Oi2E7XB2Pjve4qpalrxUnClfFpDHhLsn2zekT?= =?us-ascii?Q?4vKOLTnRfZgY9Ymmjq730JyH50etNi1rdVcXR4RrMRzqbg56N5kFhACZrMXQ?= =?us-ascii?Q?6hq4xfwHSM/7kY1ythLXrcPcBYss0kbhlSw0N/xrCBDsQ8oUJ+9ceRl3ZPkE?= =?us-ascii?Q?9VNKb9aGkmr1qKWjDkTbPtfWEyMYJq+9IUzbkkoF8E3G4NsPWEImFugBNguD?= =?us-ascii?Q?wAMIvaM0UKtCJyGq3kDnQh6SntCMZHhtoye16DWy7B7UFT0zWooFHLTjjecs?= =?us-ascii?Q?pTRzFEhAD/CC3bq6oHXkc7/d3EgfnRZGjF98YOsm06NhRkLP/UxqGdY7MEPO?= =?us-ascii?Q?t0cfl34wgrRu4fz1aq9jpWYobWPKge3ckZNOzSHxpHxxO5s+adEvqIxKAjTD?= =?us-ascii?Q?h+gjvP/TRvm6kf5fuu9pIeHaI6yj0dr0f8JKyfKOPcLfMUDInrI2MGfMdsUB?= =?us-ascii?Q?e3NHk5aH2DrOgkZFIjr4dPHPgFUuUXKBCzMtKhxCFDNlH3eOco7sc3LC+/g+?= =?us-ascii?Q?A2K4psrD2NHA9rljY8o8GveZkTPOgEkOxjUvjlkfk7ItmlgFW1xmFwpe+ws2?= =?us-ascii?Q?7Vf7E3UlvtAp72ZtJwQOKWFNzX/yJGXwSOfICOgFknY55FehqZ1gBazSVNQz?= =?us-ascii?Q?3DdEsnW8oxKaj/kIZ6y3OSEUzTk0k0fxNvB4YLKRl84n+qM7F7/4Av01GbSB?= =?us-ascii?Q?dammgv0vXaZI69A1lVX4r8h4SrCcmfr0UgyyCrPmpOy8N+NvRiJX7+aOqAfb?= =?us-ascii?Q?f3Tgr29WayHYfFzcYkU+kfQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87ace2f8-878c-486d-da40-08d9dc8956e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 02:54:27.5545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aX44OraFg66fGlJtlVPh6b1h4Yxe30yrVmXk8XM633OYOwiJKX9O+tNNRpa9+3K5+80SlRnMtWL6NObM4MAVnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5767 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi > > +++ > b/OvmfPkg/Library/BaseMemEncryptTdxLib/BaseMemoryEncryptionNull.c > > @@ -0,0 +1,90 @@ > > +/** @file > > + > > + Virtual Memory Management Services to set or clear the memory > > + encryption > > + > > + Copyright (c) 2006 - 2018, Intel Corporation. All rights > > + reserved.
Copyright (c) 2017, AMD Incorporated. All rights > > + reserved.
> > + > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > + Code is derived from > > + MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c >=20 > Can we move most of the code to a (x64) page table library instead of > cut+pasting like this, please? As I explained in https://edk2.groups.io/g/devel/message/85582, there has a= lready been a same feature requirement. https://bugzilla.tianocore.org/show= _bug.cgi?id=3D847 . (Create page table library to abstract all page table m= anipulations) I discussed with the feature owner (Ni, Ray). He said this feature is in h= is plan of 2022. He suggest I can wait for the library. Thanks Min