public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ardb@kernel.org" <ardb@kernel.org>
Cc: "Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Measure ACPI table from QEMU in TDVF
Date: Tue, 17 Jan 2023 03:46:30 +0000	[thread overview]
Message-ID: <PH0PR11MB5064CCD2E8084A94D915B4EBC5C69@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB58722A6A7D7DA248D1C6ECF68CC69@MW4PR11MB5872.namprd11.prod.outlook.com>

On January 17, 2023 10:13 AM, Yao Jiewen wrote:
> Sorry, I would like to withdraw my comment on ACPI table event and event type.
> 
> PFP spec defines the ACPI table on flash be measured to PCR[0] as part of
> POST_CODE.
> 
> But here ACPI table is configuration from VMM. I feel it is more suitable to
> extend to PCR[1] as part of configuration data.
> 
Thanks for clarification. So the measurement of the ACPI table from QEMU looks like below, right?

  Status = TpmMeasureAndLogData (
             1,
             EV_PLATFORM_CONFIG_FLAGS,     <-- event type
             EV_POSTCODE_INFO_ACPI_DATA,  <-- "ACPI DATA"
             ACPI_DATA_LEN,
             (VOID *)(UINTN)Table,
             TableSize
             );

Thanks
Min

  reply	other threads:[~2023-01-17  3:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16  1:56 [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Measure ACPI table from QEMU in TDVF Min Xu
2023-01-16  2:42 ` Yao, Jiewen
2023-01-16 10:38   ` [edk2-devel] " Ard Biesheuvel
2023-01-16 13:57     ` Yao, Jiewen
2023-01-16 14:14       ` Ard Biesheuvel
2023-01-16 14:27         ` Yao, Jiewen
     [not found]         ` <173AD0557CFDE0A2.23170@groups.io>
2023-01-17  0:30           ` Yao, Jiewen
2023-01-17  0:35             ` Min Xu
2023-01-17  2:12               ` Yao, Jiewen
2023-01-17  3:46                 ` Min Xu [this message]
     [not found]               ` <173AF6CD0E3DD24A.23170@groups.io>
2023-01-17  2:17                 ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB5064CCD2E8084A94D915B4EBC5C69@PH0PR11MB5064.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox