From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.2956.1634171238500664966 for ; Wed, 13 Oct 2021 17:27:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=gKM6XMZX; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="214726759" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="214726759" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 17:27:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="487142271" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 13 Oct 2021 17:27:17 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 17:27:16 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 17:27:16 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 17:27:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4fg3IAX32wSdgN33YaBBtosDd6G5ODBGJXXdYmIro1vxlW/KFHs+M8deeJO/Aq2K95iizg6kQDrOEaWx91y4ceXGkU7yJLMpU2KXmpxo7HCLqQLg0ICTYbLyD7WcLtkT4TBUEDg7RiQYtgkRK0Hd57/mBeMyT9dxezRcFbjF18M9ZNlBLXQITfi9SweLYXmTM6CSw2rTeEDXRi1dm2R8jISKP8OT1uo3fs6sLMUBtZKRr1a6LaWXKZOica2TgDzcLH1WUyX/Icj1W5z23yZ9N/Z+1iItAicsfbsORdxTz9p8tnTKWmQkrL2WTb22ztPQZrQvJ/apDDf0Ni+Sis4Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J1tLIJ5l7JxAngYEoDEnk3zAH1NBdgnKt1B9Ajdts8o=; b=Hxyp2hFAHc9W/lW4Y+CbU6VGgVsmRd9GNL+LDS9Rm/Cnbyhcyvs+gmiKW3KukzuB6ezCIsYhlKJI9CM4cQLvtNtNrZKGvDVKTNyetRPEfJaISXm3STawEIAH1SGidFWAbHxHgWu0OA4Pj+o9onmrs2F2iV+IvtmXdXYVmxrLsRE7R5aMSNIgl2cPLB+u/Z3MEv757pKBCnfg7lPLuNi+7Tlw9xu3iGSEVWntw50qLngke9E+Rf+ycvevvyhaWwV1x/9QMGLitwdS37aKUQUNrUm4wLtUsupOiN7FbX/YOV7a7fyLfeGPv2V8zHGyn3gqKZm3sCFDviJng8b+wL6V6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1tLIJ5l7JxAngYEoDEnk3zAH1NBdgnKt1B9Ajdts8o=; b=gKM6XMZXLIrQCHJ1AEc7k26LkpswyG9OB1MVdUGZcXAxjObpfcS+jdRsnoMqIkC5w5NKmbG8FZBxM7X8VufXHXbg1e5NpDVKDMLJDXXosf4EubsS+THwQ6PvDFWVc1rUdfUOAYRzi8Ug6Qo43+wgyuBwIKqpFQOIpFIMqLh5wmM= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 00:27:14 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4%3]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 00:27:13 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Topic: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Index: AQHXuZrKdJhnG8YQVE644DznAbIZs6vPNXiAgAJ6BFA= Date: Thu, 14 Oct 2021 00:27:13 +0000 Message-ID: References: <80403cd301cc6f0e88bc1c10e11ec262c1093cbf.1633401643.git.min.m.xu@intel.com> <20211012103139.4xkxi6p6jlkjo2wo@sirius.home.kraxel.org> In-Reply-To: <20211012103139.4xkxi6p6jlkjo2wo@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 277ec21b-6ee7-49f8-e1a7-08d98ea95eb2 x-ms-traffictypediagnostic: PH0PR11MB5064: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vqq0BeIRUzDHtTs090R7EbVzbHK8DZalBpAaGWYiZSSLObLbWz/tyitx01TFW4pDBX8/8i/mDnipLlWj5lKRc29Iw11hGrHXspaLBnGjoySvBoC3RcfSqQ+QZa/+IkNt6oJDUOHPNBYwPyAHy91b5sbwwBuhSbPOjtItIq862qZyZ8MDARCdjyaBPV+3xlh7qXxyPjm4d+IKtbLxk/cP85VtuVubj+Eugh0GCbmvIaQcxpTdJoeihhwigq8kQulw4t/OSv8JwfSd6J9wr+Gjqps9wCsTMAX4tw/XN35DsEc+SkjjcuzgrvHyASIGKnG+DRsSxB3RHmsBvf4S0WTZ02UigahGyCAqjqsigAzt/4OFeVRQ20iDaEzmMqJFtp/qgorJS0x+/KogZ/0RltuZx+rNfQwihHvXEKXf8IkHFT8+edFjhMb5Uv/kSGuaMccU0hiadrHDXrU6AZh+T4TtNdY9lSvizX0ijhy2xQD37d41r55wc0XEpku5NqlZZSGM1KUgSIJigDgdRs2O9PjfM/huZnC9l1dhpWFxsJazeR/Y2I0mV2UIIypIMtlHYvb6kxp90ICVCnSZRoTOLxbgUg8X4uAvAoIoFXY2Gx+6EEsMNQ9u0xLVdnAuw2O2TrFoYRalnibbzurtuRrEEydNHpWD82Hdh7pHMV7UxDiKE7HY6EpKggq2SIHUHVJSoBoKMrOq+Lo11ca4R5/ayczyWfFjAexIltmCZ9vc/MEfuC1hdC1l7YPit4G6zOCo032lC1yKES6lX8kMEZJdQVRYCsHTk3rXCDSGSSrUnM7+ZTSOTz/WFjnNJ7u65PwcqBDPjiWA77Fdx8l9ExTG8NwV0Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(8936002)(38070700005)(122000001)(76116006)(33656002)(38100700002)(71200400001)(26005)(110136005)(55016002)(54906003)(186003)(316002)(52536014)(66446008)(66476007)(8676002)(66946007)(966005)(6506007)(66556008)(107886003)(7696005)(4744005)(82960400001)(86362001)(4326008)(83380400001)(9686003)(2906002)(5660300002)(508600001)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9wFwB4DpjMnHk/VvicoA9Ej3Wgf4OAxQEusmKpv3JpRkbbhUUr/EiS18s1Ip?= =?us-ascii?Q?dLwwQLsVvmKzlA63I8Jy3rFOG3a6EGZ48kyZPkrFL/Irm96c1MZ1iBijV2KH?= =?us-ascii?Q?90CfNgV8kiTXKKqhgBNxPkm61lP17NGlDA/SB7HI1BvjOBoY+XGzrhodrXlj?= =?us-ascii?Q?r/Uw4yd4HsDOZlJEeZ6oO1YpKpPY5teWwapDFCO0F7OfoFCWBbaRhz2EIlAi?= =?us-ascii?Q?3s1Hrf0MLhblK17vfGZLqLF2Xd4c3RYXLUdiufMcF6Ihq2oMjw5jPzlHFMgE?= =?us-ascii?Q?uGPiBqfrWoKf58WNokIPgnBUGExb7qgKmDHmQj7DRd52i/Tz4gAvbjNuPxI4?= =?us-ascii?Q?aHbiAMO0aWPwtDRGhZzZHy/hwKfLz33Py6193+lL2HXpiTxtpUnEe3offmY/?= =?us-ascii?Q?EVkqZc/CwHoNanHp3vuYnCrPIWO6kNpmhF1tgj8lRBe5M6AReII+REr4ococ?= =?us-ascii?Q?a0JJ32D+VtNJBUndc+FzCm+OyWCQLqq5y/70/nJ4tGo4twTz8oYQC7gQQ4BN?= =?us-ascii?Q?BoQTljGa2cIvxyNbmleD15UZeuGb5CVI9aTgPEdy7Rtge/6TM6iuGL7rnAOU?= =?us-ascii?Q?S8CHevyPZeVm9Mqnyfuz4VzhqnFj//V+rXlAwb+zK1utmEEykYbhRW5HWrQe?= =?us-ascii?Q?oDaNEuf/tEUqlzs1Q4qzjR6u3voEshcezAzQnvTIP694dGnggBpEUP24daTf?= =?us-ascii?Q?ps9wauj7p1TuxPfGPokUnuHQvTkLT1qoSN0LUIhiMdBY4vL6DTcrtmNyrLgg?= =?us-ascii?Q?jNV+yCpBtzr004JIaEI78s82SkGW/SWD5UDI0jY0VI2RecVR7MBptH5RzB4t?= =?us-ascii?Q?ZgvAj+6ps/uooVynQjrzXL5LjLltP6aI/rRz5/c9EmXLBntGqix1eTpFpAWN?= =?us-ascii?Q?OMyqA2ETOQxoypCm9DrEIN6qsrOzbW1UdQ/7f9NDAERQrdNVhxlvJNA5yMl4?= =?us-ascii?Q?c4NjYV47Lsq/Nl7OUXyTEn4MegNyCOQVfMu2PmLWv+z4RbLgYLiua8fiegkK?= =?us-ascii?Q?t8uxPk42GvOHbO8oWIrSDloPyA7Knug3/z6VDTil0sXCei4ZaO+P5EJRJ9tG?= =?us-ascii?Q?F9v5oYhFgw1OpvTSYzUAycVmVedcCJepAPlTWe+u8qoFpNp/qXQNbNwKUTh8?= =?us-ascii?Q?7Zq9zr7gSqg0uwHyF9OcY1Jlhz+Ts542hzlsZJIBw4Lr9rbcaS0Z1r1yhIK0?= =?us-ascii?Q?D7jQX8ZqIg30rWQ0EXScYKwtuG/zgxntWL2cQ6vJjD2Wt97XtaFfHWsPTpmK?= =?us-ascii?Q?NThqILa+GsUwLf8ZKucf32+fYsaIVd8LL8Re5M3JkkhIi0w4mJg3v1Yu8bBL?= =?us-ascii?Q?ckCXsokHkSpcyzR93k7lsT7E?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 277ec21b-6ee7-49f8-e1a7-08d98ea95eb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 00:27:13.7580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oBEeP79Xoxw/wgTBAkWlwRQGSozosJlVTvuKe50k34l5mmRIKm9ARDzYq9nUgzsOs5Zlk/QW2wSqVbWq6OiQdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5064 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On October 12, 2021 6:32 PM, Gerd Hoffman wrote: > Hi, >=20 > > + do { > > + AsmCpuid (0, &LargestEax, &Ebx, &Ecx, &Edx); >=20 > Again: this should use PCD. ConfidentialComputing PCD is set in PlatformPei. So any check of this PCD s= hould be after PlatformPei. MpInitLib will be included in CpuMpPei. So if PCD is checked in MpInitLib, = then we must assume CpuMpPei is called after PlatformPei. In current OVMF, CpuMpPei is called after PlatforPei. But I am not sure if = it is always the case. Can we have such assumption? Based on above consideration, CPUID is used to probe if it is Tdx guest. >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20