From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.21748.1647408381358028989 for ; Tue, 15 Mar 2022 22:26:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jPaa5z1q; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647408381; x=1678944381; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=A2Qwh7SYJ43xXkLKMcvNWucK4tvvIaySUjqfZnH4WU4=; b=jPaa5z1qJWHPviW3g+e6T+fqqteExt1MMnlflLHRzMy3bywA5+mnBzQL O4TnAjsfauVFxX3GAwmWVdu/99bLqcSGEdyHXvUXNjRNjo8NNqZ5l/F3X B3wDHxezRNncAXr+wUbDovoWSbOivJw+RhX8GRUh5JjMyj1aHmnV8gxtM F7e8tA4i4yD8my9gdvFeoaA61qIWl2PiyOwz1oR5gsTRlPFxyrinv4sY6 gEK0yhCwvxjrzZLNYvhSFJPGSWXOCXf/lW+XMaYJO96WQy4S0ECzm2eoi 4fLmgQzi+3KH/o4tus3pGqD60Yi57hni6ndR+bApKttlm79f55RAQgCKG Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="256685829" X-IronPort-AV: E=Sophos;i="5.90,185,1643702400"; d="scan'208";a="256685829" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 22:26:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,185,1643702400"; d="scan'208";a="540760830" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 15 Mar 2022 22:26:20 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 22:26:20 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 22:26:19 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 22:26:19 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 22:26:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T2lqZDljLHAXKx2qRbnKZhPf15lI/OL7kRyudR2gpApEBv9Nv83C6sjpmNaZ+iS/9fSRu2vDdh9jRPp2XJA/tc2xI3ESU4sy5MFn4/zt2TfrA1gPH8+Lqqz6tGenyD35KxG2RiKLAmTSJ+qxx+ewLu8RLpTRDInrL7IPckpqzqyv4zzaeYClm+jemgY3og7KXLGeSKOSZ9v30T7z00pcG9B7xVtXzqU8KH7GMsP6f/mF24dodXDC1C3MB6wG+VxDF3dO6OD++yqGV9WV4QYKesHsihWLJ21mL/9bxD4LhO9ZpxtuzbnNPJZAiT8xcGYq1fpnvcPQz3QX55PfRNsHVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NUjERFDWXKPANEq2T1ML8czORA1l75D3vCxya31neV8=; b=lsfrd8+ExEhO/lB+x0uMCyOi2f11Iki7gMXzdihqhpHFY47cuVN1Jcl9IoS6+OXV5ZEmImUymmENYriqZ1hGc/vonITr+wH+DTKLomUmA68CS4fYrfiLj72+Q9mngTGjcQsLT2zbQjggi1p7zaK14T2G0HdzRZfUrJpZbiWCwEHkEtR52sKd78TNnx/NwRVZWvAKThHAawRLU4W3R0wPtySeua3IUE9wcCS9eeRTvLCtNqWKHU4MbLGvAmzy047q+dGi6z+0+CnYyRDuL59nFL1uZh8G7C17LJj1r5ygpBddUayuU711QMRrZw7yzDdZYCJEho0ukwTIgAni0w0JRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BY5PR11MB4005.namprd11.prod.outlook.com (2603:10b6:a03:18c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.26; Wed, 16 Mar 2022 05:26:17 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a%7]) with mapi id 15.20.5081.014; Wed, 16 Mar 2022 05:26:17 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Boeuf, Sebastien" Subject: Re: [edk2-devel] [PATCH V8 18/47] OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob Thread-Topic: [edk2-devel] [PATCH V8 18/47] OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob Thread-Index: AQHYNbREy+HquhfIUEWAES1xsOM4KazAGTqAgAFnrFA= Date: Wed, 16 Mar 2022 05:26:17 +0000 Message-ID: References: <20220315075729.nk57thjidnjbithg@sirius.home.kraxel.org> In-Reply-To: <20220315075729.nk57thjidnjbithg@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0306fa97-422c-46ac-c4d0-08da070d7f05 x-ms-traffictypediagnostic: BY5PR11MB4005:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hZ8bLyimh0ZfTGDpCL5+en5QK0iJ3LU/e4nm4knAYX6NBHdtjPQI/2FqPUl3pUffH2r4L5GQnYxW90oIJUmzcBTC8dC7p2XgsABc7B7909MVzCMK4i0eqCLfEsmEkye7xOZhvqBabjQUWGGNSSVwwCyHbrCdLSvZnqlz96CveK0Tb5dDQNzBWGESflFWW44n6DDkMuoj0sfsH9wq8H+iFiMu+APO8uAnoW8+SxT+wASagNaBSSAoEjHrkjWZTe542dNYe///7yB4CW9wN+CNb7zKpqaA+SMIG2ANf0SpuIFiRAjn/kvEwAKcho078ByKiDRETt2eoOiGlIK0DZ3ezZrIC8sKT77ZODWVnPwHwIyhSpqbVnmgPpY2dimuHO2UlfKqSsyhQCfzvCo5BuxzGlUFsdxUcz6eIcaQu2roJLEY2QrEwPMsSS5RZK4Sz9XlinLfu84gvgeFo3JFbwON9UMminAihFo2W9OUaaZlNWm85zge+eXr7PKYFcOj0rFS0wV0tbQE4dyAfNv7MAujnC2ntbop+6I+Q9vhO5hBjZRzab2spMT7aEikQ748Iadngq3OwlH+J3kF/+bQuHyrXjy6uwcOvXwPvwf7QzfJGLBcQVdSk1c8ZjGMTIxVsmaxU2Qsz7Ll0ejYWmsadtaL1fqfUQw7GGo37V+93gQlx3LHd1H/9mEUu6AAyVYSBDyCUK83giARj9c5ZidPHvN9iQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(64756008)(5660300002)(66446008)(76116006)(66476007)(66946007)(66556008)(4326008)(82960400001)(8936002)(71200400001)(107886003)(55016003)(8676002)(316002)(33656002)(86362001)(9686003)(122000001)(38100700002)(52536014)(2906002)(508600001)(6506007)(7696005)(26005)(186003)(38070700005)(4744005)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BFS1tuh09NEJKBZgTks2v65SpBab+Pcbv92tEaP2HA4qVyr2xQHekESNjOGg?= =?us-ascii?Q?y7CrX6E2oqYr+0E6MI3c/KEA87VFQz9j+M+Hpi8BPtLzd+dxLw04HLmtmoJB?= =?us-ascii?Q?9kxXfkwS81pVp83qNPRZ+oECxwbLpAKb0POXHpeSFMhclDNqSFfDIAZ/6vJC?= =?us-ascii?Q?vVKS8TSIWC4U632urQd1hh4EobG4wbLQuJiPuQvxSugj/Fuxli/0zgPsXGnF?= =?us-ascii?Q?KrjGTys1SK8NjN+Rl7bVzvFzxaUqq36pLmPiUpC3pawLhSTqnyLhO4rnV14z?= =?us-ascii?Q?KAp6LWSnj+41Ag494KmauTKdzlBrEaEwC87tz7Iqny8HswIJEDS0VS3/s/H0?= =?us-ascii?Q?lHNX5pFxldUM9E7+S2wS8u+VIBrbe+yITAlg1k7Gl0chdhAspuUgu4bI2eKS?= =?us-ascii?Q?fMlUtOFoVEYchB5nrsCoAnq/W7vPHNBp4+8xIJ+4vCiekKVQ7rUZ3qCg7c1a?= =?us-ascii?Q?xX82BBj/NZx694+kVb1yOtFn2FlfGR6DIXFMvy1T+A/qyhSOMat4asOODeaP?= =?us-ascii?Q?k5iN0X3mkY0HWqrepPAdSOseC77emkk4P77mmFFqsqb5V7J544dsMS9nnXA0?= =?us-ascii?Q?4km7sxLacBmbY5MmttHVPvj/2YhodLKcL9ATu161fp9OzndnHLORJ0HJlwBS?= =?us-ascii?Q?4cjOv/YHtRsU3JeOGnscjwiQBmLm7vmyZKkC6IROKvltjU/zLighn7EqlNQB?= =?us-ascii?Q?quKAy9w2qJ6HKdF9XkTJTDu0FDH8bnUCek8Zj9mR5QdlQhfUIZubnRBX5uJM?= =?us-ascii?Q?3mFBPrqgE1PH2lRlKdzq+56zZ3nB8hz5nFs/vQNtIetJaikPeXSb+bKPU4Iw?= =?us-ascii?Q?Xpm36g37bTtFApEKvNILLETp2jaUxEe60LGVQOzPOqL9ajwWN3H5T1moc0sd?= =?us-ascii?Q?O/OOWUIqq5YOMzEa918stftZQ9vla0mThAD9cH3+LjY/7mbFAUxKzWIDyVQ3?= =?us-ascii?Q?790eNMXuJpiBwNaivHjb08+5fJsAZBGj0YUPe1UxZdUQ+qLWhUjoPuG7fmlC?= =?us-ascii?Q?YJfR/N9BgzWZbOMJnafoVVBjVTDun295V5ibTAYDXtykDGyEusy2ERjgaotO?= =?us-ascii?Q?eUw5LWtR7kvVc3zLhY6GBT8Ae4RMf93I2XpXyTP5tzJI86WWkFjkLtZPoAmb?= =?us-ascii?Q?DnMGxhDtdM6Pjqax2fJ1pAfRKlAICvdf1E7BAdr07QnpjMLS8SpIZ778IjYX?= =?us-ascii?Q?EaLjgyHWtw2qXzb5HVRqQoMCoYW2czxBcnZHeE0rFi8Hp4uveNuKblzlM6rI?= =?us-ascii?Q?VMbhdN/AaJ67ZRdumBt5MDnXAvKQ0zpIw3Cx5qxFAVhZRRJp/vESR665O19D?= =?us-ascii?Q?lyqf4ArCPETy+dFArzs8hO120P1cfucmbrtujgORp9SCxRoK4ab+Yoadp222?= =?us-ascii?Q?24ME97/LndBFuBlgsXaP12/xZf2p1TIvpSu5mxKAla527+CVzNRvkdmlFh5k?= =?us-ascii?Q?eFoIk2a1Ir44e7g4mcWh/wdBluzRNAlI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0306fa97-422c-46ac-c4d0-08da070d7f05 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 05:26:17.2462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hhNNP9R6eSUENdfumuwC2WnpOxtkRWBkB9IiRaWzwuaQx3akfPWvT+yEWRqSgMY48sOBS1imYXn+utK2fSlXLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4005 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On March 15, 2022 3:57 PM, Gerd Hoffmann wrote: >=20 > > diff --git a/OvmfPkg/PlatformPei/AmdSev.c > > b/OvmfPkg/PlatformPei/AmdSev.c index fb7e21ec140f..c180383b42b0 > 100644 > > --- a/OvmfPkg/PlatformPei/AmdSev.c > > +++ b/OvmfPkg/PlatformPei/AmdSev.c > > @@ -24,6 +24,8 @@ > > > > #include "Platform.h" > > > > +extern EFI_HOB_PLATFORM_INFO mPlatformInfoHob; >=20 > Move that line to Platform.h? Sure. It will be moved to Platform.h in the next version. >=20 > Otherwise looks good. > Acked-by: Gerd Hoffmann Thanks Min