From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.5885.1615278450742185366 for ; Tue, 09 Mar 2021 00:27:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=E1N9dXOq; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: min.m.xu@intel.com) IronPort-SDR: RB8O2fB+zQuzxTbTLCQdipa4QqpA3RjAf06fudsYluwjyiWmKuKtsPVFOElQxi3cXjXwvnbh79 S8GAJEne+F2w== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="188291317" X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="188291317" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 00:27:28 -0800 IronPort-SDR: IhotRHiWw127udvTAZNHSZ+PV1AmfnODJx7QX9h5Qj3vws1rv41yNdQYghh0ATEyLoVEkgUQNo 6T7OQku28ZvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="437819454" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 09 Mar 2021 00:27:26 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 9 Mar 2021 00:27:25 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 9 Mar 2021 00:27:24 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 9 Mar 2021 00:27:24 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 9 Mar 2021 00:27:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k4x7vaioG/V3TnkoEz3rjUGWDLqG2cx4qt6t1nIdCy/squjJ7iY3XVrNYBTU+06nPz+hWQiLQKfg1YhO8fAetJCxHwjSvbbssvCwkwkqK+Ju47Pv6bgVyQNMXTE3d7aK9WLVIg1tbv/szzS8Ok6xG9bShg/01QlG+atACc/ituC2MtAeMhN641wPOg5eUX+ZPN09aEFtD32+ef0lsiZNervyU1uzEB00helS520ZR1OqDQeW7+ET5GQz+8e4NDRYFgQ/yzrLZoUXUA+yY2UAp36QvHCcDsd6mf/4W3fA76C8amVPRd0w6Svwpnj5aXRcKztUGsNemF5zFZ8UPdLf7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9YobPYyRyavDVm+NPPEnv+GwPUd5Jd5vnMDW+8CM1c=; b=KtoijPObv4MrtBbErt6JH14hUjEZKZvnbX5ms8ifQF/lMp3VOySyOydSdHFUEzod3upPFGZxKOW6iff1BRQubr2TsUb3Hrw9dXbUgNiy/LjZfWtuJZndefecIOTO4wwWc2kD4H+U3AJwXaFXuUtsljPJdg2PHJkDid5PLyecDedqOrhFWpTFUvz6VnhT4jJ+Kyk0D22CKN834EsXxeKG02Jy/UqMPlINFCLt/z0hYfbHFI/1ryTO5QqmsZSxkiiuhJczf629AT77k/7pkueCttD3IKK2X6e6ATdQV8dl6KExeLETdt/fY/uiGW7WfnmgzSH0G8cgXd403KkGBT3K2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9YobPYyRyavDVm+NPPEnv+GwPUd5Jd5vnMDW+8CM1c=; b=E1N9dXOqhPn1sUeBQiG5EmK7Y0+A52LQP0DK5jOKb1bhVuNs+lvH/inwTVks1LTn3OeDbGBtTgZlEiBxoZJsPsnY5SO4NkdXUH4oD94Ct8SGqdUWsokE0s2PB1ccAv9uGS8xOg0zFA0N7kv+xxZi/Qc5xdrawC/EMBkVTOel0II= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB5160.namprd11.prod.outlook.com (2603:10b6:510:3e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Tue, 9 Mar 2021 08:27:22 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::5dd:1fc:498c:93ae]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::5dd:1fc:498c:93ae%7]) with mapi id 15.20.3890.039; Tue, 9 Mar 2021 08:27:22 +0000 From: "Min Xu" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Justen, Jordan L" , Laszlo Ersek , "Reiland, Doug" Subject: Re: [PATCH V3 2/3] OvmfPkg: Add PCDs for TdxLib Thread-Topic: [PATCH V3 2/3] OvmfPkg: Add PCDs for TdxLib Thread-Index: AQHXFKto4KytwtteRk+mmo48D0MoCap7NeSAgAAbwYA= Date: Tue, 9 Mar 2021 08:27:22 +0000 Message-ID: References: <6ae7e4da528afc7c06599cac98131495ee31e511.1615269637.git.min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aaa0a7df-fd0a-41b2-fb9f-08d8e2d529ab x-ms-traffictypediagnostic: PH0PR11MB5160: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Yst5VmcHhkpzPEord3AbINciVIanpkDEPQJ64FqCXIwN04tBi5R3wwio0jWMlDmzQO9NGCy73ghdbDDFxQ/pWmNzTpCzKZQLu40B9xXpKT1Uh+sQKF/AgAPv3imqCQ5rG6qz7mNqJYAVjH7TQkgK++ONi5DmelYBDaYdb1yv4gf2gvH8fzIX3jnBci1oLSovzhA+75O30A0k+0sjzmqjd5MOlDGvdkf27PgwWJkeNytABQFNJj3X7Rn4unKKtW5wbLIP8kWLln6ykj3QO8Uvo24UkhKLZoFGCd/aJH1IfgIbXDeb0CXrHr6jY1MALOCAiHlq86gatdLuiPDulFBCCaI96B2L0i1rqXCEoL6qUFjN1PLKlwYclK+7+licOATq6SqSozVwz+MQj4jT1vQNYVjLoKtsT+9X8FuW1kHy1m9DI8wYwz9VsmkHd6M9zhvk7NRubAgW+PYM7FpYDtYIgNu1wYBlgNnzAed5gToMWIMQYp5sy40pKFX79Yr0OPcG1vrTXCcgNCABCTV/w+hddg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(39860400002)(366004)(396003)(346002)(9686003)(478600001)(33656002)(7696005)(8676002)(83380400001)(2906002)(5660300002)(110136005)(316002)(86362001)(52536014)(55016002)(66946007)(26005)(66476007)(54906003)(76116006)(6506007)(64756008)(66446008)(53546011)(4326008)(186003)(107886003)(66556008)(8936002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?NSf56oRhSPt5qUiTIXbsmWR+9uJYP98Z9F+qND0DMofHd/DPPVG8S8bQDMqy?= =?us-ascii?Q?sQO03Zay50uH21kIW7sFKWIKDO73WvM0onCrXfYtOokyZsyCV0yIYkbJ0pug?= =?us-ascii?Q?3Wq2C8SYxY2vSt4i1HhO2ljneBvtkDCeJfxoaNEeddvkSb2ie8fmNKC1IBNF?= =?us-ascii?Q?OrbxaGnVY5WzaE6PT0e68U0kFAmHblNQ1lQ2i43c4ReaNrFId6tuGVHb3IrF?= =?us-ascii?Q?RKkq0RJ6EuBCSCnulNjq7CnYsY1DalZ19+8yprPNYvkAYzRgqW5LeJ03VVnU?= =?us-ascii?Q?MRfpfc159SRC849vXCwCgtIuFRBXvmM8FSk6Qfe5LQHUOBfh9NtBPcNpO6Xb?= =?us-ascii?Q?YKG1aN8U9tGqbKllcu0Uexea1VzmqbBU35xQ1PIRVZKDgEmwRpEqrI5YOKW0?= =?us-ascii?Q?QXLjdqllFiPBQFjFIjXbz6rgpiL3IaFK0LD/OF0HF75YaLh6+L+sabhR4ECU?= =?us-ascii?Q?ZFtMkUuDr2BwSZcRRTATum6tusi9enT1RpdAJ113Pb++pYGPcU7n4qxEzp+o?= =?us-ascii?Q?+zflxFRttnr1vdZOTd/n7SBRDjJ+KlpYvqIUVSdd6XXAVuG4RBKgGvwS+0e5?= =?us-ascii?Q?hixwBxcDoRSubNQ6vwOQEpO2xGYUzYfJUnn0+EHIpBDqm2LdaALidfrnsZjK?= =?us-ascii?Q?EmSVHI3I9fsSHjaJvwh9ZYLX70hPWpqTJXNnFjnMCc77az+jbQpxDwPDLyg0?= =?us-ascii?Q?oNUPE+RNw+6gUxl2YKXm1x0s0w0PwVGPbK65fvEbF0dtW3Pi0HewSmHjw3f8?= =?us-ascii?Q?iF01wBDvbPEa4IEJthpjGEomuqqG4wBB84GEhtSc9DSuWZfvEW1+ZcG09+pY?= =?us-ascii?Q?AHyi3sglWeRNOhorYS2vCOvzbnXbjxlHFjjSXVdzoHKWI4oMgy0So+3122KX?= =?us-ascii?Q?Hv06iwuRPhyhMFT4ewnd9Ny8Lieu7Q27wx7Mi8zxwlIMvbU/Ry+LgsFIlZRh?= =?us-ascii?Q?1UHNgCF1d/VT0ALquPEpo5PfUvR6lI8ggZjapzLIAvCdzOLKYDS6XOy0d1ow?= =?us-ascii?Q?l1bx7yRKLs4gixCcB5TFYyMPkDokuByGBSNDH72v9oXULyiRh2ACaSXx2Zjd?= =?us-ascii?Q?pIiCUHohF5/RPvtoA6p6jkwQDMcfBfOStj5C2DqcOvI7ccbGbS2WXyVFKpQ2?= =?us-ascii?Q?JG/PXa+aXPI2jESzwnN9eqQEtlRU8zBCLQzFuiZmr1DKmXZHCXxcBlhlpnkk?= =?us-ascii?Q?GZW+MfEOZ+6NdBZKwuO4hDHd1eF4PourDStFXYv0FZccRj9n6mGrXqDwhz/S?= =?us-ascii?Q?Y8pzYZPISJivE5a8IOi8foe+KSfUCeuTveBWYzRUKr7/N4K4mcSR0mYPkXLX?= =?us-ascii?Q?jTwEg6kbFdKQCEmtwROoqmRR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aaa0a7df-fd0a-41b2-fb9f-08d8e2d529ab X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2021 08:27:22.6987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 04hnE1lVU61U3tKHd4mz467MpJCKbM9jCEz+JEvDMkpt+Wu+ut0prK+GCmN/rsBm790Q7ysruRocSKhFFpM/3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5160 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Jiewen See comments inline. > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, March 9, 2021 2:44 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek > ; Reiland, Doug > Subject: RE: [PATCH V3 2/3] OvmfPkg: Add PCDs for TdxLib >=20 > Hi > May I understand why we need this : PcdUseTdxAcceptPage ? > I think accepting page is always required. This PCD is for test purpose in early development. It doesn't make sense any more. It will be removed in next version. >=20 > For PcdUseTdxEmulation, This is only for pre-production. > For real production, I don't think we need this one, right? This PCD is for test in SDV environment which emulate the Tdcall by calling vmcall. It will be removed in next version. =20 >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Tuesday, March 9, 2021 2:13 PM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Justen, Jordan L > > ; Laszlo Ersek ; Yao, > > Jiewen ; Reiland, Doug > > Subject: [PATCH V3 2/3] OvmfPkg: Add PCDs for TdxLib > > > > TdxLib for OvmfPkg depends on the below PCDs > > - PcdUseTdxAcceptPage > > Indicate whether TdCall(AcceptPage) is used. > > - PcdUseTdxEmulation > > Indicate whether TdxEmulation is used. > > > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Jiewen Yao > > > > Signed-off-by: Min Xu > > Signed-off-by: Doug Reiland > > --- > > OvmfPkg/OvmfPkg.dec | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec index > > 4348bb45c64a..68b3fd86d516 100644 > > --- a/OvmfPkg/OvmfPkg.dec > > +++ b/OvmfPkg/OvmfPkg.dec > > @@ -317,6 +317,12 @@ > > > gUefiOvmfPkgTokenSpaceGuid.PcdSevLaunchSecretBase|0x0|UINT32|0x42 > > > gUefiOvmfPkgTokenSpaceGuid.PcdSevLaunchSecretSize|0x0|UINT32|0x43 > > > > + ## Indicate whether TdCall(AcceptPage) is used. > > + > gUefiOvmfPkgTokenSpaceGuid.PcdUseTdxAcceptPage|TRUE|BOOLEAN|0x44 > > + ## Indicate whether TdxEmulation is used. > > + gUefiOvmfPkgTokenSpaceGuid.PcdUseTdxEmulation|0x1|UINT32|0x45 > > + > > + > > [PcdsDynamic, PcdsDynamicEx] > > gUefiOvmfPkgTokenSpaceGuid.PcdEmuVariableEvent|0|UINT64|2 > > > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable|FALSE|BOOLE > AN > > |0x10 > > -- > > 2.29.2.windows.2