From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.36667.1629189829369245513 for ; Tue, 17 Aug 2021 01:43:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=iPzwFeR7; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="277050754" X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="277050754" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 01:43:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="680208126" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga005.fm.intel.com with ESMTP; 17 Aug 2021 01:43:48 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 17 Aug 2021 01:43:47 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 17 Aug 2021 01:43:47 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 17 Aug 2021 01:43:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kPXz6KnoShNoQsAniXCM7QKfAG4yXF0ndkt/xMVVTKGrwTfjB/bNkhiptZYTj7AT5MRIfLC6X6F7TdreZT4WnRObyMmCVvQI8KwbHGyHxiSC/9j37P30ZYKwFykoSbjHzkj0L2WtXG2rkxQXDP3n8qQyUmtckwp27bv17eFz0a1c+QtTjkoXgDxCcfuAdtGN6bJce5h9TB0PxfTASdMDhFrnZopG057hHNpLinXJ6/5kB2xgW/KH/+Cy75yOeVBeaASQ1DvIT0vPgNah0jyCNBMJ8bmiGaeunMU7hvlX+7VhMnzI5W0Y2KnkQmX/RcWnBOG+jIZgpvsvVsRT0UQgzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FeI0W+M6f2lF7kj4am3/4uZxR6r0YAcoPs7LNBIIckM=; b=jVYnU8s1GdJWWt2iXKR97Cil+diXXnazOCfmjnLG5BqgXqQ47wO2UHV9NbnhiurWpOPh/EUaNT6y3a7vH8KQ5/gdenX1yX5VoRX/OSxYMn4sVwweya8b3bzaaLb19/wP7MLd4PRZqqLH3h5rcCOBbENCkv2CqASJnI4dD6d1j7TL6OBBk9tKPwMYBAgXhno/PCTp65P9HQr7JJbE62vS5kyDbCgohQzRQfggILdd0y0tLn+LQ3VtqcasCTCsEC43tBDOBky8o4UnHJPFtiOa3vQ0A1OkGqcO1sIxBY2YLCIj/TGEvuk1NIwy/EeiOK0kcbFK2yuLNMUTgo3RGIqueQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FeI0W+M6f2lF7kj4am3/4uZxR6r0YAcoPs7LNBIIckM=; b=iPzwFeR7ZqkUfz6nQV4sxVkz+RNsFJB37eCdam39J1Saiyi46rh65+OEQnOP8ajca4PmTFcSq6As2I3WO/JOcCtOBdt5Fh6aUbFLnZlQIMVZNO30ECFHz7TM8f7NTCk3w+R7AXLGGzRe7vLhRq2FkI3eRQu87tH/nHQnF2y3CI8= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4839.namprd11.prod.outlook.com (2603:10b6:510:42::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Tue, 17 Aug 2021 08:43:45 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b%3]) with mapi id 15.20.4415.023; Tue, 17 Aug 2021 08:43:45 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx Thread-Topic: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx Thread-Index: AQHXj3FCIAbAU4r56UqJemw0Tww+IKt151KAgADs5yCAAI5fAIAABL5w Date: Tue, 17 Aug 2021 08:43:45 +0000 Message-ID: References: <20210816094301.2h3e4d747ig6eyrm@sirius.home.kraxel.org> <20210817082030.gu5ae7sjjdyyawi5@sirius.home.kraxel.org> In-Reply-To: <20210817082030.gu5ae7sjjdyyawi5@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e2858f2e-a69d-416e-9d08-08d9615b2025 x-ms-traffictypediagnostic: PH0PR11MB4839: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GUPXNZA1UVW9jlLmpEKVjQazS+ClbljFDP3//RlFu0mqRem7Hzg2phQyksA4KjzeqqqgvZpF3nvDA/kC7O0tCG9MFCjNzAY6sGldFzhjZuJ7E+IbNaonu/bh+ANfH5RLQ8e0DUcgHxtm3Mm3ahQ1LhhMngS6T0qw/IXRB3wJBK0VrdcbYTY9LzlPpRHXsXI1RX42vvh5qYzaehLjvl6rDn1isozs99YWU0ox2PIp+lYIS4fwzuXugBoqsF05dghm+Imj6fIEUWIqR1pV6SdTvszUPwsSq/3MYqqZgUT4w35KQ80wIDZX3P7GkSqBer6Ji6Bx8hp8ReXTgkECMM22fn1laXZIzbtnapBoXpAbESi5OAAJsh1N1nBkvP3YTlk4Fjine+387UoBfqJrBdZsF1tDRCDdOsg0ELKGxMwcFi9qkiybTcc8N9g3wje9qgOI7NagDZ0Rbal6kW0Lvdm7JSgCW7Hw33CNzDl+W0c6uQMy7dfReYTqwc0SbgLQEYay1AN4y740hhVXm/tGybGyI1S74kdPW05JPF6LQkY5cvmhwlQasffkQZmoleW/RlrGsG1bru0NJLWv2b0+gjB8byKbfskZJzmxBV/ypmPW1V1ktoJISxBxGpXAjwByPqb4M7dXHp84rWk1gcfNkdPIUntEnZBkm8ZM0AFI7YVrJw7l7ortzqT3k8mhFONRPArS6X5etLTmVsMf/5uVat/7JtcrcCXO6AZz7X88fbg15k1IdU/ty7RpIQUvon8Y3LGIbDk+ZGfZPHJF1rIDM4v7qW1zCD5VXO9kSsVyOyQIlWXc7P2EJn9auHAsT6ML+zf9HKZkDshUzIUF0C2dUdGtNg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(136003)(376002)(39860400002)(2906002)(8676002)(19627235002)(8936002)(478600001)(4326008)(7696005)(966005)(316002)(110136005)(54906003)(38070700005)(5660300002)(53546011)(6506007)(52536014)(66946007)(55016002)(66446008)(64756008)(66556008)(66476007)(76116006)(71200400001)(9686003)(83380400001)(38100700002)(122000001)(33656002)(26005)(186003)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MiV0ww4tBU4XAIIQkWh19cKrB9hRkljTn4aCAuqpK9HI0+BhBavEOi56mF3l?= =?us-ascii?Q?HrL+Z53fO45Me5vldAWnnnfb0y3RnNEo5iW95YWO0cBYVjKc64svs56a8HWS?= =?us-ascii?Q?CoReOzeuyA7icT43f8FRs3XzQrnMu4umCDidHL/ImE3Z8PvEjC5gycmduZ3P?= =?us-ascii?Q?68/H9k8l3Ih2dZtgnxr0wJlOPzS4D5UfbBViwcChOdHd9Dn43s7uLG+OJlK8?= =?us-ascii?Q?OkLy4OBQWUTZte7/MKfVsqXQuM3NkGDpahC1PsFTFi54jRRpESxkeA7xqwTJ?= =?us-ascii?Q?f6mSaqXvXJpMshTEa3kKUctf1QOHXKyrBPZQQNyW++0EaeWxTjqjt4aJfkej?= =?us-ascii?Q?bW9wbdnyT6DCbGv53BNU1ZS1QsXefgVJGlV7LhkQzKP6cKv3YAftYNGdP14b?= =?us-ascii?Q?qMttOhJYZRGDXZ3iktsGWm4sP5akcd9XVKNvevYv1P7EMeG2z2z1Gt21PrAC?= =?us-ascii?Q?PhFBMXgtuJJygGkUGAl847DpF/lF6JuE4klxKDYio9D8wJZLVdOVJO9OYkXO?= =?us-ascii?Q?glW20k9ncXErGZs/c5MFXtfakFjbn9kfr55g3XFTh7NWvVJJo0qDtJ5OlEgE?= =?us-ascii?Q?syJT0gTZJbWNJ160OR/O6HktXhrFre0HKGiFtTMpdQmXjV5momvCWFh/8RlD?= =?us-ascii?Q?LHog1cp0ddO8Ndh8jxYXwzJrlI4fIthKsfiC8oXRdWhTil7XHnXsJs2ddXIF?= =?us-ascii?Q?LwHq0cN35iJwZPCexsifj0uJ4CQbj5d8nxh2D1Dt8M4cDqha0e9HlQZ0cVBe?= =?us-ascii?Q?P6Bdce1f8JLwaPdmSQIRbXvXLVFMwT6RT5Mw8QstLT2Z4Yki+gYG0pzzsJ4x?= =?us-ascii?Q?qmeAPlwj+MTlHoECt9gG9XrI0U+oApbpUt1h3YnLlA38/3j0FKSXKrRikXGe?= =?us-ascii?Q?O8Zu5ajL8cjbIn6PTnjDThk+7BlsudqpfXv3QVz65ZBzNKgRELNF5Vw7z6Oo?= =?us-ascii?Q?rdCxlR3IAhwTMeRRxB4MzXqe+TArzGt5T9CqVYsLF1pdzyWRkp704/IrXt+u?= =?us-ascii?Q?YumdMZR6a12p9bnqO7b78dyKrZtzozsiK47I4y9GMWE9+gKCcWMdK4oyok19?= =?us-ascii?Q?ndOI5DL21Jle4rhufwWa3s3HT1f+6aw7LAYDKJsRaDxjBm6+VHCDw9VsDfK+?= =?us-ascii?Q?J5gIoB+An6fa5uMCs4wcJuGoCLB9uimCji0VI4rQ2rEJ/qJ0rABfeba50ts3?= =?us-ascii?Q?TUT1P6x0vjPMdKpLXy8/JuAc7EB+MwFZxkZfqsMn8CgaRTA6HSCgGWozrNL5?= =?us-ascii?Q?sP6M7VtmSbXaQhD1W1QzNmo3LK2n3eMjhY0IRAq3qpchXtE5BXIO7kwayxSE?= =?us-ascii?Q?/osbiARTqHsPdwt1P2mYxDMX?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2858f2e-a69d-416e-9d08-08d9615b2025 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 08:43:45.8163 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F2Sy7QQ+Xwd+kKki1encLAjg8y2yV12Km1Kxlik5LB7B4UcnPmsMoOClpVhDF/VZj33R7sUZb1zXpyAR+pD3Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4839 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On August 17, 2021 4:21 PM, Gerd Hoffmann wrote: > On Tue, Aug 17, 2021 at 12:14:44AM +0000, Min Xu wrote: > > On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote: > > > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm > > > > > > Any specific reason why you code up your own instead of using the > > > existing cpuid functions in BaseLib ? > > Actually there is no specific reason. I am not sure if AsmCpuid is a > > preferred way in this situation? >=20 > I'm pretty sure it is preferred over duplicating code. Thanks for reminder. I will use AsmCpuid in my next version. >=20 > Early setup code (before stack setup where you can't do calls) is a diffe= rent story. >=20 > Also: Why there are separate TdxProbeLib + TdxLib libs? This is because TdxLib wrap the operations of TdCall and TdVmcall. While Td= xProbeLib is a library to probe (call CPUID(0x21)) if it is td guest or not. I am ope= n to merge these 2 libs into one if the community think it is a right way. >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20