From: "Min Xu" <min.m.xu@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
Brijesh Singh <brijesh.singh@amd.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH 0/4] Introduce TdProbe in MdePkg
Date: Wed, 13 Apr 2022 13:27:49 +0000 [thread overview]
Message-ID: <PH0PR11MB5064D774C9500D2CE47F3EFCC5EC9@PH0PR11MB5064.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB5872CF45DBAE44E71B8E60C08CEC9@MW4PR11MB5872.namprd11.prod.outlook.com>
On April 13, 2022 9:12 PM, Yao Jiewen wrote:
>
> Thank you very much, James and Min, for the quick response.
>
> I have one small concern on the naming - TdProbeLib.
> Would it be better if we create a generic CcProbeLib, and just return the
> CC_GUEST_TYPE?
> The benefit is that just in case SEV has some usage in the future, we don’t
> need create SevProbeLib.
>
Thanks for the suggestion. It will be renamed to CcProbeLib in the next version.
>
> BTW: I also propose to change name BaseIoLibIntrinsicSev.inf to
> BaseIoLibIntrinsicCc.inf.
> It is very confusing to me, that a Sev.inf include a TdProbeLib. :-( That can be
> done in a separate patch.
Agree. I will create a separate patch-set to rename the lib.
>
Thanks
Min
prev parent reply other threads:[~2022-04-13 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:08 [PATCH 0/4] Introduce TdProbe in MdePkg Min Xu
2022-04-13 9:08 ` [PATCH 1/4] MdePkg: Add TdProbeLib Min Xu
2022-04-13 9:08 ` [PATCH 2/4] OvmfPkg/IntelTdx: " Min Xu
2022-04-13 9:08 ` [PATCH 3/4] MdePkg: Probe Td guest in BaseIoLibIntrinsicSev Min Xu
2022-04-13 9:08 ` [PATCH 4/4] OvmfPkg: Add TdProbeLib in *.dsc Min Xu
2022-04-13 12:55 ` [PATCH 0/4] Introduce TdProbe in MdePkg James Bottomley
2022-04-13 13:12 ` [edk2-devel] " Yao, Jiewen
2022-04-13 13:27 ` Min Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5064D774C9500D2CE47F3EFCC5EC9@PH0PR11MB5064.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox