Re: [PATCH V2 1/8] OvmfPkg: Move TdxValidateCfv from PeilessStartupLib to PlatformInitLib

["Min Xu" <min.m.xu@intel.com>]

On June 27, 2022 3:02 PM, Gerd Hoffmann wrote:
> On Sun, Jun 26, 2022 at 11:05:50AM +0800, Min Xu wrote:
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > TdxValidateCfv validates the integrity of Configuration FV (CFV). It
> > was implemented in PeilessStartupLib which is included in IntelTdxX64.
> 
> > --- a/OvmfPkg/Library/PlatformInitLib/IntelTdx.c
> > +++ b/OvmfPkg/Library/PlatformInitLib/IntelTdx.c
> 
> > +/**
> > +  Check the integrity of CFV data.
> > +
> > +  @param[in] TdxCfvBase - A pointer to CFV header  @param[in]
> > + TdxCfvSize - CFV data size
> > +
> > +  @retval  TRUE   - The CFV data is valid.
> > +  @retval  FALSE  - The CFV data is invalid.
> > +
> > +**/
> > +BOOLEAN
> > +EFIAPI
> > +TdxValidateCfv (
> > +  IN UINT8   *TdxCfvBase,
> > +  IN UINT32  TdxCfvSize
> > +  )
> 
> Hmm, is there anything tdx-specific in this function?
> Looks like generic verification of varstore structure to me.
> 
There is no tdx-specific in this function. I will rename it to something more generic.

Thanks
Min