From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.38925.1656317057033261310 for ; Mon, 27 Jun 2022 01:04:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Q6xGsKYh; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656317057; x=1687853057; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ihVzDiADYQxOaqbb5lnya9ilZCrKiuaeUdU/QIWD80c=; b=Q6xGsKYhR+1fF5pjP3RwMxOHm565OvQkWp8secKlbOGn5j2v5kMe3IVE ZOVZTdZ+CObfNt62kAz6CUgNwI44kS96bFIKxp/uy4Ud+S9W1ZNQ+mT7B KSjKCBPEk0fpwUASgWG2NN52W1kUrLG2/YgQgabDkomVG35ovdJK32QHq NDLFfjdQs4FTPibNjUJUagQ8D2eBQEhlfVkPpkO5j1cVw5AGO90l08cCo Cdxvbl9dJm2jT6BTcb3P8N3ty0F3HWSUJBUOteIFHRXbmO3wQgmMtHYS7 W2QulhEf0uBnhANhcNipISAEnROMEkEuH4EiPmMwmrkHVXd85rl82GVNN g==; X-IronPort-AV: E=McAfee;i="6400,9594,10390"; a="261197398" X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="261197398" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 01:04:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="716959581" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 27 Jun 2022 01:04:10 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 27 Jun 2022 01:04:10 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 27 Jun 2022 01:04:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 27 Jun 2022 01:04:09 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 27 Jun 2022 01:04:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=izeAlMNfZoeW67jgq5SmOxbTO9TamMqStX/SDOTlVulOJpkZiisQO4GQ5scaHlFSlG5HcVqemrbOAFaO8stUrfF185IcU3bALaLBg9pfXnIjzkSnubBe6JB0zRfwPnDyDT/d8nm6uyYhQCCsWGrBK/vNnjnn3uJWdCAC6PVfX1T5mZX70p/TPIwlvl3Q/pxtPC6mfUCewALK/X5ovZC6CNFP+oyMigoRw9MFLeZhYsWW17g0z92SEg5K8NHtQYuXBDsA+Ojmlsbvi7twetqisgsnINwC0pFZ4H78DuKw+Mg33sd4sWNfkl17ce0bF5iFaDpgdzmk5f+25qnFkYYA9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R0o4Yds7+mS1gOTigvXOcq6h1PsmuxWvmCaGzUcL8WM=; b=DB1NBfEollazgL9eQpwrlFd2HIxaTgL5jboD8AFJYIjDf+9XiHYnceyz11i17qsiTmU1UpzxjH5Dm4hTTH6TE98os/XXNlgAH03gN99btLuap76vlaQwZ7YxGNA5BS+rtAT/5LeV7sPjnOkFOLq9nvSEMSs08aalf/gyoVFPeUyAVa4juum4QvlAxenWtzSUkoH6pZHoAtxX+szFCvJeVe3dFwAL06e1v1vHciFi/jYZSt6hxmvG2ZrE17H+/CYAqIPgo6ZGzPKMZEDZbrqlSEHJo7AixOUjm5wWi9mFvNRcG4kHZBnaM5gtSG+6yvvGN2lTzIo5RFtFueMrPq/fwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by MN2PR11MB4109.namprd11.prod.outlook.com (2603:10b6:208:155::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Mon, 27 Jun 2022 08:04:07 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::a0ea:2e53:9c0e:9148]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::a0ea:2e53:9c0e:9148%5]) with mapi id 15.20.5373.018; Mon, 27 Jun 2022 08:04:06 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V2 1/8] OvmfPkg: Move TdxValidateCfv from PeilessStartupLib to PlatformInitLib Thread-Topic: [PATCH V2 1/8] OvmfPkg: Move TdxValidateCfv from PeilessStartupLib to PlatformInitLib Thread-Index: AQHYiQm5pKgJE3RBO06HCGg877PkXK1i1ZcAgAAQbMA= Date: Mon, 27 Jun 2022 08:04:06 +0000 Message-ID: References: <20220627070216.z65kzpjzy5tvybsu@sirius.home.kraxel.org> In-Reply-To: <20220627070216.z65kzpjzy5tvybsu@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f603849-4a3b-4d00-a0bf-08da58139bdd x-ms-traffictypediagnostic: MN2PR11MB4109:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hd3D3XTpTrhA7WRfd0ACgUdQvJMgx6K+nNFVLq8+bGgsqC5kPJggIEKrZX1CVqfAhuCjiks1cBYPdWthUqAN7/Hfp7oqspdOKkx8VomTxefOxd75aBkOOrHbpsTTgIQTsAIkMyn7WHWApuUj/oWIAYqFHryv//moMVF7/5f5TG7k2R0q08nooEtNUY2oaVaBJ7SgqpYMpArODxv/sjM/5Y9l3lDVdhTRTCpOF9LJ1c+mW1akODJ/VbDKRM9EqVO9w1i10RsaVfwF7taGC+A9WfvHHgkgFuCUOCwbzjs5Wu7v3OzkI/18VUXzzuBonh/W4TloZj1UNRBkaHT+dW9W80sayHW+b8YhsYf3C1Xc+RgEfYXJrv4ypadwP7+qHI9pzjIi4e0kYtGrnkkaT0vH9fTfUEjgramq5IAR9NPN/Zg+RzrliAgAaih/neKyDsczLe96Zh7PDCl4X9thFMkJAjEuRi848AAnciNe56r99c8sVUD8dbz4AGkaohpxrIyP3RhQl8pXkMKfot5jWmFsnGqoPcTDoofK2Fi68tVU4/Vg29y3eZA6NJO8qIXDBi2JZ+ZB3YlKp6+7uxmeqNELWdjtVFCTQZrjInGydtWXX6aL/Yvd+Yo4yNWf3LGGejh2C+lY1GIsjMIqtuL6pO+d00CtHw9pzb2vg6Ejagary4RhSjtylgkjjxh5xuvAlPKUsuBTXZf1vmEdcnENSiJDRYoWCdMTTqton4LOQ8+IyBPUyTMqDlJcBw8Er6jVFLx9yh/nLDHxNV4QZ9xQvaTuJLNYZtLeCv7zbQHNkau8iY2PGcD4fxZHmsUz1j2WhnGX02uiFuxHIJn3Iw3Qb1UD2w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(39860400002)(376002)(366004)(346002)(6916009)(82960400001)(38070700005)(83380400001)(122000001)(54906003)(9686003)(8676002)(41300700001)(66476007)(64756008)(76116006)(66946007)(66556008)(4326008)(26005)(2906002)(316002)(66446008)(86362001)(186003)(71200400001)(8936002)(478600001)(5660300002)(6506007)(7696005)(55016003)(52536014)(33656002)(4744005)(38100700002)(49343001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yra7Pa/g5DG4i8veAOhnBJ324XWqR52MTSNILeUydmU6tEILPEP2RplB2dot?= =?us-ascii?Q?dvkTGVYG6AJj/cskLiGGdBSn2pumvZ0A0LfwDoectDe962oLgxZ2JMmE76eX?= =?us-ascii?Q?rq3dAPvZyj6vrU6SI5FcaiIxnwN9QCBRJGULsKUParw3vdhzefbzbd25HIC1?= =?us-ascii?Q?VVTW+yL1cASq5IT6XFANliQZL7xLlNKGjmXnOXxKYKToA/Z6UteVbMbt9IrF?= =?us-ascii?Q?5LHjWcC1gATJsThS2fxcq9xX4+JRniR3rX5qRGSLV4MjqO/c/Np1aeiujvUv?= =?us-ascii?Q?wMOyi4u/BRPAu5q/ichG5Fc4rdqQBZ2ctqT+9nFtT3yLgllilgN3TkUsGQIk?= =?us-ascii?Q?cFySTQ0ym5asFM5CHpNL+zQfG1zPhSuUT3kNqkUHGyAbjEC3/nERatP9IzN9?= =?us-ascii?Q?sJ9qtRjmjgdmbIsBzysH803ZJGzGenAlNoz89kIzaMaVpE7INo4rpXP3EWkY?= =?us-ascii?Q?g3n6wQehC3m/Fauc08vJEPVBcO/lJ8bR7qOGuePN2jea3AQpP0eEDp57lKzx?= =?us-ascii?Q?KivLzVEG0O/KBVXlh8XF4i8XIDbbwcBN5XHJRWt3n4Oyp8IaqnE/R53nRbWj?= =?us-ascii?Q?tAGitMQNWU7jOj0ZSJ3SiISFTnwmScq5XU3ksKFGnik46NBv6Z2CbSAKaDJH?= =?us-ascii?Q?W3StDdvsXcfnMisX5ZRwInjPIhI78IXWpqT/aYEFcfyqlJLjS+/5vGONFLvr?= =?us-ascii?Q?YPQioxDo0Xce1Oiz12p+sTUrtVl6E/JtNMHTk7JLtn2b2jyiB/mNIMyoqk/M?= =?us-ascii?Q?Tnp3AQgGQ3j20BTVca4xJGdMcIvg5c7VzG0GfRGcDKfJqDjYvpoLYDU1EPln?= =?us-ascii?Q?sOWRILVyTZjcRuEPU024gdwf1aPuk03GIz2NddPa0LqjUwyEEWnX5iFeAEgR?= =?us-ascii?Q?THze1BBHiFvDiOmQaMKpn2K7+IRUFNXfxFkLx6lPOetOfzU3yqGJ5mUygV3m?= =?us-ascii?Q?yO6K/Me6WaOcNkmSHzZjcTiefaqF4WxwPC1HPbdzHqm5/mqHaMqLgs0EonUz?= =?us-ascii?Q?NWwvERETV2lpmyxtjGlAEbZh70neVuU7O+YJ/3fB1VCB6vHKbINZUG6NgdmN?= =?us-ascii?Q?f0SBGeDh/Lfp0vqFMYrPIfq1evmJarMrhuQQ0/MEXre5GM37x9aC3aXVMbCk?= =?us-ascii?Q?MsXEw/7xklJ+Ah91WaxhrF/ojDI81Hec5mqtkd34REWfGJNbNHalNGrh0Uw2?= =?us-ascii?Q?yN5Bi2hViTp5vN7iUPV03e6TzoyBbcWvNeDgTsoScf/jcEW7YGtFON6Gf8Hk?= =?us-ascii?Q?i3JaUxw4NLkOgONKhDVRqzIKo1frYbtdUhPLnDfEZEAaBxmskRj2Xi742EAo?= =?us-ascii?Q?fpMKGET0dJ2Kpy5HsPjYrRMdK6LW/Iifz4eaEivCwoN+vKDrRPjblu7ZQ2Cw?= =?us-ascii?Q?RIr4cZ2G4HaM4+jTF/v4FRhapQ1WOZxXUA4FW7qiT8iZ9l+CW2IN2QTOsFGK?= =?us-ascii?Q?X71W2eglwd2rNriRdFNujoeVJluYPL+65Tck55Gs1c2/hoGibyjzu4xZG/xA?= =?us-ascii?Q?V4XXd7AD+gobRnXYK7c/XLrDITOg8eUSNKP0rkUotDCeiHZx6nXNgcTB+IEe?= =?us-ascii?Q?LUxCQSoN1oniBjP/qgHjEbW0EmBEV9S/v7I7xpzQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f603849-4a3b-4d00-a0bf-08da58139bdd X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2022 08:04:06.8805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G9BF0BF+aHw0VA67ldnjeR+CEzVEqLSMVQXSm33eEbkiwV45H8FRW9hG/eZed+MhmO0sQO2MiOA2qPZGiLYTSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4109 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On June 27, 2022 3:02 PM, Gerd Hoffmann wrote: > On Sun, Jun 26, 2022 at 11:05:50AM +0800, Min Xu wrote: > > From: Min M Xu > > > > TdxValidateCfv validates the integrity of Configuration FV (CFV). It > > was implemented in PeilessStartupLib which is included in IntelTdxX64. >=20 > > --- a/OvmfPkg/Library/PlatformInitLib/IntelTdx.c > > +++ b/OvmfPkg/Library/PlatformInitLib/IntelTdx.c >=20 > > +/** > > + Check the integrity of CFV data. > > + > > + @param[in] TdxCfvBase - A pointer to CFV header @param[in] > > + TdxCfvSize - CFV data size > > + > > + @retval TRUE - The CFV data is valid. > > + @retval FALSE - The CFV data is invalid. > > + > > +**/ > > +BOOLEAN > > +EFIAPI > > +TdxValidateCfv ( > > + IN UINT8 *TdxCfvBase, > > + IN UINT32 TdxCfvSize > > + ) >=20 > Hmm, is there anything tdx-specific in this function? > Looks like generic verification of varstore structure to me. >=20 There is no tdx-specific in this function. I will rename it to something mo= re generic. Thanks Min