From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.5821.1634193094612266401 for ; Wed, 13 Oct 2021 23:31:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=zJqkHcDK; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="208408674" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="208408674" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 23:31:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="548400629" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 13 Oct 2021 23:31:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 23:31:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 23:31:33 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 23:31:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7dnnr1FGcj6apTkQnBAUdMtrar1MX+a8ElhqoTcD+inL1GIt2AW2Gm3hos+MW180SwFwpnVbqeCy3Zxa4F+GzuknEP6vARajpPwzqDcli9JXeXWgfM2WL5bce+0tcBlIP0OfkPytl7l4hFh5pcTEW+mMZbS0CDVT2CcpMTg4CjGU+gDT5OX1fgYI8NEtC/pFaVEXKB+QOTq6+rTN2IWKpZ8jma4PeWfKZZiIfrwzqmJB5MtVqvqgkkcS3vIBB4csEq3RhT+0sISHYbgHfv2kT6zgkAUmoqtKjFnCNjAcGlwKIEDhxDbJU21EmUkm9W6ayQNqSYd0ls5EAPIJseXZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IVYc7anEtPJCMCNzU2cFgU+AwzHv+lPrpELBgXjgfWA=; b=cZGy5gvVh/kwCgLO1hjkJkDPKxwuA1ozouF38b5l8EX0F3WAo8VYhZKeExWH5w+gJu15cAIR+ZGykgX0PnHzWfn8jZDyLZ/mCgREgD0bj+r1v5hIv6DbSQSsfbQnv12/Fd0GCFDieE//fzGvc+nGJHWgxRBZMCcY6y2JSP+3tk0M75Eo+T3lyaY3852kmqn8r7IcN3XnnVILAEyhyptjD7X7rGiMWED1zdpsukCcuhKZc4Iesag/X0WJA4Z0xppEq84KB2Ha7i8b6kSPaYc4nr/ActtfChAKtndLyEgtpeYYQGEQ6ykehocZBLEF7zPhdKIDVYR9xUShjdpCKRZeKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IVYc7anEtPJCMCNzU2cFgU+AwzHv+lPrpELBgXjgfWA=; b=zJqkHcDKSXtmNpOT1gAFw2YqFiiq0bJaIshlROTj5bp2EppZnUtYOFJviWW0cOTmIAHxmSlXkkvIpdmXmLqtuDiHhSRa7/FBJDK78tdHXXOI8Db/fUE7xb+XyZGpQz+vlw9xIbTRdleep6JvtvEXet5LKvwxDqclPutOSHjICvE= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB5109.namprd11.prod.outlook.com (2603:10b6:510:3e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Thu, 14 Oct 2021 06:31:31 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::7deb:6c36:73c2:f0d4%3]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 06:31:31 +0000 From: "Min Xu" To: "kraxel@redhat.com" CC: "devel@edk2.groups.io" , Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Topic: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Index: AQHXuZrKdJhnG8YQVE644DznAbIZs6vPNXiAgAJ6BFCAAGALAIAABlxQ Date: Thu, 14 Oct 2021 06:31:30 +0000 Message-ID: References: <80403cd301cc6f0e88bc1c10e11ec262c1093cbf.1633401643.git.min.m.xu@intel.com> <20211012103139.4xkxi6p6jlkjo2wo@sirius.home.kraxel.org> <20211014060438.yugrowggdtyohlkz@sirius.home.kraxel.org> In-Reply-To: <20211014060438.yugrowggdtyohlkz@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72585d33-3fa9-4529-bdb2-08d98edc4291 x-ms-traffictypediagnostic: PH0PR11MB5109: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IK4TSSTT8N3T7bW850Q3GbnKjIMiUuwCbugb360+Vyttn2gMrLs6FcM61vOXMs2zjPXR+NlvKcsS+jb24rDuOXhe1OTJ+jD41eCquwnwDt2iJiODUWN+O80nzV/5gpZYkJodssyTRBKtdY/al1w6w/J3bovmqlNhvl4UZqzHJbPVOo4yOuLg0DYQuf7j7a3fNDM9ybhleczq67DSE7ieerWU8L/hpt6vEmwk1RAi/cE9sxMzJN/Hq2k0vP27r9vPANM/YKwL9G/1LdBDCnV34xnVX+O5WIjMxyMT24Pe4HoBwequqBS7Ht/71kmkOqYP9nnkV/tRlG8d/mju85KbruPLkUcZaQanncOph2EC/IqMRWGMwUMx1+gbz9j016dgeC3pSDsKVzWCclAvP+AfLO8buby82tMMcCZRmDbc4ZvckSyk5z2AerDC5q7WRt8n3X2hqsTelgntNJISJzU1kiEIGozF2XkW1oD0nfSTNHkdiktEOW+wvCq09bDwUiEwOzEgUdaGN+CS3PlxhH+RvhzBStyvFjQWqRJNFAPkv9L1eHYvY/33E3WipdipauMwG6YcOjMxqBC517VVWUFgKzQ4umm8pG0pPU2qXRtiuwSeI5GJDhYE0IyYmgR/70ZLeNRakhrTRiFjO4s+TTG/UEe1iBz9id6Iqxo8R29ioPvmNaDRmLAA/mzPINncHOWP7A5GXUj2bLSWOGyFtx8kmQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(66476007)(64756008)(66556008)(33656002)(82960400001)(186003)(8676002)(76116006)(9686003)(66446008)(107886003)(4326008)(86362001)(508600001)(316002)(8936002)(83380400001)(38070700005)(4744005)(6916009)(122000001)(38100700002)(52536014)(6506007)(5660300002)(66946007)(7696005)(55016002)(26005)(54906003)(2906002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5mYoh2lotWm64X1IzUDbrfyRnuLPzAHiueHPmuQI8ovjwKdnnYY5rrRoaN3z?= =?us-ascii?Q?EIkwsmT+SM7FyhmTR9vyRbbsGFEhdkJNCZVurHoRsQkXX0KRqHpXSaO2Ud2t?= =?us-ascii?Q?h810G4+MKGNavW5G4T2ZizZY47/CyTAwuW5Se0jTBZS2pXiatnAoM597bfXB?= =?us-ascii?Q?n2m5v+66s6NaJbrbDdEXfJ+N2s7UQNWqK8ePIAGhPnT0mAOi+PuNqGQQb41O?= =?us-ascii?Q?BczMh0VpO4DrR33zNPEEf2m67sxLYpea1b/m/FJl5PNoVkXwuSOSydvrY3Ih?= =?us-ascii?Q?dkny4J9Ia/8BKsmPeLIMt/QqjAr/kDmEnHKFwiaC8aZQ2ku7tfTdsnE4Ww/e?= =?us-ascii?Q?MUR35HTy1weeH3Qftu7TJCziqvpO+SF4r4z1yHXI1PUTr3ENeLFbFl7wjlJS?= =?us-ascii?Q?Cmohal1Ud1cFzdlcrV6Y/10xEmYW5agUUjoTtnDYEAg7KZGsuXJEuQwzKcie?= =?us-ascii?Q?qcMxmK+I04I+RHwhWx4eck3LaoEY7C8EUB+sLS1SmS+NODYBZSbzAM038MVe?= =?us-ascii?Q?UQopcHZVM5H87PZCczrLyLpHbE6y27Qfd1EOEM/K3EhGQ0VC6nPoP+/swAdP?= =?us-ascii?Q?84XCob8aVh6Z8LsPJxpLLgdQr7haemBy272nL/3HPFeyuTGb0oXrW4jbwNq6?= =?us-ascii?Q?c5C5LADpnm0gB7kRm4fb0qEyXlMZspeJYYoflgwDAQEIlVFF77zpds73qvtW?= =?us-ascii?Q?q5+vjvmHEc7oCh8g1h2sPsxOKjkPrNhXvhykZH8b9nRg3+odTU16Pf1OzJoi?= =?us-ascii?Q?fCr44qe6Cw3Lj0K63druyx+BtyrtXs2anBu6UXfou9RzI4vhW0qdHx5/lpv+?= =?us-ascii?Q?N6EyGrM1pqq+LNmLUS5ott+JQMtjEfA7DG6/BQEiWE8fLmZ7nN6gRWIxoDIX?= =?us-ascii?Q?JPb8qBAKjFokkQ8UVq4VRegEmt+f7fVR9Bd7cY3TK6pFXUe/Iu1RuabSkq0C?= =?us-ascii?Q?Vmol0mtkQL1C94nEgsjl9mjo/XEmQVnql9gkp4Wwap4iGhrs54mVhPDcIO7s?= =?us-ascii?Q?1UwJnsYdfS4+M/apulkcOIZfNWTZ7BfEqq8tHso6S+S+qKsVqzpJhcP7iZK5?= =?us-ascii?Q?AgJzCNVJYOUe2RUsBn4im5UB2dHJlQr/w3KDuw+yg6HaC3Py2qdY4HyiiMrX?= =?us-ascii?Q?o6z/s/4o47NKzFiV20bXswyIT1CGa/2iiakXVda46WmbIwbXSIMsQcRYlvcy?= =?us-ascii?Q?8eZfpyN4uWB4RwjMxiFhFQC9cbUS4E6guPYqESd86FoAdOvITVglnNfoqMpd?= =?us-ascii?Q?5aVRrnQRcDRSe8aBQO5egMKNNxPIY/LYqSSwrU/X0+47XJFKgDUfXTfm/fte?= =?us-ascii?Q?oDREL2VokdCxqJyUuaDy9h8K?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72585d33-3fa9-4529-bdb2-08d98edc4291 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 06:31:30.9188 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qPM5+OSgiseQUjskqzHCSJBuQ8xvtLhf73vIyahvkmJjp5z7DOM1sfM/DNgZ6TL1SXq9Vf7MnAcOllIIMYC9Kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5109 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On October 14, 2021 2:05 PM, Gerd Hoffmann wrote: > On Thu, Oct 14, 2021 at 12:27:13AM +0000, Xu, Min M wrote: > > On October 12, 2021 6:32 PM, Gerd Hoffman wrote: > > > Hi, > > > > > > > + do { > > > > + AsmCpuid (0, &LargestEax, &Ebx, &Ecx, &Edx); > > > > > > Again: this should use PCD. > > ConfidentialComputing PCD is set in PlatformPei. So any check of this P= CD > should be after PlatformPei. >=20 > Can we move that to the SEC phase? PCD cannot be set in SEC phase. >=20 > > MpInitLib will be included in CpuMpPei. So if PCD is checked in MpInitL= ib, > then we must assume CpuMpPei is called after PlatformPei. > > In current OVMF, CpuMpPei is called after PlatforPei. But I am not sure= if it is > always the case. Can we have such assumption? > > Based on above consideration, CPUID is used to probe if it is Tdx guest= . >=20 > Not sure. There are no explicit depex dependencies, so I suspect the > initialization order could change. >=20 > take care, > Gerd