From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.28627.1644803503887150515 for ; Sun, 13 Feb 2022 17:51:44 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZLxSxkIc; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644803503; x=1676339503; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tfZgcroj8BFtmEgGTyeoe5G/nKZdxsxw+Ma1vg1x2k8=; b=ZLxSxkIcU/cBmUMh+UNw+3Lq+ElQOguOcxepDqF+2BVWxM/WlnCA3YYs 2zSqXq3ClIZLEg7yMYJFtxsqKUR46EMOoiIsZRFBm5aN2UyZ1KrgaulUC iYkAYv6LM5LL0qttpkVFFUa6JUSqM6FA337vjLrnfsm8pfJ9GeVyCW+UM gsfVSA1RhX1yUsi7zAJdQ0ce+feIMJxzALGyuTis4empcR7p/aeFJnfmX HFtmBChkG4Y5VqGDjjIifErG8k1hMqWBkeuQqnMHtwUyptI7nACjIkbgI RuHXv5hu4qHl37v7f8jd+E/r5GwLhKBlw9sP+5MLIwsmOWzwO1Q3siEIV A==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="229953988" X-IronPort-AV: E=Sophos;i="5.88,366,1635231600"; d="scan'208";a="229953988" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2022 17:51:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,366,1635231600"; d="scan'208";a="634827805" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga004.jf.intel.com with ESMTP; 13 Feb 2022 17:51:42 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 13 Feb 2022 17:51:41 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 13 Feb 2022 17:51:41 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 13 Feb 2022 17:51:41 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 13 Feb 2022 17:51:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oR2h03uXA2tY3P0M5ERXjrYHbro36fpLtn2ADgi4yr8m00At1md+L6HQD9G2GeOx9v8CbJqujYwas5WoQOxsBZhQtUOr9Y1xb1x3exJXWCfgPPif+mc5XiWmKk5+5XC7dsz3YPa2Jrm+2jpj0aqWZlkOfu8sxf7OrijeKZ+rZA+9bKoG9NNPhvMJWcaa4QOn6WeGp1dCkA+TKq+t9lm44aAN+OOalcmRgsV6/9XeDSHMHBUOVwChTBSGGfRzw1B5U9kl9VS6CC9HXB/AAxN8ArBe/UG8f/9F9wg/gSx+MWtQ48fUkWCsOyIodaWHVMnq6+o5UhlWFpvupJTPLTtIZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfZgcroj8BFtmEgGTyeoe5G/nKZdxsxw+Ma1vg1x2k8=; b=hw3ZWZyyKtl1VPGQ0bWnYUfpKprOLg9MkKUELkLyfY98H3IkYyI8IdD7YWRNAsfvo+n3y8L6tWLVpcAFKYpAqC0Qo9txmHokQDxeJwPbeIGMSjY3waBqIxoxljY7exWrFMvIsoSfSxbws1BZ3K8NJXIIIl5kMfTiP4bharPADCz2IUWyMkIrlTO9lxh3ufmS7E9dV//kOErCza4Zsm4oe5dMrrYELn2o8a2R/f+ABj3xxNPy5qmF0rxpvwYM0b8f+zxobR6TJhohnnXZ7JkdEa2y9H+9qfocpFLi0NMbycWpGmGVlrl/4QqMfKlq68E5AhNLq2ykN3+Y0Yf6+L27iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by MW4PR11MB5912.namprd11.prod.outlook.com (2603:10b6:303:18a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Mon, 14 Feb 2022 01:51:34 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%8]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022 01:51:34 +0000 From: "Min Xu" To: Gerd Hoffmann , Brijesh Singh CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Justen, Jordan L" , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Ni, Ray" Subject: Re: [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase Thread-Topic: [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase Thread-Index: AQHYEbXP1tUlVM8tCEqVtzfQBYMa2ax23uwAgAE0dxCAACpygIAaJ1ig Date: Mon, 14 Feb 2022 01:51:33 +0000 Message-ID: References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-3-min.m.xu@intel.com> <20220127132412.oqizta4k7mbtclpb@sirius.home.kraxel.org> <20220128102009.5iwa7vhhpkcsym4b@sirius.home.kraxel.org> In-Reply-To: <20220128102009.5iwa7vhhpkcsym4b@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: caccd0cf-35a9-4858-b7e5-08d9ef5c879f x-ms-traffictypediagnostic: MW4PR11MB5912:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jgb4o9hyaZAh2yemV4/qISA2JyMEuSM8RLRXAbbmTKADFiW6HGH9quj7kPrObv+yqBsr8yhjIiIz0Ipr0G1clK2RkWP/xPBshnK/SpCrbeKbR01ZsCfEp4I1FjbI//WgkOD17RMC5yzSYCwXYPdBxvbc6DqOy0E+e0y0Aeh6wIuI8Ex/I6zSjhNuzKNTsoFlMk3b/hutNfkF0vqsqbXQ3YvOmTZ3bJqZlhDJFFonARzPSybZCFgoNddCnHAzg2abxgaNAIyAj6HqmdeZJxG820r4eCEGFl1KrEi9XxKnyVtvbSQKpSCz7pbWvjZPg81OurCis0izENVlp1VM5qnfGWq5t0YVP3Dg1RfrR9niRGHKcAC7PGYRnGSexzTOixTwHXvTGeJLZ5+p5DIsS+Au6qHsP6SKZlPLFkhQY5z4HD94+ccclHijRuBiwvCopqZy0+QoiLulXN+U/UK1T5ry/zbUsPSrerDU586ILHv1b36NUl+AOQDd5msh3/cZI3T5a5PflJcnO/yUUT9QouWhNAKb2w8mW9BTXcC10CuNhEV6ybZaRZ6F31m79WA2qJvZpGMdMpOWf77aNPTMS9an8tFa+bQVDIqvuHNmJ7z4URKiEfXWKjo3IQbIBViWYACIp8hb8xI/4EUs/PC9hwVZlO+rZZxejgTrG4QCBxJs/WHl8QJyQ5hblcw9Ij1tbKf4fULIeesDDfNIJHhnL9majoDPX/fOYaJamQq76EF7Xe/xfN9BHxaSNKHqymHxTbMIvOUuPB8xSSR2fjev0OJZCw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(186003)(66446008)(316002)(64756008)(54906003)(8936002)(55016003)(82960400001)(26005)(19627235002)(66476007)(52536014)(76116006)(5660300002)(66556008)(33656002)(66946007)(110136005)(7696005)(6506007)(38100700002)(8676002)(2906002)(38070700005)(508600001)(86362001)(122000001)(107886003)(83380400001)(71200400001)(9686003)(213903007)(156123004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vT36BLWQgLOv8xCy279HhmeAZ2nQFF/Rwra6kkz9e6OSk7pyx2XWScLzwEbw?= =?us-ascii?Q?CX2YiKweyT2X4WHnD1XrTdicpSjS8hkKnA85ijDxt/UHltlOpC3FdjVdDpGN?= =?us-ascii?Q?TB94FoVSQCIK3A9GRMEF+UHil4ZsnoyhDl8/JKikjtUPcIfTUeBb52wxaBBR?= =?us-ascii?Q?6xBUyv/0v9M8HzPNjj7yYpRLEhIF+Ajah5q5SXJquMrY17vZt1AEpBhwOCwV?= =?us-ascii?Q?gdlCvo9xDjhwXVXzhmbCyWe0K6munhz4uRdKhBlwJ7lWngiSFPhZmJRV2oAE?= =?us-ascii?Q?R19RkZivK9q4o76FvXVpOkKuHxCjj1LqGYU90CpWsWgxwuBsT2G0tc2sd/kr?= =?us-ascii?Q?Ea0iyshxRxKAvnklg1+oxK43lgmjzfgqfQTcrOhY4prXGPZiW+EKY+LLMvL5?= =?us-ascii?Q?qTyJ5usXvwljSp88Z3EQhAJtHU7qAVf5ttHWkJaVOWjAAbpUM57HQnTgRhMl?= =?us-ascii?Q?vyvByUwV0/QKtcgXMmLMvElDeeAl6M9w5nk84MdKuM3M5oxTLAaJsCKL8GDk?= =?us-ascii?Q?EpEaKEwzRPE1gbGWzJ8WShdYDzc/xoeKAf8o2VBKXR2XKVR7ORVtSp/WNKxi?= =?us-ascii?Q?4OsEprJGb0eH0VtFNDpoNy7vTWQOozpQrG1Wnu241svTaqPfyTzDWnj/fC2O?= =?us-ascii?Q?gxONwUlN3oQu34tYS2RcqM3agzHn2WVESZCvwoZDmdoTu+hyt3bghTw/NXQj?= =?us-ascii?Q?xJCMs+hnLt2AXdalxTRPtkKy26klCZCQgRUVK1wd0hWZYmB2hm+F4hGmWBQA?= =?us-ascii?Q?nv/NJpLt99w8hwUnABRTsHstSh4ufYcZ18B823teud7h7M/7aClniWeKEtLw?= =?us-ascii?Q?o6nkfKnVNhhrg2rLWCyFuVEojuToTIvLDqCwgJDRSWmBdrtVcL1AfHcwzjkY?= =?us-ascii?Q?r6h8ut9uvuq9ECWSV7eqtxWELe2KXcN7TmXebQGY6z4dvYua8sHOq7cCgdys?= =?us-ascii?Q?wLFEkoY2aQfY2VyIOrH8mZkQLuBlUqlDuMhVlmI7AQjeZbUFBNCkIZY/7Nf9?= =?us-ascii?Q?9tDMy2c8LAqny6fLqBU3xk0hiJB0v7W6LwIABb64SMDgZaghWrRr9vYaZOaI?= =?us-ascii?Q?EHMNQQu27q0ep8lR02eCQGnnlOArXI9MPLUbxQMQk0+wvRuJG/YaQk1SLssM?= =?us-ascii?Q?zzK0e46LNHEqdV1TIAXGlsI9hXg0U7ApE+aOL5lawuGOuFUAdZci/dNZpXC8?= =?us-ascii?Q?Iicmaqh7c00Uc7fd8cF4eZArhMxTeQetxFGUX2JnFSb2TXX6G5tmswkqnu3w?= =?us-ascii?Q?le783pLbS2UxmGfT1U7YA+C5r++MTMddKN9n4lO9/a/rU1sJ1RX/5xnjbajM?= =?us-ascii?Q?Vso4fQs34cPmgk90Ecn+iLwp8VXoq1D8faH+/kzsVuyQAyn0CR7aYkoMbwt/?= =?us-ascii?Q?TTVwZYFm+QFuMkWG1IWnZ4IP/nJxY/f042IYJML6YRqiGZ7EVd8RDCq+tTFC?= =?us-ascii?Q?pLwlXVVM3hgENjMSzJnCb0ASMDfjXsKF+eIQoUCl7KxbWkWoygElzWZHKurt?= =?us-ascii?Q?xQryd3j7Sf2+8vlsHAsHMtcCtV3L5TTcYBDL6AkzRDAC00wgviSWvMjaICw3?= =?us-ascii?Q?3lC1fRJkV1SHA3UzaahHk4TzHxyGJVt3xeQ3tPB9HjweI07xmVIAnc6RnBYd?= =?us-ascii?Q?OpkkdCirA2/8hUEVuEoNmbE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: caccd0cf-35a9-4858-b7e5-08d9ef5c879f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 01:51:33.9963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: de8bwc3VHjGAOF+Nfp7vq97zJy6w01VeAbApfA3oFoTRbbE3iCUPEo5iJNIj+53ZsCMTQPK02enkqhIZi/kzRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5912 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi > > > > Add PcdTdxWorkAreaBase to indicate the area of memory where the > > > > TDX work area block lives. > > > > > > Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when > we > > > have a shared work area? > > PcdTdxWorkAreaBase mimics PcdSevEsWorkAreaBase. Yes, > TdxWorkAreaBase is same as SevEsWorkAreaBase. But the name of > TdxWorkAreaBase is more meaningful in the Tdx related code. >=20 > Yes, using PcdSevEsWorkAreaBase in TDX code would look somewhat odd, > but we can rename the PCD to have 'CC' in the name like we already did fo= r > other bits shared between sev and tdx. >=20 Agree that can we rename the PcdSevEsWorkAreaBase to PcdCcWorkAreaBase.=20 Brijesh Singh is the owner of PcdSevEsWorkAreaBase. Brijesh, what's your thought about it? I check the files which need be updated from PcdSevEsWorkAreaBase to PcdCcW= orkAreaBase $ grep -rn --exclude-dir=3DBuild PcdSevEsWorkAreaBase - UefiCpuPkg/Library/= MpInitLib/AmdSev.c - UefiCpuPkg/Library/MpInitLib/MpLib.c - UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf - UefiCpuPkg/UefiCpuPkg.dec - UefiCpuPkg/UefiCpuPkg.uni - OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLibInternal.c - OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf - OvmfPkg/Sec/AmdSev.c - OvmfPkg/Sec/SecMain.inf - OvmfPkg/CloudHv/CloudHvX64.fdf - OvmfPkg/OvmfPkgX64.fdf - OvmfPkg/Microvm/MicrovmX64.fdf - OvmfPkg/ResetVector/ResetVector.inf - OvmfPkg/ResetVector/ResetVector.nasmb - OvmfPkg/AmdSev/AmdSevX64.fdf I would suggest Renaming PcdSevEsWorkAreaBase to PcdCcWorkAreaBase be in a = separate patch-set.=20 Gerd, What's your thought? Thanks Min