From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.4495.1643356977199123985 for ; Fri, 28 Jan 2022 00:02:57 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ao1qPh4f; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643356977; x=1674892977; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XEXQJUsadz6Yug7NkVAT3UPCfl4pT3RIVFcsFiBYzdc=; b=ao1qPh4fY+N1/0/Cvvb7yuVx+Yn/UK6+qhXYNTWUaezsyTu70qVOYysd kx9T4SiAh/abiVk2vO9i2IQobx+01I13n84K8A2mDBnCpUW6ilLd9OdjV tDj1OaN7VnPXDHO8jfD1QKWz1Di8UIW1i8+VXhpKM5pjNS0H//a+rgKdT Db3t8nmOMCzJeEq/NUqJLjD9EiPTuyIhH3TM0AQi4znHTrkha0xeyqewz aXe6vbpromTGP5lDmaPJrB/fwwi7leUhd9jzZeEDrZH+j96UeuXl5HFxx EOJFesBfaPJmF6Vxi4rHaanXJ0WNyGpGEKmR+0xZ6ksKEbKaikiQAYYRg Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10240"; a="333425654" X-IronPort-AV: E=Sophos;i="5.88,323,1635231600"; d="scan'208";a="333425654" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 00:02:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,323,1635231600"; d="scan'208";a="697011800" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 28 Jan 2022 00:02:34 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 28 Jan 2022 00:02:33 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 28 Jan 2022 00:02:33 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 28 Jan 2022 00:02:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ljEHTQPOyAM/Jk2clpiDDGqP6F5fmBZK0hzsVe8dmJK32KlFKYz0jP5zOVxZt1e21O++1qadt8+wZ8eZ2sXYSe/lqbIlNlWAfpB5ooTs5E0Xv0ZegcGiBVq1qn46u3LZ+lntZkYdiObPkduB+Ftv13e4XH3DHJX3fSmTYPCuHMvf9IZ0rnFLEwl6kIBq6AkO7zy/CPh98qP5qt0N8YoM6lCyNRdIGr/WZLDckN0S+2M2tIUt6+VAmVv8swkljk3D4iixOCGz1vJmJMyS/k+dbupdLvFTQWkfYr3SqJoVvb7pASwu8gyUymW8PQV64QwmTmMPAfctLeXP2OfIJReF/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uutWA1FEFalaglyYZnAMTCKYsNjA7TLMmCQLDj5ohds=; b=m+J/ytdlcIiZLLTv2LW4yIt2QZk3FWy4FLyczR3Y7qPSk7PxCWUA3Zvu641WiZ9rHeQYFUzVfSEgXIfs4nbleoUBf81vKQQc/D2DgyPhglptmaw2uHF79yblXjztGMPNkPoDZ9NHUvXE4knkr/ZpcWbgoEqJF7xVzPgD1LxTEzWo0j9mu8GL231gNUbnwdIThuciXVnjP3iCihU0vLOxbh5k2idLssHEsbnwWhbERcKShKa+6+2bZsCcSoe6I4gU0YS4mr/UjVzxqg++VrO5XD97ybZnMKZp8rlMvgetOVqVYtAtGT+LZIgXckvHhN9Qgw/eLlRTa6oqUy3MA9VJPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by BN6PR11MB1988.namprd11.prod.outlook.com (2603:10b6:404:48::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Fri, 28 Jan 2022 08:02:24 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ed65:b010:fc2c:f48c%7]) with mapi id 15.20.4909.019; Fri, 28 Jan 2022 08:02:24 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Ni, Ray" Subject: Re: [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase Thread-Topic: [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase Thread-Index: AQHYEbXP1tUlVM8tCEqVtzfQBYMa2ax23uwAgAE0dxA= Date: Fri, 28 Jan 2022 08:02:23 +0000 Message-ID: References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-3-min.m.xu@intel.com> <20220127132412.oqizta4k7mbtclpb@sirius.home.kraxel.org> In-Reply-To: <20220127132412.oqizta4k7mbtclpb@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1a2f992-1708-4b71-944e-08d9e2348492 x-ms-traffictypediagnostic: BN6PR11MB1988:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y6FYJF3By8MuIuTY+EYQlX4C1dIBjPNBJiMc+Zu+Piwv084cfl41ATZ0ALtvuCbEFCqpnRVXaPgkrB7NSnEViasgLLWPzHyrl98s1ZrS+iZXxpHAtkfaoIqhk0dvnwzzOfY8Sx+Dg8yd3TuHiWvgyIBt19a5A4+CrzroZHzlo3MrKLI2uCY0F2YWjmYfLwbvM48TewBeSeH2Z88Ea2UUzZwRvZsY4fAlaKTjrH/FAWi+H7BPGq6oQo1wX/vsKQdVcL3YK/5tmDIiGANSl5s6xkpw1fLQGHZkzeUEZwEW3eP02qLFFBQkdrUOcpWfmI1cvT/1dW/Ez1K//VqQb58eZZAGgaDzfhJKtQNM2Bg8VsTcnxhdOfWuQUFigZWK1Zel8TzcXj0s5sqyWISwx8+e+yJrsWOEGAHxr5ODOz4ODkCDN02b9fBVY6YG9KLH01jXAQkx5eSYdK22y4EtTuFaC2bZFdgSq2+DFHJcm9TQbg2wEj1B5V7NPieS1SRYh2Z1kN7hMUyTe5abF3067OxzUQzwkedqjnDXZjcqDzIcRlrj4T+mOlI1huEo7iRSd9FPoEJoUu+zEkWJTimSwIHtDwVlhYq7icz0OLGuSvsCuC3ytvfrdM+IwLPw45i+hMb+5EwTJpqZ138ZbMdWP+gTMjIVD+7zykjJOxG5xSN/dXFXkESel7Q2hCATvlniXbV+JxNy8XaUrz5xM7lp/OdWffmh+rwIR3LmXdtB8o7SoAVb+gMfso8PGU6U7Qq7ZbjApybTFmGSSLFpjrtoN2PLKWyJzy7viLicxvFkkWy/yv5A8e2+iaUs7RppnL+I86EbeKAkBIklc3C3p9iw/vxPZQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38070700005)(83380400001)(52536014)(55016003)(4326008)(508600001)(4744005)(122000001)(38100700002)(9686003)(5660300002)(6506007)(7696005)(2906002)(82960400001)(86362001)(316002)(186003)(71200400001)(26005)(107886003)(66556008)(76116006)(64756008)(6916009)(66946007)(966005)(66476007)(54906003)(8676002)(8936002)(33656002)(66446008)(156123004)(213903007)(20210929001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r59d8Spd7uitnftudXE/RjB/2IUXIpmlJo2kcOCFwGujCphjc1iRnOg7rs0E?= =?us-ascii?Q?AQ4gBGVfyYl5fCYhqzzzYixABbWY5eP7lYBKjindFNs+dYPsxG8LBGECv6Jw?= =?us-ascii?Q?Gq0fwVStHxLMbzp2r3cbAC1wgpzE+nT0nkFdQtm9uAt7O3V/x4brat1d91vE?= =?us-ascii?Q?jTiELem8wvHnQyyyiEi0V3/WHIAjYb1hEs3dJTEa9O7pFlukxolUMQi03pga?= =?us-ascii?Q?ODnF6CAZPJYcC2GTAj8VwDiSavOeJcuYmLREWL2nu02jF84efwNZCty8F9M/?= =?us-ascii?Q?kECC/vOlgVoDRrT+Rzjbg6MFzkOpK18daFmBqVb2B4yLTE19s9oJj25GdJhO?= =?us-ascii?Q?eDY6DNdIisUEOGp8/WuX0VKhrsgqToffq9OTDq8aKjJaH5LCuTr9Xx3TWEbF?= =?us-ascii?Q?uca0PXx2jNPRcgCAd7rPxltGN698owPUCKQPhEqg83y/pnhlERQEduyd4t73?= =?us-ascii?Q?T2fdT2UBF2nihLq7TA+FOvEYSxa5BZpuTZD9eIARqxTOdxref6S/cgPtJ8Ye?= =?us-ascii?Q?ayxFej1yUZTG1LJKZSIw9o4GjQA8PPuadWDgoIfCH211wWFcGlZPBOlSjbNE?= =?us-ascii?Q?2dcx3l0IykZ4kEvEWGhBUEajRi9W37clyYiYJNx1AREmz50ZxEOiobSuNCIL?= =?us-ascii?Q?6nZ7mJSu81a3zm7CC8hkDnX7eXaOreOu+poOMP+BXETJmVfLR4QN77M4jf+2?= =?us-ascii?Q?DAG1rlCIpfrQZXRINq3832FKsXF8Sgsd5fNBPBTJ9n9hvRbs36iSj9p7geTO?= =?us-ascii?Q?myNtTHocriA42wURYnes2GaxDd68cbwNVr33k69U9pWHAE5elgsAATiQfsaK?= =?us-ascii?Q?mFEELz/MOD+KTnWHPJ4KOZxXOmrEi+iO2KWjpgGN/9x3pEgUPoVy/+uxejyB?= =?us-ascii?Q?w5p0IXfoQsuxpewj4LqmhXr6pfovcXVzugs0kmlP/MpL578C9IkW56R3chC+?= =?us-ascii?Q?fnr2TJE+WzjIaR758HeTtW0DfY4zOLt5u8/YCFOuVTVy9nP2LeVNr3y/fyxw?= =?us-ascii?Q?njoizNYZ+NVJDij9f6pHyRucayiv1miFYkfzZOREJDEeGR0PamtQk9TycqW7?= =?us-ascii?Q?RMi058G+nFTJCX4NQROImjJhGfmrs5pxEwQOFwAtGd2q8ptJigXbxXnfhbuc?= =?us-ascii?Q?zYy/lIZ18rIqdJ8gRF031JV7nWMIHHgjPjoy6weJELwBt+DQJO2bBXmqqFwd?= =?us-ascii?Q?xj1jQGLkGJ6PaIgron4UBOKrkEzFqvckP6pSXfp+0+7duv/l9cEZ7GJYfokw?= =?us-ascii?Q?PMl2pQf89b2PM1uA1Qk5w9I6g8pV39PcuLyKOlQcWSqHpX+7O0TaWeyffcHv?= =?us-ascii?Q?Z1Z5qcZUovC7UT7XneP11v5hH1uv/IQucBYoPjB4XQfbQJZR0Z6Feq+6AlDX?= =?us-ascii?Q?xnlE0V6Ad3EvWtlizRByPaAKrlRs0ywWeI8DxinNOqpO5Qpx6RDdFBP7s7SB?= =?us-ascii?Q?faPl5rujbpHbTAfTm4bd1VsL/lEiZNf3bb4M5BdV7kAE9dQeWibD67sjRsOa?= =?us-ascii?Q?sTGannPoyySZmhEy/2UpzGgwUqRJxT8ETpFGF5hZu4qfKWncRPz5CN73yZlg?= =?us-ascii?Q?s8jzDueI8jWpy3K3bBCTnEB/5G+iZO7EZc9gnrCNstHlmDIeUnXmL+55QNMD?= =?us-ascii?Q?+G9hXD+YQcmmzifQB7tkW5c=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1a2f992-1708-4b71-944e-08d9e2348492 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2022 08:02:23.8604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7oWD3iotG0y6Jh/nk5OJoq9Ree7LLTtQzUd+gL0Qxm1bf0QE0TYPDNVE2ErsiVnzF9+JzK9KYg3k0sZHMFmTRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1988 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 27, 2022 9:24 PM, Gerd Hoffmann wrote: > On Tue, Jan 25, 2022 at 02:33:10PM +0800, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 > > > > Add PcdTdxWorkAreaBase to indicate the area of memory where the TDX > > work area block lives. >=20 > Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when we > have a shared work area? PcdTdxWorkAreaBase mimics PcdSevEsWorkAreaBase. Yes, TdxWorkAreaBase is sam= e as SevEsWorkAreaBase. But the name of TdxWorkAreaBase is more meaningful = in the Tdx related code. For example: TDX_WORK_AREA *TdxWorkArea; TdxWorkArea =3D (TDX_WORK_AREA *)(UINTN)FixedPcdGet32 (PcdTdxWorkAreaBase= ); ASSERT (TdxWorkArea !=3D NULL); ASSERT (TdxWorkArea->SecTdxWorkArea.HobList !=3D 0); return (VOID *)(UINTN)TdxWorkArea->SecTdxWorkArea.HobList; Thanks Min