Re: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib

["Min Xu" <min.m.xu@intel.com>]

On March 15, 2022 3:44 PM, Ni, Ray wrote:
> one more comment:
> the functions headers say "@return EFI_SUCCESS". Should we say "@retval 0"
> for a successful call?
Thanks for reminder. It will be updated in the next version.
> 
> +  to the host VMM, as selected by Leaf.
> +
> +  @param[in]      Leaf        Leaf number of TDCALL instruction
> +  @param[in]      Arg1        Arg1
> +  @param[in]      Arg2        Arg2
> +  @param[in]      Arg3        Arg3
> +  @param[in,out]  Results  Returned result of the Leaf function
> +
> +  @return EFI_SUCCESS
> +  @return Other           See individual leaf functions
> +**/
> +UINTN
> +EFIAPI
> +TdCall (
> +  IN UINT64    Leaf,
> +  IN UINT64    Arg1,
> +  IN UINT64    Arg2,
> +  IN UINT64    Arg3,
> +  IN OUT VOID  *Results
> +  );
> +
> +/**
> +  TDVMALL is a leaf function 0 for TDCALL. It helps invoke services
> +from the
> +  host VMM to pass/receive information.
> +
> +  @param[in]     Leaf        Number of sub-functions
> +  @param[in]     Arg1        Arg1
> +  @param[in]     Arg2        Arg2
> +  @param[in]     Arg3        Arg3
> +  @param[in]     Arg4        Arg4
> +  @param[in,out] Results     Returned result of the sub-function
> +
> +  @return EFI_SUCCESS
> +  @return Other           See individual sub-functions
> +
> +**/
> +UINTN
> +EFIAPI
> +TdVmCall (
> +  IN UINT64    Leaf,
> +  IN UINT64    Arg1,
> +  IN UINT64    Arg2,
> +  IN UINT64    Arg3,
> +  IN UINT64    Arg4,
> +  IN OUT VOID  *Results
> +  );
> +
>