From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.20114.1647396910797600312 for ; Tue, 15 Mar 2022 19:15:11 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=idoGn21P; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647396910; x=1678932910; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oEblh5tZaVxp6bqeABI3AbazQpXG6BDvzg9HpAyM7xc=; b=idoGn21Pion4+svwom4GO5xVH2y73q3r5R4Uu0dz88XNYcuOr3w63Wyv QkxiyOaNotuNHkk53OMASOM7YGMeokl9CvjqrSlqfgdSL95dmt8CMDke0 D/vePKa920InZh3L8UF2mw41k+DTINacNTOMul1CAr1+1lXOctebzprhq LJgW6jdUmz/ivUqbIyd5pXGXcAuHLq40iK1hT7Gt5A5cgu/2yR6KES+ty eHZdmhuz32Ir4M30ZX8UFvow+F6W9uegCPQwKnsozDIM+gV6Q73RPJJlo 1q0Ew/QaLyHoUwY25/mF7+eKtXX9Ixk7Yh+jMgjZywW9/KepyD8zst0yd w==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="255300958" X-IronPort-AV: E=Sophos;i="5.90,185,1643702400"; d="scan'208";a="255300958" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 19:15:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,185,1643702400"; d="scan'208";a="646463302" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 15 Mar 2022 19:15:09 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 19:15:08 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 19:15:08 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 19:15:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l4mH56/PsTH9yWQT0dm2KuKsmBt1SGswGbcOMWwTSVog1IzEO9V/XmdrRzG4E8zK9sHFhQHD5CIjhUqw3o1c2B0HQcx02CgxXFzZk1ybUx8pwctRUGxCJELxAztcmXz2/RwhpNpDsD4koOiIeswxXrvHWTJ7fBCMh+HBifmFuMrOEQ864z1a9c2fZhl4eHCgSbysoldBRuxjhSa39IJVm1PpZy2lzoWKE5huw46vM9Aj5Lq1vKMvHWc5xRk6hdmUJ2muWpneolrpiJCKo8H+qZlSrQieFE34MMaj8WG0dJ1YLD6dATA2EgfNBimrQZvHS//LtmDKpGD0hVvM0/+lGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d2h93Sd0P8PFs3j5S3ISVz7qmZLoVHnjWe5LK9y9oME=; b=MyUQZxMeWYO7V124oufHwcytRfLm/ZUA1Mbk3ABEMUXEGEXxzgi1IOevoL/JpxLKLAND6XxHYlRDuzzmofPnHfNZ52f9QHboFWODzjZZ3xP8XWxjqgWg1kMWS86skN27j9w3tFCFkOWyiHecQkd6CQSR37CMD2KQn1GcApFduO3ravF+qr1D86aenUk2sY1r6G/S4HhZqBcKrzl+PphWLYC8y+qXbe5PDLSjZsHXyvRt0jWvPr0rznckJGLnd+3m0hbcHNBccRTNKbGvtYj4FwEJHwqCzSEwpKtoDGkQlfU1/nenscCJ/cjmbgu9wJAl3H0lfhdlN1SKouh9fD7Upg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by SA0PR11MB4525.namprd11.prod.outlook.com (2603:10b6:806:9d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Wed, 16 Mar 2022 02:15:06 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::ece5:6170:a99a:480a%7]) with mapi id 15.20.5081.014; Wed, 16 Mar 2022 02:15:06 +0000 From: "Min Xu" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib Thread-Topic: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib Thread-Index: AQHYNbQjjtSvkrSrX0C8H8lbdUndoKzAFYWAgAE2IjA= Date: Wed, 16 Mar 2022 02:15:06 +0000 Message-ID: References: <78b2b2da2b70601cc173ce5801138226ca9f4bb7.1647047481.git.min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 453123e7-65d0-465a-8b97-08da06f2c9dc x-ms-traffictypediagnostic: SA0PR11MB4525:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qtPMXMV1rOVy43vvb8Kd6geg+IhyqJ3pv0y6q0M+aVbs9QjoCSBnW37LdfxNjsPOBc5uf2jJtuEuZl8z46T67V+HlxLvbOrqf1rH8QZO4C9sGtcB8mKLt+cQhQhKRyHxe3sKfoykLHM3lpAiZ67PT/zB0L/JDJGTOiHrVLg2f0idsRfJPotd9Ot14FHmJZ72M5yvi06PRH2PDY3xTdec8ZXc97NeDNWNPyQhczcBdsbhP0a9Te7ActPaNX7B3aEPNm6VuezpE5ck5WjwyGSQBl/imAhebO3a6hu2g9trpDr0FsXfPMu2SqpmVN8mNrmUjXNul3pLu6X+NLjkJTtDktr/W6mLwp3buAOwtsb7VPWy33yIgdIOYvrIenK0vTP9A6CMEwphvuReU39PCCfivqXOWoIY04exhC+bvXLvVI+WCvJmTRW9F+UX0uos8wo4Mh8PzvzB/XNfromp8UP95wrnb1GUqAOeZyVg2c0cCkRlhaHKt7N8IdIzTYX7nM5Bs6sT4++CgXGpQx3NekXKJ9wYbjFa4Cbkig6mTZpXGitgmGN8uvzQaUtr9hTijxeHTS6GCrpiOXtQlOwK6Z5VYVJGWSjquZj6PkhYWt8fs1BvtCr7czt+F0HJnlBaUPNEcMHKcuLaevMo3P00dZGYUo2JrRc20//KbJ4GBpt9RpbTwuYidQBSj7cquXCne9PNbdwDC2lkbaRzQwvWMPSvGg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(7696005)(33656002)(86362001)(8936002)(52536014)(5660300002)(82960400001)(83380400001)(71200400001)(110136005)(54906003)(55016003)(122000001)(66946007)(8676002)(4326008)(66556008)(66476007)(66446008)(64756008)(508600001)(76116006)(6506007)(26005)(186003)(38100700002)(2906002)(9686003)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GLpu7/kMrTPAxpbbO9V8zOo8MI6PeOBO5kT9LZ/cOxJ2xwnAkgwOzQ7Gw5vY?= =?us-ascii?Q?VZxp+XVXXUQyZx6aXjSBRYRG/3nMzLjfgELpWEUgLNHSD26zrEUlmo+mixU3?= =?us-ascii?Q?XtSmoyITp45a7ilqDpRp8QKXISU3+CInmR50F8QfnyT1FmpErqYgrmqzxx8T?= =?us-ascii?Q?aaMMhWmvuTxUNflza6cEDw3e2DtW/WgUySns7jJPqjd67tE8I3w3BIreR8nh?= =?us-ascii?Q?1jdUK700TY9mf12OYLhb8e79VFdlhA7EdvRadN8UtyhV8Pejkv5ULoti/UQY?= =?us-ascii?Q?jr4A5YiIqOinpkp5rulBHQzn22jdBUBLNy1Ak9AkGuocp4UXqowdMk9s37Zv?= =?us-ascii?Q?MQgvPcAg7LY9sQZXwI8pXW/mYS2pqmzIdWh1fGk5Im3W3LUVRTkpOn7n0Qdt?= =?us-ascii?Q?8NYIiC6U5Go4NjlptV+aF0XcfcRNi97jSHAiOCL2z6nAloXHPnUWSx2nWZfG?= =?us-ascii?Q?NZrPbNHjJ8hgPK2YGElgYcmmgT6+zxEDq8Wnu3ab7D3uNh5AUY3lve2n9/4E?= =?us-ascii?Q?CspVucbozgeHAn8HHtyLWfHOvct4pZFdfrRDBEp/H9PsvpVnX4ReRlF+zYSP?= =?us-ascii?Q?Aix35dT1l0XBdP7b7A/Wv64vh68lLlyqA6p1zEpKhG5uLZdQQv1Zf8LbdHip?= =?us-ascii?Q?8OWrX0vmGvwLpB9dQ1iNm2hOQ8djzamnNUzcd2m0oSzt6objfq352muWCqUv?= =?us-ascii?Q?krxWcJIBenF2nvnZBq5Fg5A8bRbifr9iarkxHgxLhlhhCoKJSbdG399/N9XJ?= =?us-ascii?Q?aq9lk4H6hlkg1bQ0nGbfEW86gLMVOppESWC1lNtNaZBHf7EElacfXv+zmgM5?= =?us-ascii?Q?N72jGLvZRXtcQNFcfJ0lUG40blpePfJHHr246ag01dNXoYi2DAg7LDx6zqxt?= =?us-ascii?Q?LNQSqmbnqur34cjN9y0sPX3btAky9kExS9zcijIqzoCEe7nmSu9bVmqSFxjv?= =?us-ascii?Q?j9k8BHu1xxWxdS+TsT0AvOmkTgB1KPl3dBOrSyLtdEz7BLB+Ba/XL016rch0?= =?us-ascii?Q?fMZP3KBpBqFPbCLwbzUl3C3l08tvFho6WxAqFUQOKqXZu8lAVdMfYIWVv/O3?= =?us-ascii?Q?d+LiKHzCKpaYWRhcJvhbQ1+hSQrtHmQ0V0G6DTlRqxIzWMl1R+1oWH/fkKRS?= =?us-ascii?Q?+hD9ZVCrCXhWpNa+wIhG/Edo9Iya4G6w/X8UQ5Yd/wR0BbPNfej8voBPGtWU?= =?us-ascii?Q?hJE2D2t1PguuDQuMX9K95RQWiXEdB+7ypEroFOWO79MU4c+YA8AYFhXe5URX?= =?us-ascii?Q?BB81gddjJkbbGLN98Jmmg3HQIVKo96aTr3ZLI9fGW9NR1eN1qBbmatjHA3u9?= =?us-ascii?Q?LQsvxdNOcsGFdXVNkPXGoXTBZ0+PjRpskYHaa6xqj6cjdbZnifKpRcOJ4tmc?= =?us-ascii?Q?YSE/SjUrv7nKIc7cVW94URTpRv9myNSLkC31kRK6HOeQmK+HBC7BSt5hJ4Xa?= =?us-ascii?Q?mnSMmqqKStRWsCg09O4BtKlTJ/3adL1d?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 453123e7-65d0-465a-8b97-08da06f2c9dc X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 02:15:06.4560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +S56PO8Hy6UwkANH3OiCgA2aisE7eoK9nCWZ284rJ99tyb5SJ77PrPXYWOFYFk1/aD5pjgwG3ZEUOTMC/wgcCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4525 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On March 15, 2022 3:44 PM, Ni, Ray wrote: > one more comment: > the functions headers say "@return EFI_SUCCESS". Should we say "@retval 0= " > for a successful call? Thanks for reminder. It will be updated in the next version. >=20 > + to the host VMM, as selected by Leaf. > + > + @param[in] Leaf Leaf number of TDCALL instruction > + @param[in] Arg1 Arg1 > + @param[in] Arg2 Arg2 > + @param[in] Arg3 Arg3 > + @param[in,out] Results Returned result of the Leaf function > + > + @return EFI_SUCCESS > + @return Other See individual leaf functions > +**/ > +UINTN > +EFIAPI > +TdCall ( > + IN UINT64 Leaf, > + IN UINT64 Arg1, > + IN UINT64 Arg2, > + IN UINT64 Arg3, > + IN OUT VOID *Results > + ); > + > +/** > + TDVMALL is a leaf function 0 for TDCALL. It helps invoke services > +from the > + host VMM to pass/receive information. > + > + @param[in] Leaf Number of sub-functions > + @param[in] Arg1 Arg1 > + @param[in] Arg2 Arg2 > + @param[in] Arg3 Arg3 > + @param[in] Arg4 Arg4 > + @param[in,out] Results Returned result of the sub-function > + > + @return EFI_SUCCESS > + @return Other See individual sub-functions > + > +**/ > +UINTN > +EFIAPI > +TdVmCall ( > + IN UINT64 Leaf, > + IN UINT64 Arg1, > + IN UINT64 Arg2, > + IN UINT64 Arg3, > + IN UINT64 Arg4, > + IN OUT VOID *Results > + ); > + >=20