From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.9538.1632131515023555227 for ; Mon, 20 Sep 2021 02:51:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=xDsG3q0c; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="223131880" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="223131880" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 02:51:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="556043892" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 20 Sep 2021 02:51:53 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 20 Sep 2021 02:51:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 20 Sep 2021 02:51:53 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 20 Sep 2021 02:51:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mtCod/vnH67oekn8bHPoAssBGlCbD30OAtnD2gFJ4JHEct0LbgK+ClDrDjZu7hxEdbRmV2DN3dD8pmSU26XJQKhASzbA/sF+YG9BXUp+TxTVHkqT+ITHYkXQYNLqrTCT2WJg6cxfh+r8arXb0Q4Pq+uRWTg0f0vwV3YApTgHM8TL9NCDe2XeEcLC8CZzUAI3d6sjf34Zo35/zrX2Bj8wY71OPqSKPhqxMD33+095U++6CsXNBeH3aIjPiYKuFoGNZ8GWu3zFucz4d/xDIZ7MFh/e5D7L8YYcbAQspktuW6C78Z9o/TYP33SMlAHa7zGkwWmhMPQvjDrZouoUeTDCQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PcHb/JHIOnKETtRZDkZKLppJc2Hcj8xWsi5ul1A7MpM=; b=FjKc0pyfxaYgQz92wskIxPgmRL2XQUkyLajOYOmF/zf2VnPDqt2DOdyb5fK+kzetKuUY/3CkLJl3Ty+XTis51VeFNQCJ2Rwvkj7FjxTQzAHqXVBGX1y0FMwF7ochioK5EvCpJH36Kvd9ZnHOij+rn5KYHE4tnoqILz0i30Ngd10zFEXTRZCXzKHGTQbQD+H9zcdOwGy/SS7ygHbZCbc8eom61r3tLS5hBhjjq4CkwhGdV4hWyehnYhRkq/GEbhrkTfOQNGQCEuBZ+OS5DQL9KLb1ovnn1uj/1gkwCRu1kr7bkKua/aGL6AQZstwzujWkd+3OKjW9E6qrdhOkNPvW7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PcHb/JHIOnKETtRZDkZKLppJc2Hcj8xWsi5ul1A7MpM=; b=xDsG3q0cMNfynx1Cx+fPmZs7DAiIlkqiU8sS8CmnvgtwKNPwVsRjOmuIsovFFsTX3QiDYeBnAOzXTw3YtVbzeNYI4heDBDfNU1N08xe+dL3rSKKvbhymUBWU2TIUmpl249/RAuX6lNBqkgD3W4F0DgSptX/BEb+llp8zkrXNr3A= Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB4966.namprd11.prod.outlook.com (2603:10b6:510:42::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Mon, 20 Sep 2021 09:51:48 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::c93:200e:5aeb:e11b%3]) with mapi id 15.20.4415.029; Mon, 20 Sep 2021 09:51:48 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V6 1/1] OvmfPkg: Enable TDX in ResetVector Thread-Topic: [PATCH V6 1/1] OvmfPkg: Enable TDX in ResetVector Thread-Index: AQHXqUWVKGnjdIxMkUC5t80PA95r5qumTbwAgAZmoeA= Date: Mon, 20 Sep 2021 09:51:48 +0000 Message-ID: References: <20210916075456.ymddpwrguipziq2f@sirius.home.kraxel.org> In-Reply-To: <20210916075456.ymddpwrguipziq2f@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ae9f48ea-5db5-4c05-65c8-08d97c1c43c9 x-ms-traffictypediagnostic: PH0PR11MB4966: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7n8te3BR3X972wA8LxV6Nejk7T47XFZQHE5TXm4x9piMInzKubqdkxFcLsZZRdDG/lHyWGV+xTtwSmNpzErr4xi6OELaH+fjJ+5s6oNAgm8k66pulI9pFB+qO3LCjzrY+s5njYF7C3TQRfbT5SKrmzVPs4MpNI4bXR6HpYd2+XFFdH6VSB/sCmbbH72pKLnwSqD6GbgY84lmQ2YWncBHjWO6En1z0rwLw4WsqUMEivSD8n0Geul5MRlcgs33nf0zvVvkL1SabP2JlyQAAqgBd+Ls8ME1Y77c4NQWXAf0VcOko63PJGVJoeZz0QGEwh57vDSCIKR+zJbra7zNVyZuLDXnr/hM1Dw4NSGV4emhwEaHuUA72g4d1ptkmwqgonHcjbCSbefyzS0pA2rQBiNIogqVuBDTxNtV3mHkwQSXPFRPFXQQAF9VVrL97jt5FFcNFIVmpzSzNxe977DPzdTp6M2oqg65YzCDKVPeMIoXj50bGvuBNbDsT+ttcTYca5zsYJJtlFKTqiIru2kvCwS25L3wmKcjGhytVz7l4LITXeiVJYeVOrdM6iwZahm7KBJ4mcmtkkvkJDw7Csv042oHXDsATidPberguPPrxk5jKpB6Atk6arLRbft5G4DOkJmXYJ+sCMof510aXwJyjBomXMAQfYHuNrtaJcMofC6ES/dJlFxIuzRERS7yws9w6jGln90F3GzzmQYivBhYeg5PGQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(346002)(376002)(136003)(366004)(8936002)(26005)(316002)(64756008)(33656002)(86362001)(8676002)(478600001)(6506007)(71200400001)(186003)(5660300002)(122000001)(38070700005)(9686003)(6916009)(66446008)(55016002)(52536014)(4326008)(83380400001)(54906003)(76116006)(66946007)(2906002)(38100700002)(66476007)(66556008)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wd9fo43kptveTmL4UBd5OeYIo3dEnoXruJqthLF1LsHL2+GFJWfNiepol+pG?= =?us-ascii?Q?LCrRQBTogNNsaFzl2AoGFuScQyn7R5uX7xK8pJGW0n1qd8KNL/PMMD6M7s+O?= =?us-ascii?Q?r3PQ7xD2MTe1Ecl5hX9wOCjwFqPlAiTJNIiaNgP9x5/EcOrXxKbg2GEkyy4Q?= =?us-ascii?Q?vn3kxKlzQWXZ4i1VyHiDfr4fSDBVPJQYYYuncEKwPSY7bDkM4u5rCLGU7U00?= =?us-ascii?Q?5qxAbIsbSJjitraPS7mezFjW6K4yzsQFw8c79ek7pzoez/UzZBv78rNfsb16?= =?us-ascii?Q?FOwSgC3O+J/o07zj2z/+89dAaFGvl69Xnop7WzshIpmUWm8clBLnNvVzoYf8?= =?us-ascii?Q?ZYQDoUuAJIwN1uONTJsihcUSsPgzPwElQjGXJpE0pp7qF2oa5Gwvv/5jilzv?= =?us-ascii?Q?0M3r3CBa99ZdQbS4jXGOsmL/SGHG9vjFPyIk5P8Un8yYoc0E52VPKQcVIgmb?= =?us-ascii?Q?Ek2FwqChBlfyHl+XY7kGCkipHzh2gUYcaJUoenJlebkCjq0DI6fsr9i/93jR?= =?us-ascii?Q?zIZQi78ergedjpmH0qCCr3MPwJgNzsxPUZl0IH8auFf3tThqmBhMtL3Wh9+2?= =?us-ascii?Q?gWn7+OQMVC/cI0TJadoWu+F9vARS100q6d5hA3nh4KaLeaXegp04AcxDiJmQ?= =?us-ascii?Q?UfWXX6aJh+ze4MA1nW+rGRMpALI1io6esX9hQoO5X/5+krqy6JQ79j16OkiH?= =?us-ascii?Q?xfT9HcCnfUolhR1eRWv3I+4vVzwUGBoDtUzKgDDX8FzWlzNFp8jmcuvqDVau?= =?us-ascii?Q?FESPxR2fnTcuy0/sQhGBNyQo/cL/e6M1EDKOayGWyminEqkb3L7pC0kxevhz?= =?us-ascii?Q?c/0ta25z/TMVq0ZEC8fYpkG/UGqhGbDWMSB2bQaVeTC7aWufvq2b29cZbjs8?= =?us-ascii?Q?eBOoMevtmWsjuCo5TytVF2br76gXk9mXTdl+PZqXapNwrWXMmlzJ63G8FH39?= =?us-ascii?Q?a1RjlNN7FUSq7rsAwz6LW1mkAbUWSvzsYEsSxJH9hZD8GnZTlqlHWTRNkV2L?= =?us-ascii?Q?pbP9e6/3Ao60Q44+5363C12GObXb3UsZUXPHKkpXD8r3lTJLn9tmXMzXxv7C?= =?us-ascii?Q?/aNVDYev7bu2yVIzFBrqYHNz9fBy0otKKQn5dF0pCU9RTdJ3eAbBjP8xKSd6?= =?us-ascii?Q?69MZu+lSl01fRecANB2KwZNcyGN0Re5FIyW91MjhdIzF+ORqs7wecfSxBat2?= =?us-ascii?Q?8VJJIcCiE6oKW+FlShvUFtAUTbzSCWr2Z1+iNEpgO/uCDJRMpRlm+rBK46tO?= =?us-ascii?Q?FBZuVB5+Xf5rMwnH5qb/uFvdAHAeUlZZbUqjnXpn03OqrACI9puCbLC5T8NX?= =?us-ascii?Q?JyYMkFnlXChV0yRJANdD2Xyu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae9f48ea-5db5-4c05-65c8-08d97c1c43c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2021 09:51:48.7149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dj+76j4tsuhN0i6KC+kOYdQpCmGmEyJRuS1PD3Ava4g5ghfnSY+kT64gNHL8Z91gjEw7/ggO1sh7oxFJjPwQZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4966 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On September 16, 2021 3:55 PM, Gerd Hoffman wrote: >=20 > > typedef struct _CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER { > > UINT8 GuestType; > > - UINT8 Reserved1[3]; > > + UINT8 SubType; > > + UINT8 Reserved1[2]; > > } CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER; >=20 In [PATCH v7 19/31] UefiCpuPkg: Define ConfidentialComputingGuestAttr There are below ConfidentialComputingGuestAttr: + ## This dynamic PCD indicates the memory encryption attribute of the gue= st. + # @Prompt Memory encryption attribute + =20 + gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0 + x60000017 + + +typedef enum { + /* The guest is running with memory encryption disabled. */ + CCAttrNotEncrypted =3D 0, + + /* The guest is running with AMD SEV memory encryption enabled. */ + CCAttrAmdSev =3D 0x100, + CCAttrAmdSevEs =3D 0x101, + CCAttrAmdSevSnp =3D 0x102, + + /* The guest is running with Intel TDX memory encryption enabled. */ + CCAttrIntelTdx =3D 0x200, +} CONFIDENTIAL_COMPUTING_GUEST_ATTR; + ConfidentialComputingGuestAttr is a 64-bit PCD, the byte[1] indicates the G= uest type, byte[0] seems the sub type of the guest. And in the current definition of CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER: typedef struct _CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER { UINT8 GuestType; UINT8 Reserved1[3]; } CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER; Byte[0] is the Guest type. I am not sure what you mean: > we should use the same approach (and the same enum) we are planing to use= =20 > for the ConfidentialComputing PCD (see discussion in the other patch seri= es). Shall we update CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER so that byte[0] is = sub type, and byte[1] indicates the Guest type? Thanks! Min