Re: [PATCH v2 5/6] SecurityPkg: Add new modules to Security package.

["Min Xu" <min.m.xu@intel.com>]

On June 1, 2021 9:12 PM, Grzegorz Bernacki Wrote:
> This commits adds modules related to initialization and usage of default
> Secure Boot key variables to SecurityPkg.
> 
> Signed-off-by: Grzegorz Bernacki <gjb@semihalf.com>
> ---
>  SecurityPkg/SecurityPkg.dec | 14 ++++++++++++++
> SecurityPkg/SecurityPkg.dsc |  4 ++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec index
> 4001650fa2..dad3cae0ba 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -190,6 +190,20 @@
>    ## GUID used to enforce loading order between Tcg2Acpi and Tcg2Smm
>    gTcg2MmSwSmiRegisteredGuid         = { 0x9d4548b9, 0xa48d, 0x4db4,
> { 0x9a, 0x68, 0x32, 0xc5, 0x13, 0x9e, 0x20, 0x18 } }
> 
> +  ## GUID used to specify section with default PK content
> +  gDefaultPKFileGuid                 = { 0x85254ea7, 0x4759, 0x4fc4, { 0x82, 0xd4,
> 0x5e, 0xed, 0x5f, 0xb0, 0xa4, 0xa0 } }
> +
> +  ## GUID used to specify section with default KEK content
> +  gDefaultKEKFileGuid                = { 0x6f64916e, 0x9f7a, 0x4c35, { 0xb9, 0x52,
> 0xcd, 0x04, 0x1e, 0xfb, 0x05, 0xa3 } }
> +
> +  ## GUID used to specify section with default db content
> +  gDefaultdbFileGuid                 = { 0xc491d352, 0x7623, 0x4843, { 0xac, 0xcc,
> 0x27, 0x91, 0xa7, 0x57, 0x44, 0x21 } }
> +
> +  ## GUID used to specify section with default dbt content
> +  gDefaultdbxFileGuid                = { 0x5740766a, 0x718e, 0x4dc0, { 0x99, 0x35,
> 0xc3, 0x6f, 0x7d, 0x3f, 0x88, 0x4f } }
> +
> +  ## GUID used to specify section with default dbx content
> +  gDefaultdbtFileGuid                = { 0x36c513ee, 0xa338, 0x4976, { 0xa0, 0xfb,
> 0x6d, 0xdb, 0xa3, 0xda, 0xfe, 0x87 } }
> 
>  [Ppis]
>    ## The PPI GUID for that TPM physical presence should be locked.
> diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index
> 854f250625..e031775ca8 100644
> --- a/SecurityPkg/SecurityPkg.dsc
> +++ b/SecurityPkg/SecurityPkg.dsc
> @@ -259,6 +259,10 @@
> 
>  [Components.IA32, Components.X64, Components.ARM,
> Components.AARCH64]
>    SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> +  SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
> +  SecurityPkg/EnrollFromDefaultKeys/EnrollFromDefaultKeys.inf
> +
> +
> SecurityPkg/VariableAuthenticated/SecureBootDefaultKeys/SecureBootDefa
> + ultKeys.inf
> +
> 
>  [Components.IA32, Components.X64, Components.AARCH64]
>    #
> --
> 2.25.1

It looks good to me.