From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.3400.1641537004492536198 for ; Thu, 06 Jan 2022 22:30:04 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TuiuCpke; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641537004; x=1673073004; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qO5fK3NLXwE6j0kdDWQQokt+Hrdm+LCo023Z33Ru85c=; b=TuiuCpkeVUfJNM1LLsqBloH26tonxKfkdRiZWxnKRVrw1Xrcgtr20yLA wT7puRKjkh5KdZkETN/jZjUYtV+4aREV4/Ico3hFQozZd3oBAwEc0UEUA aXET+PF9sfgxHYbeutqxQHXmXj0Skhzo/9bm8UPEzESg2H7rcOxhHkJkj NHo98d1M/GZ+lAFCFSdgnXJl0crWWdQqy0+FlfnAWM1jyj2jTX8wXrxbH EV0uUyfeauHRzncwaZXhmxTTgF5BMbl/dy/wew6XxH0CNnQApYZhesF53 PgjOMSalwwCY1EjBtT11NXVPP1ZZlChiJzBlhFPGqP9seq+cjm0f8amVE A==; X-IronPort-AV: E=McAfee;i="6200,9189,10219"; a="230159055" X-IronPort-AV: E=Sophos;i="5.88,268,1635231600"; d="scan'208";a="230159055" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2022 22:30:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,268,1635231600"; d="scan'208";a="575014281" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 06 Jan 2022 22:30:02 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 6 Jan 2022 22:29:53 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 6 Jan 2022 22:29:52 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 6 Jan 2022 22:29:52 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 6 Jan 2022 22:29:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ck31fhuRJ788k1oUVuz23ZsI2Hhg/Cnb3Ff2lxPoKRV4kDnB8pE70eeF2dbcg+UFT0UxwnVwafoqnxK7hi6gOTI2Jw14sQGNc+BqTs2Wu+RIRRkcleTcFARwvtORAIXxGNW8uYw8GyItPJg81aBRWynj+6TRAocKHZddNpOoyzOzE/6c34zZt901Zs4JZPJ8eYSBLM0k0AcRuOiOUhGb3i2jqUjNXUoCJn/+dR4JZraWvvzl2SpC2nB6Q6iPh6s4hNOOHSeLzn9aJ6RPjWhoWnbbaFCoxVC+oFSlD+pNc9TjznTPbkE82UDq37BnXsXJoXBuqsOQGAUPKAVH2fpv2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkjXbfyGglEe6+/Z0bnUu9ixLj1z3h24IBnBlQahkuw=; b=RzAy+41nfGXoWbC+ZrhwQl5iqRZNf8tgQGjpczGznrgDuDgn0hZ9/8anUEkGREW/TroB00f5ZYk0vctYHgJS+3V/toqP0Fyl//WiRtfF9+BMHXwY1RKX711oT52d8nsbcxpiZ7JYCCEeKyFZWq/EcJ6I3eYAjgohJeFK4RPYRw0DYtCo9GedaItFFp5qnvwzxSQpDuPqTeC92ktksT6rXi6m1ptp2zW9V8eLGqv1MFySGeoPMkQ2kNwnmhUrQIo6NH4zvJydoHB0dOr+fHewNwLOQ248yWFOiROU+fJWccOnRrfLpSdtAocdhNoUZfPO7wLFK6rChbppZIh+bJQZsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH0PR11MB5045.namprd11.prod.outlook.com (2603:10b6:510:3f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Fri, 7 Jan 2022 06:29:51 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::fd42:b334:5030:af8d%5]) with mapi id 15.20.4867.011; Fri, 7 Jan 2022 06:29:51 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH 05/10] OvmfPkg: Add SecPlatformLibQemuTdx Thread-Topic: [PATCH 05/10] OvmfPkg: Add SecPlatformLibQemuTdx Thread-Index: AQHX8PBkwVvJkNadhEuZs3c8CtGFMKwzUAqAgCPtaUA= Date: Fri, 7 Jan 2022 06:29:50 +0000 Message-ID: References: <20211214134126.869-1-min.m.xu@intel.com> <20211214134126.869-6-min.m.xu@intel.com> <20211215094849.4f4vj64akrvrqj77@sirius.home.kraxel.org> In-Reply-To: <20211215094849.4f4vj64akrvrqj77@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f06bf4c5-2b57-47b2-e1b8-08d9d1a71c2a x-ms-traffictypediagnostic: PH0PR11MB5045:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6hheViWz/30gUaflyJoWZLS2skNsHnLZrkfBYo9hs/SRGxue7+pcbbKLxhXfT06fGUpt1w7Qhox8RMKqSRQxA3U0zmhC08z5Shxi7u/UVRa/eXWtJRXlkrTHnW/eh/bVYd7LeSJlPurU0qFk4/doKP4BMhl3w1EIcFpS29DQlRKQk137NyICI5mjF9NPlYQ+vHse/XJ4TNe9mr3EmWDyM3mpFYYm3rO+r5SlqBksJL8n5vIrNMQ9dzTFtt7BTxnPWakrjaOwVnwe9GWswIPU4g5Csnh3lwRqLBdEe18A3A0PQWhfdT0mHgpe1GIqbgClRG7LGz3lvcHiE3hqmPkj8680mwH/clx6/VKPagEVvFVZiZkm1scmFGtqxZrBNDsV5GDEJ41Udzq7QpWA4pjbVg7PQk5/lPiKDwb3WhjQGE1em3cSKPqb0EZr2iK/7+DIcDmGbJkoeM7FIvfOy1XbjREZU1niD4tZjHeGogw9+mezhWjeWPphwIVaW0l4JwxJnj6BSqJyoSZJweyhaKadj7XNwB+RhMS+PEf9Z/L24Sfh+PP9wCm+Kq+6UPAfqVj2qK9rtKcMkAytFi/tf3OOGJ/576NMc0F0Jzf/cs4iwjybTmgu+pwNdqvXoJVpkgSLPV1c0a2uWutAruGVR1aMvgjfvvRwi5GzolQLh0N+em2o88UWK7QYZLVHHJ/r5ojaExjdZgFXsfYsAdVBEER1QqTje+zoG6DF/tq6Yf88Lo4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(38070700005)(82960400001)(55016003)(26005)(7696005)(54906003)(33656002)(8676002)(5660300002)(52536014)(2906002)(508600001)(6506007)(186003)(8936002)(76116006)(4744005)(66556008)(66946007)(66446008)(9686003)(122000001)(64756008)(71200400001)(66476007)(316002)(86362001)(6916009)(4326008)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KECU4yeYThBAblnCKRZIZ5R47NrSdV4OC7XfAm1prIBaFhAmh1UoKpUhkXbB?= =?us-ascii?Q?3c3rIce2TuhI5BJ6/tHVTI5Ny9IMXzK+MYFpA7NJpxIa6Lo/LGkQbZyASA2x?= =?us-ascii?Q?sYBUuNLcrG048IVz+6jMdUeDzOIkdGh1GVD6SJnRQfbFts1C30xxP/D+9EbO?= =?us-ascii?Q?7N34RcTblgTV5Q6Cv11h9RxIKQnHQykOYLqGxi6CQBmOSA5X6PtP8M0qsLw4?= =?us-ascii?Q?pATpsGx8xS9RrAnqOfJyibVB+AK+gvI9rzmRQ3SqbJXAIPChQO34udl26APL?= =?us-ascii?Q?6kmzC9phTJwR0hZgv+AOqh7HPt10L5ye9KpCco112oCWa08ICZaUk9W6F35n?= =?us-ascii?Q?JsCSOKPSn2wR6cbG3kEYzVhq4rJ9v1gyIxxFfcWYxXRF7cTxMBza7DUpT08l?= =?us-ascii?Q?SGH+XqhT3IZ+1+bE59fYW6GG/bV3EqDEcaLfqnhyTczqAb9QjhFcILNlH20o?= =?us-ascii?Q?UKR33VbKXiPqR0QrDl5sDG8I20A9XFIm2tZS9K7UbsY+8OS+INS/nIrRPObf?= =?us-ascii?Q?NvKihNN/MTrcVqQNqspcUzYVZcKMdycDCfonFxRcSme/XRd80P8flT428Uhr?= =?us-ascii?Q?EQXOnBlziZhVuojlv5lWHxxAahshjOGw4gaQuT9u89kJWkLW4MfdFGtGisO9?= =?us-ascii?Q?Nl+YLZ0O1OvU7jy9h914QI5W3Is28jDUMN0cImHRSzYrr8BAXhlh03swjbnj?= =?us-ascii?Q?gC2/QgLweCHZXso6uyGY/Ntjg3ysA3pyoamYJrlNXfJSXEzlSNpeqfqTivhX?= =?us-ascii?Q?GGGwkJ+s4XK31xr++gJjMEVIlyAxYzN3zT2dlJlQDahf4xzLR0hbzebzLrDL?= =?us-ascii?Q?d2vcDG3Orha0gUbbUMCGXvchkK1KTixtIQec6cCJWvfF1OG3UzL6BHXB5q77?= =?us-ascii?Q?bz0a1Ezi1yEimRhasjNLcce/RYlSfZOnVvQBt0AmAjoMDcjXfPZwJTNV8zdw?= =?us-ascii?Q?oGnfLDpIU1jy09M1R+MTaV+cwPuIFjGC4kGfiJFYyDNherJ7KhkG26i8mgs4?= =?us-ascii?Q?vps0zPSjcscn9ZZbVDjMfkhvFx3c69bFIDq/LCubhUVTWGg/SRBgQu32OfOQ?= =?us-ascii?Q?2EmCg7ZHtg+FMjAlkq45TID4y6T/SAJcHnxxGibjvE/nY0br+iyhaok4eoAw?= =?us-ascii?Q?w8F/FrBd4tdeUfLZ6Wie0v9Ku/kjFL7S50IXI8gOkIqoE1gwVtlqB8eUM2h8?= =?us-ascii?Q?rAhgs0nC2WBNvGKPGHHWz0h7mASnBNgpUbcMJ57+aAhOuNWCfdppBXXi0Acu?= =?us-ascii?Q?nvVc7wM35H4654wmgwViaeJ0i18ACiwn3OSxIcia/e9pmtMKUewmJwk0EDdl?= =?us-ascii?Q?fHl0pAfE+Gybk10wqASy99Wew1YEtEpLAm5mcMy4XHzi5hT3gG5rZUvYKTdM?= =?us-ascii?Q?iRy0ZMA3DzdyzAwU46HfSBF4m3SZYM+ZhxLZu0QyfcpLyDclX7osYPKp7lvM?= =?us-ascii?Q?KzUx9onUm98PwZ14/2+Q5SFp6mfTaorcH+f7FGImVUIumGosgVmM9IbjuWq9?= =?us-ascii?Q?nVgMN8p6Gy/dc67/im/SgzMdkQsAlAo8Ya8GLMZxnafld9NcxT7Sg3u3NeAY?= =?us-ascii?Q?UqfdsWNuQFCoq8DrOxns1GwZCBj43tcdDO9kYh71l3cHCApfuctt+0tY4MI/?= =?us-ascii?Q?iBNrLwsZloXmk+nOEYbXYS0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f06bf4c5-2b57-47b2-e1b8-08d9d1a71c2a X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2022 06:29:51.0159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rm6EKf6JnEs/1jes5nTF+mWi2joZrZ0BOmFFtjVz5gE6e+llmQoV7KlYO0I6CCWOVu4Nisy/wR8h3dQVpVFTOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5045 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, >=20 > > +#define FW_CFG_NX_STACK_ITEM "opt/ovmf/PcdSetNxForStack" >=20 > Why this is needed? >=20 > > +// > > +// Values we program into the PM base address registers // > > +#define PIIX4_PMBA_VALUE 0xB000 > > +#define ICH9_PMBASE_VALUE 0x0600 >=20 > They are in OvmfPkg/Include/OvmfPlatforms.h, no need to copy them over. >=20 > > +VOID > > +PciExBarInitialization ( >=20 > > +VOID > > +MiscInitialization ( >=20 > Cut+Paste from PlatformPei >=20 > Please refactor the code (move the functions needed to a Library?) so we > don't have multiple copies of the setup code. >=20 As we're discussing the PlatformInitLib (which wraps the functions in Platf= ormPei), SecPlatformLibQemuTdx is deprecated. Thanks Min