From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.8784.1644309784926120872 for ; Tue, 08 Feb 2022 00:43:05 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=SjKKhE9d; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644309784; x=1675845784; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lgfELVzYVwgM6VbG3RfB7NEbk+TrnNV63pEM8aC22Z8=; b=SjKKhE9dqcYhk4pcuR53Xb890+uexVVLIS/Tt6sLmiXsiZv8Z4jMCgGX PjrKrbIUElz7qnhXZB+77ZE3nzIJSiQPfvL3O5OAtG9JeGzEww/fw7u0y RRAIZ6mPi4WhdRKh++PoOgdSMrdC/R4WGmQbbbnR9GIQwPIsssZCKt3wP GH+8RCJRzoJ4qc/vGxOBOFlm9+VJKDq8NfpySMgveD9aFJr64rDoPkz1G lYaZwPYKIF3CC7qMgtJZJPKhYCDV1n2OMGlzTLsVi5N8ahzX4gbTXl0bT +HrAsVoD1ewln/kn6rXDhogaD1gwi5bmzbz7VMisjEYxqocd8lFqFlMyd g==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="335305353" X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="335305353" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 00:43:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="773064025" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 08 Feb 2022 00:43:04 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 00:43:03 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 00:43:03 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 00:43:03 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 00:43:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c69Wu0BDerxG2q8sNs315tcj0FEAba57gqo63MxhR5Noah42Z4u4DMNVflNMultxjQNRc5XVPtFRJvkojwx2hq0SXazd8WV3Zkqv/I8SuBRL+u+c/tVmnDtoVwOV7B+BPdcm1553j30EX8e9CaQ6zSV1yfVYnF7q5cMk2Cn89nGlI+yM9KYi58WNn9jF+YTbWHwRPdaMR3ugFyBttsfAm5yHaTSJu2NKslGwlT2TngvW4AYsS/piOfo4W52HJe7Hu0nFfys/TVe/8jydWg1pLuGJ2UZlnLooCnhvM8Z7r1cdzuqPmv+7L99XHUWyDiyqnx/WyvHVfrjITzJytMatcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EjNnn11rdC5HjZuMcOGvzzQmeqyIOT/e8ieOsPJwHTo=; b=g2Dre/2HfkClHgzfjY7u4vCgqQUeQ/Bx+wZ2TyIA9jxCAeigHLeqMRpbrbOJasSTeKmrrgsX+XJ6sS7C4YDB1iI6+OlA+8xWgB+L3eiQOmiP+Y2ryBGuSz/1wqYzr5n8Ob7K05ONdoTMwTqtJzat2JsOHcgUGeCLsGU15ejdW1nRcRm6Bzmt8HmUNX1isgU95ObHC0Tg/r9A1RwdgrIFyRAtQpo0pylWuNwPqBZvigvys6mJf+9j9V0kr22nazjKw7FcRSDOJxBUY7jualQe7E1IOjSIeg0qYHW83fhhcEyacFT7a6hAFtBw/r7FpZINFt7a0YGg4/V4/Z0CL3fH3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by DM4PR11MB5374.namprd11.prod.outlook.com (2603:10b6:5:395::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 08:43:01 +0000 Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::98f5:edb6:aee6:6886%5]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 08:43:01 +0000 From: "Min Xu" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Kinney, Michael D" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [PATCH V2 07/10] OvmfPkg/IntelTdx: Add Sec to bring up both Legacy and Tdx guest Thread-Topic: [PATCH V2 07/10] OvmfPkg/IntelTdx: Add Sec to bring up both Legacy and Tdx guest Thread-Index: AQHYEbXRHCR2Nyxp0UOkbDZxROCOsqx24+wAgBKICaA= Date: Tue, 8 Feb 2022 08:43:01 +0000 Message-ID: References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-8-min.m.xu@intel.com> <20220127134206.hfg2mbvwtzi32fk7@sirius.home.kraxel.org> In-Reply-To: <20220127134206.hfg2mbvwtzi32fk7@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 850391cd-f98f-4bf9-5c89-08d9eadf0439 x-ms-traffictypediagnostic: DM4PR11MB5374:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hG3m2cjdX/CQ6diBoxwp5h2OIA/YcmvhbhKeqq6XwzVALVZKhh7QwUz4fFkWSubVlRXs8K0fTIWB2XKGmwu6ZhhEXZTkDq4wIYTAp0r7HZ09LMmb90mEd2VHLMOKdiK1l3F3hM6dy29xa8vyVR2K99WEzjTmbYtwXiWHGwRobH71seuiwXSPIQFjzaULhFvaOiAh7bhtjjof3AwjOwt1WMW/7b29Z1Z7I5cBe1u+y4n34zVTpoJcVeYcGLFZtXO2ToE8/sO7+0skFcZZJ0XtQB/JDGcnms6Tb+vhpWXZZxLkc4787ZHBnpJAYW1denlyZsJkV68RMQ351+a2iLEegGbfl3wfGEcpgbgTPwHE46YbXIh+hM0F4e8vL111JkyrKOWjDvhKYj8XMdMXQilxhZzWN0DOkDDpYdyA76HhD4tpNOKcOjQxXTeXLO2DeUlGMzQRY520KOYRXL81Ccm9uuyzy7FHJ3sBKQIHb2c4lEUOOUEtzyYkILeZ7Ef3Ojs7VSLp8wu/jzt/ZCrumC31yn3apQHvjRyoJR0PW3+cgtQngaHxVpEe+NrGMNuwCuXVrLRBaud0WROwf+upUY+R3wCyB7fd1wROufm6ZMao9+bEZgwrDQTy7HWDi7C2M6bHlKTuJQyNtmNPDxgTdibZspth7kx/xqcTPpUxpqrvQSM2Go+Ti0JVzRqYAx5zZ2g9a9l0V2yTa7PML8rxJYxbiBWR4jsI/1hYB3VcydfWPPUUU/ZaT88fkHxW/Js39BcA0QlWLyLcSAUUMmXJ03aIaGhAXMoxCZeTJF03sz8VI2A= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5064.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(55016003)(186003)(83380400001)(316002)(54906003)(966005)(6916009)(508600001)(122000001)(38100700002)(82960400001)(6506007)(8936002)(7696005)(66946007)(8676002)(4326008)(66446008)(66476007)(66556008)(64756008)(33656002)(4744005)(5660300002)(26005)(2906002)(71200400001)(38070700005)(9686003)(76116006)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eCs9QkAceZUGaUvY8jrrZZZWnDF3/4RXx5v8EUlLIYDZLwXp7EsDocMpExph?= =?us-ascii?Q?StRx5T7W2k8hrYqnMaia46lwFBo75BfV35etqbv65JqNC99BlheKPSfzr6Nl?= =?us-ascii?Q?4lztAzi1tn/72aPTrhQVBLD8qDF5QOxqY5hUS+XzB0a9rwGvWtZ83icmXGQg?= =?us-ascii?Q?l6Q00ICciOj4k0XKEFPVBiDb/WY5CESyw6UtwXTj5Y1rXBMGd7v9bHlNiZBj?= =?us-ascii?Q?jsN8o7Zd6iCr81zx/FvoD5f0BAbUx4HU9L1JuFyV85O9phpASqWTFl7ajkbI?= =?us-ascii?Q?kIuFsKjaImf28xtgjMQJLq8LYWXEkTjPYx+ZOHon7+qrcVb7PajOaSqsXMZ1?= =?us-ascii?Q?ooWyNVMo14LTUyX+m5j6RWNfrBdUyhDrfa1WkUSaLCb7aFSKMfBVdIZwvfdI?= =?us-ascii?Q?a7wno5Qqorv7Ehu4/W/R5YBEGX6JuvcqjVGT9YP9eOm51CQyQAYMgdAJoaHB?= =?us-ascii?Q?RyT1wIdy1LDtHwA6X3P3e3unN5FeUSvWXr3oo+J7SYYWHZn5oFaEOt+2Ri8r?= =?us-ascii?Q?tEbg42RC9jsVXMosUxlt8xVtbQ6/t5L9+/a5MzLKV7B4NcbN7q4xFywNVBNO?= =?us-ascii?Q?Dh4LRZyxYpqWsSF3oFZm9z/XZjs5MqlImDhlSHV6gHdI0x5Zw/4pBtTsNj8R?= =?us-ascii?Q?exMyXaHSobv15zXWuBQmmQmotb80uqbRJkmaUfxp+piK53MZQ2gSztiNNTdV?= =?us-ascii?Q?kjczoIDfbaK0XAQEW8yju59hwUvu0KVv6Bo952fabAbjPVIZHQquWammqjiU?= =?us-ascii?Q?d4hDzElfEfcq6SklDduk8Z27PBeRfhFisr1q4S77mTRAhrJSg7w2l7Bmazhb?= =?us-ascii?Q?ie7DGsDxR+R3fW+hvCqUZlbRA86xXCTqHQQsOjL6Z0hh8qIFY0Gdr7hIGeN+?= =?us-ascii?Q?mUFrJSx4GZKtLhYxwJQivN7drIGYB6G++4s1DE8qyEvKbpfx4fXNfinmzLd9?= =?us-ascii?Q?QyTohcmAr6UmzERZP255rfmormp14IdTPdDow0YQTurA8v8QXnpfp+SWjhOa?= =?us-ascii?Q?bATzXk4q4fwIRUkmQazfYTPz4dYQ4vmfKLenOxwo7HcLWQ3o1JKXvdxifym7?= =?us-ascii?Q?AGcdMwCokmze0nzKc6iketqoVGzpCuhom+Cl1qB2yJjU/5q1A/Zx1hzQiRvL?= =?us-ascii?Q?MGs08ckb+AT2QCaZCoXrwAnz/fW05VWjisfKXvAjpASikC5cRjPldkNYy6Kf?= =?us-ascii?Q?zq7V8aKkN999qN/DrnSisJY1lI8IAZuibrTgVlfjgLuI+5WeAz5zOKUVYOpw?= =?us-ascii?Q?X71+HC60MvPJwzzk7M9QYKquEp7mFG+owBUPLxg6BdB6cRnw4+0lhw54VnuA?= =?us-ascii?Q?kHjJVx77dgHh4zNZxjI7oe5jt142Y8+lp6EO16jAQNi+8v/3r4M3/y+9Biqh?= =?us-ascii?Q?+FrukrWf6jeOyltAYH4nMHtwCMqjY2J7bCaq27g5yldRGe8FsNUzYB9TaWfS?= =?us-ascii?Q?kWo8BAtwgNPpcOspxvwcLwwzu1J3EpUe3wf2l4RMUfP/00hF9KoHGKrfmBal?= =?us-ascii?Q?zOL/6JW8t3O32FgmbkVMkrPWBM6/+0L07qUjoEyLpqWqgTtUnDn0vu0hc5Tw?= =?us-ascii?Q?Jg8bV4URvGEZG/KB2AzmGDdyzEjgbZsTmDpPTRzCVhqYbyOeayIE2VtOQ2zY?= =?us-ascii?Q?Q2b4KQZfkpjg8CoNEzPZ12w=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 850391cd-f98f-4bf9-5c89-08d9eadf0439 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 08:43:01.8173 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b5YBL/8iiBls7jJ7sWAGg515AlD5wnqSNKsfG7DKo/0PgubeYKRzNyoE/CpzFK8+PZ6YP6aoj7wA6Q39VKUSMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5374 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On January 27, 2022 9:42 PM, Gerd Hoffmann wrote: > On Tue, Jan 25, 2022 at 02:33:15PM +0800, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 > > > > OvmfPkg/IntelTdx/Sec is a simplied version of OvmfPkg/Sec. There are > > below differences between these 2 Sec > > - IntelTdx/Sec only supports Legacy guest and Tdx guest. > > - IntelTdx/Sec calls TdxStartup () to jump from SEC to DXE directly. > > - IntelTdx/Sec only supports X64. > > - IntelTdx/Sec uses MemoryAllocationLib / HobLib / PrePiLib in > > EmbeddedPkg. >=20 > Quite some code duplication here ... >=20 > > +BspAcceptMemoryResourceRange ( >=20 > > +ValidateHobList ( >=20 > ... and possibly more. >=20 > I think these functions should move to the new PlatformInitLib too. Ok. These functions will be moved to PlatformInitLib in the new version. Thanks Min