From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B82BE74003A for ; Tue, 20 Feb 2024 06:27:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=n2ePslEQhhbtNjGhmSTTdElB3flPczOxjIemzQN8aJM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708410447; v=1; b=gCtJ5o/CEoikJ9cbS4/kjUFhtlqs7Z2G2SjVOLSa5vKyO0fYQhHKHGhrEC/1rouo2nHHYBTH WDGko+UBiEu7ku37FQZzB0+F51iohsWzR8aEqZlmuw+s5cHj9lLfmC1u8qMswcONzNZUvlSQfjs rc6Veg0q3nn5NPZr7W1GHCOw= X-Received: by 127.0.0.2 with SMTP id CBOLYY7687511xhVgCg5JWjI; Mon, 19 Feb 2024 22:27:27 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web10.7954.1708410446132978451 for ; Mon, 19 Feb 2024 22:27:26 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="13206740" X-IronPort-AV: E=Sophos;i="6.06,172,1705392000"; d="scan'208";a="13206740" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 22:27:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936402588" X-IronPort-AV: E=Sophos;i="6.06,172,1705392000"; d="scan'208";a="936402588" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Feb 2024 22:27:25 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 19 Feb 2024 22:27:24 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 19 Feb 2024 22:27:24 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 19 Feb 2024 22:27:24 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 19 Feb 2024 22:27:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SPx0ZjfwreGEz2hOKv1DI0a5YDRs7St/C2IppiBi8QWJAo+O2YQiVEgSSMUdLtee0je4L7ER0is3BYp5TgchoiHQ6M7L46dkWGNhuFB6IWzcsEcBpZrC6CMWj+R/rf60a2sYbcwKAWGgm38C6JdDcRLsxfNfpHuQFwKboYDLnkONUDvp6Z02oHZsS3PENvySwp0KySXh68YGKEhMKyrhL0ul6jrARRfZ50lVFEtOJYrqoGF1lVifckNW04kuo9wZS/eu2UJ8Ass6gG8ABJXj+6bAz5WCqgsPSYJYRQ1rH5gRUaon3TejZY5J5JUTdm02qOVr0DXap9AumBAwLGPaWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s2EDSO+9G3tW8kIvHfIXHghe/rlwwmep+nd/UR3J/G8=; b=bFMpOImuYG6vGAqvqfhplwI3DN7xcGR1/0GRtj9vlU4wALlKRxGUiPI0j4pp8Y26H/OTvH87c+Chp6mrdKK5Hai4/0QsIHxub5LMhZm0ES5j82y6rC13O6QPzs5YO89CCWmOHrOCbqXIpSu9xkjrbZp6doaKJjMKFuoyCYSHUNfaH/KjumAPIUGgNRgaz0DhQVU9WJrHS8ViJTrh3tpWxTtdEQqdLhTRawF8J96tIVMM6vGvW1poG6GcfDqpdFuKm8pKRNNy4dZMG8XVEePzTNn46L9PNGxbJjbYYxOrXR9xXm50RvWasrTPeP3o2sd8cnHSnpX+IG2uNJYbDeLWww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH0PR11MB5064.namprd11.prod.outlook.com (2603:10b6:510:3b::15) by PH7PR11MB7002.namprd11.prod.outlook.com (2603:10b6:510:209::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.35; Tue, 20 Feb 2024 06:27:21 +0000 X-Received: from PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::e526:b83e:9ee1:c862]) by PH0PR11MB5064.namprd11.prod.outlook.com ([fe80::e526:b83e:9ee1:c862%5]) with mapi id 15.20.7292.036; Tue, 20 Feb 2024 06:27:21 +0000 From: "Min Xu" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: "lersek@redhat.com" , Michael Roth , Oliver Steffen , "Yao, Jiewen" , Tom Lendacky , "Ard Biesheuvel" , "Aktas, Erdem" , "Sun, Yi Y" , "Huang, Jiaqing" , "Xu, Min M" Subject: Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process. Thread-Topic: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process. Thread-Index: AQHaXcdM90v1Z3Bn7kKeBTMSfTU6DbESzvCw Date: Tue, 20 Feb 2024 06:27:21 +0000 Message-ID: References: <20240130130441.772484-1-kraxel@redhat.com> <20240130130441.772484-2-kraxel@redhat.com> <7b3177f0-9696-07e1-ad0e-040d5392b067@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5064:EE_|PH7PR11MB7002:EE_ x-ms-office365-filtering-correlation-id: d1f4c093-172a-42d5-aea4-08dc31dcfeb8 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: /fom2eDoiLUSqQru135/AZjfxaIbuFNWGEu+53ozfL2qq/Nd/amZWBtkCKDHxJruDZMTiwgXwtZwkpWQQdhi4Fr7III83dFA7Of5c3C8MkDPk5ei4+gPTFb7AZCEHtaeEC8zgM2iJOvTOT0mEx4Dpryyz//m2zrW68+K62m5ZlQZwoMnfsM79r61sSheClT370yD/aYNn4kzrvKfcWL+VdXeUafd8yJI+2So3ynot2hRTr7bT4Q1/+uA2YCSlP2XYd4CBGzW6CurRed4GqDneemrukmjlyN2CHWXqC017VeWZpiEz65PwbnAE2jpTWAs4k1GBBPDLVIiA8WZzbBw0ZVEme4HaM7sZIxyySVigKwbeQwyHTrvlnLXPsINrvVQak+j/k45CbwTur17rnOvwAgq4QVD7PL8UEF/+figYFmA4kmJZwmQUQEYMfmLWafOdBqGSZtmDiOzw4BvN1LvQZW4U0mL9kazK4MIKn+B8ox9wt11WWeVYSVgYG5Ns3otFD3ooCOvs4azWsacnY1B0B9pdFJkr4dlZsuGPkYAbNDuXJBrpe22ELkjqmPreRpUooHUlFiX0B6anJhoaJpV3JX5Jepnw0wmvZI0tyi0PyicW+Exs/RgbDjuZAF/YGEF x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pubnkPdU+EGVsbpSNEmibF6z10Ej8DEj+Xh8iMbfnKjMHhiK7pch94nn2tUZ?= =?us-ascii?Q?YgT55tY4WMkNFat6xljNI/NBcxmgbYW2hPYao7P/BDWPfN76v+AsA4Z/1XAs?= =?us-ascii?Q?a7Fci7nkZ/fie+KugfsqvNDKHs4e5919XGyrNuP+6o7tEILKL5MS2aD7yBRg?= =?us-ascii?Q?v827R8/u7Deq0Sh88PQ5enrns8O8UumQXZT1oVo26FHAY2tKJIaJhTYCo2B8?= =?us-ascii?Q?iJpNBQiktCwNIflQP3qsZxgkeYIx+kStDL56wWrp5RqlLA+gdEbCCfti1MjF?= =?us-ascii?Q?+rfBXnSNgcjt4iwfjrMeyC552s2Is/1OV71c2hrONj4i3pE8aq4YplVo/hey?= =?us-ascii?Q?Dfsiook4IbxSICE5LWXffPpMm1ZLDw4RxvqQNhgKvDL+gP/gbG2TYTJ2rwkT?= =?us-ascii?Q?PU+W/XMq95u78VxBYtGOeaUkJCZOzPjENSOuru7v6i/Q/+dYJs+SKelmQPgX?= =?us-ascii?Q?KYkaFpOg9UnocyThsyAOJF5nz0j2Pks7570XEYv2zrq9AmCyUIxS23KI95iT?= =?us-ascii?Q?BIfvAmgQflpHXoQygjA5dRMnz4ZocHfMfK26yic8IddkiC5wqDA5dW8NdD7H?= =?us-ascii?Q?NGi7WXAzWoAlyamC2rjw2qTsF01CyLJEeROvbJ5zHnbanlP9nYibulBYKuUC?= =?us-ascii?Q?v207DoIp+1cnKLaY6KtdQfbZs5mFfiZwUIccNhrehdRx1iHPNiLjY0TWQXTD?= =?us-ascii?Q?+ivKUbhwmTwVJqA0wfexvCyzbZ8ECd6zlyuE0oJZwUGjeT/LGA8LJZ1Gpgfx?= =?us-ascii?Q?UAPE0lIRvVVXyHdHB8DmbZeGmg/N5Kra/bily6sBy9DyvNKvwkHhqTJlwTUg?= =?us-ascii?Q?UCIVpWzRgv0FvDTvEiQv6aDtdVJrZZ7trDJBv19FVPN9+ie3PWpU+5rAI/73?= =?us-ascii?Q?3yZZOOBeUk0MT9Tu7888HJz7bG9iZBZqBR9Scb46kJ6hEGzKmwgDZSic4G7C?= =?us-ascii?Q?mautV/Wjbmlks7OGkhsGT+gi659kMq3IhHdyDF8qNOKDhfK+0+77ihruJtBc?= =?us-ascii?Q?XQbDmJ8NgmyzYWkPZpbCKqvjriUa3QfGOQpXD1s/a4c85ILaeezKZpOy2owy?= =?us-ascii?Q?vzKLqgEbVQ9UtlcomKt+vXZtE8Y5g3WvzJbUAVws6gw1gN588mAEaUA1/uGh?= =?us-ascii?Q?AOR6BzGeG6SGPPyHozRMp9YevT9BuSxlP3els4kz6iJgzwaLSjfzofe8+MVH?= =?us-ascii?Q?zB99LcaUcDgsu+OTXL9dqqQY7Yz+ZybjBJsyUjF3BUYRPUxXOFSwra/2JtnU?= =?us-ascii?Q?ewq+kHjT4aFJjMpIQv6fxJCSaO6v9b2g5HmHVgTZEkXjkXMGp/U48NtiVB6+?= =?us-ascii?Q?33qw7bA0Dpv2jP5a3LKfGUUhJQ7RrIfbxL+hLHLhwGuu7fDYb119oZTJHlvA?= =?us-ascii?Q?sAh+cn8cPlIvVFfag0yHoTg94Flv0or0B0TaG9pQgcLpDN68vAA7HZhtthFq?= =?us-ascii?Q?hvwTtRTprc1o4h3XoBaihc1Fios6BX8ui3VjbyungBPoiiCGolRgyyWcxOSq?= =?us-ascii?Q?sD/NBAnMhqjXD91R4KSkKJcuxYj24g1lOUQ7RkXT1+5dJRhtBzyzLcdjSe10?= =?us-ascii?Q?GCa8diSQoO3qVLhSJy7K6rcSap9wLn1ISCqKr+IP?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5064.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1f4c093-172a-42d5-aea4-08dc31dcfeb8 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2024 06:27:21.5647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v8Pmqcyc3g29DR3e6rIhTze9RH2r1UfCU64XwAlbWVoBrvv8OKVr4EiyNcVf/zqAZerUNeE5qSustxIl9bL9TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7002 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,min.m.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ECC2UUzxweV2p2nBTtQVLaQvx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="gCtJ5o/C"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") On Monday, February 12, 2024 11:22 PM, Gerd Hoffmann wrote: > On Thu, Feb 01, 2024 at 10:38:43AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > Can you confirm (a) this patch is OK for > > > > "OvmfPkg/IntelTdx/Sec/SecMain.c", and (b) this series fixes the slo= wdown > you had encountered? > > > > > > > > (that's what's left before we can merge this series) > > > > > > > We test the patch in TDX and find EXIT_REASON_CR_ACCESS is triggered = in > DXE phase. > > > > Hmm. Sure this caused by this patch series? For the PEI-less TDX > > build this series moves the MTRR setup to a different place in SEC. > > Once the DXE phase started the MTRR configuration should be identical > > with and without this patch series, and the series also doesn't touch > > any control register. >=20 > Ping. Can you double-check please? Our QE ran a test build with this se= ries > applied through regression testing (including TDX) and has not found any > issues. We double check the patch-set (v3) for both OvmfPkgX64 and IntelTdx. It tri= ggered EXIT_REASON_CR_ACCESS in DXE phase when launching a td-guest. @Gerd, what's the qemu command and test environment your QE run the case? W= e'd like run it in our side. Thanks Min -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115624): https://edk2.groups.io/g/devel/message/115624 Mute This Topic: https://groups.io/mt/104052591/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-