From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.32112.1634529462880076443 for ; Sun, 17 Oct 2021 20:57:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=QbFZdUhc; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ianx.kuo@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10140"; a="228438380" X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="228438380" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2021 20:57:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="549798573" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 17 Oct 2021 20:57:40 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 17 Oct 2021 20:57:40 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 17 Oct 2021 20:57:40 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sun, 17 Oct 2021 20:57:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DgfygIkQejj4Y/wjmz4y7Y4PKofjKrujueg6Pu9jLxQs7v2BsgWSg5XxPZye/yl++gUhi2lgGvCA0X1v0HBwsbA0n3Y88DEWiOiqyHFXWYYKkK1X266cuW8UXr9O0VeM1dGPoVeyqadNlA6iEyWSrXYgfmWApAwIOklmjM2kFQYt1K+XmVWTvlsspfADT+BdyM0i/sjuT7i9zEOvasVt7fbp5SfCRE9yv23iHoUGFI9Ny+0WMCMVTOqzTT0mhZMesMNh02MQpL3xE+k8imUlu7WKvcKVT72i4ZHKG9I8yD2HgEDKNU202sCzXaVdmltm2j8FvREYt3AczZsU22vedA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TPDu9ERYiHk/HtGMBVvlzuUF8/4PjBmogqoz8juwInI=; b=fb/R8L1xIHr0fR3kRxaXwVwb+S+hTg63H0zklcWGsb99PtKkU6CUQ+gDS6dvruMabKlEzjkZQ+hjvGL8J131is6LADUHF+7nxSwQ8TvHV1BODYTLpgR/B7w81hiUOfZfW3+61prqK25kXEtECcqeb6CnOOrW82sJr37ta6X4dvUDbHhvJJUCpbDagDmaRoWFnG6ClxYcy+3lne6lMeAsFwl4OnD413jQ8+Zo0suxx9yNnf1WERdiBu38dxN2wSGxV4as+kbRiPZyNGYpOpUISOzSzgWU4lage51mIoVrXVHzs0Y+SES9VCNQAEHumN+EsfS+Z0lxDhSky5ttpgF/Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TPDu9ERYiHk/HtGMBVvlzuUF8/4PjBmogqoz8juwInI=; b=QbFZdUhcSbEL6ZVeVzcV6MfOz9qirDXauXcksXULHElpQggaJkxBfutWG3hbY9uYA/k5iLbSNugYswMdE4KDA7BP5so5eY01zqFtkxXSfwCzvU4jK+qEoY6Ur79AempDQJLBV6BcJe5HzRC7PMh6aHuDk/QSa+pfStioPcSZhyA= Received: from PH0PR11MB5174.namprd11.prod.outlook.com (2603:10b6:510:3b::12) by PH0PR11MB4936.namprd11.prod.outlook.com (2603:10b6:510:42::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct 2021 03:57:38 +0000 Received: from PH0PR11MB5174.namprd11.prod.outlook.com ([fe80::4435:90ac:24fe:b6a6]) by PH0PR11MB5174.namprd11.prod.outlook.com ([fe80::4435:90ac:24fe:b6a6%6]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 03:57:38 +0000 From: "IanX Kuo" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Chan, Amy" , "Dong, Eric" , "Kumar, Rahul1" Subject: Re: [PATCH v3 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib Thread-Topic: [PATCH v3 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib Thread-Index: AQHXwt37hwsj4GxIUEWanESZzXNRoKvYHo0AgAADDvA= Date: Mon, 18 Oct 2021 03:57:38 +0000 Message-ID: References: <20211016223406.935-1-ianx.kuo@intel.com> <20211016223406.935-4-ianx.kuo@intel.com> In-Reply-To: Accept-Language: en-AS, zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 769ab4dc-07f2-452b-fbe4-08d991eb6d32 x-ms-traffictypediagnostic: PH0PR11MB4936: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GhW+p2HLqJTipUNmujRPFvd9+wft4VbQrd5Ywf/+BArvhjteM2kv6WJ1TiAd+iCHXoORKkw48WQ+3szI00K1NAmAaW3wq3vb7XRF4MAg99/ulY9e5sKYu5WyzhGYyYa3VMPZa3DcPZQ3DuI9K251l5N04dW9nr4zNC63lhrQcjx88W7i8o0CSUJIJrHMZKXDKizqlOlS0wEEIup944/609079KjXBWp5EznOKm/HGEaPB5XCzePl4qCrsnp2IeCGmf53sl6JxZa1gU/BjZettB7FbQeGKUwL/I9GT+SE6fCairITZAnSjp2qI649hOjbriV39qEESsh8F8NF+Dmn0nu9m/t8qZ32Da3sMlMC4DJO62itWvFyf8y+xX2j2BR+tAcKHUF71OR1DYEs2+uqE+krw25GFivutdSY53HFHeH9SOtxjnbsySkXgzQ7eHtAzwaRQpbWdU2uIlOLGqRDSbShmk7z0wlICkmtknrtsP+5fKG6ySsFyegE6K/yURmppaHWyDCJLcfiiDwtha27c3htIRm7FoRnPGeJ/4Lf55p0909X2MyHwyQork9jfiQWLJE9Y5wCdRzzJSx7CUKdd1eDNQnyu5gf5oinTfyveiwjOY83rngJmi0U0Oso7fZ0LtL0loAicSyvQUG1+pqWn4ZxrYqY29wLhrhIPHcxn+c1iqWWZgiYNYVmMC98M2O2hZ9AfHPCl0ytSE8ryRVTwQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5174.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(110136005)(8676002)(5660300002)(107886003)(122000001)(52536014)(9686003)(66446008)(66476007)(66556008)(316002)(71200400001)(54906003)(64756008)(66946007)(53546011)(55016002)(7696005)(38100700002)(33656002)(508600001)(8936002)(4326008)(26005)(186003)(76116006)(83380400001)(38070700005)(86362001)(82960400001)(6506007)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h13K+JYlqdltHt2/mU7o9pJezggSxdmaFMDSjpPHKOhNDvnxXA0LUhkvFQZL?= =?us-ascii?Q?uRbGaI0hNMtCKcu0lDTQy1k8zQgENe3Zy7bFWjdC5AInt4M10dlSZAL3mOhz?= =?us-ascii?Q?zeY4ggLrQ/Bhf72WQEO+zJhXhIgzQXnQ/IEeU4vPKbyBGIIozPeCK3KeiGCg?= =?us-ascii?Q?XnDHtW7oehxQDklHyBpZeP1zMB1MxQZ+qYNaobZv6ZRujr75aowq9gGC4nsH?= =?us-ascii?Q?Xsq3vL9mVanmTXmitGczgc0n3w8bk/mH6SF5Vb9aurBekLNneS7WO74w3yw4?= =?us-ascii?Q?A3M6ZxVv3DQ2vqBVrOehYzwNEKg9U29BW//4J+lfsXQn4CNI4/z/TOZfFHZc?= =?us-ascii?Q?RY/UWBr0r9MT7EC6wrXs5V8NMH7gsDspPOAMybxu8SMp4a968NYS5MHN/uq7?= =?us-ascii?Q?PkB+cK25Oa+YwqEpvtnjulCc7N7O6YxCbLgDuh1xXnF8yTQ3kiOhtmblOoAq?= =?us-ascii?Q?FUcJxV9Cqf9IuIIV0RRuLY1GIgSKPuyQnosDxb1Bm7Fj/ItVkDlkG5iyHNTr?= =?us-ascii?Q?LWDlo7a8s9EhrKT8vY4qsvTEf/h2zjsEhZV5BLDDyjRbjS5IRL8pzcCfJBd/?= =?us-ascii?Q?VHHNKtGwDDIKlrAqdXZnLIfJa8llu4URyId5U40Ap5M+aZnaZ+dWOAYTonkZ?= =?us-ascii?Q?HpLJC0+sHTtHc6WFcKxPBxf5lcG1Z1fH8GRpxO1DFcewZvLqH+IIlbzRykQw?= =?us-ascii?Q?xL8Qkcq/aWqnVL8GvKAcu5LmT9SHWHx5pGPPoKREpJOidIBGiu74VUEPOA+X?= =?us-ascii?Q?OIHDVGnrSqfCmq5jvRe3Sq3b2Ts5OiNriNo9WrhUyFsh0wJaGqBpnqtD3v3q?= =?us-ascii?Q?mH6qhi3Jnn/5fO387IwZ8ox9J8AD+IiEjgRU0fqxjbUKdlWKMSgJFHHC6FsW?= =?us-ascii?Q?HRMGeYsUVaTTFq/13964jZOSfbquiIoKsfzUjd88Tw3wqQQ5cKCZPxc2yrPC?= =?us-ascii?Q?KSMFMhN1KgKFNJ8N43T9HPW5pYTr0gQUWfrG2blXQ35FaV5BoS8Os68fD5aj?= =?us-ascii?Q?8LMEH4fXRbXq3/5+ITaIzdRqKreQrQLPNDCdJNB0H9TIlTU5R41OuDZ55nMa?= =?us-ascii?Q?kLJKKqpQ4nWYv/+kWbrSxLXtStjrcJGGlHd2lOvZ8HYONa44/vIeZ1lI1YHN?= =?us-ascii?Q?XoNTIL+rLEfZZl65j4MXbhJHOJ2DomykQLfw5S3SXv9uvlV9GOuGorjxk/f/?= =?us-ascii?Q?BZcf4p4tKL0KzIE31TYtxYToc9y87Urlh/1KsXYBUHocCs20atFMNXbh8dSr?= =?us-ascii?Q?JN6V+RQ+L1nHzBIs+UiGoTekVqMnYriK1TKpwX+VAjGvpDjaJxIYOomEgDou?= =?us-ascii?Q?orTQ7XEBff0t0zSe0M6NuYpF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5174.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 769ab4dc-07f2-452b-fbe4-08d991eb6d32 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 03:57:38.3711 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7bWLqvH5QqQpLGvu8mHkd6poP+/fFDOZR0yjXtWz09SXyoR/NHeP+HkVSR76qVr2cPnAeHsQomW+KK1+ERUNAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4936 Return-Path: ianx.kuo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the comment. It will be taken care by V5 patch. Thanks, Ian Kuo -----Original Message----- From: Ni, Ray =20 Sent: Monday, October 18, 2021 11:42 AM To: Kuo, IanX ; devel@edk2.groups.io Cc: Chan, Amy ; Dong, Eric ; Kumar= , Rahul1 Subject: RE: [PATCH v3 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort funct= ion on BaseLib Ian, Thanks for cleaning up the code to remove MdeModulePkg dependency. Minor comments below: UINTN NextIndex; + VOID *QuickSortBuffer; 1. Can you use local variable? "CPU_CACHE_INFO SortBuffer". - PerformQuickSort (LocalCacheInfo, LocalCacheInfoCount, sizeof (*LocalC= acheInfo), (SORT_COMPARE) CpuCacheInfoCompare); + QuickSortBuffer =3D AllocateZeroPool (sizeof (*LocalCacheInfo)); + if (QuickSortBuffer =3D=3D NULL) { + return EFI_OUT_OF_RESOURCES; + } 2. With #1 change, you can avoid "calling AllocateZeroPool() and checking p= ointer". + QuickSort (LocalCacheInfo, LocalCacheInfoCount, sizeof (*LocalCacheInf= o), CpuCacheInfoCompare, QuickSortBuffer); 3. Just pass "&SortBuffer" as the last parameter.