From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.17048.1664920501894697370 for ; Tue, 04 Oct 2022 14:55:02 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=muBM+aNf; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664920502; x=1696456502; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JA5z5erJyfdIDUkeWpIlVjWfufFvEeUJHvl9JOerkEw=; b=muBM+aNfE1L8h/zUYF8jqj0HN0Hid941+Y5qkPPU1zwo6xLN2FUXj1AQ kbyJAw53jM2qITk5fVkH1DsMXJi1wn3UkJxaP4lkxDrRmYXX1rCdiHq1B 94zz4AIMgIEHba2tCu+5yp6j97Y5V+C9c2+1Pz2jQVKkK3FAO/0fpStk4 fxr17BcJQ1lvcEdncSz6W8KgVv8UjvYCmK7SfoJ9UYD8SgA7yer1Va4cS Q01wJ3uAyPl0xWktx0qp1Uvifugk3AnFJLtJqhaL2CsL3IVehmVXb2MUr mBjyZiLyPmDxvQOGLcW2aKkfL2XdRCXpsMd+sk2a1/2bTxMWUnMoaXHj6 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="367152788" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="367152788" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 14:55:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="728420741" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="728420741" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 04 Oct 2022 14:55:00 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 4 Oct 2022 14:55:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 4 Oct 2022 14:54:59 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 4 Oct 2022 14:54:59 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 4 Oct 2022 14:54:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFNSAywrV2Zmm2C8qbRjD0mmyIruZCYlQRB42AlmHWREqrPufoZCxpDB64ceDiAinNiZFITHX4q5ZoQVffnEq9LtSM6EgYPqfnnRXV09l9R8iYqGEkDK9a4QVeKL47Ao6ahNon8VjvN1jC4kt2bvwblYlB3lXXjjHprjBYCBa+bggp23VvSqC4YRuEhdo3REMCnA3qR/mHqu+U+CHdMXhhDKegHIZB//ZE/5x8FnFeldMv44DUMuU0Spu1Mqu6OZ23PXGwiuHAbl+kbta7Fa347W/mu9tXorKh6OL4jdlhLvpPqMFr/KH/4nAvQNThanu8MxsFWeRWONxm1pnDVKfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aAsN+Xc6YfXVmKk5d3jwJANIO5OFrdKDPng0TBl+phw=; b=jVTyI1NXelfJ2CDOY8jxWumHxRkcGtk9/Oun304nAxebYoZiVRjWo7nWGtTWu5UQQM3fMwuZBCPiTgqBDMl9Km5ewnkNJwW5nEZvV7QFtnYOvExkEgSFPzwiTyIJU1dtErZOHiO4HP/SzplmUUJOJm//hE9wYdp2gSfqgdL4BkFUSuAvZsOYHPwa9gAoN38JtpudtZfmscuVAux6mlF4y830gLHZWoWmdUDdKrqT1VpmSiptlHQIfE7UbTgTHMSjws02YBwjV9xLHJsLRAWnvU8pyLkCYnVs2u0MNqzuHGyCLCQPyxAxWe6TB4ANRpndnzkkL4GH+0nMK283nfyrWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by PH8PR11MB6949.namprd11.prod.outlook.com (2603:10b6:510:227::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Tue, 4 Oct 2022 21:54:58 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::e9d1:3c1e:d9ed:57b2]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::e9d1:3c1e:d9ed:57b2%7]) with mapi id 15.20.5676.030; Tue, 4 Oct 2022 21:54:57 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Zeng, Star" Subject: Re: [PATCH] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib. Thread-Topic: [PATCH] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib. Thread-Index: AQHY2DCkK17Vbb+NzEy8Vc5tFBQOEq3+x2sg Date: Tue, 4 Oct 2022 21:54:57 +0000 Message-ID: References: <20221004203338.1355-1-chasel.chiu@intel.com> In-Reply-To: <20221004203338.1355-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|PH8PR11MB6949:EE_ x-ms-office365-filtering-correlation-id: 98207c2a-56d8-488c-5f80-08daa6531442 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T01iFfp78SHBTIhOYg7h/le7haEl++qC+nzxTk8p/WWfzr9XKeaP0Q9Q9HX+zfbXFJ/RayhWVgrpDtMm2Rx2AVeCamzoCRITJXf//N5oQMvwgjFgb1/aTcVVsXTg3703RPhLTQ+dVmOjDC8Xt+K8pwjR/WP+SkZcTuv6YCzyjsamL2i5ilMmOu0iQ7+AgSt1Ig6RxzYJ66Gt+znVc1PXtSTcg6cPEBeGcQBl4N9POFH1qyAFQchmKUd+JcaQq7oKmJCm3HakIwYaxTZ4R5p1x2N/t0HNJsYuVMYPMHpGJqbK3FFydyNK4oEf6G0jw+TFstHW2fkx+w/MCog5dXwYKApVAgWKRYhvxelQWto5upjkEn7JrE79RMWGYm3ZIq7Nb8XgKd8we9qaJn8W9jsaikDhQqO6KPOEB9clSMT6w5CdH7sxhhbz4OGNvAgjEFXWauZOWz0eVYa88tOGEXrlL3AqwdFdd3bqeovOnlGA2/Pa53A7azQieJlJruLcV1WndNp6SAXj2r1h5ZgzjpsISxwrqypBe2IwwRN78BPKMIxPIuMYMuGuFw7GtnQPJvEXrc1p2LDePjB3WQm39OMWA9Pf/Wuba8j+Fh3ozeL/qPKOlNPe5JVv9RPink6Ey5oBaPb+KfpViFZsGeIZfO+bgkqGbqyVnb5Y+NamrjfXMLzCdL1CnbVFoSqdkzbpRgFfiA+/NowfY+2sIDervXpl9vYnLqHUyAs2Wz9oH8ZVq2wegUXCntBdNZbvaiPWNAxBNfRbNMCeq1WJwBeIqI+wQB//qIktL3aXkulAoYRxYf4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5832.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(366004)(136003)(396003)(39860400002)(451199015)(66556008)(4326008)(8676002)(52536014)(66476007)(66946007)(66446008)(64756008)(33656002)(8936002)(38100700002)(76116006)(38070700005)(82960400001)(2906002)(122000001)(86362001)(5660300002)(9686003)(53546011)(26005)(6506007)(41300700001)(7696005)(186003)(71200400001)(107886003)(966005)(55016003)(478600001)(110136005)(19627235002)(316002)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CA6vgRogXuNBp85/nlIMt261Tio/RCjabTj8Dq9bk87B9jwJpg5wabRwe005?= =?us-ascii?Q?TcM1X9OwxLdk+7IUJ59023nt7qCD7KdIz7rzty62AQmZAEOAJyP1/wZgDiZN?= =?us-ascii?Q?f4bQMapA0L+fZub/VZDGpe80zbnKzPpHrPNFzDdkv3KXYCXtkzFjp0oJXQ6p?= =?us-ascii?Q?lblkSXN51Pt7lDkF4lD0k5mY0SwQXuid6zz2OVyn2JcmbdDxps5F4wx/0wK4?= =?us-ascii?Q?5RHwYavDW8txRcYa+2knaak+6PAH84KUmyjhVjBI6hFXQvr0nRTTrVhI/rc+?= =?us-ascii?Q?Hx3wIabEKdjIYuQDNv+eqJgoOOhmVCF08fokQykCt+E1EAzwCdOwNkQYJJ69?= =?us-ascii?Q?tFQPzRIcUDtaooPRy41x231M2owCa5L/vh4+g5KbXKEiiy8BZeeTC82Lrdfw?= =?us-ascii?Q?kCpMZ7IjMCPt0o0IpBUqj4Bgb5PUaLzWQFgMjZ7j7NRooeBAqq+3WbjhEqCN?= =?us-ascii?Q?liznGtbGnPh/2Pc/rQGt0XbUk37BABkoWPshG/CfI0oFtAs0j+t8iFAWukto?= =?us-ascii?Q?piG80+PuNNFBJ+wIO9jbEC1V9CFL0MfiTTjzCUXkFr96DVa0i5T7i35KOpQJ?= =?us-ascii?Q?gaT8iP9GOoz54cLlN0GqpsmBDiUpAfdrPV8mPYT7+Xp9nlSYjOckS3RIYelm?= =?us-ascii?Q?bcAabS5YyHj0FbDU8QUJTGb87FDRG9DFt1lP5bto71paKdatE7DOTpj45pMZ?= =?us-ascii?Q?oSNi1CsWqHhnBjN7cY31kCmWJW5SFfLRuujV4I6DWKxvXW8FkNwn9voIA74Q?= =?us-ascii?Q?u/uh7lPqj9Xshab/IMTaJ+Pe5gbYTOzZ9cuwkorj3CF8AZwCBC9HIWBJy+0y?= =?us-ascii?Q?gSTTWNaOvTFYUv/2GCSbdNEKhavu88QU9FEYOWg/jU3pV9DwGerLkso9GiRA?= =?us-ascii?Q?h4TkwKwENLZz0FvYtYk96XrQgxZGGHUMpZIXW4m0IEw/AVQ+OBjXdJ5MeAjK?= =?us-ascii?Q?+ylrULjGeZjBKjN7dUDgM7iLAdwR8MPwD5GTkP75LiAefFwi9lLCDBu6YFIL?= =?us-ascii?Q?oWxWCfj7PmR2WOKWtvSpJAOBghCT1nhTotYIZOp7QQ1PLXUaLPaN1tvKlKbz?= =?us-ascii?Q?PO8Xh1r3jg0ULZHQQ/+RXMi/0F4f5QKjySBugI8sPIgqxOjawjc1o8/VylOC?= =?us-ascii?Q?I7dwyO5lYT1M5OljbEtkoIPVpN6G27NgdsVCf5svfxc8Rajrkz3d+q3B0y5p?= =?us-ascii?Q?iPA+u0pA+XsClg3MWuJ8/LgNAtB1eiIC0CYXuC/SE5u3ffWPVl6EyjtAIi+8?= =?us-ascii?Q?Ndb2GB9DePhhPXY7ha3l68nephJheOYSJpdigu0gCSMUKhPJKHZNNpWYQxFK?= =?us-ascii?Q?k1PJdc5HD9Q6kklTctvAfHij8z5rWVA8MMOyTTCKZAZ8A97AKgrM4Z1/qHmK?= =?us-ascii?Q?w6OqpSQ/M8hZqWoqhSG/j745Pz6o2FKty9N+6HHE2d7792n9+D9Qd8FUr7EA?= =?us-ascii?Q?T7NtqsMBuTnRW4/JjvT7D5zUyaqCS+Zi7clYH3ttWVLwvB+pypfRp3no++y5?= =?us-ascii?Q?B9Ks/drl3vILpvH/cPSki3nGLFysQN9jZ7JHGqS6Bm2j9xf6AjrV0UO00/Ah?= =?us-ascii?Q?iGc/Ux2eowmOqI84iUtHGj2s/1D1fyDYMw+aOiAua2RPtkNTO3sg3B69ujjj?= =?us-ascii?Q?NQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98207c2a-56d8-488c-5f80-08daa6531442 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2022 21:54:57.8268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hN4uwLD2R7J2LOIrihUekoanVTBZmQqU5kcLLvmU9y+xPSJsVkVE42IZf21+pAl1qed29daA4bzQIHFhz4H2n3n7b1u0V7gXq8nJafpB7+o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6949 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Chiu, Chasel =20 Sent: Tuesday, October 4, 2022 1:34 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4092 To comply with coding style rule each library class should have its own hea= der even if it is just a private child library instance consumed by parent = public library in the same package. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMu= ltiPhaseProcessLib.c | 2 +- IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h = | 18 ------------------ IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h = | 30 ++++++++++++++++++++++++++++++ IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec = | 2 +- 4 files changed, 32 insertions(+), 20 deletions(-) diff --git a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/Pei= FspWrapperMultiPhaseProcessLib.c b/IntelFsp2WrapperPkg/Library/FspWrapperMu= ltiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c index 3ddc07690a..1248accf87 100644 --- a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrap= perMultiPhaseProcessLib.c +++ b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspW +++ rapperMultiPhaseProcessLib.c @@ -16,7 +16,7 @@ #include #include #include -#include += #include /** Execute 32-bit = FSP API entry code.diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrap= perMultiPhaseProcessLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperM= ultiPhaseProcessLib.h index 65a5db233f..aadacc9b50 100644 --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib +++ .h @@ -9,24 +9,6 @@ #ifndef __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__ #define __FSP_WRAPPER_MU= LTI_PHASE_PROCESS_LIB_H__ -/**- FSP Wrapper Platform MultiPhase Handler-- = @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FSP-= M completed)- @param[in] ComponentIndex - FSP Component which execut= ing MultiPhase initialization.- @param[in] PhaseIndex - Indicate= s current execution phase of FSP MultiPhase initialization.-- @retval EFI_= STATUS Always return EFI_SUCCESS--**/-VOID-EFIAPI-FspWrapperPlatform= MultiPhaseHandler (- IN OUT VOID **FspHobListPtr,- IN UINT8 Componen= tIndex,- IN UINT32 PhaseIndex- );- /** FSP Wrapper Variable Request = Handler diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatform= MultiPhaseLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMul= tiPhaseLib.h new file mode 100644 index 0000000000..79b5ba0ec3 --- /dev/null +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLi +++ b.h @@ -0,0 +1,30 @@ +/** @file+ Provide FSP wrapper Platform MultiPhase handling functions.++ = Copyright (c) 2022, Intel Corporation. All rights reserved.
+ SPDX-Lic= ense-Identifier: BSD-2-Clause-Patent++**/++#ifndef __FSP_WRAPPER_PLATFORM_M= ULTI_PHASE_PROCESS_LIB_H__+#define __FSP_WRAPPER_PLATFORM_MULTI_PHASE_PROCE= SS_LIB_H__++/**+ FSP Wrapper Platform MultiPhase Handler++ @param[in] Fsp= HobListPtr - Pointer to FSP HobList (valid after FSP-M completed)+ = @param[in] ComponentIndex - FSP Component which executing MultiPhase = initialization.+ @param[in] PhaseIndex - Indicates current execu= tion phase of FSP MultiPhase initialization.++ @retval EFI_STATUS A= lways return EFI_SUCCESS++**/+VOID+EFIAPI+FspWrapperPlatformMultiPhaseHandl= er (+ IN OUT VOID **FspHobListPtr,+ IN UINT8 ComponentIndex,+ IN UI= NT32 PhaseIndex+ );++#endifdiff --git a/IntelFsp2WrapperPkg/IntelFsp2Wr= apperPkg.dec b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec index 95ada0f7a1..922ccc063f 100644 --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec @@ -33,7 +33,7 @@ FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProce= ssLib.h ## @libraryclass Provide MultiPhase platform actions related f= unctions.- FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMulti= PhaseProcessLib.h+ FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrap= perPlatformMultiPhaseLib.h [Guids]--=20 2.35.0.windows.1