From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 60189D80144 for ; Thu, 9 May 2024 20:16:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6exkSs2sobGj5Ct9/keKUM1N1qgniicTfPOs0qdooug=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715285805; v=1; b=XqT7sb3jZKYFEy7ofl0YkxV0Yn/ghNvKO/WidfRA+p0C8EBW85AfovnWefzzuR3UdT3RgUw6 HqZALixrx93z7EGr64PrqzzJDXnWI7j5XoIKej+ylqF0Q+R4H5YKjAOZj5OvCzzamUvKkfdGAVI +qCablnZxfSQBNL08gLMb+ENDL7kCHA1/pfSO/5YX11Szkocdmm4K9vCn0pdQcMYChoUdEovMwT l5VpDXCwwxUSDk7IoQptMoW3Gzkrd/2CXnlLV2ih9v3ycn9MjhyCb15ttvAJsKQNvp9pWtIsXvA tr0IdFm2/vSG8R40xbecILKa186WQ6r+AmAPZiLKof/IQ== X-Received: by 127.0.0.2 with SMTP id f8N9YY7687511xNAS87oBWH5; Thu, 09 May 2024 13:16:45 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web11.1661.1715285799417699396 for ; Thu, 09 May 2024 13:16:39 -0700 X-CSE-ConnectionGUID: PZuooG50QlOi4NiBGNVD0A== X-CSE-MsgGUID: vqt8JyGNRRK6zqFfEexuBQ== X-IronPort-AV: E=McAfee;i="6600,9927,11068"; a="22641503" X-IronPort-AV: E=Sophos;i="6.08,148,1712646000"; d="scan'208";a="22641503" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 13:16:39 -0700 X-CSE-ConnectionGUID: ONfUNVSDT6ujLC0U9gdrxg== X-CSE-MsgGUID: UZ7V5UqfTLC8Tqk6yNSy2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,148,1712646000"; d="scan'208";a="60545572" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 May 2024 13:16:38 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 9 May 2024 13:16:38 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 9 May 2024 13:16:38 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 9 May 2024 13:16:38 -0700 X-Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by CH3PR11MB7795.namprd11.prod.outlook.com (2603:10b6:610:120::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.47; Thu, 9 May 2024 20:16:35 +0000 X-Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::c338:32f0:7c75:67d8]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::c338:32f0:7c75:67d8%7]) with mapi id 15.20.7544.046; Thu, 9 May 2024 20:16:35 +0000 From: "Nate DeSimone" To: Abdul Lateef Attar , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop Thread-Topic: [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop Thread-Index: AQHalL4CNUn+mBkEVUG57RS2Bn7U7rGPYcjw Date: Thu, 9 May 2024 20:16:35 +0000 Message-ID: References: <2c10c7f9d2f548cf05cb23639dffe7c6576412ac.1713794592.git.AbdulLateef.Attar@amd.com> In-Reply-To: <2c10c7f9d2f548cf05cb23639dffe7c6576412ac.1713794592.git.AbdulLateef.Attar@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|CH3PR11MB7795:EE_ x-ms-office365-filtering-correlation-id: aad9dc47-602f-4d46-3404-08dc7064ecd2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?5bCqLRHMh15+RiiPJd1ZpS9nGO1ixNcg3Fl03mG5D/sx2mZb97VU7ltFPVwA?= =?us-ascii?Q?/mAoNIzQg6yK43DLH9Dyo5NZvPErp0vUVvpwPAZigisi928sfVOdivBVn5fW?= =?us-ascii?Q?sCu0Hdq41mRNuWTgv8A6DiljXdYeSVhGdtuCXXByFhZb7CC28c/moh9vPW3O?= =?us-ascii?Q?QtCLc5f5uzpneYqXCjGqwoXgvUDTGnuB1PaKWtBzgLSorIwHAQpF4Bwd0NGm?= =?us-ascii?Q?+0TVYh50mnfF417/lUlJ3hRuS4/zlmYi3Y7flYjwqZhfDsVGePHbfU22u9C/?= =?us-ascii?Q?rlhH03/HQ2RIP6Mx9mS8dx7nr8aOpKjyGtv3T7AQhwrODax2pfo79KJzjeQf?= =?us-ascii?Q?w/J+VICzD44Kd+eMU/mzv7erJQy9/ydGN7/IkrZVcR0odWLIrjn2bI7lmIDb?= =?us-ascii?Q?jcSZMjcM1pReDDF9TjT37Z7CKztfBIZE8Jm4XipOPGKND5QXsgv88PMv5tQ0?= =?us-ascii?Q?vSvFSv2a5pf0c7zUIT4WlYBgJ9/kvRGxj58DD9oZq+r/P3+sV4fnyE9MtQHv?= =?us-ascii?Q?eznQRnZ2jI2HotKtTxodYSWnESBuurvVqWsw92+Rsyny/bVCHtjj7PkLlyUR?= =?us-ascii?Q?YTy39ddNxwIAwFvlnflJHIP4svwPOgJyc2aZWWARGSmDl/fb4BrLEmuvMS+j?= =?us-ascii?Q?m4ZPnqKJklsDTJh8MmGTf4xEPjdUVybS1JFIEOBBYMEOkVpNvdnAiq7lOm//?= =?us-ascii?Q?cwJ7BZWqDVDi5rdU+AHFKIOG7f2j25wkpRrmCPbFjMzk01kNrsGUYWZuiAcQ?= =?us-ascii?Q?Vx4ldQkIZuESk7CrFb2/5c8zJi3G/RcVbrfiMKQ7sLw8SJwQXBoLhe64wc0l?= =?us-ascii?Q?Sq5Glc+WmWx5lF2z18/fSMnAURB0fz6qj2NZGJ3KGFCuyXckM/YvOcY+sI4D?= =?us-ascii?Q?CGiasK9psIpsGDc0zW9Ol+2xDhIS9G+FXaoGlUhoqruwgsXGYaLAnm72/scY?= =?us-ascii?Q?Eeqw7E07fLwVkRWB2wMO8g/3FQH3WSnIEzGV5jgr3lbWc/N9wsfbrypmec52?= =?us-ascii?Q?EyzDGFrjfA7rHNo5OaEtYepLC6uZOpKnKIx6AUUCLbyu7rL2EpZf78puAKgD?= =?us-ascii?Q?02Sd7vSOnzzYa/9NoXFAGrfAeikt8sMnxXc4SRr7zFnMEKJ3xZpoIn5DqhFc?= =?us-ascii?Q?VYPtgwIOIp/mzpJNMAD6EfveePJSKlI125KpmDdck2fQYMGI6xF0gSEBePWJ?= =?us-ascii?Q?mgnd0Sx+GLRDtFnSqoRAK1b39Hc+QOCJq+1IhTORaOwBqh4B37cf3aazAMXB?= =?us-ascii?Q?EVpmdW0WQNo0vV2ub2zd91UDzNd67RZdPoN6bhd+VpkdfVz9o0m9Iy+/E+Vz?= =?us-ascii?Q?aMtV23sAK6gespLk7gPdJKZMZeYFKQvXD+2S6LiHdArhRg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T4TG+m82xfAp4SxSdu57Zs2YuH2cjG0XY11tgWsxE7lWyS9Qsu0ve6ScraMT?= =?us-ascii?Q?zltkdEUdPBB9iYh9wPGlEUukEk7K8s/hY+ScZ04H37DO8ZqAQ9WEi5I7yx1+?= =?us-ascii?Q?N4IAoLFujOGGkuOnKaESU+dDjg4lx9gMR1/i4lzwZoGMJj4U1maccwDd6e5x?= =?us-ascii?Q?ap38DgcxRvQ51ac/VdGxCeKYX8Mg/W3YxxKF0viE9pB24+kXdGdpqhEm4t72?= =?us-ascii?Q?svkkpyuaocn6VnNREn8K+u5A3QoypE/VqgFBYLUG0G4yKdNNCvtA9TWqlvv/?= =?us-ascii?Q?bb48ZDPFWqEqbkecSXXI17VhPXZoIvSIA1FBn8DicUDPBL6/ICAzHhmKDc5q?= =?us-ascii?Q?jrL1f4JT7ONw4heLOVLEvzvruQPYAOyDL+pf6eB1oqVdB6scp6ozj8p7dXg9?= =?us-ascii?Q?X16XCL/RxgnDSAI9IcaLyrEvmSuDTIGE7tJHtUM1wgbiNila1ofFwgskz+wA?= =?us-ascii?Q?pFvF1x4gIxdoSefLo7iboTqX+Ab4lPxGzD7pe+VaKUJnVGNY6hVo12MAKlYY?= =?us-ascii?Q?bhcrnRIA8jfrytKp1cHCPFTShYterUcyacQJc4cS3NBTVqAQK3VMMCJEcNKx?= =?us-ascii?Q?2cWQOOYJDjmD4CuIGiVuT5/Y81hsgvIvnvUWldcne0Hli7xhhW2M7yVijYqN?= =?us-ascii?Q?+KLwB6Z4skTONA1EJoXKm7L3tbcofD9gRKMDmDgodDVPkOZcOMEXWMHKDa3W?= =?us-ascii?Q?2ec/GQ1Wi+wB9P7yglpvBcNMS34O5X+kd8/iwgJqIWH/Yf468znvrZ6i75BY?= =?us-ascii?Q?Y3apcVGIUcV2AL/4M2pQ3GwVgioCsvpF7mGm41CqFDLi0j9L2zhHHrhPKz6p?= =?us-ascii?Q?zlB1blXa8ICGt26VffsNN2DUIFu0lMKKgheCQ8dxM2itAFBpsC5g3sZHXsWk?= =?us-ascii?Q?swx7WhXoDvJM+VSTLAvVA4Gq9ZZNknitYzr6Xuo6HbcjNonKUG4HY1qbWHik?= =?us-ascii?Q?47Ui0O78E1FdqVfJPgFEnRZ0J1TdDKAWHPicrphXK3aDDjaA9FJdhD6Mqh+Q?= =?us-ascii?Q?ZhQFVZ5J01vSk8yM4CfsLBWwEMqnRJo8SvTf+1Y7M5HY65AcTUne0X5wtKKW?= =?us-ascii?Q?9g6owiEiS/0ImclmxdJ77+vi5b9xrs/lCNZIhhCGIarv4cyHTx/qxXbeUWxD?= =?us-ascii?Q?xzPthfhqVUNk9hfbxp/oeDTaVZloFQel8GUXy2GcI2xuleXqUDt3SGIpdxX5?= =?us-ascii?Q?Kish0A4LeNAglX84whGhBcet+uru+tzSDQSDvIg3iQUj2/9HVDOpyxDtPr2L?= =?us-ascii?Q?USP3tIMSCBThSLymI44VY7kSMM4S5jg+9mr/HHML3Dmsnzyl3orHojwA3oOP?= =?us-ascii?Q?8PVz4WHOTyM8BZDdYGi7Ug7f2pMdmCjKP6qX4MDkTg3eJkUjIx9V794llaRJ?= =?us-ascii?Q?bEPQRGauvVmS5Sn7UFyHr9V7KqziLOBiiGHVS2R2G34ThxsfXsdwGRwCxl4h?= =?us-ascii?Q?+cK9DJvkbP3gjZu/B186seXSgYKkw2O/4ELbEidc89ZC4mH/nigAlOIY7l1U?= =?us-ascii?Q?BdiPB6ejFyrZeOKtVaQIZaIxub+yFUhQ5rqR/XfsA6+MReZx/2RVUSgNRHgi?= =?us-ascii?Q?pHHcm7J+svFmbn7Wss7W8Tnq+vZfUoDVLsbzjFfpcJOwcHW8Gt/do/8nks3W?= =?us-ascii?Q?ug=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aad9dc47-602f-4d46-3404-08dc7064ecd2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2024 20:16:35.0847 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iSuZusTKcr/zHl2dqHFqzn1NCaUpMKm0W+ukgePmZT9O/tp22WpJMoxffu5VCxgb9YlCIRClaBgoujrUtH5m1zLzMS2t+1lES6dPj0srzzY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7795 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 09 May 2024 13:16:39 -0700 Resent-From: nathaniel.l.desimone@intel.com Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fwW0XgHZHuvNMmHIgg4SQaRrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=XqT7sb3j; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Pushed as 3f89df4 > -----Original Message----- > From: Abdul Lateef Attar > Sent: Monday, April 22, 2024 7:04 AM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop >=20 > Update the MadtLen varaible before the next record is read, to void infin= ite > loop. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Abdul Lateef Attar > --- > .../Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib= /DxeCheckAcpiMadt.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointC= heckLib/DxeCheckAcpiMadt.c > index 7e29b47a0b..04cc6f963a 100644 > --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChe= ckAcpiMadt.c > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChe= ckAcpiMadt.c > @@ -1,6 +1,7 @@ > /** @file > =20 > Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > **/ > @@ -235,8 +236,9 @@ DumpAcpiMadt ( > DEBUG ((DEBUG_INFO, "\n")); > break; > } > - ApicStructHeader =3D (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeade= r + ApicStructHeader->Length); > + // Update MadtLen first to avoid the dead loop and system hang > MadtLen -=3D ApicStructHeader->Length; > + ApicStructHeader =3D (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeade= r + ApicStructHeader->Length); > } > } > =20 > @@ -324,8 +326,9 @@ CheckAcpiMadt ( > default: > break; > } > - ApicStructHeader =3D (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeade= r + ApicStructHeader->Length); > + // Update MadtLen first to avoid the dead loop and system hang > MadtLen -=3D ApicStructHeader->Length; > + ApicStructHeader =3D (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeade= r + ApicStructHeader->Length); > } > return EFI_SUCCESS; > } > \ No newline at end of file > --=20 > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118770): https://edk2.groups.io/g/devel/message/118770 Mute This Topic: https://groups.io/mt/105669987/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-