From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.4461.1642045926923306914 for ; Wed, 12 Jan 2022 19:52:07 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Dm7txXMx; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642045926; x=1673581926; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dgjPgNqxhXpsOKt+2Dfwqqsx5PhE8vtoFPZVTWBO3uU=; b=Dm7txXMxtXseh3mTkydgPaS/utqDCzGQRDNfXjRSKWH7WIRqgJxMIjPh m5cVi7XL+H7m5WisoGnNNXan9RiuqUl1xXMAp24PahoaJXo7tabJL/8ur L3BpCb8byjZHFSQBcUR0YcmOCiNHXtBsosY2MfCxdI/fZMuJk+ncJVwuf hla2EUpPUvWkW+NFhKk7EvpZZO5UoS2tEmzvydS+ptFa7Id84mUhiqdWm f03oQa/AZ1ssBkoBfVRHd3MEoh8rRdHDkMMmfU5Ln/l5MvYGsobSjHTCt kV4NeN2OY+xwCujR243Dov5TZp+6UGBsYJ5L496Hq3bsBl/FXFNJ6Aleh A==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="330273622" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="330273622" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 19:52:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="670383539" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 12 Jan 2022 19:52:06 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 19:52:06 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 19:52:05 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 19:52:05 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 19:52:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MR3eOwflzYuNxz5gO97hBM/19ckDwB71zT6kj2rS7eH7T7UDOlMG/ZERIeyPOV5e9igKiHm596L64N4ZHexEpBo9Amhsf2pg2AdzDhdrfKciUXAag/GpThChGM2jTUxnbeyjvjH+LfzAE1Frre9uS+IXziSDbKB9TO0PTeNL5uvPLDjZh5pRjtnwxsbIG5svQAioeIX6MBnH8PRsV0O0GTaVYgkFAHxeDxRxskIJb2p7/8sycY2jIYk84DnZAgb3jAR6E7CVaY9d/GGl2ieVTzzyFye40QYj0qMSylbtKX1W2zFsrjIfblsPnTehpym2nWnldvGJ+9hH/3e7ASMCQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uERcSFlyciK571+9wmGovDeGcA5sLMwud3Q/ZTVERqg=; b=WcpP+2Wj2ix+Vu6JyAl1S57DDDZAkgXQcbx8DH3IsTLx9Rp6hWFWs9ztxsZjkhVZnGPCU3N58h0TUsOgxQZlPL/Yj5MG/mfgPpVvTXZdzpCszHCt80tfygZAP29i+Gr6wv7t3TOW/7yietCTc7UWhkT54rNZvgcjk4Bq64P+6TIcE+aUqdMY74qyopK7LmKA+pukutxiYcpD9xOyUhhgoobj32IKMQSDGWVkOXp+gohKI5J4XzhLoxCoTLMSTD51B3izcUDzaHOXTO3UdChm4sOS2y+aCtvlGInRxI265LNDvK6hGT3y6c9eL/tZ/BUZ5iWb7528dmAJdhci7r3+Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by DM4PR11MB5374.namprd11.prod.outlook.com (2603:10b6:5:395::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 03:52:04 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::d131:a091:314e:a310]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::d131:a091:314e:a310%3]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 03:52:04 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" , "Dong, Eric" , "Tan, Ming" , "Chiu, Chasel" , "Bi, Dandan" , "Shindo, Miki" , "Abbas, Mohamed" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build consistency Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build consistency Thread-Index: AQHYB1sISarRaTwIlUi+MdpsUKVHSKxgJu7AgAAh5ACAAAbdcA== Date: Thu, 13 Jan 2022 03:52:04 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7ee4c692-f1c0-4fd5-9bd2-08d9d6480fde x-ms-traffictypediagnostic: DM4PR11MB5374:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dWfhgBWTDKoLyBziHgK8UrLlJKzZv1GQSK0UIiv4BnG8kC+cB4ND0tqj3O1N7W62nV46/vz05FwNOd42LaivnkNRvsaBHBmDbd6/suO1ciRx2TssfGQr+NR8kTJjtrwk6u5dkHDds+9Um2MNiZYdOLxdGWQUCa6mjm1el5hmclqQ5Rn8bcZ+TMTwGQs7MZApJ2tAGaidKJ0csU6kXMxhiRAOWVs94+IvcEwuxTTW+BxWc+NB6wdAZ2lM7dj84sIUwIFgcM48FUXcZ9ZnCUVOv0ms08dznHC7ktv2dHqa1gLOJoFLZVugSxa+disvyTHoicbqpkPfmDG7zF9BOF3kyU7Bn36oMq0CHuvHR6YeTxUWqoyrOTPoUb60GbZ57IUs5AfPme3ydHhqrdVovpWsTxz6ZeatsGuFD6cDafmn/VxFLpJ9RA2rLQ0z2gcrpy+NjxqnFLIYu7HYFYUJWvIM5OEmN4mnY9qI/Eu7QSxwNu3wzFpGsPnI+7SEyCRKSZfMSCZagMCH3p/PO/p+61lC//4GSxnxD9bs71oeFRV2CDEyKYW3aNffGnnOvsBa9R/lQOw5MAj//Jt28bYEyYol2R4aCTG36p8uxZ2BfLHrhMukgNUZ+HJZ8ZO25q7weH3mkyjeQAC+uYYYv9yqp39NLPU+0DPogYN4SIUSgeiwx/mVEk9kxw5elpcAFT4cXd/0Qv90YDnAUOfGoJqjoPiWQw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5832.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(83380400001)(8676002)(82960400001)(8936002)(55016003)(7696005)(66446008)(64756008)(4326008)(66556008)(6506007)(76116006)(53546011)(66946007)(66476007)(5660300002)(30864003)(86362001)(38100700002)(2906002)(71200400001)(9686003)(316002)(54906003)(122000001)(186003)(110136005)(33656002)(38070700005)(19627235002)(52536014)(26005)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2QQNoPtfBpkc8Mu1NMHKwgn8Yf42+QYRl0Jikt99zrmYVCWZCPyZful3G490?= =?us-ascii?Q?5WGLjwmFpm8KqrcBpT/iYykAfLCkijeYiWZplizIJB+ubrrwcMH2PBN2yWlv?= =?us-ascii?Q?wcIa4GIyYbfNs9w9yw30A/wmWsBIstMI3Uo8IjoQwh1b2jH9J8wY5N2rNsvo?= =?us-ascii?Q?Vj+wx7dPqIWKnlQG4XbIsO4qBFdt5RIWWVWvNhPa8ZpQiX+x9o+LaOdBzWC2?= =?us-ascii?Q?mUDmNYoJ/YkZNTGvMKRISOzyjKDUCUW70cgtuctOhSO6eCGFMBEBlIl5vZI2?= =?us-ascii?Q?ik8jCCQm/fEOPB69FXinS8YZFGRGaJyKq/BE3KHcEnTO8AKiBvlTov3AYqju?= =?us-ascii?Q?pAlX219W0t4vmkQLBA376mrnKAyjs3Q10r8qpFabjkURmySUxd6LrdoDEzdH?= =?us-ascii?Q?DCv2/TnGh3K+AmCkzC4qjqaLLYl8ALkPUZliTnEQoJ3SPF+q2a06CLG2yKzv?= =?us-ascii?Q?3xaPGGAv7vDkumR+5+91qHAGriZYOKG+H2jNbSQh2m8atgnvrWOuqNpFbk7T?= =?us-ascii?Q?8dFMZmc4vBlh4Fx/GkUC9RmG2TFfz94y1zS6R0OZw4PY6bnocXi4LGNDWUov?= =?us-ascii?Q?Y9FYO3Kc0G/WHD8GaBf4DVWH861LVjsu9dW2Pn4C+0EieOca+VzSuCLZA4yo?= =?us-ascii?Q?eqf2jeHj/zbHpR1fv/Y2gsWzLbvwtnLudMIfoT8XZhdwQLiXdZ+QHqbziiNg?= =?us-ascii?Q?LW07b1qDAtuPgnaCkbs6EYi4bQ0P6SJnDW03lWiMq+H6aLTlHY5vYs5zR7wW?= =?us-ascii?Q?p4o42/Kf10UiovX5VmR3mf87XucoHHAMDC43Azr6CEnUspwvyk6ejjGgGHMo?= =?us-ascii?Q?VUq1Sq1DpmZxxeD5COjch4DD5zCCXmikXDx+ASKgSC936f6KbS2xuB10Nv9N?= =?us-ascii?Q?k6lqHr9lh3nFunv5MDs26BKgHHlEXM6TI+Y2qEJPCzfNYjg35CHn0RpGkCmP?= =?us-ascii?Q?jGL5AdgJl+5+M723m548ab8fMbVoEua0GM1xBaEcbDMXNrWwPagk+K6s5Vuv?= =?us-ascii?Q?mRkvT49Z3x2d/lhAYeC7yVqO0/BhgEXWDRSXOhxmGYJ+lF8pQ4DgWyHge/Kt?= =?us-ascii?Q?46d6MCLnR7jD7UwNgcnqe/bMzYXf9TpEckHbJ0VWLLLNsDsFtlHOmk4boPDB?= =?us-ascii?Q?LbHN64zu1T6Z67vRcfrororZFf3t2bRuPgz30jSDaSSHnYxQrQ7j7+7okVEX?= =?us-ascii?Q?ecwL9WaCZ4Eo4ys5qczU2BYojvm4Hsv1c27qnyE4QtgPDJ8ZYFApgzU935LE?= =?us-ascii?Q?xHihGdtMFC7rnHUozmkfCa384v03LC5YDFTImhz6nWn+MOULBLwLpcIbwB+S?= =?us-ascii?Q?nJj8MIEcn4uu3QJkmGPtTltsCwUvlbRFYqY4CAN9L+bHS78jWEmxEYn4bbu2?= =?us-ascii?Q?RstWfppqnwytbZq1Id5XpYfXYkGMT62ZRjEjWfbbPCtm38KTcZyjtTK0GUpl?= =?us-ascii?Q?q6FEwhqZwKcFQLgU4tyurt3FSdQK54DB1vjn6BNGWFiX1jo9lNJYKWv0Z12G?= =?us-ascii?Q?P5WMvJiIzBXpdMp/hiO8GK1bWWCE74R/6Po7/NGXdkiz3g7sK0T5q9g/QbHv?= =?us-ascii?Q?lEBhAgbSUU8LeKIn8M99NZjC5u9TrFadjPX3jG6k0LX5aod0og+ePnAwvopO?= =?us-ascii?Q?qib7JCzx3FnSZYdUHWvRLO7PHaAAWLlDMaUei5xs66bNf99apO1HTOXjOQJz?= =?us-ascii?Q?pQXj3w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ee4c692-f1c0-4fd5-9bd2-08d9d6480fde X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 03:52:04.0310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IHDmqEM9YsdB5LQb6aMW9mNSmeGwgJhjeUgE8FGr2psnXCF8EzlZNqnpHZm8Fmo9qMlf7Xe+jcnS5w1dSOiZuRo5h5pO5RN9HAVL1EXZwmk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5374 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable -----Original Message----- From: Oram, Isaac W =20 Sent: Wednesday, January 12, 2022 7:15 PM To: Desimone, Nathaniel L ; devel@edk2.grou= ps.io Cc: Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric ; Tan, Ming ; Chiu, Chasel ; Bi, Dandan ; Shindo, Miki ; Abbas, Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature b= uild consistency Thanks Nate. Comments in line. Regards, Isaac -----Original Message----- From: Desimone, Nathaniel L Sent: Wednesday, January 12, 2022 6:47 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric ; Tan, Ming ; Chiu, Chasel ; Bi, Dandan ; Shindo, Miki ; Abbas, Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature b= uild consistency Hi Issac, Thank you for doing this cleanup work. I have some comments for you. I have= provided a summary of my feedback below: PATCH 01/27 * Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc Line 69: [Components.IA32] should be changed to [Components.$(PEI_ARCH)] Li= ne 83: [Components.X64] should be changed to [Components.$(DXE_ARCH)] Note: These comments can also be addressed by restoring the @todo comment s= tating that these changes still need to be done (which you deleted.) [Isaac] $(DXE_ARCH) and $(PEI_ARCH) are not fully functional. It appears t= hat they are fine in DSC files, even when inside an include. But they are = not fine inside an include in an FDF file. The PreMemory.fdf and PostMemor= y.fdf do not work when I try to introduce this change. =20 As these are not required, ToDo are against coding style and are bad for co= mprehensibility, I would prefer to not add such useless comments back in. = Comments should improve the comprehensibility of code and should not distra= ct from understanding the code. [Nate] The $(PEI_ARCH)/$(DXE_ARCH) additions are not be necessary in the FD= F files. Adding them to the DSC file should be sufficient. Can you re-test = with just the DSC file change? PATCH 18/27 * Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc Line 33: [PcdsFeatureFlag.X64] should be changed to [PcdsFeatureFlag.$(DXE_= ARCH)] Note: This comment can also be addressed by adding a @todo comment stating = that this change still needs to be done. [Isaac] See prior response. PATCH 19/27 * Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc Line 35: Typo here. Usb3DebugPortParamLibo should be Usb3DebugPortParamLib. [Isaac] Good catch. I guess we don't catch that class of error if the libr= ary class is not used. * Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc Line 40: Did you test compilation for the Usb3DebugFeaturePkg? I've general= ly run into issues when a components sections does not specify a machine ar= chitecture through some sort of means. [Isaac] There is no code consuming these libraries. I verified build of 32= and 64 bit modes as well as part of AdvancedFeaturePkg build and a board p= ackage build. I believe that library classes can be specified by module type and the buil= d tool builds the right mode for the consuming driver on demand. Basically= , there is no value to specifying architecture for a library. This does not work with components however. If you leave the architecture = unspecified, you get an error when including the component in an FDF as the= build does not know how to resolve. [Nate] I bring this up because you added a [Components] section and put thi= s package's library classes into that [Components] section for the purposes= of running a build test on those library classes even though they are not = consumed by anything. That new [Components] section does not specify a mach= ine architecture so I'm wondering if the compilation still succeeds. PATCH 26/27 Since FvAdvanced is post-memory and not covered by the boot guard IBB, I su= spect we should probably also support optional signing of that FV. [Isaac] I do not know how to act on that suggestion. That seems out of sco= pe for this change. I restricted my changes to be functionally compatible = as I do not have hardware to test these changes other than minimally. [Nate] Nevermind. I checked all the OpenBoardPkgs we have and none of them = have FV signing enabled anyway. Ignore this comment. Thanks, Nate -----Original Message----- From: Oram, Isaac W Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric <= eric.dong@intel.com>; Tan, Ming ; Desimone, Nathaniel L= ; Chiu, Chasel ; Bi= , Dandan ; Shindo, Miki ; Abbas= , Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build= consistency This series addresses inconsistencies in feature implementation and use. So= me inconsistencies are just conventions of the feature design/template/conv= ention. Some are inconsistency with feature design intent that negatively = affect the usability of the features and the amount of work required from b= oard porting engineers. Some features were missing feature enable flags. Some features had non-functional standalone builds. Many features were implemented to include common core build content in thei= r feature include files. Updated some of the Readme content. Added AdvancedFeaturePkg.fdf to build all feature content to support verify= ing no build time issues between features. Removed duplicate and unused content from build files. Modified the TemplateFeaturePkg to use the common MinPlatform include conte= nt. Removed all instances where features were relative to Features/Intel and ma= de them relative to the package roots. This does mean PACKAGES_PATH may need to be extended for all the feature do= mains. Debugging, PowerManagement, etc. However, it should enable packaging tools to function properly as the relat= ive paths violate spec. Use of the common MinPlatformPkg build includes does increase the build tim= e for each individual feature in standalone build modes. It does not negati= vely impact board or AdvancedFeaturePkg builds as the common content is onl= y built once. Part of MinPlatform arch intent is to reduce cognitive comple= xity, so the simpler build is more valuable than fast build time. Cc: Sai Chaganty Cc: Liming Gao Cc: Eric Dong Cc: Ming Tan Cc: Nate DeSimone Cc: Chasel Chiu Cc: Dandan Bi Cc: Miki Shindo Cc: Mohamed Abbas Cc: Manickavasakam Karpagavinayagam Signed-off-by: Isaac Oram Isaac Oram (27): BeepDebugFeaturePkg: Use MinPlatformPkg build include files BeepDebugFeaturePkg: Fix all relative package paths AcpiDebugFeaturePkg: Fix all relative package paths IpmiFeaturePkg: Fix all relative package paths IpmiFeaturePkg: Fix build errors S3FeaturePkg: Fix all relative package paths S3FeaturePkg: Use MinPlatformPkg build include files SmbiosFeaturePkg: Fix all relative package paths SmbiosFeaturePkg: Use MinPlatformPkg build include files UserAuthFeaturePkg: Fix all relative package paths UserAuthFeaturePkg: Use MinPlatformPkg build include files VirtualKeyboardFeaturePkg: Fix all relative package paths VirtualKeyboardFeaturePkg: Use MinPlatformPkg build include files VirtualKeyboardFeaturePkg: Add feature enable PCD NetworkFeaturePkg: Use MinPlatformPkg build include files LogoFeaturePkg: Use MinPlatformPkg build include files PostCodeDebugFeaturePkg: Complete as an advanced feature AcpiDebugFeaturePkg: Use MinPlatformPkg build include files Usb3DebugFeaturePkg: Align with feature design guidelines SpcrFeaturePkg: Use MinPlatform build include files TemplateFeaturePkg: Use MinPlatform build include files AdvancedFeaturePkg: Fix all relative package paths AdvancedFeaturePkg: Add missing features MinPlatformPkg/Build: Add an include file for the common SPI FV info WhitleyOpenBoardPkg/Build: Use common SPI FV Header include AdvancedFeaturePkg/Build: Add FDF to create FV for all features WhitleyOpenBoardPkg/Build: Enable Features/Intel features Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = | 67 +++++- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf = | 49 +++++ Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc = | 49 +++-- Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc = | 64 +++++- Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf = | 49 +++-- Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf = | 49 +++-- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.= inf | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.= inf | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec = | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc = | 21 ++ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc = | 74 +------ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf = | 4 +- Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec = | 7 +- Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dsc = | 28 +++ Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc = | 222 ++++++------------- Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Library/BeepLib.h = | 6 +- Features/Intel/Debugging/BeepDebugFeaturePkg/Include/PostMemory.fdf = | 14 ++ Features/Intel/Debugging/BeepDebugFeaturePkg/Include/PreMemory.fdf = | 13 ++ Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/PeiBeepStatusCodeHandlerLib.inf | 5 +- Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/RuntimeDxeBeepStatusCodeHandlerLib.inf | 3 - Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/SmmBeepStatusCodeHandlerLib.inf | 3 - Features/Intel/Debugging/BeepDebugFeaturePkg/Readme.md = | 91 +++++--- Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostCodeDebugFeat= ure.dsc | 231 +++++--------------- Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostMemory.fdf = | 14 ++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PreMemory.fdf = | 13 ++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Library/PostCodeStatusCod= eHandlerLib/PeiPostCodeStatusCodeHandlerLib.inf | 2 +- Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeaturePkg.d= ec | 11 + Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeaturePkg.d= sc | 30 +++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Readme.md = | 31 ++- Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc = | 131 ++--------- Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md = | 50 +++-- Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec = | 14 +- Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc = | 18 ++ Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc = | 89 +------- Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc = | 18 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/GenericI= pmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGener= icIpmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGener= icIpmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc = | 90 ++------ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf = | 16 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf = | 6 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc = | 18 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf= | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf= | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/Ipmi= BaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLibNull/= IpmiBaseLibNull.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/I= pmiCommandLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHook= LibNull/IpmiPlatformHookLibNull.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/P= eiIpmiBaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/S= mmIpmiBaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf = | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/SpcrDevi= ceLib.h | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemory.fdf = | 13 ++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemory.fdf = | 11 + Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc = | 62 ------ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md = | 12 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec = | 6 + Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc = | 18 ++ Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf = | 2 +- Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc = | 74 +------ Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc = | 18 ++ Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf = | 2 +- Features/Intel/Readme.md = | 49 +++-- Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf = | 2 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.ds= c | 54 +---- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBas= icDxe.inf | 2 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec = | 10 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dsc = | 18 ++ Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc = | 2 +- Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc = | 18 ++ Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc = | 69 +----- Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec = | 2 - Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc = | 38 +++- Features/Intel/UserInterface/UserAuthFeaturePkg/Include/PostMemory.fdf = | 6 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.ds= c | 92 +------- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/PlatformPasswordLi= bNull/PlatformPasswordLibNull.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/UserPasswordLib/Us= erPasswordLib.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/UserPasswordUiLib/= UserPasswordUiLib.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dsc = | 18 ++ Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthentication2Dxe.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthenticationDxe.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthenticationSmm.inf | 2 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/PostMemory.= fdf | 2 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyb= oardFeature.dsc | 64 +----- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeat= urePkg.dec | 7 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeat= urePkg.dsc | 18 ++ Platform/Intel/{WhitleyOpenBoardPkg =3D> MinPlatformPkg}/Include/Fdf/Commo= nSpiFvHeaderInfo.fdf | 2 +- Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.fdf = | 48 ++-- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc = | 44 ++++ Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf = | 54 ++--- 96 files changed, 1159 insertions(+), 1334 deletions(-) create mode 10064= 4 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf create mode 100644 Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Po= stMemory.fdf create mode 100644 Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Pr= eMemory.fdf create mode 100644 Features/Intel/Debugging/PostCodeDebugFeaturePkg/Includ= e/PostMemory.fdf create mode 100644 Features/Intel/Debugging/PostCodeDebugFeaturePkg/Includ= e/PreMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inclu= de/PostMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inclu= de/PreMemory.fdf rename Platform/Intel/{WhitleyOpenBoardPkg =3D> MinPlatformPkg}/Include/Fd= f/CommonSpiFvHeaderInfo.fdf (88%) -- 2.27.0.windows.1