From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.4554.1642046023109365681 for ; Wed, 12 Jan 2022 19:53:43 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YlZW9QtH; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642046023; x=1673582023; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VlEJfKjeMH5418evf8M76bxKGIHBLHEwobKFE191BPE=; b=YlZW9QtHoFQ8iwo8Rbh6DHhNbuAnigoUMlY5rr7lSY9v3UCckoDg7wJN w0n2vY+V6xyJjccT1Tk5qpjkhHmRiesVe2dY/+FuHQ0TNKEaAgXuFs9gt xq8OcOZg+CYWfngWmJjFjuI4UkczleTT5lSOoLRATAGWWsA778t7qp+I/ 75fMYEt+O4miCKVSKtqkfzNJvYHOefF5h0NHrYkwii1yYCLTmqjUpl/EY qnVBAggmsD7ur/pBrWmbpE+vU1NeoKdEj6ETeP+nYvRlt4qSnqq5QeQPc ETjJ2PvszJRB3KYpX1rHm5jR74H/KfotTMncrGdBcbShm/vitp6chbmPF Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="241483607" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="241483607" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 19:53:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="576804585" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga008.fm.intel.com with ESMTP; 12 Jan 2022 19:53:42 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 19:53:42 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 19:53:42 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 19:53:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B618q5O9JJPQsLak6WcL2cbIkvAfToDtrPHTcnCYA7zID4LTjinZjg3peSmfJqYU4ni7PkLxQaz4XKV1SP1MXsR3wgM6okWmagVDCHEuhlshlmDNhPqLTNt72tKSMgVWe1ofZXTYidnzoZArea+dpY0reotoKWUuqRBhyYrLJw1R8E8LPYk9C0Wpga/q3DjEGAHEVqvNFixsuyZHsxqxhvKwnEySaZ07l9pCpBSr4urx28Dold5BYTHzGFPmxzXFuT7Uzziz8B4YFj/Pqtt3qpizDc8uhegIl/hsHiKzuEKqGKk1N/J7f8M/RnjoER/3M9LBg0KOOE5CdUj33fg2pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8y9ocuUSNkf3UiWtDe5z4Qw1S5ROVcIQoTqNmLpluiw=; b=ZPLPNI+883BSJUK6y7tzImCSVEiOsGbIdaHXCCmBT2Zr1cuovCqRBlD9wmMIZk2QW/WWUs2SfkMoo8f3umu4kJ6Uwtexu6h//oOhXA4KBsYgJCQwQ4VzuP6aN8wq8N7yc/5sjlnb5LHOS1bEi6nZmcY/bT1wxK1V80lQKe1BwqHyCJ0wY3gbXSl+imMlChvI5Drjgqrysh1Z/9TQR3DdX30/ysmcAy/3Hshn3jN5ewhks4mX2v7umtDGuxkmBt19p6hVIyunkD29iGYHJB4fLoWYmYnt5/UTgaaiujbELkHkDC79ASsgwxro7XNiupRa3UPE6QiO/ZhaDcV2dxw0RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by DM4PR11MB5374.namprd11.prod.outlook.com (2603:10b6:5:395::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 03:53:37 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::d131:a091:314e:a310]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::d131:a091:314e:a310%3]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 03:53:37 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" , "Dong, Eric" , "Tan, Ming" , "Chiu, Chasel" , "Bi, Dandan" , "Shindo, Miki" , "Abbas, Mohamed" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build consistency Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build consistency Thread-Index: AQHYB1sISarRaTwIlUi+MdpsUKVHSKxgJu7AgAAh5ACAAApv0A== Date: Thu, 13 Jan 2022 03:53:37 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17fe35c9-d432-4c79-2879-08d9d64847bd x-ms-traffictypediagnostic: DM4PR11MB5374:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AsSDk4yT+7ug7mT3fy4QPJ02zX0p3NnTdjLgu1LinzIIrxMHAFiF9xxP4ONGl/P9BuOVTJnei5GdZaCXBJoeWHQ7CjPiUc0lPECchAX5GkFoW9YzOm9v5mZh1aW16OCS9iu+NBNH2rTwE5Z7RCkWuOZhgQb+hxbeU+9frmMEBKsctaLl6E3WEiVzi++PsjyCD5DrgiEbsb5a2o8l2HU1Es2l69bEajNEqi8JSuLClEerjtNgQW2KjhAx1kxCDPxgz5uKdCvSoKK1j3oCqUtEy2gwsJS4Vo3inz1LabcWJpxWdRCF2ee6VnuXXx10eWfv3H8KthLz005JHjixHsFR6/sY3R0ltt0clUiMOENNT2y2HsWlQLYtf+wQTkjq0fxocPaE+Fv7zKN2FgOj1NXzNTULwaJgaVfvH80B1ZccgsxBydtZCgzbkQrCVv7EFk6IHh/FfTqa0hlSq8+klKW2Tm4IB1cO1yXZ0BR/7am5kI7gP0icxBMq+cvPXcFqdXIKccYn319+kpTHxRi8PGTevFlrTxkpbhgS2Qn+5m5m2vljFfOtM4pqketpQGYaZbUo9OPUFTbnnJpwjJ+0TOVFi0HW2ZsZXipPNKkKhJQp4k0zW2G0AP1uELKtvnku4M5MP4GNgsBGH4Oujy1sbDdEKDapEsMo9bFUYxrEwR1LOU4Z+gUqwD41mVjV8mAtiZCvsZiQ0dg0RJNTFgFVvZfx0w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5832.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(83380400001)(8676002)(82960400001)(8936002)(55016003)(7696005)(66446008)(64756008)(4326008)(66556008)(6506007)(76116006)(53546011)(66946007)(66476007)(5660300002)(30864003)(86362001)(38100700002)(2906002)(71200400001)(9686003)(316002)(54906003)(122000001)(186003)(110136005)(33656002)(38070700005)(19627235002)(52536014)(26005)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I9GjTWPSEXCFBSJ+KCNg+3fpGYR4caoDPMFGq8L1RK7WqkdqP2r5WIbP9loZ?= =?us-ascii?Q?CoYg/SIcfg8vSIBAR5z8SxXnGkwv/DgQLB4wq/FVHD87a5oexNUR/lfRuO+6?= =?us-ascii?Q?hmK7Op3hjI71C8hJLywTLE0S42BJa2jlLpp0DP0GIBCW8iSm7WVhtHpntXb9?= =?us-ascii?Q?aD1V9TFavBw9HZ9NUvMTkv4T5iwNuCZwrMkdbjjViAbLUl4cgpzjOwA5oPSk?= =?us-ascii?Q?txyZoEJMPDU0MX+gaHbcLz0D6GPb+Ed4dDiKEHRgIcL7zimRf1JOYSsoLZ7d?= =?us-ascii?Q?vlMVfILhjDFXNWUbTowNKMUIz6/gCFx5s5pIgsWkx/rc0IcXiGK3nOnaQwWm?= =?us-ascii?Q?ztDvANRQ3tMt6ymoU0hvPjEk74j73dH7HQhUi6cq5FUxYy7xAlixUnkHHo6t?= =?us-ascii?Q?0u9p0XIX/7ufpKMhbCvznvBv2VPUX7Gr+EVFGZtoVXzLzAzRKgFoGn8bP/yx?= =?us-ascii?Q?t0b8437CV4KvHD4MhXGmHmP4LrBgoZKmRTKy8/g6nU4tJPDG+QQm7w66K7dJ?= =?us-ascii?Q?GlYadOW3oBEGId6tdjcVH19W3mpl+4R/RPey7gWRu8moWqmNyYvJBP1BfZyg?= =?us-ascii?Q?QCV1onHnsia8t94hIjpyVYm5yqXQBQvJFEJHoHDOjW9PyIsbixpQXKKB9O/g?= =?us-ascii?Q?lKPd3Ij9LTYc9puJRXQyUH9XQQMBlAAwF5+rNfRAUNFD8s5SA2KJWEAuzy7D?= =?us-ascii?Q?RSRzpxDvijheZBA4REyYwvDqFO/agG4LUsYjAw6WyN10odEnmTNnI+oTb5yU?= =?us-ascii?Q?w8wYKAeH0BPrsuDZq1eUDyvmB9OU9s1VDLIBUyekcIAFsWYH2uxXRYpyOPkq?= =?us-ascii?Q?HpImS6mJKPzKQiMDNKaBCrNiP+svfvTX962dxjwKc2TpvkMIhWqdeYSG6CVt?= =?us-ascii?Q?YiveHPywmrsa9flyQVyLzwlv3jlrQ/PVX9ihtth1s6GcHIh39G088phCapDx?= =?us-ascii?Q?R/OJegtYoiNJTWj6O762jpqq/Ln23fJMh6Zw4Q25kuwmZf8hrQrqAC8qFRRJ?= =?us-ascii?Q?z4s0xnqulDF/uujbzVZjCxUBXxM2qsY8QD13Qflz9vZHr1ljo4LFFp80ZbHw?= =?us-ascii?Q?JYUMD1gV4HnEb8FUe8jEnuXK+q7O6+WqbyK9B8RAH06gMEFDNQFXqetdc9f7?= =?us-ascii?Q?bqclmPV1MI17xmG/jX8cogB1jqM6yXQqWcVsQ/SWy5neY1tJNGuAGvFbKqxe?= =?us-ascii?Q?re3QHfeww+daHZCjeqVksAefBFuaZeIc7ui5fGiXJ784auMhd6rxFb0zAhxk?= =?us-ascii?Q?Tw4MaJ/dY47Iavc1TgrAsTgMziIyGiwQ3H4d0QTzI31Ki0F/KUGwncB8ot+y?= =?us-ascii?Q?nQg50N7XhcKbfj0yc26UdZhHysMOJYFYWr66fD8jhClTlo7b7j3GN4Nt0g84?= =?us-ascii?Q?8XGOMzHyreq7Nd8pe8SnSDt0dLOEB9+64F6biexWMY6P2t4Z9QcpT+MdaEWQ?= =?us-ascii?Q?jTqMt+mjhqbEBhgn6O4DTKQw1ZlmjmC4JLSFs5wUUJSOWyivIe9n+lLTUkHn?= =?us-ascii?Q?0dZdSVGco521Wu3ygdB3KEr1IOKhYWxx8B6BAg3tM7uec42nNWT5M/PooyTE?= =?us-ascii?Q?V3Arqmgh0M0wN/zfpUgEBLl2kXgB0ib+AJ1nxTY9r7J1wyUeeQUC7FQYs/LB?= =?us-ascii?Q?c22n2Ivg5IJ+mbH+xHhl+wh3hjDpNU187+PW1n1E/InyXqPjx6pwwgxIr8A4?= =?us-ascii?Q?g9mxpg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17fe35c9-d432-4c79-2879-08d9d64847bd X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 03:53:37.7798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Asq41rokaPrXXco/7TMjFaiLH5t9qVXvCGb71+kjtWvoom0icA18CgMinfMdkU6o/2ackeakxg0yc32iHbo7lvCvk4ndeYqhoiLwgKU6d80= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5374 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Isaac, Comments inline. Thanks, Nate -----Original Message----- From: Oram, Isaac W =20 Sent: Wednesday, January 12, 2022 7:15 PM To: Desimone, Nathaniel L ; devel@edk2.grou= ps.io Cc: Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric ; Tan, Ming ; Chiu, Chasel ; Bi, Dandan ; Shindo, Miki ; Abbas, Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature b= uild consistency Thanks Nate. Comments in line. Regards, Isaac -----Original Message----- From: Desimone, Nathaniel L Sent: Wednesday, January 12, 2022 6:47 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric ; Tan, Ming ; Chiu, Chasel ; Bi, Dandan ; Shindo, Miki ; Abbas, Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature b= uild consistency Hi Isaac, Thank you for doing this cleanup work. I have some comments for you. I have= provided a summary of my feedback below: PATCH 01/27 * Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc Line 69: [Components.IA32] should be changed to [Components.$(PEI_ARCH)] Li= ne 83: [Components.X64] should be changed to [Components.$(DXE_ARCH)] Note: These comments can also be addressed by restoring the @todo comment s= tating that these changes still need to be done (which you deleted.) [Isaac] $(DXE_ARCH) and $(PEI_ARCH) are not fully functional. It appears t= hat they are fine in DSC files, even when inside an include. But they are = not fine inside an include in an FDF file. The PreMemory.fdf and PostMemor= y.fdf do not work when I try to introduce this change. =20 As these are not required, ToDo are against coding style and are bad for co= mprehensibility, I would prefer to not add such useless comments back in. = Comments should improve the comprehensibility of code and should not distra= ct from understanding the code. [Nate] The $(PEI_ARCH)/$(DXE_ARCH) additions are not be necessary in the FD= F files. Adding them to the DSC file should be sufficient. Can you re-test = with just the DSC file change? PATCH 18/27 * Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc Line 33: [PcdsFeatureFlag.X64] should be changed to [PcdsFeatureFlag.$(DXE_= ARCH)] Note: This comment can also be addressed by adding a @todo comment stating = that this change still needs to be done. [Isaac] See prior response. PATCH 19/27 * Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc Line 35: Typo here. Usb3DebugPortParamLibo should be Usb3DebugPortParamLib. [Isaac] Good catch. I guess we don't catch that class of error if the libr= ary class is not used. * Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc Line 40: Did you test compilation for the Usb3DebugFeaturePkg? I've general= ly run into issues when a components sections does not specify a machine ar= chitecture through some sort of means. [Isaac] There is no code consuming these libraries. I verified build of 32= and 64 bit modes as well as part of AdvancedFeaturePkg build and a board p= ackage build. I believe that library classes can be specified by module type and the buil= d tool builds the right mode for the consuming driver on demand. Basically= , there is no value to specifying architecture for a library. This does not work with components however. If you leave the architecture = unspecified, you get an error when including the component in an FDF as the= build does not know how to resolve. [Nate] I bring this up because you added a [Components] section and put thi= s package's library classes into that [Components] section for the purposes= of running a build test on those library classes even though they are not = consumed by anything. That new [Components] section does not specify a mach= ine architecture so I'm wondering if the compilation still succeeds. PATCH 26/27 Since FvAdvanced is post-memory and not covered by the boot guard IBB, I su= spect we should probably also support optional signing of that FV. [Isaac] I do not know how to act on that suggestion. That seems out of sco= pe for this change. I restricted my changes to be functionally compatible = as I do not have hardware to test these changes other than minimally. [Nate] Nevermind. I checked all the OpenBoardPkgs we have and none of them = have FV signing enabled anyway. Ignore this comment. Thanks, Nate -----Original Message----- From: Oram, Isaac W Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric <= eric.dong@intel.com>; Tan, Ming ; Desimone, Nathaniel L= ; Chiu, Chasel ; Bi= , Dandan ; Shindo, Miki ; Abbas= , Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build= consistency This series addresses inconsistencies in feature implementation and use. So= me inconsistencies are just conventions of the feature design/template/conv= ention. Some are inconsistency with feature design intent that negatively = affect the usability of the features and the amount of work required from b= oard porting engineers. Some features were missing feature enable flags. Some features had non-functional standalone builds. Many features were implemented to include common core build content in thei= r feature include files. Updated some of the Readme content. Added AdvancedFeaturePkg.fdf to build all feature content to support verify= ing no build time issues between features. Removed duplicate and unused content from build files. Modified the TemplateFeaturePkg to use the common MinPlatform include conte= nt. Removed all instances where features were relative to Features/Intel and ma= de them relative to the package roots. This does mean PACKAGES_PATH may need to be extended for all the feature do= mains. Debugging, PowerManagement, etc. However, it should enable packaging tools to function properly as the relat= ive paths violate spec. Use of the common MinPlatformPkg build includes does increase the build tim= e for each individual feature in standalone build modes. It does not negati= vely impact board or AdvancedFeaturePkg builds as the common content is onl= y built once. Part of MinPlatform arch intent is to reduce cognitive comple= xity, so the simpler build is more valuable than fast build time. Cc: Sai Chaganty Cc: Liming Gao Cc: Eric Dong Cc: Ming Tan Cc: Nate DeSimone Cc: Chasel Chiu Cc: Dandan Bi Cc: Miki Shindo Cc: Mohamed Abbas Cc: Manickavasakam Karpagavinayagam Signed-off-by: Isaac Oram Isaac Oram (27): BeepDebugFeaturePkg: Use MinPlatformPkg build include files BeepDebugFeaturePkg: Fix all relative package paths AcpiDebugFeaturePkg: Fix all relative package paths IpmiFeaturePkg: Fix all relative package paths IpmiFeaturePkg: Fix build errors S3FeaturePkg: Fix all relative package paths S3FeaturePkg: Use MinPlatformPkg build include files SmbiosFeaturePkg: Fix all relative package paths SmbiosFeaturePkg: Use MinPlatformPkg build include files UserAuthFeaturePkg: Fix all relative package paths UserAuthFeaturePkg: Use MinPlatformPkg build include files VirtualKeyboardFeaturePkg: Fix all relative package paths VirtualKeyboardFeaturePkg: Use MinPlatformPkg build include files VirtualKeyboardFeaturePkg: Add feature enable PCD NetworkFeaturePkg: Use MinPlatformPkg build include files LogoFeaturePkg: Use MinPlatformPkg build include files PostCodeDebugFeaturePkg: Complete as an advanced feature AcpiDebugFeaturePkg: Use MinPlatformPkg build include files Usb3DebugFeaturePkg: Align with feature design guidelines SpcrFeaturePkg: Use MinPlatform build include files TemplateFeaturePkg: Use MinPlatform build include files AdvancedFeaturePkg: Fix all relative package paths AdvancedFeaturePkg: Add missing features MinPlatformPkg/Build: Add an include file for the common SPI FV info WhitleyOpenBoardPkg/Build: Use common SPI FV Header include AdvancedFeaturePkg/Build: Add FDF to create FV for all features WhitleyOpenBoardPkg/Build: Enable Features/Intel features Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = | 67 +++++- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf = | 49 +++++ Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc = | 49 +++-- Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc = | 64 +++++- Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf = | 49 +++-- Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf = | 49 +++-- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.= inf | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.= inf | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec = | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc = | 21 ++ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc = | 74 +------ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf = | 4 +- Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec = | 7 +- Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dsc = | 28 +++ Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc = | 222 ++++++------------- Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Library/BeepLib.h = | 6 +- Features/Intel/Debugging/BeepDebugFeaturePkg/Include/PostMemory.fdf = | 14 ++ Features/Intel/Debugging/BeepDebugFeaturePkg/Include/PreMemory.fdf = | 13 ++ Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/PeiBeepStatusCodeHandlerLib.inf | 5 +- Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/RuntimeDxeBeepStatusCodeHandlerLib.inf | 3 - Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/SmmBeepStatusCodeHandlerLib.inf | 3 - Features/Intel/Debugging/BeepDebugFeaturePkg/Readme.md = | 91 +++++--- Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostCodeDebugFeat= ure.dsc | 231 +++++--------------- Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostMemory.fdf = | 14 ++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PreMemory.fdf = | 13 ++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Library/PostCodeStatusCod= eHandlerLib/PeiPostCodeStatusCodeHandlerLib.inf | 2 +- Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeaturePkg.d= ec | 11 + Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeaturePkg.d= sc | 30 +++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Readme.md = | 31 ++- Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc = | 131 ++--------- Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md = | 50 +++-- Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec = | 14 +- Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc = | 18 ++ Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc = | 89 +------- Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc = | 18 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/GenericI= pmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGener= icIpmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGener= icIpmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc = | 90 ++------ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf = | 16 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf = | 6 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc = | 18 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf= | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf= | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/Ipmi= BaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLibNull/= IpmiBaseLibNull.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/I= pmiCommandLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHook= LibNull/IpmiPlatformHookLibNull.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/P= eiIpmiBaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/S= mmIpmiBaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf = | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/SpcrDevi= ceLib.h | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemory.fdf = | 13 ++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemory.fdf = | 11 + Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc = | 62 ------ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md = | 12 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec = | 6 + Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc = | 18 ++ Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf = | 2 +- Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc = | 74 +------ Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc = | 18 ++ Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf = | 2 +- Features/Intel/Readme.md = | 49 +++-- Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf = | 2 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.ds= c | 54 +---- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBas= icDxe.inf | 2 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec = | 10 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dsc = | 18 ++ Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc = | 2 +- Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc = | 18 ++ Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc = | 69 +----- Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec = | 2 - Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc = | 38 +++- Features/Intel/UserInterface/UserAuthFeaturePkg/Include/PostMemory.fdf = | 6 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.ds= c | 92 +------- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/PlatformPasswordLi= bNull/PlatformPasswordLibNull.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/UserPasswordLib/Us= erPasswordLib.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/UserPasswordUiLib/= UserPasswordUiLib.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dsc = | 18 ++ Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthentication2Dxe.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthenticationDxe.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthenticationSmm.inf | 2 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/PostMemory.= fdf | 2 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyb= oardFeature.dsc | 64 +----- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeat= urePkg.dec | 7 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeat= urePkg.dsc | 18 ++ Platform/Intel/{WhitleyOpenBoardPkg =3D> MinPlatformPkg}/Include/Fdf/Commo= nSpiFvHeaderInfo.fdf | 2 +- Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.fdf = | 48 ++-- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc = | 44 ++++ Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf = | 54 ++--- 96 files changed, 1159 insertions(+), 1334 deletions(-) create mode 10064= 4 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf create mode 100644 Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Po= stMemory.fdf create mode 100644 Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Pr= eMemory.fdf create mode 100644 Features/Intel/Debugging/PostCodeDebugFeaturePkg/Includ= e/PostMemory.fdf create mode 100644 Features/Intel/Debugging/PostCodeDebugFeaturePkg/Includ= e/PreMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inclu= de/PostMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inclu= de/PreMemory.fdf rename Platform/Intel/{WhitleyOpenBoardPkg =3D> MinPlatformPkg}/Include/Fd= f/CommonSpiFvHeaderInfo.fdf (88%) -- 2.27.0.windows.1