From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 44AC07803CD for ; Thu, 9 May 2024 19:19:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RwOfUaVoWo2hQ1bZAvWABo9gxeAMPLjNsSTm4Xu98Xk=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715282355; v=1; b=PAx8TusIRZY/xRgXbUywFrzzcybDa34S4avaqTIxqByMl0fphf9H5syJMNtchNTleII4fYeR jBj95RaqOlbdSOhi7KTyp0McQZ32wWFb0sZ+QzUNVaIRRIsb6gDPlDfARRZKmGRN9K88+iHDolW ist5N4NRzK6OvRfW/8l4UQsP9vUbh0gGDtdu+YYrzNEzdEGVDeTGEpyRnrEALQ8znVsbBCC72HM tzDXCEnfLbmlzTWAxzCZEV9kPuoteB+3RP+WQriPjkgA8XrNLP98FA/JUjTV+Q0X5jqKnstNOmj pDeofcVTXAvsGNtMQNVhyPSPLa3IWCf2L8uGDJ7nm5ApA== X-Received: by 127.0.0.2 with SMTP id pecPYY7687511xdGer68iw6l; Thu, 09 May 2024 12:19:15 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mx.groups.io with SMTP id smtpd.web11.317.1715282354932771212 for ; Thu, 09 May 2024 12:19:15 -0700 X-CSE-ConnectionGUID: 0NmXKzCdTe6H9+Uqh9ZnUw== X-CSE-MsgGUID: QIu6z0MhRruqeY7RAPz9ww== X-IronPort-AV: E=McAfee;i="6600,9927,11068"; a="15038735" X-IronPort-AV: E=Sophos;i="6.08,148,1712646000"; d="scan'208";a="15038735" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 12:19:15 -0700 X-CSE-ConnectionGUID: COwnng2gR1iNHmxDfL6KJg== X-CSE-MsgGUID: D1r7KOiJRnWICTkRj7kFwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,148,1712646000"; d="scan'208";a="33879827" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 May 2024 12:19:15 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 9 May 2024 12:19:14 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 9 May 2024 12:19:14 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 9 May 2024 12:19:11 -0700 X-Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by MN0PR11MB6253.namprd11.prod.outlook.com (2603:10b6:208:3c6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Thu, 9 May 2024 19:19:09 +0000 X-Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::c338:32f0:7c75:67d8]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::c338:32f0:7c75:67d8%7]) with mapi id 15.20.7544.046; Thu, 9 May 2024 19:19:09 +0000 From: "Nate DeSimone" To: Abdul Lateef Attar , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop Thread-Topic: [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop Thread-Index: AQHalL4CNUn+mBkEVUG57RS2Bn7U7rGPYbFQ Date: Thu, 9 May 2024 19:19:09 +0000 Message-ID: References: <2c10c7f9d2f548cf05cb23639dffe7c6576412ac.1713794592.git.AbdulLateef.Attar@amd.com> In-Reply-To: <2c10c7f9d2f548cf05cb23639dffe7c6576412ac.1713794592.git.AbdulLateef.Attar@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|MN0PR11MB6253:EE_ x-ms-office365-filtering-correlation-id: 72301a42-c46f-4ab2-a42e-08dc705ce71b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?Du3Cyt/zwecB7ISt5iubcwFVnfY/25LA8GzXXGWvPIz1FH84weFll0gP0CXU?= =?us-ascii?Q?PjPBVF1tJXUXhsVoqqlS1K+wZELwzyl0ZBnLguaCR9qSDrIgYmYDh4KWxCAK?= =?us-ascii?Q?zPMQJvHrt8m3Wenf/ADR+ZNpEKi2slb90eB+9Cj2Er3BPZJhy9KfeAuQ4KI1?= =?us-ascii?Q?7Jsn10D0LsVS5/kdvqLIDCa4qC/7wCjrlbdpqhQhyLP/Z3lRYoiZCossiawy?= =?us-ascii?Q?2ZSY/q1QFhWIjhVjT8dT6dQM5RINGs0tpYEU+r2I7KnHQLUGddXXq4gEgCSx?= =?us-ascii?Q?gmDlaUp/KI9HEKpcVxdtdKfR8U5eM2xnY6l8EXWn3TrNwKfjP/lEwXQ8W5gK?= =?us-ascii?Q?EQ/G6kZCdWY+coMIPnS/7IvUvKwBXuSI7GObj7hD/heAyV0abj+/bJm21IaY?= =?us-ascii?Q?bfOdysOGfVNiKH3BsvrfzfSyLdFJH71aVjw7ZEjPirfF9lau8bfD3krnon4Q?= =?us-ascii?Q?Xqlb+D4QQt1Oj31t7EVlgpwxN/Jcsap5qLhrGTPFgzUkyYly6VfCeECH97cS?= =?us-ascii?Q?4zc76uTwPmiebMT3mv7kxO0aDE2pUJnJUOd9oR3zXKYX3Cm98u9u00zSk0mx?= =?us-ascii?Q?QVHP9NxMsOg3cwFkVKwBspg0AVCrlRALIhRayIlqoOUgOiZ3zyCZkAmIf1RV?= =?us-ascii?Q?/WP0u20Py+vtrsXrnwMlN5gN894t+xTOqwUjSmSJs/YHuiWkH5HM2q+tudjD?= =?us-ascii?Q?H51k+1XliplykJFw55FT6vBdEQL0AR++8OMfKTVpIndI/FA/TWCN62KQEdf9?= =?us-ascii?Q?OsLj5BhqN3csy7KDK81PifsX8r2Cy+320sSUuu+bfPkvTfe0I3L066S6QHjc?= =?us-ascii?Q?YQC0JFmGDCZZycJPds6AaNWSGv9L+njZdJlEq1IMmMUX3QjgtNvhPBxmD7+Y?= =?us-ascii?Q?6VhwD/7D+UgxsOzLeiVNBD6XxKX+O8MCfikOW5y7MhorfKpXnjIXshAfAj+M?= =?us-ascii?Q?Jdkzzc+HlhBmBWjKkvGmSwG02z7cp9bOqhkVZkb4RhzZA6OWT0h1eoIDwVjE?= =?us-ascii?Q?1ZAtx48YeFdtrudb7dA8CHXybMtKd6yZxOPHIOzrxCmQHYmQtTdl+eRl+kzF?= =?us-ascii?Q?KSaBAj0rBycFaUzrabO9bX+HAOslF40Vt07T8/QxcdEHK/cmHJ47KqYPkeWu?= =?us-ascii?Q?4t4OMOoQ3r13bHbIjK4ioFeuIx+4LotamHwkEEdDnQPR4StiKjZtAot+o4GE?= =?us-ascii?Q?MOfnKSCeI9RI3M3bXGP9Yin5MZCFDl8/tUDFVrHNr2V/bOAWy4DxGWjI6N2p?= =?us-ascii?Q?XS/4M7GR39PJQub/S+lmnZwDkpf47a6FB2+4WlIzI88PKYT106GAjIPC6QN9?= =?us-ascii?Q?DSNY5TtoNvXI00E/hL0BHJD70/U1r3vYq5/UUDDCTHASoA=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y4n9KqnU73cyQoBIgfJYSdQPxiXjOClgGQ4O+4nOLnHHkuoP8HHrJIuYvzsu?= =?us-ascii?Q?IAPh9/IFe97vByccx8ZrH7LYYCS0eUZ+ji6F72zvVBk6k9x3RfYAYmbKByEe?= =?us-ascii?Q?eavoUVdCfmItFqS6EQO/oDlHqZb76xR+kD7KwtBLuGma/6cnEPeW2JEYN8b2?= =?us-ascii?Q?DrlrCaFwAQ+C9IHjC7wpw1chkH9wAOfJqcpVX4E3OMsnu52NmqlqCJi4M/So?= =?us-ascii?Q?ZHDpSc03DxbMfU60hGqwtgFYcsD3EdMQBk1kM0cq/MayW3EK/XXNL7ob0+XJ?= =?us-ascii?Q?stFKdJPS/1pkvPoCD07znvs52v5F9RVTWrM5lFhFQnmfNR/dXPVLFD18KpwV?= =?us-ascii?Q?Ftbt52qj5dUfjPhquu/FA+7HFx+CGlpM+pRxSH32ofbupsK7IXFfXRjlR589?= =?us-ascii?Q?RL6xKCrnrAkucpCXNCgJHyH51H6gKxSTtW9CjQg/12E7SECLII8SuB+nyPoU?= =?us-ascii?Q?cgF0HPeNGjY6G5tVSVQZwL7bfmH1vxUwfcFQ7cN/p/7snZMtCnmf2Le408+z?= =?us-ascii?Q?Q7bHSIZWLGF45Ssht4wkil6H2BDN/TzRh8xJGm4WkaO/4WcpYoUmGasyOEcN?= =?us-ascii?Q?rs+Qlwp/cKIB8Us+rpvrMGn5W7SULuEtMD/Jq4c276D4eRwuMlHwW7mdh0yk?= =?us-ascii?Q?ASF9ONDfz+ldlSZxtfZVvZCeRPPBEBhKmmbuI+bvwwN0cDptQS/9kJCsl8KU?= =?us-ascii?Q?3hUBUS+pXhhJECXicc+MYFFU1itLyvhAYvpObOzdmmDkxRwM2KwSeIIM//12?= =?us-ascii?Q?K8HKBiE31+ZUk0WwlSy4rmZdW8M3kgxSz0xT+qhTtB+tWV0XXNhiSgQFe9y0?= =?us-ascii?Q?w8XVBjw50jDvl0suZuY7uv7CQkBgqJECxZ2jtU+NZGHxQSXWlv/pcW7Dnk+e?= =?us-ascii?Q?WSn0Ihknr+MKieX3EeywpmNB5slLHacQ13xz0htdDmygr4SSRlSX1YpQdoBh?= =?us-ascii?Q?6ocvYJ2dpHT9hxhDuO2ZUtf0oBS9RwiGjyVR1Q/JGdR9E+1NVlKX1GqKh2q1?= =?us-ascii?Q?X+vG8RSCIThRW/5vqkXhb93z0gsQRVQMuB9oG2U3xQImB/sdI0fkvGPrfkls?= =?us-ascii?Q?OjksHKsq6j7LQck0gITK0S0ws2JzvWBuijD+ZODmZoXgTX5Ur9jmvQKpPMs0?= =?us-ascii?Q?N4d88LvQRjhFxi5bprdu/IZw14s7ARq+vOHKiLhte3tk1Ww3pjoxbBbEBjF0?= =?us-ascii?Q?GqA7CCyWZDZnPojUlgjI7M0T/mvIjHFrJhCm01xLYFzGIEUk1TIiCaAHy4sh?= =?us-ascii?Q?MddQLqPBZqSi8MN2BeutlLXIdVoKxTz/c0vmedQ8axEYu6dGhr/tUPOXJh8l?= =?us-ascii?Q?Yqtv/KZiQxaj0kiA/9g+9dhs9KVy1ATsyms0piO1z6z/buYN59BaScV61KEc?= =?us-ascii?Q?KaBScsNeqZ/AVkGhdz5rTh/XXgWe43kLeQCpQ+4libg8TyvODBM7+8o/SCk/?= =?us-ascii?Q?4hf1OlgRGzi9c+eGYe8uCVqPwKT2JZcl7eR6V3va322GI7Q4s7EEF8ECwsp1?= =?us-ascii?Q?kgm/BOoaXE4H20qOfQ8yfpkwbi8YP8SUXd8jpVEToTsQ7DJptjzyt0Dy0P+r?= =?us-ascii?Q?yA4oKaTd4re/pdwmrbRHIsr+YIwAa36i3JhzbwTSsFym//+iWit1LGtXhIvA?= =?us-ascii?Q?WQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72301a42-c46f-4ab2-a42e-08dc705ce71b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2024 19:19:09.6221 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xlvlM9mG7HRrC8qKop8R04297cmo7yURfPLP2dJvbdG0GhgYFM3H4QIfmmMxZtqd+iNIgRz/QVFuiU3JoSQhIGqiASLpUek9jbK6LnBkp9o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6253 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 09 May 2024 12:19:15 -0700 Resent-From: nathaniel.l.desimone@intel.com Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hN6NPWGLQuvGS2s96ojBI7eMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=PAx8TusI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nate DeSimone > -----Original Message----- > From: Abdul Lateef Attar > Sent: Monday, April 22, 2024 7:04 AM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop >=20 > Update the MadtLen varaible before the next record is read, to void infin= ite > loop. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Abdul Lateef Attar > --- > .../Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib= /DxeCheckAcpiMadt.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointC= heckLib/DxeCheckAcpiMadt.c > index 7e29b47a0b..04cc6f963a 100644 > --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChe= ckAcpiMadt.c > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChe= ckAcpiMadt.c > @@ -1,6 +1,7 @@ > /** @file > =20 > Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > **/ > @@ -235,8 +236,9 @@ DumpAcpiMadt ( > DEBUG ((DEBUG_INFO, "\n")); > break; > } > - ApicStructHeader =3D (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeade= r + ApicStructHeader->Length); > + // Update MadtLen first to avoid the dead loop and system hang > MadtLen -=3D ApicStructHeader->Length; > + ApicStructHeader =3D (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeade= r + ApicStructHeader->Length); > } > } > =20 > @@ -324,8 +326,9 @@ CheckAcpiMadt ( > default: > break; > } > - ApicStructHeader =3D (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeade= r + ApicStructHeader->Length); > + // Update MadtLen first to avoid the dead loop and system hang > MadtLen -=3D ApicStructHeader->Length; > + ApicStructHeader =3D (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeade= r + ApicStructHeader->Length); > } > return EFI_SUCCESS; > } > \ No newline at end of file > --=20 > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118769): https://edk2.groups.io/g/devel/message/118769 Mute This Topic: https://groups.io/mt/105669987/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-