* [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop
@ 2024-04-22 14:03 Abdul Lateef Attar via groups.io
2024-05-09 19:19 ` Nate DeSimone
2024-05-09 20:16 ` Nate DeSimone
0 siblings, 2 replies; 3+ messages in thread
From: Abdul Lateef Attar via groups.io @ 2024-04-22 14:03 UTC (permalink / raw)
To: devel; +Cc: Abdul Lateef Attar, Chasel Chiu, Nate DeSimone, Liming Gao,
Eric Dong
Update the MadtLen varaible before the next record is read,
to void infinite loop.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
---
.../Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
index 7e29b47a0b..04cc6f963a 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
@@ -1,6 +1,7 @@
/** @file
Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -235,8 +236,9 @@ DumpAcpiMadt (
DEBUG ((DEBUG_INFO, "\n"));
break;
}
- ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
+ // Update MadtLen first to avoid the dead loop and system hang
MadtLen -= ApicStructHeader->Length;
+ ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
}
}
@@ -324,8 +326,9 @@ CheckAcpiMadt (
default:
break;
}
- ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
+ // Update MadtLen first to avoid the dead loop and system hang
MadtLen -= ApicStructHeader->Length;
+ ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
}
return EFI_SUCCESS;
}
\ No newline at end of file
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118095): https://edk2.groups.io/g/devel/message/118095
Mute This Topic: https://groups.io/mt/105669987/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop
2024-04-22 14:03 [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop Abdul Lateef Attar via groups.io
@ 2024-05-09 19:19 ` Nate DeSimone
2024-05-09 20:16 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2024-05-09 19:19 UTC (permalink / raw)
To: Abdul Lateef Attar, devel@edk2.groups.io
Cc: Chiu, Chasel, Liming Gao, Dong, Eric
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Monday, April 22, 2024 7:04 AM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop
>
> Update the MadtLen varaible before the next record is read, to void infinite
> loop.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
> .../Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
> index 7e29b47a0b..04cc6f963a 100644
> --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
> @@ -1,6 +1,7 @@
> /** @file
>
> Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -235,8 +236,9 @@ DumpAcpiMadt (
> DEBUG ((DEBUG_INFO, "\n"));
> break;
> }
> - ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
> + // Update MadtLen first to avoid the dead loop and system hang
> MadtLen -= ApicStructHeader->Length;
> + ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
> }
> }
>
> @@ -324,8 +326,9 @@ CheckAcpiMadt (
> default:
> break;
> }
> - ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
> + // Update MadtLen first to avoid the dead loop and system hang
> MadtLen -= ApicStructHeader->Length;
> + ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
> }
> return EFI_SUCCESS;
> }
> \ No newline at end of file
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118769): https://edk2.groups.io/g/devel/message/118769
Mute This Topic: https://groups.io/mt/105669987/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop
2024-04-22 14:03 [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop Abdul Lateef Attar via groups.io
2024-05-09 19:19 ` Nate DeSimone
@ 2024-05-09 20:16 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2024-05-09 20:16 UTC (permalink / raw)
To: Abdul Lateef Attar, devel@edk2.groups.io
Cc: Chiu, Chasel, Liming Gao, Dong, Eric
Pushed as 3f89df4
> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Monday, April 22, 2024 7:04 AM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop
>
> Update the MadtLen varaible before the next record is read, to void infinite
> loop.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
> .../Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
> index 7e29b47a0b..04cc6f963a 100644
> --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpiMadt.c
> @@ -1,6 +1,7 @@
> /** @file
>
> Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -235,8 +236,9 @@ DumpAcpiMadt (
> DEBUG ((DEBUG_INFO, "\n"));
> break;
> }
> - ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
> + // Update MadtLen first to avoid the dead loop and system hang
> MadtLen -= ApicStructHeader->Length;
> + ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
> }
> }
>
> @@ -324,8 +326,9 @@ CheckAcpiMadt (
> default:
> break;
> }
> - ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
> + // Update MadtLen first to avoid the dead loop and system hang
> MadtLen -= ApicStructHeader->Length;
> + ApicStructHeader = (APIC_STRUCT_HEADER *)((UINT8 *)ApicStructHeader + ApicStructHeader->Length);
> }
> return EFI_SUCCESS;
> }
> \ No newline at end of file
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118770): https://edk2.groups.io/g/devel/message/118770
Mute This Topic: https://groups.io/mt/105669987/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-09 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22 14:03 [edk2-devel] [PATCH v1] MinPlatformPkg/Test: Fix DumpAcpiMadt infinite loop Abdul Lateef Attar via groups.io
2024-05-09 19:19 ` Nate DeSimone
2024-05-09 20:16 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox