From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc
Date: Mon, 13 May 2024 21:34:04 +0000 [thread overview]
Message-ID: <PH0PR11MB5832CBBB17FA57ABC04549AACDE22@PH0PR11MB5832.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240510020843.9-2-vnowkakeane@linux.microsoft.com>
Pushed as 59c6866
> -----Original Message-----
> From: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
> Sent: Thursday, May 9, 2024 7:09 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc
>
> When building MinPlatformPkg, a build error occured because the inf was not
> found. The path was incorrect -- DxePhatAcpiLib folder doesn't exist,
> PhatAcpiLib does.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
> ---
> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index ecb4d8f65efa..f81ad3cabf56 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -64,7 +64,7 @@
> PciSegmentInfoLib|MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.inf
> PlatformBootManagerLib|MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
> AslUpdateLib|MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf
> - PhatAcpiLib|MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.inf
> + PhatAcpiLib|MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.inf
>
> #
> # Misc
> @@ -209,7 +209,7 @@
> MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.inf
> MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib.inf
>
> - MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.inf
> + MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.inf
>
> [BuildOptions]
> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> --
> 2.43.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118876): https://edk2.groups.io/g/devel/message/118876
Mute This Topic: https://groups.io/mt/106014298/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-05-13 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 2:08 [edk2-devel] [PATCH v1 0/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path VivianNK
2024-05-10 2:08 ` [edk2-devel] [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc VivianNK
2024-05-13 21:32 ` Nate DeSimone
2024-05-13 21:34 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5832CBBB17FA57ABC04549AACDE22@PH0PR11MB5832.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox