From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kraxel@redhat.com" <kraxel@redhat.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"Xu, Min M" <min.m.xu@intel.com>,
"Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Rebecca Cran <rebecca@bsdio.com>, Julien Grall <julien@xen.org>,
James Bottomley <jejb@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
"Brijesh Singh" <brijesh.singh@amd.com>,
Pawel Polawski <ppolawsk@redhat.com>,
"Peter Grehan" <grehan@freebsd.org>,
Oliver Steffen <osteffen@redhat.com>
Subject: Re: [edk2-devel] [PATCH 0/3] OvmfPkg: move include files to inc subdir
Date: Fri, 9 Dec 2022 07:10:41 +0000 [thread overview]
Message-ID: <PH0PR11MB5879023E7512A7902BDD29018C1C9@PH0PR11MB5879.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221202130533.3187383-1-kraxel@redhat.com>
Hi Gerd
I like the idea to put *.dsc and *.fdf to a subdirectory.
I recommend to follow what we did in MinPlatformPkg.
https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Include/Dsc
https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Include/Fdf
*.dsc -> Include/Dsc
*.fdf-> Include/Fdf
Thank you
Yao, Jiewen
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> Hoffmann
> Sent: Friday, December 2, 2022 9:06 PM
> To: devel@edk2.groups.io
> Cc: Anthony Perard <anthony.perard@citrix.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Xu, Min M <min.m.xu@intel.com>; Boeuf,
> Sebastien <sebastien.boeuf@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Rebecca Cran <rebecca@bsdio.com>; Julien
> Grall <julien@xen.org>; James Bottomley <jejb@linux.ibm.com>; Tom
> Lendacky <thomas.lendacky@amd.com>; Aktas, Erdem
> <erdemaktas@google.com>; Gerd Hoffmann <kraxel@redhat.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Brijesh Singh <brijesh.singh@amd.com>;
> Pawel Polawski <ppolawsk@redhat.com>; Peter Grehan
> <grehan@freebsd.org>; Oliver Steffen <osteffen@redhat.com>
> Subject: [edk2-devel] [PATCH 0/3] OvmfPkg: move include files to inc subdir
>
> We have a number of include files for *.dsc and *.fdf in OvmfPkg/, lets
> unclutter the directory a bit by moving them all to a subdirectory.
>
> Gerd Hoffmann (3):
> OvmfPkg: move dsc and fdf include snippets for TPM support to inc
> subdir
> OvmfPkg: move dsc include snippet for Network support to inc subdir
> OvmfPkg: move fdf include snippets to inc subdirectory
>
> OvmfPkg/{ => inc}/NetworkComponents.dsc.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmComponentsDxe.dsc.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmComponentsPei.dsc.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmDefines.dsc.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmLibs.dsc.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmPcds.dsc.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmPcdsHii.dsc.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmSecurityStub.dsc.inc | 0
> OvmfPkg/AmdSev/AmdSevX64.dsc | 14 +++++++-------
> OvmfPkg/CloudHv/CloudHvX64.dsc | 16 ++++++++--------
> OvmfPkg/Microvm/MicrovmX64.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32.dsc | 16 ++++++++--------
> OvmfPkg/OvmfPkgIa32X64.dsc | 16 ++++++++--------
> OvmfPkg/OvmfPkgX64.dsc | 16 ++++++++--------
> OvmfPkg/AmdSev/AmdSevX64.fdf | 10 +++++-----
> OvmfPkg/Bhyve/BhyveX64.fdf | 6 +++---
> OvmfPkg/CloudHv/CloudHvX64.fdf | 6 +++---
> OvmfPkg/IntelTdx/IntelTdxX64.fdf | 8 ++++----
> OvmfPkg/Microvm/MicrovmX64.fdf | 6 +++---
> OvmfPkg/OvmfPkgIa32.fdf | 12 ++++++------
> OvmfPkg/OvmfPkgIa32X64.fdf | 12 ++++++------
> OvmfPkg/OvmfPkgX64.fdf | 12 ++++++------
> OvmfPkg/OvmfXen.fdf | 8 ++++----
> OvmfPkg/Include/WorkArea.h | 2 +-
> OvmfPkg/Sec/AmdSev.h | 2 +-
> OvmfPkg/Sec/AmdSev.c | 2 +-
> .../{ => inc}/FvmainCompactScratchEnd.fdf.inc | 0
> OvmfPkg/{ => inc}/OvmfPkgDefines.fdf.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmDxe.fdf.inc | 0
> OvmfPkg/{ => inc}/OvmfTpmPei.fdf.inc | 0
> OvmfPkg/{ => inc}/VarStore.fdf.inc | 0
> OvmfPkg/{ => inc}/XenElfHeader.fdf.inc | 0
> 32 files changed, 84 insertions(+), 84 deletions(-)
> rename OvmfPkg/{ => inc}/NetworkComponents.dsc.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmComponentsDxe.dsc.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmComponentsPei.dsc.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmDefines.dsc.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmLibs.dsc.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmPcds.dsc.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmPcdsHii.dsc.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmSecurityStub.dsc.inc (100%)
> rename OvmfPkg/{ => inc}/FvmainCompactScratchEnd.fdf.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfPkgDefines.fdf.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmDxe.fdf.inc (100%)
> rename OvmfPkg/{ => inc}/OvmfTpmPei.fdf.inc (100%)
> rename OvmfPkg/{ => inc}/VarStore.fdf.inc (100%)
> rename OvmfPkg/{ => inc}/XenElfHeader.fdf.inc (100%)
>
> --
> 2.38.1
>
>
>
>
>
next prev parent reply other threads:[~2022-12-09 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 13:05 [PATCH 0/3] OvmfPkg: move include files to inc subdir Gerd Hoffmann
2022-12-02 13:05 ` [PATCH 1/3] OvmfPkg: move dsc and fdf include snippets for TPM support " Gerd Hoffmann
2022-12-02 13:05 ` [PATCH 2/3] OvmfPkg: move dsc include snippet for Network " Gerd Hoffmann
2022-12-02 13:05 ` [PATCH 3/3] OvmfPkg: move fdf include snippets to inc subdirectory Gerd Hoffmann
2022-12-09 7:10 ` Yao, Jiewen [this message]
2022-12-09 13:04 ` [edk2-devel] [PATCH 0/3] OvmfPkg: move include files to inc subdir Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5879023E7512A7902BDD29018C1C9@PH0PR11MB5879.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox