From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Ryan Afranji <afranji@google.com>
Cc: "Nakajima, Jun" <jun.nakajima@intel.com>,
"Xu, Min M" <min.m.xu@intel.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
"vannapurve@google.com" <vannapurve@google.com>
Subject: Re: [edk2-devel] [V1 PATCH 1/1] OvmfPkg: Add INVD case in #VE handler
Date: Fri, 9 Dec 2022 07:11:57 +0000 [thread overview]
Message-ID: <PH0PR11MB5879337CD65DD2AD637431638C1C9@PH0PR11MB5879.namprd11.prod.outlook.com> (raw)
In-Reply-To: <172F0D44D4F3B834.22457@groups.io>
Merged https://github.com/tianocore/edk2/pull/3741
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Friday, December 9, 2022 2:50 PM
> To: Ryan Afranji <afranji@google.com>; devel@edk2.groups.io
> Cc: Nakajima, Jun <jun.nakajima@intel.com>; Xu, Min M
> <min.m.xu@intel.com>; Aktas, Erdem <erdemaktas@google.com>;
> vannapurve@google.com
> Subject: Re: [edk2-devel] [V1 PATCH 1/1] OvmfPkg: Add INVD case in #VE
> handler
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
> > -----Original Message-----
> > From: Ryan Afranji <afranji@google.com>
> > Sent: Thursday, December 8, 2022 8:51 AM
> > To: devel@edk2.groups.io
> > Cc: Nakajima, Jun <jun.nakajima@intel.com>; Xu, Min M
> > <min.m.xu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Aktas,
> Erdem
> > <erdemaktas@google.com>; vannapurve@google.com; Ryan Afranji
> > <afranji@google.com>
> > Subject: [V1 PATCH 1/1] OvmfPkg: Add INVD case in #VE handler
> >
> > According to the Intel GHCI specification document section 2.4.1, the
> > goal for instructions that do not have a corresponding TDCALL is for the
> > handler to treat the instruction as a NOP.
> >
> > INVD does not have a corresponding TDCALL. This patch makes the #VE
> > handler treat INVD as a NOP.
> >
> > Signed-off-by: Ryan Afranji <afranji@google.com>
> > ---
> > OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > index c35f65a649..3798c2bb13 100644
> > --- a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > +++ b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > @@ -541,6 +541,7 @@ CcExitHandleVe (
> > case EXIT_REASON_MONITOR_INSTRUCTION:
> > case EXIT_REASON_WBINVD:
> > case EXIT_REASON_RDPMC:
> > + case EXIT_REASON_INVD:
> > /* Handle as nops. */
> > break;
> >
> > --
> > 2.39.0.rc1.256.g54fd8350bd-goog
>
>
>
>
>
prev parent reply other threads:[~2022-12-09 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 0:51 [V1 PATCH 1/1] OvmfPkg: Add INVD case in #VE handler Ryan Afranji
2022-12-09 6:49 ` Yao, Jiewen
[not found] ` <172F0D44D4F3B834.22457@groups.io>
2022-12-09 7:11 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5879337CD65DD2AD637431638C1C9@PH0PR11MB5879.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox