From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.3137.1649403387177659613 for ; Fri, 08 Apr 2022 00:36:27 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FTicv67t; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649403387; x=1680939387; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FlKvQWWE3GCu5icF/iZ3vza6KQj91Mu0Un9m2zFbosM=; b=FTicv67tmRxoMVd1h+uxIBUss7c0R1HERlgzgByHZH1o7YWohuKEKpy1 n2FQ1PSpayVjhBJ18RQOkmtSjL+2EIV5HFdA1kd2AefJsAGq/vVNSsw6E f/tGm9dP6sEfxmxBhpn7vM3b0jh2kgJDew+eYT6FQ/maR4vNEWKSSLhRP JqkEarXOqlzEtZRo8qomKKr1V7DnXVtSKMRJ491NYWXYG9BL3ERKDDBsG o12WZLMq4H1EqGBhPzV6H0em9S1EuKcMN2vZlIrog6nYc/wz8OnVO4d23 221gjz9vZuHfaMvZW9sVRSoBlpjH7948XbScDNqNtvVtrI7fR/uP3oul1 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="260370303" X-IronPort-AV: E=Sophos;i="5.90,244,1643702400"; d="scan'208";a="260370303" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2022 00:36:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,244,1643702400"; d="scan'208";a="723297866" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 08 Apr 2022 00:36:22 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 8 Apr 2022 00:36:22 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 8 Apr 2022 00:36:22 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 8 Apr 2022 00:36:22 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 8 Apr 2022 00:36:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEzVlIvp9gJHpP61pmWCBMwDAWL/8YlIq63snLElhP02tA/6TZX3gOHf6VrJZeZt8RclL+xL7i7/SMwKjdduxrAo9rFJzFq54NmaKhyonT/wkjESVRqLaGoDIRVwQoj5frO8cNnVfo1+LbBuQiU8vrsRYkBoOqOQLGWYNF/t3TKLKhpkCYp4WCne9iUSX6SoO6nQy1SKQ1cvisHsCTuShBbz6pvFut59HGVLxaCh7KY0Pr8dbG2RebA9LqMBVWEUBBZRUpIFv4FsjelxW9N1YzkPrxW4l71JSxcN/x3W7gD/L5+xxYh1qSi8VfMMQgr3qKOmgrAvIx6Fg/dBLh/E5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3+8pdSteozizHHakmCVNKfeFR+3uA6BNB+b19YF7SXM=; b=EEQXCF8NEIsg2uH7remiZ5R7NgaoLEYkHrJCkHtWdMkHkNiq9mqb+spI6tWFQl/vwUOkhzzQmGujVtZBUhfkOWfxemb1LeDVD6lBUqriJCh+Baf6ljNJvASLMbZGnYtOrLsSYQOLXnuJ7r2nx74kOJVo+hF1HUPaB80Md5xwhRcnr8ii21qi89TXjUETX8FNTJ2CpVo8vQpR9L7WJOCymZ6qxl55r2M2tQgHQYGGd4V86Ysi3oD6elSZRtchOaFHP4tRVb3t+xURYf79SdeSdzSP6UPMi13+oic9Wl8PWM+iKaLdtS+9F7su8tf3ewCD0OiVcac+hIlCTfIkww5xvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5879.namprd11.prod.outlook.com (2603:10b6:510:142::5) by DM4PR11MB5454.namprd11.prod.outlook.com (2603:10b6:5:399::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.26; Fri, 8 Apr 2022 07:36:20 +0000 Received: from PH0PR11MB5879.namprd11.prod.outlook.com ([fe80::289d:9245:f6bd:af78]) by PH0PR11MB5879.namprd11.prod.outlook.com ([fe80::289d:9245:f6bd:af78%5]) with mapi id 15.20.5144.022; Fri, 8 Apr 2022 07:36:20 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" , "Gerd Hoffmann" Subject: Re: [PATCH V2 2/8] CryptoPkg: Add SecCryptLib Thread-Topic: [PATCH V2 2/8] CryptoPkg: Add SecCryptLib Thread-Index: AQHYSxO8hF5Xt1mh/kaY/P3+LiuvcazloDQw Date: Fri, 8 Apr 2022 07:36:20 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e72f1693-22f6-4dea-edf8-08da1932796f x-ms-traffictypediagnostic: DM4PR11MB5454:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U0a2Sgxg7txJ8FTIevWjC/qaOyzDPqtJTuFuSwQI2gixrPACXSvZnmUlrfYp8naybnJFpCwPMjWWyZoMY5MurUrw7TMM3Nq/QUZzAXeYDzRurtNeRBwszViBOxeFasWm1yEv0sQ8/GOYxUkuMyBX1d6pH6AG0+NJDoCf+xDiyEe3LdfQUfEC51jEw04DsD98iAhvHGd+GpYb3Bm8ZVLxtux37c/VHZRWBuCo0erKVjQQiyEZGtvkUHztGdET67qs/Y8E6TuputkYziHJIhVNv0aTnM/yL/tvHYuf1MmqTHxU8RIY43J3WvuWyOwZ4jfG4sf2VageDzCyW4HMF9zqAc3hdI6rErhdygMrnavj/eJeJPVFDPsyhMgT6y16QUm9LwM2BFHeoa+wi1vQcnAgbtH+qHgkzfVJl+2UDaIkypjrtD4Aakc0tiykOKX8u/mM05L6GnxkVjUh/tI0W/pfvDI0Myh9DZEOTrYzENXhkAByoButEzrOf6h7wwiLPsj651m4N5p8C2w2dxOLT4XoOL9DmE/Wc1v5HyhjmoI4Z96gzjf5r87OXkFBqHMwfZLwsH99JdfcF2a7zbP/Sa06C0UnXhK5PNshpIvJ+134Rw+acHh5qtyVXki8gELcOTbdzd5qWIxoNSHPRQVgSLDwGXvQ3jR/L1PW79/NoRlH9tkX2Zqku9DsIU7/nUHCMZzTidakqX/0kt7ekMN6UaUJiepflaANHb2RcT9GsEcqEkTXJBBZ1x91+BV5fvUgWUo6XMi9Bi7GHjuep4P0eKbs33rfrXWbMoOE6l9z0DI81CfTSZevRV8p5Hk35UpJjGEq x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5879.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(76116006)(966005)(122000001)(64756008)(8676002)(66946007)(66446008)(66476007)(66556008)(4326008)(38070700005)(316002)(86362001)(82960400001)(38100700002)(26005)(5660300002)(186003)(52536014)(2906002)(110136005)(8936002)(54906003)(6506007)(7696005)(9686003)(508600001)(53546011)(33656002)(55016003)(71200400001)(83380400001)(19627235002)(3714002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?17ErQQxwRCIB94PKw3PYp5spHw120hH/hIdR31vvl+IG//DauopQVZPdZQYR?= =?us-ascii?Q?5Mcx63/fsBUwR1VzRrQutsdDyDqJwXYr81DSFyli9+jZ0ilIx1ZT9WInjvq/?= =?us-ascii?Q?niLFizXwAhYDsQLfvMIBaZn50uwdlKODZ+zoUYo3uvPsasl9uW7c4iUzKtSC?= =?us-ascii?Q?TbCG6xTbYe0p/CyIbQwa9GKsgewv6o5dBJrAdVrUyUFYWCQV8PhbtMhEhd9y?= =?us-ascii?Q?06TS3+l//9NRHXIFv8vT7f+T4hRvwmwJLU9V5lNK/8pJ4w7drT1pPV1wJuj/?= =?us-ascii?Q?j3vXeRuSyRt2yEwyxAyTzVlzkf92qQ1lM5C+ipdAP+mL/HNIibsjgMfFIPJ+?= =?us-ascii?Q?ZZP7RQ2wK+Fhg0g210ssoS7BOoTv3VGDpXLguENjr0uexNHmSO0d+ru3t8io?= =?us-ascii?Q?byhEVpr1HMKTOparN3BwfGGkeJbu91sla5NIaNrwXV6ppjdy62dIZ2jPD5xs?= =?us-ascii?Q?blyjUFFE4c9dgNs/CsE12RN+eplFS7u+k/K3V6pQYmxkgM4afRhbp1hiSJcD?= =?us-ascii?Q?wjBclieg5KvY0z+obwGOlZdY8IPWZTyIO7ErxMaSN8d0ST9JP5yRSuMw8Jqc?= =?us-ascii?Q?kQdEW8ffQmmZrI+Ovss2PTAG2MpHUT+DVz5DBNfeQdcvmvrF1FB5kP1n0M+k?= =?us-ascii?Q?/QfYbOfthPzhh/rOhRAS3i68rnZ09mId1LMysj96onuGG2FS7zmNpJk6wnFo?= =?us-ascii?Q?CI3KVJNSYyF3D07MQXwCuA9rVVAB2WmaDivgDX8A41S7hfcQamXwllsETxR8?= =?us-ascii?Q?EH3jZ+StSbAXgUHWKtrRvtsPjQIp+SzBtaTsUUcrbIM7HKAZ5wL244cWl66R?= =?us-ascii?Q?4ywweYXrYvVaUOCBf1YPWY/pmLpsdHD8ce2HdDqokJQgkSFyRY7Tc47U4W7e?= =?us-ascii?Q?Nv7wJwwWL11vL1ik1/6D5E15IznqocJSrcFhtyBbba6NCgxZEU8RqDxeGltH?= =?us-ascii?Q?Z/wFXvg28at1gO4sx1bEx8Xax695Hq/pLZPvuXJpZCtmXcpMBT4l4v2TynJx?= =?us-ascii?Q?w4EXMTCRIHOjqEqTeSMqSFnuvgqGPbEEMMJAtQvaK/Z5NvEyQfl7eVweNsgQ?= =?us-ascii?Q?usiMNFB9EXnw7g1iJ9ryRybPzyf6zXfdh+H4D1Z2yhfRMUzmNvtITGOMom0l?= =?us-ascii?Q?Y/PVvtnk7Y6Uw6BMXitnhB/WpVLUs2d4QnfV/Yr1YVCq+RAwLP5SldH8jzo9?= =?us-ascii?Q?4YcxVxU31q75YHnfMssYEfNFQLOrPGQzNMG69VT4s9NW2SRTBGR0/AvhCyxk?= =?us-ascii?Q?3V1+vTFKjlYbJr4bs0JAy1nor4n6Mn/vipXUGV0Pm57yl3jtpCQnSRJoUksV?= =?us-ascii?Q?DXsBvgS1DSiqZzpF3efzFnvF9vgjmkvLCbpwErmIBjtyAYjmOQPRn22hvtgP?= =?us-ascii?Q?Fc/zoxP5vfh+Z4mYKauvk8kvA0A6VvbnlN8yTlVdKOzQN1G0x6tb5gkUTq5P?= =?us-ascii?Q?71JYk4iCKYUdIHWpB3Tncb2nOhxmw5opIcBvl8eCLZTzkAEWrwbpcMrLWYYr?= =?us-ascii?Q?e4rm858pKUEYpyr0hX7WT+/+NMVemYUVToeUCX5TyExTQNVTBDnVxrZym3Uf?= =?us-ascii?Q?dBVQRHkPlFwz4zhFq9w0m5tOryOKkN5W+tUbzd45+Rhek+HcYtTmy33aXsLj?= =?us-ascii?Q?Uu7Q2EMUUBZQci0hIXQO3j88yNntj33Dw0tSVQ7qDhk4n9v6HsP3YylkUQKJ?= =?us-ascii?Q?nrFi2uOr+zekGFMnSU3s3A/YqYrp4W76zcSvckVxo/0N7I8W5U2jNtGQ4Jfe?= =?us-ascii?Q?WHBdBnWnqw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e72f1693-22f6-4dea-edf8-08da1932796f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2022 07:36:20.1065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PsqR129Cd9HP404zKaA10lhdA+t66T1jB0rPImt5j2mAmp0SZEA6rpWMd3zPDU5e/ve8BGoLBWUt8k8PQFVotA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5454 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi The rule for lib instance is: It must provide all interfaces defined in .h = file. As such, please use NULL version other algorithms in SEC instance. Thank you Yao Jiewen > -----Original Message----- > From: Xu, Min M > Sent: Friday, April 8, 2022 2:39 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Yao, Jiewen ; > Wang, Jian J ; Lu, Xiaoyu1 ; > Jiang, Guomin ; Gerd Hoffmann > Subject: [PATCH V2 2/8] CryptoPkg: Add SecCryptLib >=20 > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3853 >=20 > This is the Cryptographic library instance for SEC. The motivation of > this library is to support SHA384 in SEC phase for Td guest. So only > Hash/CryptSha512.c is included which supports SHA384 and SHA512. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Gerd Hoffmann > Signed-off-by: Min Xu > --- > CryptoPkg/CryptoPkg.dsc | 4 ++ > .../Library/BaseCryptLib/SecCryptLib.inf | 67 +++++++++++++++++++ > 2 files changed, 71 insertions(+) > create mode 100644 CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf >=20 > diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc > index 0aa72ed87846..b814e9616454 100644 > --- a/CryptoPkg/CryptoPkg.dsc > +++ b/CryptoPkg/CryptoPkg.dsc > @@ -109,6 +109,9 @@ > [LibraryClasses.ARM] > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf >=20 > +[LibraryClasses.common.SEC] > + BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf > + > [LibraryClasses.common.PEIM] > PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf >=20 > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiRepo > rtStatusCodeLib.inf > @@ -236,6 +239,7 @@ > !if $(CRYPTO_SERVICES) =3D=3D PACKAGE > [Components] > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > + CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > diff --git a/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf > new file mode 100644 > index 000000000000..6ef2f67e35dd > --- /dev/null > +++ b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf > @@ -0,0 +1,67 @@ > +## @file > +# Cryptographic Library Instance for SEC. > +# > +# Caution: This module requires additional review when modified. > +# This library will have external input - signature. > +# This external input must be validated carefully to avoid security iss= ues such > as > +# buffer overflow or integer overflow. > +# > +# Copyright (c) 2021, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D SecCryptLib > + FILE_GUID =3D 3689D343-0D32-4284-8053-BF10537990E= 8 > + MODULE_TYPE =3D BASE > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D BaseCryptLib|SEC > + > +# > +# The following information is for reference only and not required by th= e build > tools. > +# > +# VALID_ARCHITECTURES =3D IA32 X64 > +# > + > +[Sources] > + InternalCryptLib.h > + Hash/CryptSha512.c > + > + SysCall/CrtWrapper.c > + SysCall/ConstantTimeClock.c > + SysCall/BaseMemAllocation.c > + > +[Packages] > + MdePkg/MdePkg.dec > + CryptoPkg/CryptoPkg.dec > + > +[LibraryClasses] > + BaseLib > + BaseMemoryLib > + MemoryAllocationLib > + DebugLib > + OpensslLib > + IntrinsicLib > + > +# > +# Remove these [BuildOptions] after this library is cleaned up > +# > +[BuildOptions] > + # > + # suppress the following warnings so we do not break the build with wa= rnings- > as-errors: > + # C4090: 'function' : different 'const' qualifiers > + # C4718: 'function call' : recursive call has no side effects, deletin= g > + # > + MSFT:*_*_*_CC_FLAGS =3D /wd4090 /wd4718 > + > + # -JCryptoPkg/Include : To disable the use of the system includes prov= ided by > RVCT > + # --diag_remark=3D1 : Reduce severity of "#1-D: last line of file = ends without a > newline" > + RVCT:*_*_ARM_CC_FLAGS =3D -JCryptoPkg/Include --diag_remark=3D1 > + > + GCC:*_CLANG35_*_CC_FLAGS =3D -std=3Dc99 > + GCC:*_CLANG38_*_CC_FLAGS =3D -std=3Dc99 > + GCC:*_CLANGPDB_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Dincompatible- > pointer-types > + > + XCODE:*_*_*_CC_FLAGS =3D -std=3Dc99 > -- > 2.29.2.windows.2