From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.7683.1670570913103679679 for ; Thu, 08 Dec 2022 23:28:33 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RRW9feAK; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670570913; x=1702106913; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/sggfiCLhQoiFyYPqZDRG+STb2sYuoBCzKbiouhcjzI=; b=RRW9feAKjnoIPqO+ZLSusiTIjvt51ja7TY/XPFhW3T+K4j/799nBSyYX 8qpgnx0beAwl5AGpnymZ2McObfLDQk5mnPkZlvKltNEXDR4KqAimIw+rS lsDQu9xkC7U93M26pHNkZnZRKG1ox578UvRZ29OXnlD7U79tp8CeIaGnH RIWcOcPfnqX7gLyB/zNCRAgF0cozdAZUl+2JBh3BB6ajak2WPgAzKAa0o YuJ1gdze6KQLlxyPT0nCs3PdQHiIlxBClA1MPhxBLXIbap3jSmTTCI8R7 PxL2qrB/CoHbxWrbLav6c8iVQsrIWBwlUnQTO4bjo1THm3pKXhG83osWZ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="379615575" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="379615575" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 23:28:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="649469835" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="649469835" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 08 Dec 2022 23:28:30 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 8 Dec 2022 23:28:30 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 8 Dec 2022 23:28:30 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 8 Dec 2022 23:28:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MZDw2O0JvrUxlJ+iFDs9xOk1TS9/nYZeie6tIkSGNmVecjqakqSDix1jprGh/QhxWoDkJzAxUbQ7AcoofoZ0KMEn4NzPCUZduW5bIxyXYBu4GelgjX8q7iR5mtAJ7MCoNpXSb8dueeCPQcOfhVzjFGSmgdVwVbOBeRLDkbNVbpMrsWM7IMD8zRkmStvdXyH2YQEcrF+t3BW6W47GnBemMzj93WZ0P0yUeQU+wvWc/o+0W97DePraFtvM6IXbTHI5wGq35p5jxmsob+j0udrUcDi26Px/N30C5HbMzCNujeHQiHXyNstfRoxaEJN5zLFyLw09ZqE5WpbWOig5lvI3AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ml1Www7RAh+SOQzPBidHBz2WqfJkQ0KAz6hNgECbAsw=; b=ebdbhnyRoNuCSZw2DGYxC44WvmdaQPPuZ5BsILy04qxg3q8rgwYFORYhyVDJMT3K5JSqhRZShmQCQF3VygL8gajE76CPj+TRt0SlAySG+nIDL4yS7PjG4faYrtkvuIou0+QqlKw8/j55AUIS3Pxn5dtJOvPgCUow9r7UmTa1IaR/I4tdpMpuS3O2XRUAxV6SlKwE8ygs+Y9YnzkdP+Ka5H0FI9N5OnGhkFJagqRq7LLkUOXb8+4gf5sk8oewb+DA0brfxWtZcxNrFUAyqoGxj4QVpad1uMfVn2YvcogGLniHLYBzrWmQde4BL80Hmy7NekBgs/kb0QX2LQDT8mGqrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5879.namprd11.prod.outlook.com (2603:10b6:510:142::5) by SA2PR11MB4828.namprd11.prod.outlook.com (2603:10b6:806:110::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.16; Fri, 9 Dec 2022 07:28:28 +0000 Received: from PH0PR11MB5879.namprd11.prod.outlook.com ([fe80::dfc:656b:a06b:72f]) by PH0PR11MB5879.namprd11.prod.outlook.com ([fe80::dfc:656b:a06b:72f%3]) with mapi id 15.20.5880.016; Fri, 9 Dec 2022 07:28:28 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Oliver Steffen , Pawel Polawski , Ard Biesheuvel , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size Thread-Index: AQHZAvJRA7Wcbc41EEiaJx9Qz+qPja5lONwQ Date: Fri, 9 Dec 2022 07:28:27 +0000 Message-ID: References: <20221128062558.173307-1-kraxel@redhat.com> In-Reply-To: <20221128062558.173307-1-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5879:EE_|SA2PR11MB4828:EE_ x-ms-office365-filtering-correlation-id: 0fb2224a-2ca4-4dce-4e18-08dad9b6f714 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z9hd1xrbpBpUHC9Pe58mUuZtL1bven9bOzWLmnGaoEplpSSUVOg+LQZPhSew0J+ihi+TgJ2u/RBp59JNwE1FDFM8NYRcQwfrEQVT08UZOrArrvhBLVeIXqqk4nSqCun6sFzLli3pIAJXAYV/0v2MJIrk07W4RNZdfJR+C88sVD8fb+gK1FN/UdB6H2Z04CDPdMVIpS5FFlJ/fDPxcLURxxmXRCw9frhoH3mQwyTbOx9uF++NQOcC8gQ9GAj4Ju0Whe0czeCcMfE1hyp2qo9z/f+iKBQDT5jGGiWZrMe1Ndp4uv6JvJQVSgmCv0ZZ/vDFStnH2Mova8FE8k+6yBNY6bolm4px4kI20xE+TVj4sxoCNKlGnz/NOZcKbVxVyBYqmg0t9epFJjymfMjFcMKuX+LGcTog5sIoKjlKMR77/6KP2exEnNZNc+KM0E2GQ/D7jyBQaZFYq88jzr4p6zcOJenEqNY8WSyVBrRCky6JPrm97o9EsqKnkoHF2CLHzVq3A/Hzsh20mQ5QoOGhgxEcxQbdT5cbgtFpk2fEs4ZNjcnZH153q7Jb5rTGAxLTgVIibNCV2WLkxoMj5yMWEzE6potbhmS1qcUYyHru3W6I8plAMO/f7qkhjN8SsAhUmjflCKLnGGZsH4qdo+AgbLuumGxdhAkAHkrAtxZvtsSqIJG0J+kYcinbfceV4MgFFS0hsOe60YzgrDMFamJn+cdODbEwChrYiEb4Hhc6G9g9L/MeRweASEcs5NfyjM0sEuR7nEPXGqSnZdUnQr3WkPcM3+8ah0PdRRmCBZHpJWoMhhs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5879.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199015)(122000001)(55016003)(33656002)(316002)(82960400001)(4326008)(38100700002)(66476007)(66946007)(186003)(66556008)(76116006)(9686003)(66446008)(64756008)(26005)(8676002)(54906003)(71200400001)(53546011)(5660300002)(6506007)(83380400001)(8936002)(110136005)(52536014)(7696005)(66899015)(86362001)(2906002)(478600001)(38070700005)(41300700001)(966005)(107886003)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uEoFZfP1+C8HBX9O/yIFQLhB8gnr/j5jEKrUm9xuDRC14l267eoV35RC+LvW?= =?us-ascii?Q?ECL0FnZRAzYdrHryULUD3osDI92XmGQmnm/GxVCrX+8shbRvz1/t3cn7UDvn?= =?us-ascii?Q?8Sh//52Z+Je1GuTNPYdaso2Hera3GM2FD3ytBCONHeBXFCoh2NosBx7IAE80?= =?us-ascii?Q?sY6IU36/m7n01r0BKtyf47QLfo5IVtn3ZLBmRpTmDkzbdih5G/ktediNDS4o?= =?us-ascii?Q?rkltWi5d/15kd5uSZKGWaeg/87XDR1ghmOiMyke9n5D0mpIwnMm1KwioO0Cp?= =?us-ascii?Q?YxJiqq+iSPlT9vVOYv/cWEMrGnAGIhfQxNIR+ic3LkEhBLkbA3+fu3+joP5c?= =?us-ascii?Q?LPv968/SNPLsyQDk5dyZpQTXVCSQkpAhlQ4KH2dV1XoDdXqOv7tA4A8jAOGC?= =?us-ascii?Q?bkBLLzU40X4htWrCnHbjTqdKELsetY1Js+NiQEBVLd/ziyWpa7qUlkPDmlCM?= =?us-ascii?Q?Ya+S6PSWaJepGg9EQNuZC35He54Vg1cBH1IPhaeztkFxhke7dXq3frRc7Lby?= =?us-ascii?Q?pUxmgydnAEDPVlX+/kIVvbcw0PpBs+2AfgSyMjPS3sQcrLzUSCdz93VhG3gU?= =?us-ascii?Q?Tk7SLHgbuT4sDeTBhecrnHssUvlQsp67kZrMNCF1N34kThsGCnU24WlA1XLh?= =?us-ascii?Q?4itbn5b0//Y5b4McLdNY0DeuB1V5sXjgXivK8QEJxpBbpx+RRIppHeoFhm1I?= =?us-ascii?Q?WhMIdEf1vy2EMEULj6L7BBUh4yqyc0OhwgMF7+iLfomZzoKbH92wyD7Sj/3t?= =?us-ascii?Q?draEgvgua9uiHHu0q/OG5b7FxngGKtwIoHRTnhnx2n5sr38zBKBsUnXipqWI?= =?us-ascii?Q?BcSESOHzMw7pjJNDZYBBVraw739UTJQuDgVQCLcvhV7bwFyU1houNx9Dn9eB?= =?us-ascii?Q?/9Pr21k9+HIRjkDksilDAsdDxryWd++VwYvMnGLXjC2cHjLLuvva+rwgvUDQ?= =?us-ascii?Q?wSKF5EioAGl6J2gmmAnKPz47uKsi2FWr/m3VQLqt7+Nt60Din1BOWjzr5e6l?= =?us-ascii?Q?s3M+le9x3DutokMnxIhdmCvi0UlPoT2aR5f/B0u7AomaLAHHuMezygP6spw1?= =?us-ascii?Q?d956zAPkNXbUm/DyRhbUZ2EXDHezt9GgOdM0ik2XYCUC4PyjJSzIv3MX6W3+?= =?us-ascii?Q?esDCdGvEwFoEteiE2H+nEZsBbSyCjgRnbgVKa/HwvD9fFSwmWckNTkzuCm3u?= =?us-ascii?Q?UlV9fISWgw54CRq0+RMN+Eqk/AhGiOQho12XdPI8QhXsFS/3R84+UYzzHzX7?= =?us-ascii?Q?2bUs+tl9qcCG1XPA07fymIYDr61FXsIQ6hQ1BiS+7mHqNeoVmK+SKX178jsZ?= =?us-ascii?Q?lKPLl6yl5NLWOkgamfxtBlvkRN/CFEuLkVFBxaVeWu9Q5sEU6MPAjhE49tA3?= =?us-ascii?Q?l4Y09KoyXsaxpq4D46uab1okhak6y4vY5aA9gCiDzIGMPExGDizWz8jZOfQR?= =?us-ascii?Q?9eXnTLTh6dImrRglnpobcmgbp6Vs9aKaL3QT956G3HaW/gMDQZ0tvxbWdre+?= =?us-ascii?Q?sYAlwi+TWKsk8k3tVABSq78cl9Cu1ejrMuQrgaNcWo0Kpvde1PAQUonqpWMg?= =?us-ascii?Q?fxjw5DyjHBM52IKNKlsMqSkZWBuzbFww2J0H7Pg9?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb2224a-2ca4-4dce-4e18-08dad9b6f714 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2022 07:28:27.8299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XjikNUuTjHFk93zHHbZgIFVruV/A2vuzECYgW8ySHj5V8xlrpchsvXLHwrgn4i3SQZz1KPim3/L3QGb78arzPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4828 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Uhmm. I assume this should be done in PciBus driver. It will be a burden to let each PciHotPlugInitDxe to fix the smallest IO wi= ndow. + PciBus maintainer: Ray Ni and Hao A Wu What's your opinion? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, November 28, 2022 2:26 PM > To: devel@edk2.groups.io > Cc: Oliver Steffen ; Gerd Hoffmann > ; Pawel Polawski ; Ard > Biesheuvel ; Justen, Jordan L > ; Yao, Jiewen > Subject: [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io > window size >=20 > Smallest IO window size for PCI bridges is 0x1000. Add a check and > fixup the Exponent of needed. Avoids broken resource assignments > like this: >=20 > [ ... ] > PciBus: Resource Map for Root Bridge PciRoot(0x0) > Type =3D Io16; Base =3D 0x6000; Length =3D 0x7000; Alignme= nt =3D 0xFFF > [ ... ] > Base =3D 0xC000; Length =3D 0x200; Alignment =3D 0xFFF; = Owner =3D PPB > [00|02|00:**] > Base =3D 0xC200; Length =3D 0x40; Alignment =3D 0x3F; = Owner =3D PCI > [00|1F|03:20] > Base =3D 0xC240; Length =3D 0x20; Alignment =3D 0x1F; = Owner =3D PCI > [00|1F|02:20] > [ ... ] >=20 > ... which the linux kernel fixes up later: >=20 > [ 0.644657] pci 0000:00:1f.3: BAR 4: assigned [io 0x1000-0x103f] > [ 0.646833] pci 0000:00:1f.2: BAR 4: assigned [io 0x1040-0x105f] >=20 > With the patch applied: >=20 > { ... ] > PciBus: Resource Map for Root Bridge PciRoot(0x0) > Type =3D Io16; Base =3D 0x6000; Length =3D 0x8000; Alignme= nt =3D 0xFFF > [ ... ] > Base =3D 0xC000; Length =3D 0x1000; Alignment =3D 0xF= FF; Owner > =3D PPB [00|02|00:**] > Base =3D 0xD000; Length =3D 0x40; Alignment =3D 0x3F; = Owner =3D PCI > [00|1F|03:20] > Base =3D 0xD040; Length =3D 0x20; Alignment =3D 0x1F; = Owner =3D PCI > [00|1F|02:20] > [ ... ] >=20 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > index 3f9c84cf2b54..6c8bbc3b199d 100644 > --- a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > +++ b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > @@ -117,6 +117,10 @@ SetIoPadding ( > IN UINTN SizeExponent > ) > { > + if (SizeExponent < 12) { > + SizeExponent =3D 12; > + } > + > Descriptor->ResType =3D ACPI_ADDRESS_SPACE_TYPE_IO; > Descriptor->AddrLen =3D LShiftU64 (1, SizeExponent); > Descriptor->AddrRangeMax =3D Descriptor->AddrLen - 1; > -- > 2.38.1 >=20 >=20 >=20 >=20 >=20