From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.8183.1670573509915857929 for ; Fri, 09 Dec 2022 00:11:51 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XzdsTPBY; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670573511; x=1702109511; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0jBIjt3kWC8U1Iky2dQFhG+DXENQh5G88Ihk7V4S8PE=; b=XzdsTPBYnhTpJgntiKujiQlI7xjVzByJUTq8jFbwrjLUK9KyfLJDWjmO jCmyyjOFIxL4nenfdhfVobkrbh2PGUql+d68vxfUnMdyLT+/zQZeoJBhp vXVb9s43u5UQwI/h5Kaai+qCnBs4N+Srd+MIrIVZlO68Y4SR7FwZX1aB2 FYVnIwetfivyaSuQYEm5jE0FYoRMuItUES8yCe7dKwD0pEPsoSKxR7Pcv M8uOQ8wDf7680LP0HBMKWQoAxK502kNmPL3r9SzK99FStWHkPPK1fLtra Sxw8xsSTVUadfhMGz/L5Sbbi0msdd2H1tRPro5jnpACJTT2g4JDjIxATI w==; X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="379622730" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="379622730" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2022 00:11:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="625038384" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="625038384" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 09 Dec 2022 00:11:34 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 9 Dec 2022 00:11:33 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 9 Dec 2022 00:11:33 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 9 Dec 2022 00:11:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RCLNxroDAIXzoIRq3Me9e7pjlSTMb/mUc/gsAgzvpdw+EnhH/e8xTvWxGfwb8VUSOwiufNEbMnYdBrGb1MYz6zIIIokVvropHEXV6PmfrHr2g2chvXu1vzQKFpeycK/bt0ZAqwXBDVzeyhHNMcDdKDDC/WEBCx8x27AmLVyz6i8phVXSNujNBcFjV3ycUTpZj0eMb0/a9bwKUj1uqZFlNJMqQTUZlMKOFtzNXYliqkgYf9dQGY/ayqxUDCVYBR4rWDGQhzZAgw5720Yuz88nvzPXkN+9g4SVQZbBqBDFv3SL5lj+BCOKPgbTEJAJcH4eqPrYJ9bP4KvgaPf/eY2LKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vESuWkM4q9UCKJOxYb7/aapBMAx0KmIq9+8lAenOAI4=; b=BdIFCBl2990G2ve+Ul3oU3do0qg/4VRysTMwHbHBL+hflH0XhOc+ZOSmMV2NDVU5oLVdZBLGXFIogKoSkuIC9ZmJlHwPBldETq2+kL8rN8Q6EXLZD1nLHbepYnYX3VajFzEr+iio2WKgLeVyRcrW74G9N3ym16EQ7XK1WzM5A1EvRlhibkoHmpwDoO9cRpsYzwBhln/tgPt7dq7CY5EYdsWQaKGBFz7U1BjTtWcQbcMrAnGNt0YM/6EFXLJa6CGIMWVgyvEI9stLwqXP4LZ8YaEYcHHIUb4878UeU2Lzn/PAxA6FCoiIvaZoRh95ccxUjQKxbpTmneH6zl0efDAoyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5879.namprd11.prod.outlook.com (2603:10b6:510:142::5) by DM4PR11MB5972.namprd11.prod.outlook.com (2603:10b6:8:5f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 08:11:31 +0000 Received: from PH0PR11MB5879.namprd11.prod.outlook.com ([fe80::dfc:656b:a06b:72f]) by PH0PR11MB5879.namprd11.prod.outlook.com ([fe80::dfc:656b:a06b:72f%3]) with mapi id 15.20.5880.016; Fri, 9 Dec 2022 08:11:31 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "kraxel@redhat.com" CC: Oliver Steffen , Pawel Polawski , Ard Biesheuvel , "Justen, Jordan L" , "Wu, Hao A" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size Thread-Index: AQHZAvJRA7Wcbc41EEiaJx9Qz+qPja5lONwQgAAMfKA= Date: Fri, 9 Dec 2022 08:11:31 +0000 Message-ID: References: <20221128062558.173307-1-kraxel@redhat.com> <172F0F650773A361.1612@groups.io> In-Reply-To: <172F0F650773A361.1612@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5879:EE_|DM4PR11MB5972:EE_ x-ms-office365-filtering-correlation-id: e0e0978b-9804-4d12-5f86-08dad9bcfb30 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wdy7IKZuw3GV97ERspuz35SYSwquVgOeDGFYNAZcAdAeT7Xo1nuo3QnGXzgFqVy5dqEwhYOfoUOoZM0dPXsv3wOCG55s2Rm/xzN0SJhU0T6wSOqWoabGwBIdnBazfbZpbBmttlo8MLt3JbkZaepJC9LwZ8efRCZJn1H7+xLQn+c6ZypQlm9556ybiqhkqaj7dbUJ/T63S/HQQXI5iHl4ppwM5JI3BGdGjul7YRmfsdPEwITw3bdhelLQYGsxrp2UISR1OK+AI4NrQFblY0AYznLM6U1T1u+zqPKlDxAXxYOC16HNkRNdtu+IzavThG8gOqWk+WKYZu7yCxEeGLYLGl1HgfZT7kSOkPFu5TFQXyd/zgG6jNa/kKutGLXBX0WAz7iYsyUY31i/a41jwOzJ+ocoJ+8yERtCNgZRGYayGDPsBSXqmeQDyIA1sPNAOrSOQulDcIOasPPEeEfo3E4SL5raz/ix/ecnExWH1o4Tok+ZCJib8p2a/mtZrVFtlO8GLY9E3OmWBD7kO2zTVI5xvrjAJdIawYzZLRBd6ho+pg9BduS/6nMzvxFWvop6f1y+9fEUYR1c4lPUcYIb4563ZQdMchyneqfUiCeUQm7u/VejRBhaNNRQ1zQy6Ng310ENvop8pG0ZmwJ4/6FWn+NGwOudXKffhCFwHwj1lQYoC7b/PyHtyZ0voxYa9JEy3aKHZaiDA4r/pCFeHtVlSYwWiP0K/Xd+njAUieKnp6nfOBP7YQwn4icYMW6B2kDUa1qP5iwjl443ZYT5l8r367qVlV1qsZ2W2wxqLNHcTD/wReQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5879.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(2906002)(55016003)(966005)(107886003)(38100700002)(33656002)(82960400001)(53546011)(186003)(6506007)(7696005)(478600001)(110136005)(66899015)(54906003)(9686003)(26005)(41300700001)(71200400001)(8936002)(5660300002)(52536014)(66446008)(38070700005)(64756008)(122000001)(76116006)(66556008)(66946007)(83380400001)(66476007)(86362001)(4326008)(316002)(8676002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jqBIWaKg9PCJz7Z2+J6c+t2swxmE34OLkmaUwzrVJbPs83Rmw0PpPmGKacDD?= =?us-ascii?Q?mfjiWATCbPKXFYQI93GIBD6KvBHwYp0wOsLQ7g7FfDm9VqxDEjzJdLFOhAJu?= =?us-ascii?Q?Z+uE61eqxVP5EmUJyx1RujJLQ6wQtxmjKH6JRB2YEyeIiQ+kvjZsVmV1O6eV?= =?us-ascii?Q?aRyia7LRp96xaSl+H595CHbAj8EML3FYjOtGeqA8hrFF7jOwMwxi5MOViAcN?= =?us-ascii?Q?dqIlKhSs0qdhE/5LNg9aKYStHx42LFn/hdJN216kbv8du3FHMGyJ9rt/ZRqJ?= =?us-ascii?Q?IjgNRnPZS4f//FFWtgLlDFhcif2wsAuE2dkYh0vmQa/RL2nWzvIapd/CZwL6?= =?us-ascii?Q?cm73iKr394SDxDo+asCBeKNnUcLXG0WQTAhW04XoIF0zPM0kSZ46NFO2eZfm?= =?us-ascii?Q?ID1CgdoHSzwKU15IjExHzC5N9iQBuVzAGjnVvM/K4BwFgpVVyQE77F1qgdhO?= =?us-ascii?Q?mLGShbAG4DrtNw3qzGGjzqzeY8vM8zlfi7sDZZISdMjPaaO4omlu6VuUcQRK?= =?us-ascii?Q?qLwt7KLGYn0dgmUweGA3122Ut77H7VUaARYBYbhnSzuOWivVPtuzFhQfJKZj?= =?us-ascii?Q?2tF3TtPO+I8JsgG+g9cZJW8TtGanlsXnYI7iNeH1EPQFdoUT/UYcXZ/a36Hn?= =?us-ascii?Q?vNvOVpqaqQDfl4QRBe4u3kmVJaFtlauzzgki3B34BiimZLnzw/nPraetqK4V?= =?us-ascii?Q?JhqV1OG5bMZRC80o22+r9Fw60eFDlUH9cAi/W7iQ9LLl+9YTzXBkOvE1GxzZ?= =?us-ascii?Q?nNhKQVbIh9W3+3Idbh0laMOCJkUv37U3EIQl2UNnkUBSoTNUfJGEYAZmyseK?= =?us-ascii?Q?WYVMBqxPb3kWluLwuy+8TSPch7PdzKqvetyUKzP49PDqgABNDyGJBBkgmBX4?= =?us-ascii?Q?OcDkQq4GbIyoBTuQcVIYuHXvMHjz0RLwvNbugnq/g8LUl8Vb19nPupOnJeZY?= =?us-ascii?Q?492ILLxrPcyJlkgmM3COZttNroVTESWatKSFTiy7zqVz24wvlmvhfFOxjOcU?= =?us-ascii?Q?R1Vt61tz/T4EliT4JuRYFnOgAZ6B/RIGycwLH+EfNhAI9O0sp+QUyJofRX/U?= =?us-ascii?Q?9d191JNHMIWTx/qvnYvOo0Fv8aYIC+a2GKreIvc2w+YGq0OGgNm/cPZTlRS1?= =?us-ascii?Q?HaEu5Bd92b9aIRarGZPlDsw9huAZm0o5pNclcxfvsERQXmjokqKSQVfKoTdd?= =?us-ascii?Q?QMjvodVGMgq+15as2zdaHL9/l6/IkLnJYWIGUG/kTD6Xk0vcfmWrJcoRhXaB?= =?us-ascii?Q?WYR3nxO4DF3LU6ksx19hRt8x1Osr2qWB46a/thvbXiif20dl8y56D9xLqCE5?= =?us-ascii?Q?1a85TIZpaK17WY124DXGwrVMx1JLd7bK0Hu7cNQEQ7j72yIrpXPCGFe17xXw?= =?us-ascii?Q?2kaDdVcUYz8uSA8Dez9QHWMolHsZLiqfeJkIfxinq0JwpkQr72YLYDvsJJ/p?= =?us-ascii?Q?ZLUV7Yp2a/KialKAwCwxtfff98QsVwxvhOZ58R1BHyloSPPw2JsErj4S4ekw?= =?us-ascii?Q?FixNi2kvQLyX7ZjpMVVg9eZJMn4V40WEpFB/QBRfB/d+gX6DqAVC5tgKnyx5?= =?us-ascii?Q?poeQU+P8Tf2ry5CLsndSIWD1l1yQDe0NKRx2lJdN?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0e0978b-9804-4d12-5f86-08dad9bcfb30 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2022 08:11:31.7208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 67qiH8GgI1H7Two7iV1o4y7b1qaRnTJuC57bB8eh33O57Oh3mwB84hThTva4Y9AgwyU4vImORqF0zJmEWIwv0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5972 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Maybe it should be done in PciHostBridge driver, because PciBus is generic = and PciHostBridge knows the smallest windows size for this platform. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Friday, December 9, 2022 3:28 PM > To: devel@edk2.groups.io; kraxel@redhat.com > Cc: Oliver Steffen ; Pawel Polawski > ; Ard Biesheuvel ; > Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io > window size >=20 > Uhmm. I assume this should be done in PciBus driver. > It will be a burden to let each PciHotPlugInitDxe to fix the smallest IO > window. >=20 > + PciBus maintainer: Ray Ni and Hao A Wu > > What's your opinion? >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Gerd > > Hoffmann > > Sent: Monday, November 28, 2022 2:26 PM > > To: devel@edk2.groups.io > > Cc: Oliver Steffen ; Gerd Hoffmann > > ; Pawel Polawski ; Ard > > Biesheuvel ; Justen, Jordan L > > ; Yao, Jiewen > > Subject: [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io > > window size > > > > Smallest IO window size for PCI bridges is 0x1000. Add a check and > > fixup the Exponent of needed. Avoids broken resource assignments > > like this: > > > > [ ... ] > > PciBus: Resource Map for Root Bridge PciRoot(0x0) > > Type =3D Io16; Base =3D 0x6000; Length =3D 0x7000; Align= ment =3D 0xFFF > > [ ... ] > > Base =3D 0xC000; Length =3D 0x200; Alignment =3D 0xFFF; = Owner =3D > PPB > > [00|02|00:**] > > Base =3D 0xC200; Length =3D 0x40; Alignment =3D 0x3F; = Owner =3D PCI > > [00|1F|03:20] > > Base =3D 0xC240; Length =3D 0x20; Alignment =3D 0x1F; = Owner =3D PCI > > [00|1F|02:20] > > [ ... ] > > > > ... which the linux kernel fixes up later: > > > > [ 0.644657] pci 0000:00:1f.3: BAR 4: assigned [io 0x1000-0x103f= ] > > [ 0.646833] pci 0000:00:1f.2: BAR 4: assigned [io 0x1040-0x105f= ] > > > > With the patch applied: > > > > { ... ] > > PciBus: Resource Map for Root Bridge PciRoot(0x0) > > Type =3D Io16; Base =3D 0x6000; Length =3D 0x8000; Align= ment =3D 0xFFF > > [ ... ] > > Base =3D 0xC000; Length =3D 0x1000; Alignment =3D 0= xFFF; > Owner > > =3D PPB [00|02|00:**] > > Base =3D 0xD000; Length =3D 0x40; Alignment =3D 0x3F; = Owner =3D PCI > > [00|1F|03:20] > > Base =3D 0xD040; Length =3D 0x20; Alignment =3D 0x1F; = Owner =3D PCI > > [00|1F|02:20] > > [ ... ] > > > > Signed-off-by: Gerd Hoffmann > > --- > > OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > > b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > > index 3f9c84cf2b54..6c8bbc3b199d 100644 > > --- a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > > +++ b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > > @@ -117,6 +117,10 @@ SetIoPadding ( > > IN UINTN SizeExponent > > ) > > { > > + if (SizeExponent < 12) { > > + SizeExponent =3D 12; > > + } > > + > > Descriptor->ResType =3D ACPI_ADDRESS_SPACE_TYPE_IO; > > Descriptor->AddrLen =3D LShiftU64 (1, SizeExponent); > > Descriptor->AddrRangeMax =3D Descriptor->AddrLen - 1; > > -- > > 2.38.1 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20