Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon initialization firmware binaries

["Xing, Eric via groups.io" <eric.xing=amd.com@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

[AMD Official Use Only - General]

Thanks Abner for the prompt review. Will follow coding standard and correct the new files’ name in PATCH V2.

Eric.

From: Chang, Abner via groups.io <abner.chang=amd.com@groups.io>
Sent: Thursday, September 28, 2023 11:23 PM
To: Xing, Eric <Eric.Xing@amd.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon initialization firmware binaries

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hi Eric,
As the file naming is defined in the edk2 C coding standard, the AMD terminology used in the file name should follow edk2 C coding standard. Such as APCB should be Acpb, ABSupportNvramPei should be AbSupportNvnamePei.
Could you please review all of the files in this patch?
Thanks
Abner




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109167): https://edk2.groups.io/g/devel/message/109167
Mute This Topic: https://groups.io/mt/101638925/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4718 bytes --]