From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9E8427803D2 for ; Wed, 18 Oct 2023 14:45:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ae2mg91mVY3CMUMiMqTO9Ts2o/BWcmj1enrTTA+C+aQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1697640342; v=1; b=IqxK1qK1Dy0IUziqVbZRmUaGOTmJQrll+H4Oi2jmBIndVNHHu0MqzpyPc8McT86x+DvRpE/N cIWTqx9rNUpCLcxq4T6y9tLxnEUtPZ0JktjvnbP7x5nSmsmIGZSRQyr07EVMKfuK/cs6hhtt7Ne t78NudemneBaMpNmhKmeXF8M= X-Received: by 127.0.0.2 with SMTP id F0bqYY7687511xSyrvsCMEAk; Wed, 18 Oct 2023 07:45:42 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.87]) by mx.groups.io with SMTP id smtpd.web11.282981.1697640341481610261 for ; Wed, 18 Oct 2023 07:45:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BSkreiUR+X+kg/DcWfBYIjjfsxMj5QDQMbaL08DrQ63WhCNEkRjfdXbcWv+QInKzwZfZ956X4rascPbGqmmuWHLOmJJOpkfJ+boK0vZWRtgBkzUU4CNiLD8g6wQyez14Xu6FcXCDNY8jca3gJ6R38Mq9WiwP9iUQ4LdjE9FgUkvZDUiTAl5kB6VAKJsCB8Bcstv9EyvcCU8DSIJGddo5zob7JgguixnhwAk15Wudrj0v2r7+9d38RDoish6yq7hBrvMLEnxEYFti/iI8OeQXRC9GYH88/eo5ZPxgrjhFIkLVBy7KFeSr/Mr+kVms18MKGPbKUkhupy7djnHD2Jmawg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jShsJUIFSxl6lhK7Mv07sqqWJxXWEWeiPGHKZQAwxeg=; b=HdCOc+9XnkcJbX2nU201X7SzjlKokILgwczYCz0YE0nYevbiozf1FWw1mMfzzc3QPuQGLDWMdta4hECwUoxSJ4Wv2uUWKTXHto9KfP3vwFPbZduDODQ3C3MnxZqIUheWrsOq07Hq5XX21UBAD6tUFkmXW8u1R4a1m95PosBywZ/t9ksOw3MLJ0fn6HkBz7w1O0KppKjpy9DrVqpKz1G9IH00bsUy5csy+XD//JeonQ6u91ZdW/yLrRpJr+TuIJoUCZgpzoBbrtnvZlMm3C4IQ2ZKEV3cQxt26PIklmAEGoLz5Aor8doviZx+VPIKlj6NQ7R8Zjn6OCG7ohVmiyLWyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from PH0PR12MB7888.namprd12.prod.outlook.com (2603:10b6:510:28b::20) by BY5PR12MB4935.namprd12.prod.outlook.com (2603:10b6:a03:1d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.21; Wed, 18 Oct 2023 14:45:39 +0000 X-Received: from PH0PR12MB7888.namprd12.prod.outlook.com ([fe80::dfe2:8a2c:6122:e15c]) by PH0PR12MB7888.namprd12.prod.outlook.com ([fe80::dfe2:8a2c:6122:e15c%3]) with mapi id 15.20.6907.021; Wed, 18 Oct 2023 14:45:38 +0000 From: "Jake Garver via groups.io" To: gaoliming , "devel@edk2.groups.io" CC: "michael.d.kinney@intel.com" , "zhiguang.liu@intel.com" Subject: Re: [edk2-devel] [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message Thread-Topic: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message Thread-Index: AQHZ96emCrqf73ti7kyigBE4A44UCLA9yGYAgBHrrYU= Date: Wed, 18 Oct 2023 14:45:38 +0000 Message-ID: References: <080101d9f8db$dc3f6a10$94be3e30$@byosoft.com.cn> In-Reply-To: <080101d9f8db$dc3f6a10$94be3e30$@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR12MB7888:EE_|BY5PR12MB4935:EE_ x-ms-office365-filtering-correlation-id: 1c057a49-c431-4f8a-d8da-08dbcfe8e53a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ou64OfiBo1f1pCebqat7fVyjM2RswL4MNGPp59CndoWCP4my1iDBEBD60XF7Yd0Ojuiy/AOt5n6yJEF2vdHHKjI+LN202ztRUcM99ETi3LMhrZfl7TazeZi/Ot9kyNnfdpSntJxKTMtXkjc75G2DkJ7JB6/SqVQvqxhUV6MiBCL/T95YbiwVVhHCdMEx1atUSYgaH3bQ0tJOcYhTZMn87O23gQtG8MVdOg80dcczoUIigs4+detQ7/5ynNcD7b3meue1pcbDPbJyBPKfmHq8q0haF0AN1IIyU1xJ29gXZni5ULJMWoMdisgg2iTeljDgioqX6SMcYsePpmmtGYNifzt8Qu1p8n132wGCSihFZirDgTGnGpOjewobMkRO55nbQpgQyh8cL/H+DZ0WS7b7oicXrfMEE6RBacx9i1zkXxTclLClW83/bh6dze7iJYbL0zOZsiWTd1qJfYy2OPrlKfGnEYROmATmO7KbSdBCIxjjgaAPtEiZ16CVWky4UcQ+9FVb/viYRaPtdaQ46krFEJ7hDdQr+y8ASQ2xaRsP2CfRtXgyQzbyf0w5YypYqMbOQ1U/EFWsJQnv9fKiCGWqPT9gzPP1Hb/hcYgPtdxn//KQY3pKBe8E24WhudxgkZFw x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?MjVOODBJc2IyZERhZTRRendFa2Q0SXBnblFDRWhGcVBBSHlIQzBzVzFwTXhP?= =?gb2312?B?ZGQyRzJMYUVGcmxDUXg1TFJ3QXIyTWR2TU44LzVLRjJHZEdoREZpSnJXaWRP?= =?gb2312?B?RExIcXN2RTdZUEFaZko5RFFVdm9LU0p6L1VZc3ZjZ0dUMzNSNnZuMklWWlpp?= =?gb2312?B?bEhjRjUwcHppeGZGZEVQUm9WMHRoUlJMQ2JqanVsN1R0RFBSY2xFamoxNHUv?= =?gb2312?B?aXhmd3plY0grdVVYMS8vM0RmaUhWYURFOWlyUkpiUjBHUUYvbFRFckdTckdM?= =?gb2312?B?U1RueklCVVVhUU1KYmE2RjcxODB0WmV6OXBoNnJDSEJEK0ZDQ09GQVpkSmxK?= =?gb2312?B?YzdlVkJTSUt5anZCTWRZUjdRMUVhMk5zK3MyZUZuZThJWGxJbm1tUUJyTElt?= =?gb2312?B?a1VmSVZvSU9LMldqWGVwU0ZFcmtGazhaTWJMclYxKzhybnhaOW9abG9QYlll?= =?gb2312?B?cDlvZ0p3OXdJWmFSalF4bnMvelE2Q3NJMDlweVlvRk51ZTVJeXFDOE9JcHk4?= =?gb2312?B?RFV0UTUrZTZBNTdjVmFaOTY2emNvdDN4S25KY0cxcVc5cUtrbkxpWnZVRUR2?= =?gb2312?B?R2tuSnNoT25WWi9vcUpTWkdFMFA5cW1hS1A3TUgvUXZyQ1pXYmdxbnhFUDhh?= =?gb2312?B?c3U0Q3V6OWt3WExxVk9ETUlhZ2RYZDMwMUF2QzJyVVptblRwSFhuZElVY1pr?= =?gb2312?B?RHJUSm1XUzJsK2huVmE4djNCRHlOMmRsLzJVTmIreVV3am9GVTNrOUVQZWZ2?= =?gb2312?B?ajhYellXUytsdHhKRUpudld4YnFQNWpXKzI0ZE5wK1BWcE8wbzVvRUlZUnhL?= =?gb2312?B?VmE2THdiZjRsZmVXNXZFcFFhMmxib1R2alBDdE9hMlB3MDR5MkY0dk56enZs?= =?gb2312?B?bk9pcERvLzRHT0VPSFR1RThHekdNVms3Um9qb3B6WDRtbUJDelJ0TVY5dDRV?= =?gb2312?B?Q2hUSUNST0gzR2ZLaFcwWXJGbW5TRVZ1U2kzUE5SVldOWENIWXp4dXpkcWU5?= =?gb2312?B?OTN3Uy9OVUtDbW5DVHBOQ0VnK3JnMU9mdFkrUW55ZGRMTmpLT0pGRDNWT25h?= =?gb2312?B?ZkdUcWkwd1l2c1BpZUxVN1hNME8xcHh4NkhXSncwS0xvWVQ4RzFKV08vcVRy?= =?gb2312?B?bnpHSEFaVXR6dGVDV0pUeW5vemZtV3VvWGd2OS9rQmhiU283QzVOOTMxcHk4?= =?gb2312?B?MSttUi9rdS9DdWh3Tmt4d3pVc1hDNHNLRUFQU1U1MGVydWt6T2h1cVY4QzU3?= =?gb2312?B?OEZ5dkw2emJXWUpHbERXNllkb0FuUkZubnBYWlFEbFhPTXhKS0FzenpRVUxZ?= =?gb2312?B?ekV4b2x5WWZwb2JnakU0VHQ0cGJmK0dRalIvNlJGMmk5NXZHUjE3RmMzVGp2?= =?gb2312?B?YUlmSkZFUVNMY2tPSGRLYzU5SFMwb2lBSmh2SUFGV25ycXFNS21wMldRWklZ?= =?gb2312?B?bHRjN2ZYejJyQUd0Y0FZU090dTZsZWlXV2RpK1dQZ1phNnpQWkF6c3VlbGJH?= =?gb2312?B?a0JtSVRoWSt2MjFiRThtWHlXbzEvZkF3RTNCT1V0UXhTNnV2b2NmQ2ZhT2kz?= =?gb2312?B?djBqSFI4ZlE3NDk4WVIzYVVtR1FzNzVOamYrNEJqN3VzREc3WlhCSXE5Ymxv?= =?gb2312?B?OE0zbnlwOXhFdVNhUzR1YmxyTHFwZGpKb0RvRHlQbUZORHRQd3dJZXRUSmpt?= =?gb2312?B?R3hrNkdHclBDYm9XUDYwT0pLcFkyVlExRXRwamFZS05SSzVBU3kwT0NxaW1r?= =?gb2312?B?UUtQSnk5QWcrZHFHUWRuM1NXRkVoSTBuM3R2akNETG5kNVhtdHhTeHY3aVVk?= =?gb2312?B?WklzSWdYanJNYnpTbWZrQnBlcU1UQkxLVXhvZW56eDAvQTZ4cTkvTTJ5RVNY?= =?gb2312?B?QXpuUFcwWk1DbzJQNWplSjdnY3F2ZkZWaEFDU3RBWVU5Q0JrMW1jbml0TDBU?= =?gb2312?B?V2I5dUpoTk5SZmpMYkoxa0xLcnZqQjdMSnBEL21MQnBVNGxKVWNYdkd6RXU2?= =?gb2312?B?TjcxMzdwYkp5eTFTRGhTaVBpWVlOdTN0c1pMa1lRU1BCRXRDTklvdk9qYnU2?= =?gb2312?B?anROV2JSZVZrVGt5VWZPbS9SUG9xQzZqVDQxV1M1aVA3eWdOREw3ZDgyZEl5?= =?gb2312?Q?egxU=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7888.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c057a49-c431-4f8a-d8da-08dbcfe8e53a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2023 14:45:38.7918 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G1FkGsmAhkchzsJcuXDqklQIHZhPx71yMLAO8tE4JnHvDS76CcFovzc7Q46048Yd X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4935 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jake@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: aN8fzvFJOAY3yj0Tq3G0G0VTx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR12MB7888DD3C849FA76C4C25EE20ADD5APH0PR12MB7888namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IqxK1qK1; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_PH0PR12MB7888DD3C849FA76C4C25EE20ADD5APH0PR12MB7888namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 VGhhbmtzIGZvciB0aGUgcmV2aWV3LCBMaW1pbmcgR2FvLg0KDQpBbnkgZnVydGhlciBjb21tZW50 cyBvbiB0aGlzIGNoYW5nZT8NCg0KVGhhbmtzLA0KSmFrZQ0KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18NCkZyb206IGdhb2xpbWluZyA8Z2FvbGltaW5nQGJ5b3NvZnQuY29tLmNuPg0K U2VudDogU2F0dXJkYXksIE9jdG9iZXIgNywgMjAyMyAxOjA1IEFNDQpUbzogSmFrZSBHYXJ2ZXIg PGpha2VAbnZpZGlhLmNvbT47IGRldmVsQGVkazIuZ3JvdXBzLmlvIDxkZXZlbEBlZGsyLmdyb3Vw cy5pbz4NCkNjOiBtaWNoYWVsLmQua2lubmV5QGludGVsLmNvbSA8bWljaGFlbC5kLmtpbm5leUBp bnRlbC5jb20+OyB6aGlndWFuZy5saXVAaW50ZWwuY29tIDx6aGlndWFuZy5saXVAaW50ZWwuY29t Pg0KU3ViamVjdDogu9i4tDogW1BBVENIIHYyXSBCYXNlU3RhY2tDaGVja0xpYjogRml4IFNUQUNL IEZBVUxUIG1lc3NhZ2UNCg0KRXh0ZXJuYWwgZW1haWw6IFVzZSBjYXV0aW9uIG9wZW5pbmcgbGlu a3Mgb3IgYXR0YWNobWVudHMNCg0KDQpSZXZpZXdlZC1ieTogTGltaW5nIEdhbyA8Z2FvbGltaW5n QGJ5b3NvZnQuY29tLmNuPg0KDQo+IC0tLS0t08q8/tStvP4tLS0tLQ0KPiC3orz+yMs6IEpha2Ug R2FydmVyIDxqYWtlQG52aWRpYS5jb20+DQo+ILeiy83KsbzkOiAyMDIzxOoxMNTCNsjVIDA6MTkN Cj4gytW8/sjLOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbw0KPiCzrcvNOiBtaWNoYWVsLmQua2lubmV5 QGludGVsLmNvbTsgZ2FvbGltaW5nQGJ5b3NvZnQuY29tLmNuOw0KPiB6aGlndWFuZy5saXVAaW50 ZWwuY29tOyBKYWtlIEdhcnZlciA8amFrZUBudmlkaWEuY29tPg0KPiDW98ziOiBbUEFUQ0ggdjJd IEJhc2VTdGFja0NoZWNrTGliOiBGaXggU1RBQ0sgRkFVTFQgbWVzc2FnZQ0KPg0KPiBfX2J1aWx0 aW5fcmV0dXJuX2FkZHJlc3MgcmV0dXJucyBhIHBvaW50ZXIsIG5vdCBhIHN0cmluZy4gIEZpeCB0 aGUgU1RBQ0sNCj4gRkFVTFQgbWVzc2FnZSBpbiBCYXNlU3RhY2tDaGVja0xpYiBhcHByb3ByaWF0 ZWx5Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYWtlIEdhcnZlciA8amFrZUBudmlkaWEuY29tPg0K PiAtLS0NCj4gIE1kZVBrZy9MaWJyYXJ5L0Jhc2VTdGFja0NoZWNrTGliL0Jhc2VTdGFja0NoZWNr R2NjLmMgfCAzICsrLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvTWRlUGtnL0xpYnJhcnkvQmFzZVN0YWNrQ2hlY2tM aWIvQmFzZVN0YWNrQ2hlY2tHY2MuYw0KPiBiL01kZVBrZy9MaWJyYXJ5L0Jhc2VTdGFja0NoZWNr TGliL0Jhc2VTdGFja0NoZWNrR2NjLmMNCj4gaW5kZXggMGQyOTE4NjY4ZS4uZWExNjg4NDFiNiAx MDA2NDQNCj4gLS0tIGEvTWRlUGtnL0xpYnJhcnkvQmFzZVN0YWNrQ2hlY2tMaWIvQmFzZVN0YWNr Q2hlY2tHY2MuYw0KPiArKysgYi9NZGVQa2cvTGlicmFyeS9CYXNlU3RhY2tDaGVja0xpYi9CYXNl U3RhY2tDaGVja0djYy5jDQo+IEBAIC02LDYgKzYsNyBAQA0KPiAgIHRvIGV4aXRpbmcgdGhlIGZ1 bmN0aW9uLiBJZiB0aGUgImNhbmFyeSIgaXMgb3ZlcndyaXR0ZW4NCl9fc3RhY2tfY2hrX2ZhaWwo KQ0KPiAgIGlzIGNhbGxlZC4gVGhpcyBpcyBHQ0Mgc3BlY2lmaWMgY29kZS4NCj4NCj4gKyBDb3B5 cmlnaHQgKGMpIDIwMjMsIE5WSURJQSBDT1JQT1JBVElPTiAmIEFGRklMSUFURVMuIEFsbCByaWdo dHMNCnJlc2VydmVkLg0KPiAgIENvcHlyaWdodCAoYykgMjAxMiwgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLjxCUj4NCj4gICBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogQlNELTItQ2xh dXNlLVBhdGVudA0KPg0KPiBAQCAtMzQsNyArMzUsNyBAQCBfX3N0YWNrX2Noa19mYWlsICgNCj4g IHsNCj4gICAgVUlOVDggIERlYnVnUHJvcGVydHlNYXNrOw0KPg0KPiAtICBERUJVRyAoKERFQlVH X0VSUk9SLCAiU1RBQ0sgRkFVTFQ6IEJ1ZmZlciBPdmVyZmxvdyBpbg0KPiBmdW5jdGlvbiAlYS5c biIsIF9fYnVpbHRpbl9yZXR1cm5fYWRkcmVzcyAoMCkpKTsNCj4gKyAgREVCVUcgKChERUJVR19F UlJPUiwgIlNUQUNLIEZBVUxUOiBCdWZmZXIgT3ZlcmZsb3cgYXQgMHglcC5cbiIsDQo+IFJFVFVS Tl9BRERSRVNTICgwKSkpOw0KPg0KPiAgICAvLw0KPiAgICAvLyBHZW5lcmF0ZSBhIEJyZWFrcG9p bnQsIERlYWRMb29wLCBvciBOT1AgYmFzZWQgb24gUENEIHNldHRpbmdzIGV2ZW4NCj4gaWYNCj4g LS0NCj4gMi4zNC4xDQoNCg0KDQoNCgotPS09LT0tPS09LT0tPS09LT0tPS09LQpHcm91cHMuaW8g TGlua3M6IFlvdSByZWNlaXZlIGFsbCBtZXNzYWdlcyBzZW50IHRvIHRoaXMgZ3JvdXAuClZpZXcv UmVwbHkgT25saW5lICgjMTA5NzU2KTogaHR0cHM6Ly9lZGsyLmdyb3Vwcy5pby9nL2RldmVsL21l c3NhZ2UvMTA5NzU2Ck11dGUgVGhpcyBUb3BpYzogaHR0cHM6Ly9ncm91cHMuaW8vbXQvMTAyMDQw MzQyLzc2ODYxNzYKR3JvdXAgT3duZXI6IGRldmVsK293bmVyQGVkazIuZ3JvdXBzLmlvClVuc3Vi c2NyaWJlOiBodHRwczovL2VkazIuZ3JvdXBzLmlvL2cvZGV2ZWwvdW5zdWIgW3JlYmVjY2FAb3Bl bmZ3LmlvXQotPS09LT0tPS09LT0tPS09LT0tPS09LQoKDQo= --_000_PH0PR12MB7888DD3C849FA76C4C25EE20ADD5APH0PR12MB7888namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable
Thanks for the review, Liming Gao.

Any further comments on this change?

Thanks,
Jake
From: gaoliming <gaolimi= ng@byosoft.com.cn>
Sent: Saturday, October 7, 2023 1:05 AM
To: Jake Garver <jake@nvidia.com>; devel@edk2.groups.io <de= vel@edk2.groups.io>
Cc: michael.d.kinney@intel.com <michael.d.kinney@intel.com>; z= higuang.liu@intel.com <zhiguang.liu@intel.com>
Subject: =BB=D8=B8=B4: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT= message
 
External email: Use caution opening links or attac= hments


Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Jake Garver <jake@nvidia.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA10=D4=C26=C8=D5 0:19
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > zhiguang.liu@intel.com; Jake Garver <jake@nvidia.com>
> =D6=F7=CC=E2: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message >
> __builtin_return_address returns a pointer, not a string.  Fix th= e STACK
> FAULT message in BaseStackCheckLib appropriately.
>
> Signed-off-by: Jake Garver <jake@nvidia.com>
> ---
>  MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
> b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
> index 0d2918668e..ea168841b6 100644
> --- a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
> +++ b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
> @@ -6,6 +6,7 @@
>   to exiting the function. If the "canary" is over= written
__stack_chk_fail()
>   is called. This is GCC specific code.
>
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights<= br> reserved.
>   Copyright (c) 2012, Apple Inc. All rights reserved.<BR&= gt;
>   SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -34,7 +35,7 @@ __stack_chk_fail (
>  {
>    UINT8  DebugPropertyMask;
>
> -  DEBUG ((DEBUG_ERROR, "STACK FAULT: Buffer Overflow in
> function %a.\n", __builtin_return_address (0)));
> +  DEBUG ((DEBUG_ERROR, "STACK FAULT: Buffer Overflow at 0x%= p.\n",
> RETURN_ADDRESS (0)));
>
>    //
>    // Generate a Breakpoint, DeadLoop, or NOP based on = PCD settings even
> if
> --
> 2.34.1



_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109756) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_PH0PR12MB7888DD3C849FA76C4C25EE20ADD5APH0PR12MB7888namp_--