* [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10 @ 2024-05-20 2:48 Li, Walon 2024-05-20 16:58 ` Michael D Kinney 0 siblings, 1 reply; 3+ messages in thread From: Li, Walon @ 2024-05-20 2:48 UTC (permalink / raw) To: devel; +Cc: derek.lin2, walon.li, gaoliming Follow UEFI specification 2.10 to update system table revision. --- MdePkg/Include/Uefi/UefiSpec.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h index 79fc8c72ca..5cabb196b7 100644 --- a/MdePkg/Include/Uefi/UefiSpec.h +++ b/MdePkg/Include/Uefi/UefiSpec.h @@ -1,8 +1,8 @@ /** @file Include file that supports UEFI. - This include file must contain things defined in the UEFI 2.7 specification. - If a code construct is defined in the UEFI 2.7 specification it must be included + This include file must contain things defined in the UEFI 2.10 specification. + If a code construct is defined in the UEFI 2.10 specification it must be included by this include file. Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR> @@ -1840,6 +1840,8 @@ EFI_STATUS // EFI Runtime Services Table // #define EFI_SYSTEM_TABLE_SIGNATURE SIGNATURE_64 ('I','B','I',' ','S','Y','S','T') +#define EFI_2_100_SYSTEM_TABLE_REVISION ((2 << 16) | (100)) +#define EFI_2_90_SYSTEM_TABLE_REVISION ((2 << 16) | (90)) #define EFI_2_80_SYSTEM_TABLE_REVISION ((2 << 16) | (80)) #define EFI_2_70_SYSTEM_TABLE_REVISION ((2 << 16) | (70)) #define EFI_2_60_SYSTEM_TABLE_REVISION ((2 << 16) | (60)) @@ -1852,7 +1854,7 @@ EFI_STATUS #define EFI_2_00_SYSTEM_TABLE_REVISION ((2 << 16) | (00)) #define EFI_1_10_SYSTEM_TABLE_REVISION ((1 << 16) | (10)) #define EFI_1_02_SYSTEM_TABLE_REVISION ((1 << 16) | (02)) -#define EFI_SYSTEM_TABLE_REVISION EFI_2_70_SYSTEM_TABLE_REVISION +#define EFI_SYSTEM_TABLE_REVISION EFI_2_100_SYSTEM_TABLE_REVISION #define EFI_SPECIFICATION_VERSION EFI_SYSTEM_TABLE_REVISION #define EFI_RUNTIME_SERVICES_SIGNATURE SIGNATURE_64 ('R','U','N','T','S','E','R','V') -- 2.23.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119071): https://edk2.groups.io/g/devel/message/119071 Mute This Topic: https://groups.io/mt/106197340/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10 2024-05-20 2:48 [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10 Li, Walon @ 2024-05-20 16:58 ` Michael D Kinney 2024-05-26 15:27 ` Li, Walon 0 siblings, 1 reply; 3+ messages in thread From: Michael D Kinney @ 2024-05-20 16:58 UTC (permalink / raw) To: devel@edk2.groups.io, Li, Walon Cc: Lin2, Derek, gaoliming@byosoft.com.cn, Kinney, Michael D Have you verified that every feature from 2.10 is in edk2? That includes both the include file content as well as all the Library/module implementations. A platform can always update this version value in their tables if the platform is using a subset of features that are all 2.10 conformant. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Li, Walon > Sent: Sunday, May 19, 2024 7:49 PM > To: devel@edk2.groups.io > Cc: Lin2, Derek <derek.lin2@hpe.com>; Li, Walon <walon.li@hpe.com>; > gaoliming@byosoft.com.cn > Subject: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10 > > Follow UEFI specification 2.10 to update system table revision. > --- > MdePkg/Include/Uefi/UefiSpec.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h > index 79fc8c72ca..5cabb196b7 100644 > --- a/MdePkg/Include/Uefi/UefiSpec.h > +++ b/MdePkg/Include/Uefi/UefiSpec.h > @@ -1,8 +1,8 @@ > /** @file > > Include file that supports UEFI. > > > > - This include file must contain things defined in the UEFI 2.7 > specification. > > - If a code construct is defined in the UEFI 2.7 specification it must be > included > > + This include file must contain things defined in the UEFI 2.10 > specification. > > + If a code construct is defined in the UEFI 2.10 specification it must be > included > > by this include file. > > > > Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR> > > @@ -1840,6 +1840,8 @@ EFI_STATUS > // EFI Runtime Services Table > > // > > #define EFI_SYSTEM_TABLE_SIGNATURE SIGNATURE_64 ('I','B','I',' > ','S','Y','S','T') > > +#define EFI_2_100_SYSTEM_TABLE_REVISION ((2 << 16) | (100)) > > +#define EFI_2_90_SYSTEM_TABLE_REVISION ((2 << 16) | (90)) > > #define EFI_2_80_SYSTEM_TABLE_REVISION ((2 << 16) | (80)) > > #define EFI_2_70_SYSTEM_TABLE_REVISION ((2 << 16) | (70)) > > #define EFI_2_60_SYSTEM_TABLE_REVISION ((2 << 16) | (60)) > > @@ -1852,7 +1854,7 @@ EFI_STATUS > #define EFI_2_00_SYSTEM_TABLE_REVISION ((2 << 16) | (00)) > > #define EFI_1_10_SYSTEM_TABLE_REVISION ((1 << 16) | (10)) > > #define EFI_1_02_SYSTEM_TABLE_REVISION ((1 << 16) | (02)) > > -#define EFI_SYSTEM_TABLE_REVISION EFI_2_70_SYSTEM_TABLE_REVISION > > +#define EFI_SYSTEM_TABLE_REVISION EFI_2_100_SYSTEM_TABLE_REVISION > > #define EFI_SPECIFICATION_VERSION EFI_SYSTEM_TABLE_REVISION > > > > #define EFI_RUNTIME_SERVICES_SIGNATURE SIGNATURE_64 > ('R','U','N','T','S','E','R','V') > > -- > 2.23.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#119071): https://edk2.groups.io/g/devel/message/119071 > Mute This Topic: https://groups.io/mt/106197340/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119084): https://edk2.groups.io/g/devel/message/119084 Mute This Topic: https://groups.io/mt/106197340/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10 2024-05-20 16:58 ` Michael D Kinney @ 2024-05-26 15:27 ` Li, Walon 0 siblings, 0 replies; 3+ messages in thread From: Li, Walon @ 2024-05-26 15:27 UTC (permalink / raw) To: Kinney, Michael D, devel@edk2.groups.io Cc: Lin, Derek (UEFI Development), gaoliming@byosoft.com.cn Hi Mike, Nope. I didn't try all changes with UEFI 2.10 specification. I just noticed that edk2 had been merged serval 2.10 changes but this version is still keeping to 2.7. Only checked the UEFI version number in efi-shell (QEMU), it changes to 2.100 from 2.70. I'm neutral on this change, if you think we're not yet to declare edk2 is 2.10 compliant this moment. Thanks! Walon -----Original Message----- From: Kinney, Michael D <michael.d.kinney@intel.com> Sent: Tuesday, May 21, 2024 12:59 AM To: devel@edk2.groups.io; Li, Walon (UEFI Development) <walon.li@hpe.com> Cc: Lin, Derek (UEFI Development) <derek.lin2@hpe.com>; gaoliming@byosoft.com.cn; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10 Have you verified that every feature from 2.10 is in edk2? That includes both the include file content as well as all the Library/module implementations. A platform can always update this version value in their tables if the platform is using a subset of features that are all 2.10 conformant. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Li, > Walon > Sent: Sunday, May 19, 2024 7:49 PM > To: devel@edk2.groups.io > Cc: Lin2, Derek <derek.lin2@hpe.com>; Li, Walon <walon.li@hpe.com>; > gaoliming@byosoft.com.cn > Subject: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10 > > Follow UEFI specification 2.10 to update system table revision. > --- > MdePkg/Include/Uefi/UefiSpec.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/MdePkg/Include/Uefi/UefiSpec.h > b/MdePkg/Include/Uefi/UefiSpec.h index 79fc8c72ca..5cabb196b7 100644 > --- a/MdePkg/Include/Uefi/UefiSpec.h > +++ b/MdePkg/Include/Uefi/UefiSpec.h > @@ -1,8 +1,8 @@ > /** @file > > Include file that supports UEFI. > > > > - This include file must contain things defined in the UEFI 2.7 > specification. > > - If a code construct is defined in the UEFI 2.7 specification it > must be included > > + This include file must contain things defined in the UEFI 2.10 > specification. > > + If a code construct is defined in the UEFI 2.10 specification it > + must be > included > > by this include file. > > > > Copyright (c) 2006 - 2021, Intel Corporation. All rights > reserved.<BR> > > @@ -1840,6 +1840,8 @@ EFI_STATUS > // EFI Runtime Services Table > > // > > #define EFI_SYSTEM_TABLE_SIGNATURE SIGNATURE_64 ('I','B','I',' > ','S','Y','S','T') > > +#define EFI_2_100_SYSTEM_TABLE_REVISION ((2 << 16) | (100)) > > +#define EFI_2_90_SYSTEM_TABLE_REVISION ((2 << 16) | (90)) > > #define EFI_2_80_SYSTEM_TABLE_REVISION ((2 << 16) | (80)) > > #define EFI_2_70_SYSTEM_TABLE_REVISION ((2 << 16) | (70)) > > #define EFI_2_60_SYSTEM_TABLE_REVISION ((2 << 16) | (60)) > > @@ -1852,7 +1854,7 @@ EFI_STATUS > #define EFI_2_00_SYSTEM_TABLE_REVISION ((2 << 16) | (00)) > > #define EFI_1_10_SYSTEM_TABLE_REVISION ((1 << 16) | (10)) > > #define EFI_1_02_SYSTEM_TABLE_REVISION ((1 << 16) | (02)) > > -#define EFI_SYSTEM_TABLE_REVISION EFI_2_70_SYSTEM_TABLE_REVISION > > +#define EFI_SYSTEM_TABLE_REVISION EFI_2_100_SYSTEM_TABLE_REVISION > > #define EFI_SPECIFICATION_VERSION EFI_SYSTEM_TABLE_REVISION > > > > #define EFI_RUNTIME_SERVICES_SIGNATURE SIGNATURE_64 > ('R','U','N','T','S','E','R','V') > > -- > 2.23.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#119071): > INVALID URI REMOVED > 071__;!!NpxR!mB7x3kTUEcviqRRJF9uqlrvMWEVg0fQ3_tIm8s-W-zcDbaQMFZz9NxhOp > eveHiQoACrlRk-Jru0nV8Zd_7TAIqI$ Mute This Topic: > https://groups.io/mt/106197340/1643496 > !NpxR!mB7x3kTUEcviqRRJF9uqlrvMWEVg0fQ3_tIm8s-W-zcDbaQMFZz9NxhOpeveHiQo > ACrlRk-Jru0nV8Zd5SpoWG0$ Group Owner: devel+owner@edk2.groups.io > Unsubscribe: > https://edk2.groups.io/g/devel/unsub > pxR!mB7x3kTUEcviqRRJF9uqlrvMWEVg0fQ3_tIm8s-W-zcDbaQMFZz9NxhOpeveHiQoAC > rlRk-Jru0nV8Zd2GYv47o$ > [michael.d.kinney@intel.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119268): https://edk2.groups.io/g/devel/message/119268 Mute This Topic: https://groups.io/mt/106197340/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-26 15:28 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-05-20 2:48 [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10 Li, Walon 2024-05-20 16:58 ` Michael D Kinney 2024-05-26 15:27 ` Li, Walon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox