From: "Abner Chang" <abner.chang@hpe.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
"Jian J Wang" <jian.j.wang@intel.com>, Ray Ni <ray.ni@intel.com>,
Hao A Wu <hao.a.wu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Pawel Polawski <ppolawsk@redhat.com>,
"Oliver Steffen" <osteffen@redhat.com>
Subject: Re: [PATCH v3 2/6] OvmfPkg/FdtPciHostBridgeLib: io range is not mandatory
Date: Tue, 12 Apr 2022 07:50:19 +0000 [thread overview]
Message-ID: <PH0PR84MB1647865CB710C8B711AD5CB3FFED9@PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220407093304.1551182-3-kraxel@redhat.com>
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Thursday, April 7, 2022 5:33 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Jordan Justen <jordan.l.justen@intel.com>;
> Jian J Wang <jian.j.wang@intel.com>; Ray Ni <ray.ni@intel.com>; Hao A Wu
> <hao.a.wu@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Jiewen Yao
> <jiewen.yao@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Pawel
> Polawski <ppolawsk@redhat.com>; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; Oliver Steffen <osteffen@redhat.com>
> Subject: [PATCH v3 2/6] OvmfPkg/FdtPciHostBridgeLib: io range is not
> mandatory
>
> io range is not mandatory according to pcie spec,
> so allow host bridges without io address space.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 45 ++++++++++---------
> 1 file changed, 23 insertions(+), 22 deletions(-)
>
> diff --git a/OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
> b/OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
> index 98828e0b262b..823ea47c80a3 100644
> --- a/OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
> +++ b/OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
> @@ -292,13 +292,8 @@ ProcessPciHost (
> }
> }
>
> - if ((*IoSize == 0) || (*Mmio32Size == 0)) {
> - DEBUG ((
> - DEBUG_ERROR,
> - "%a: %a space empty\n",
> - __FUNCTION__,
> - (*IoSize == 0) ? "IO" : "MMIO32"
> - ));
> + if (*Mmio32Size == 0) {
> + DEBUG ((DEBUG_ERROR, "%a: MMIO32 space empty\n",
> __FUNCTION__));
> return EFI_PROTOCOL_ERROR;
> }
>
> @@ -333,13 +328,15 @@ ProcessPciHost (
> return Status;
> }
>
> - //
> - // Map the MMIO window that provides I/O access - the PCI host bridge
> code
> - // is not aware of this translation and so it will only map the I/O view
> - // in the GCD I/O map.
> - //
> - Status = MapGcdMmioSpace (*IoBase + IoTranslation, *IoSize);
> - ASSERT_EFI_ERROR (Status);
> + if (*IoSize) {
> + //
> + // Map the MMIO window that provides I/O access - the PCI host bridge
> code
> + // is not aware of this translation and so it will only map the I/O view
> + // in the GCD I/O map.
> + //
> + Status = MapGcdMmioSpace (*IoBase + IoTranslation, *IoSize);
> + ASSERT_EFI_ERROR (Status);
> + }
>
> return Status;
> }
> @@ -413,17 +410,21 @@ PciHostBridgeGetRootBridges (
>
> AllocationAttributes = EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM;
>
> - Io.Base = IoBase;
> - Io.Limit = IoBase + IoSize - 1;
> + if (IoSize) {
> + Io.Base = IoBase;
> + Io.Limit = IoBase + IoSize - 1;
> + } else {
> + Io.Base = MAX_UINT64;
> + Io.Limit = 0;
HI Gerd,
Does the consumer of Io (in PCI_ROOT_BRIDGE structure) know that the MAX_UINT64 for Io.Base refers to no memory map I/O?
Abner
> + }
> +
> Mem.Base = Mmio32Base;
> Mem.Limit = Mmio32Base + Mmio32Size - 1;
>
> - if (sizeof (UINTN) == sizeof (UINT64)) {
> - MemAbove4G.Base = Mmio64Base;
> - MemAbove4G.Limit = Mmio64Base + Mmio64Size - 1;
> - if (Mmio64Size > 0) {
> - AllocationAttributes |= EFI_PCI_HOST_BRIDGE_MEM64_DECODE;
> - }
> + if ((sizeof (UINTN) == sizeof (UINT64)) && Mmio64Size) {
> + MemAbove4G.Base = Mmio64Base;
> + MemAbove4G.Limit = Mmio64Base + Mmio64Size - 1;
> + AllocationAttributes |= EFI_PCI_HOST_BRIDGE_MEM64_DECODE;
> } else {
> //
> // UEFI mandates a 1:1 virtual-to-physical mapping, so on a 32-bit
> --
> 2.35.1
next prev parent reply other threads:[~2022-04-12 7:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 9:32 [PATCH v3 0/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2022-04-07 9:32 ` [PATCH v3 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Gerd Hoffmann
2022-04-13 5:24 ` Abner Chang
2022-04-13 8:12 ` [edk2-devel] " Gerd Hoffmann
2022-04-13 13:44 ` Abner Chang
2022-04-19 13:14 ` Gerd Hoffmann
2022-04-20 9:44 ` Abner Chang
2022-04-07 9:33 ` [PATCH v3 2/6] OvmfPkg/FdtPciHostBridgeLib: " Gerd Hoffmann
2022-04-12 7:50 ` Abner Chang [this message]
2022-04-12 9:03 ` [edk2-devel] " Gerd Hoffmann
2022-04-13 5:25 ` Abner Chang
2022-04-07 9:33 ` [PATCH v3 3/6] OvmfPkg/Platform: unfix PcdPciExpressBaseAddress Gerd Hoffmann
2022-04-07 9:33 ` [PATCH v3 4/6] OvmfPkg/Microvm/pcie: no vbeshim please Gerd Hoffmann
2022-04-07 9:33 ` [PATCH v3 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak Gerd Hoffmann
2022-04-07 9:33 ` [PATCH v3 6/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR84MB1647865CB710C8B711AD5CB3FFED9@PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox