public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"kraxel@redhat.com" <kraxel@redhat.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	"Jian J Wang" <jian.j.wang@intel.com>, Ray Ni <ray.ni@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Pawel Polawski <ppolawsk@redhat.com>,
	"Oliver Steffen" <osteffen@redhat.com>
Subject: Re: [edk2-devel] [PATCH v3 2/6] OvmfPkg/FdtPciHostBridgeLib: io range is not mandatory
Date: Wed, 13 Apr 2022 05:25:52 +0000	[thread overview]
Message-ID: <PH0PR84MB1647BBEA287F6611E71EB00FFFEC9@PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220412090356.ko5np3i64lqlohuy@sirius.home.kraxel.org>



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, April 12, 2022 5:04 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Jordan Justen <jordan.l.justen@intel.com>;
> Jian J Wang <jian.j.wang@intel.com>; Ray Ni <ray.ni@intel.com>; Hao A Wu
> <hao.a.wu@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Pawel Polawski <ppolawsk@redhat.com>;
> Oliver Steffen <osteffen@redhat.com>
> Subject: Re: [edk2-devel] [PATCH v3 2/6] OvmfPkg/FdtPciHostBridgeLib: io
> range is not mandatory
> 
>   Hi,
> 
> > > -  Io.Base   = IoBase;
> > > -  Io.Limit  = IoBase + IoSize - 1;
> > > +  if (IoSize) {
> > > +    Io.Base  = IoBase;
> > > +    Io.Limit = IoBase + IoSize - 1;
> > > +  } else {
> > > +    Io.Base  = MAX_UINT64;
> > > +    Io.Limit = 0;
> > HI Gerd,
> > Does the consumer of Io (in PCI_ROOT_BRIDGE structure) know that the
> MAX_UINT64 for Io.Base refers to no memory map I/O?
> 
> Patch #1 handles that.
Ok, I had my comment in the response to patch #1.
Thanks
Abner
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 


  reply	other threads:[~2022-04-13  5:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  9:32 [PATCH v3 0/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2022-04-07  9:32 ` [PATCH v3 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Gerd Hoffmann
2022-04-13  5:24   ` Abner Chang
2022-04-13  8:12     ` [edk2-devel] " Gerd Hoffmann
2022-04-13 13:44       ` Abner Chang
2022-04-19 13:14         ` Gerd Hoffmann
2022-04-20  9:44           ` Abner Chang
2022-04-07  9:33 ` [PATCH v3 2/6] OvmfPkg/FdtPciHostBridgeLib: " Gerd Hoffmann
2022-04-12  7:50   ` Abner Chang
2022-04-12  9:03     ` [edk2-devel] " Gerd Hoffmann
2022-04-13  5:25       ` Abner Chang [this message]
2022-04-07  9:33 ` [PATCH v3 3/6] OvmfPkg/Platform: unfix PcdPciExpressBaseAddress Gerd Hoffmann
2022-04-07  9:33 ` [PATCH v3 4/6] OvmfPkg/Microvm/pcie: no vbeshim please Gerd Hoffmann
2022-04-07  9:33 ` [PATCH v3 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak Gerd Hoffmann
2022-04-07  9:33 ` [PATCH v3 6/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR84MB1647BBEA287F6611E71EB00FFFEC9@PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox